René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"RBD/RADOS volume management should be handled by libvirt","articleBody":"##### ISSUE TYPE\r\n * Enhancement Request\r\n\r\n##### COMPONENT NAME\r\n~~~\r\nCloudStack Agent\r\n~~~\r\n\r\n##### CLOUDSTACK VERSION\r\n~~~\r\nall\r\n~~~\r\n\r\n##### SUMMARY\r\nThe CloudStack Agent uses com.ceph.rados.* for many operations as when implementing the RBD storage pool support not all features were supported by Libvirt.\r\n\r\nFor example: https://github.com/apache/cloudstack/blob/1a304ccf68a75d835cf5e723b56b57155be6ebda/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java#L913\r\n\r\n```\r\n                IoCTX io = r.ioCtxCreate(pool.getSourceDir());\r\n                Rbd rbd = new Rbd(io);\r\n                RbdImage image = rbd.open(uuid);\r\n                s_logger.debug(\"Fetching list of snapshots of RBD image \" + pool.getSourceDir() + \"/\" + uuid);\r\n                List\u003cRbdSnapInfo\u003e snaps = image.snapList();\r\n                try {\r\n                    for (RbdSnapInfo snap : snaps) {\r\n                        if (image.snapIsProtected(snap.name)) {\r\n                            s_logger.debug(\"Unprotecting snapshot \" + pool.getSourceDir() + \"/\" + uuid + \"@\" + snap.name);\r\n                            image.snapUnprotect(snap.name);\r\n                        } else {\r\n                            s_logger.debug(\"Snapshot \" + pool.getSourceDir() + \"/\" + uuid + \"@\" + snap.name + \" is not protected.\");\r\n                        }\r\n                        s_logger.debug(\"Removing snapshot \" + pool.getSourceDir() + \"/\" + uuid + \"@\" + snap.name);\r\n                        image.snapRemove(snap.name);\r\n                    }\r\n                    s_logger.info(\"Successfully unprotected and removed any remaining snapshots (\" + snaps.size() + \") of \"\r\n                        + pool.getSourceDir() + \"/\" + uuid + \" Continuing to remove the RBD image\");\r\n                } catch (RbdException e) {\r\n                    s_logger.error(\"Failed to remove snapshot with exception: \" + e.toString() +\r\n                        \", RBD error: \" + ErrorCode.getErrorMessage(e.getReturnValue()));\r\n                    throw new CloudRuntimeException(e.toString() + \" - \" + ErrorCode.getErrorMessage(e.getReturnValue()));\r\n                } finally {\r\n                    s_logger.debug(\"Closing image and destroying context\");\r\n                    rbd.close(image);\r\n                    r.ioCtxDestroy(io);\r\n                }\r\n            } catch (RadosException e) {\r\n                s_logger.error(\"Failed to remove snapshot with exception: \" + e.toString() +\r\n                    \", RBD error: \" + ErrorCode.getErrorMessage(e.getReturnValue()));\r\n                throw new CloudRuntimeException(e.toString() + \" - \" + ErrorCode.getErrorMessage(e.getReturnValue()));\r\n            } catch (RbdException e) {\r\n                s_logger.error(\"Failed to remove snapshot with exception: \" + e.toString() +\r\n                    \", RBD error: \" + ErrorCode.getErrorMessage(e.getReturnValue()));\r\n                throw new CloudRuntimeException(e.toString() + \" - \" + ErrorCode.getErrorMessage(e.getReturnValue()));\r\n            }\r\n        }\r\n```\r\n\r\nHere the CloudStack agent purges any RBD snapshots as they need to be removed prior to removing the RBD image.\r\n\r\nModern libvirt can do this for you (pseudo code):\r\n\r\n```\r\nStorageVol.delete(VIR_STORAGE_VOL_DELETE_WITH_SNAPSHOTS)\r\n```\r\n\r\nThis removes a lot of lines of code from CloudStack and leverages what libvirt can do for us.\r\n\r\nThis is just one example, but there are other places where the CloudStack agent uses the librados Java bindings directly while those things can be handled by libvirt.\r\n\r\n","author":{"url":"https://github.com/wido","@type":"Person","name":"wido"},"datePublished":"2022-03-30T19:56:24.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/6180/cloudstack/issues/6180"}