Title: errorprone cleanliness · Issue #11438 · apache/cloudstack · GitHub
Open Graph Title: errorprone cleanliness · Issue #11438 · apache/cloudstack
X Title: errorprone cleanliness · Issue #11438 · apache/cloudstack
Description: go through the code by instating error prone and fix any issues it reports. Once that epic work is done we can permanently install errorprone as a pre-commit hook. commit 9f9a2b6b7e094537fea75f633d355f983d4c15d7 Author: Daan Hoogland Open Graph Description: go through the code by instating error prone and fix any issues it reports. Once that epic work is done we can permanently install errorprone as a pre-commit hook. commit 9f9a2b6b7e094537fea75f633d...
X Description: go through the code by instating error prone and fix any issues it reports. Once that epic work is done we can permanently install errorprone as a pre-commit hook. commit 9f9a2b6b7e094537fea75f633d...
Opengraph URL: https://github.com/apache/cloudstack/issues/11438
X: @github
Domain: github.com
Links:
Viewport: width=device-width
Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"errorprone cleanliness","articleBody":"go through the code by instating error prone and fix any issues it reports. Once that epic work is done we can permanently install errorprone as a pre-commit hook.\n\n```\ncommit 9f9a2b6b7e094537fea75f633d355f983d4c15d7\nAuthor: Daan Hoogland \u003cdaan@onecht.net\u003e\nDate: Thu Jan 12 19:32:35 2023 +0100\n\n errorprone\n\ndiff --git a/pom.xml b/pom.xml\nindex 204c74cc76..13c46d7521 100644\n--- a/pom.xml\n+++ b/pom.xml\n@@ -817,6 +817,32 @@\n \u003c/execution\u003e\n \u003c/executions\u003e\n \u003c/plugin\u003e\n+ \u003cplugin\u003e\n+ \u003cgroupId\u003eorg.apache.maven.plugins\u003c/groupId\u003e\n+ \u003cartifactId\u003emaven-compiler-plugin\u003c/artifactId\u003e\n+ \u003cversion\u003e${cs.compiler-plugin.version}\u003c/version\u003e\n+ \u003cconfiguration\u003e\n+ \u003csource\u003e8\u003c/source\u003e\n+ \u003ctarget\u003e8\u003c/target\u003e\n+ \u003cencoding\u003eUTF-8\u003c/encoding\u003e\n+ \u003ccompilerArgs\u003e\n+ \u003carg\u003e-XDcompilePolicy=simple\u003c/arg\u003e\n+ \u003carg\u003e-Xplugin:ErrorProne\u003c/arg\u003e\n+ \u003c/compilerArgs\u003e\n+ \u003cannotationProcessorPaths\u003e\n+ \u003cpath\u003e\n+ \u003cgroupId\u003ecom.google.errorprone\u003c/groupId\u003e\n+ \u003cartifactId\u003eerror_prone_core\u003c/artifactId\u003e\n+ \u003cversion\u003e2.18.0\u003c/version\u003e\n+ \u003c/path\u003e\n+ \u003c!-- Other annotation processors go here.\n+\n+ If 'annotationProcessorPaths' is set, processors will no longer be\n+ discovered on the regular -classpath; see also 'Using Error Prone\n+ together with other annotation processors' below. --\u003e\n+ \u003c/annotationProcessorPaths\u003e\n+ \u003c/configuration\u003e\n+ \u003c/plugin\u003e\n \u003c/plugins\u003e\n \u003cpluginManagement\u003e\n \u003cplugins\u003e\n@@ -1074,15 +1100,26 @@\n \u003cconfiguration\u003e\n \u003csource\u003e${cs.jdk.version}\u003c/source\u003e\n \u003ctarget\u003e${cs.jdk.version}\u003c/target\u003e\n- \u003cfork\u003etrue\u003c/fork\u003e\n- \u003cmeminitial\u003e128m\u003c/meminitial\u003e\n- \u003cmaxmem\u003e512m\u003c/maxmem\u003e\n+ \u003cencoding\u003eUTF-8\u003c/encoding\u003e\n \u003ccompilerArgs\u003e\n \u003carg\u003e-XDignore.symbol.file=true\u003c/arg\u003e\n \u003carg\u003e--add-opens=java.base/java.lang=ALL-UNNAMED\u003c/arg\u003e\n \u003carg\u003e--add-exports=java.base/sun.security.x509=ALL-UNNAMED\u003c/arg\u003e\n \u003carg\u003e--add-exports=java.base/sun.security.provider=ALL-UNNAMED\u003c/arg\u003e\n+ \u003carg\u003e-XDcompilePolicy=simple\u003c/arg\u003e\n+ \u003carg\u003e-Xplugin:ErrorProne\u003c/arg\u003e\n+ \u003carg\u003e--illegal-access=warn\u003c/arg\u003e\n \u003c/compilerArgs\u003e\n+ \u003cannotationProcessorPaths\u003e\n+ \u003cpath\u003e\n+ \u003cgroupId\u003ecom.google.errorprone\u003c/groupId\u003e\n+ \u003cartifactId\u003eerror_prone_core\u003c/artifactId\u003e\n+ \u003cversion\u003e2.18.0\u003c/version\u003e\n+ \u003c/path\u003e\n+ \u003c/annotationProcessorPaths\u003e\n+ \u003cfork\u003etrue\u003c/fork\u003e\n+ \u003cmeminitial\u003e128m\u003c/meminitial\u003e\n+ \u003cmaxmem\u003e512m\u003c/maxmem\u003e\n \u003c/configuration\u003e\n \u003c/plugin\u003e\n \u003cplugin\u003e\n```\n\nthe above can be added to the main pom.xml and for any issues reported child issues of this or PR can be created directly. The scope of this is would be enormous and too big to deal with at once.","author":{"url":"https://github.com/DaanHoogland","@type":"Person","name":"DaanHoogland"},"datePublished":"2025-08-13T07:15:55.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/11438/cloudstack/issues/11438"}
route-pattern /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) route-controller voltron_issues_fragments route-action issue_layout fetch-nonce v2:613836d3-72b4-84b7-72dc-82ce3fe47690 current-catalog-service-hash 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 request-id CE96:78281:261BD38:3718259:6A4D1D13 html-safe-nonce 091a76af218d731fb04180ed15155e4cd85461823db71d48f4a149f2ba5a78c4 visitor-payload eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRTk2Ojc4MjgxOjI2MUJEMzg6MzcxODI1OTo2QTREMUQxMyIsInZpc2l0b3JfaWQiOiI3Mjk2MTkwMzA3MDY1NzMyMzcxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= visitor-hmac 60788a201bf752337228f55f2d653470a7ec36d23345255fb5d5e3e721bea10b hovercard-subject-tag issue:3317199875 github-keyboard-shortcuts repository,issues,copilot google-site-verification Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I octolytics-url https://collector.github.com/github/collect analytics-location / fb:app_id 1401488693436528 apple-itunes-app app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/apache/cloudstack/11438/issue_layout twitter:image https://opengraph.githubassets.com/edda7e05f745a6aabcfbed67a2596c497661f08eb7a73dc91495c1a12386b3e7/apache/cloudstack/issues/11438 twitter:card summary_large_image og:image https://opengraph.githubassets.com/edda7e05f745a6aabcfbed67a2596c497661f08eb7a73dc91495c1a12386b3e7/apache/cloudstack/issues/11438 og:image:alt go through the code by instating error prone and fix any issues it reports. Once that epic work is done we can permanently install errorprone as a pre-commit hook. commit 9f9a2b6b7e094537fea75f633d... og:image:width 1200 og:image:height 600 og:site_name GitHub og:type object og:author:username DaanHoogland hostname github.com expected-hostname github.com None bcb4661e6fb4fe8b394c51ea02ccdb2236d40dc59afc75a3bbba50bf6517134c turbo-cache-control no-preview go-import github.com/apache/cloudstack git https://github.com/apache/cloudstack.git octolytics-dimension-user_id 47359 octolytics-dimension-user_login apache octolytics-dimension-repository_id 9759448 octolytics-dimension-repository_nwo apache/cloudstack octolytics-dimension-repository_public true octolytics-dimension-repository_is_fork false octolytics-dimension-repository_network_root_id 9759448 octolytics-dimension-repository_network_root_nwo apache/cloudstack turbo-body-classes logged-out env-production page-responsive disable-turbo false browser-stats-url https://api.github.com/_private/browser/stats browser-errors-url https://api.github.com/_private/browser/errors release fb70bd3c4b2bec429781b65419e912c66e2d5581 ui-target full theme-color #1e2327 color-scheme light dark
URLs of crawlers that visited me.