René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[Java] VectorSchemaRoot#addVector() cannot add a vector to the end of the current vector collection","articleBody":"The current implementation of Java VectorSchemaRoot cannot add a vector at the end of the current list (which is the generally understood meaning of \"add\").\r\n\r\nThe Precondition check in the method's second line prevents providing an appropriate index for adding at the end:\r\n```java\n\r\npublic VectorSchemaRoot addVector(int index, FieldVector vector) {\r\n  Preconditions.checkNotNull(vector);\r\n  Preconditions.checkArgument(index \u003e= 0 \u0026\u0026 index \u003c fieldVectors.size());\r\n  List\u003cFieldVector\u003e newVectors = new ArrayList\u003c\u003e();\r\n  for (int i = 0; i \u003c fieldVectors.size(); i++) {\r\n    if (i == index) {\r\n      newVectors.add(vector);\r\n    }\r\n    newVectors.add(fieldVectors.get(i));\r\n  }\r\n  return new VectorSchemaRoot(newVectors);\r\n}\r\n \n```\r\nOne possible implementation resolving the issue is shown below.\r\n```java\n\r\npublic VectorSchemaRoot addVector(int index, FieldVector vector) {\r\n  Preconditions.checkNotNull(vector);\r\n  Preconditions.checkArgument(index \u003e= 0 \u0026\u0026 index \u003c= fieldVectors.size());\r\n  List\u003cFieldVector\u003e newVectors = new ArrayList\u003c\u003e();\r\n  if (index == fieldVectors.size()) {\r\n    newVectors.addAll(fieldVectors);\r\n    newVectors.add(vector); \r\n  } else {\r\n    for (int i = 0; i \u003c fieldVectors.size(); i++) {\r\n      if (i == index) {\r\n        newVectors.add(vector);\r\n      }\r\n      newVectors.add(fieldVectors.get(i));\r\n    }\r\n  }\r\n  return new VectorSchemaRoot(newVectors);\r\n}\r\n```\r\n \r\n\r\n \r\n\r\n \r\n\r\n \r\n\r\n \n\n**Reporter**: [Larry White](https://issues.apache.org/jira/browse/ARROW-17530) / @lwhite1\n\n\u003csub\u003e**Note**: *This issue was originally created as [ARROW-17530](https://issues.apache.org/jira/browse/ARROW-17530). Please see the [migration documentation](https://github.com/apache/arrow/issues/14542) for further details.*\u003c/sub\u003e","author":{"url":"https://github.com/asfimport","@type":"Person","name":"asfimport"},"datePublished":"2022-08-25T18:16:24.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":4},"url":"https://github.com/301/arrow-java/issues/301"}