René's URL Explorer Experiment


Title: refactor: drop signal writes effect by Harpush · Pull Request #455 · angular-split/angular-split · GitHub

Open Graph Title: refactor: drop signal writes effect by Harpush · Pull Request #455 · angular-split/angular-split

X Title: refactor: drop signal writes effect by Harpush · Pull Request #455 · angular-split/angular-split

Description: Drop the validation effect that also updates internal sizes (with allow signal writes) and use computed instead as per the official angular recommendation. The signal flow is now: SplitArea has visible and size Split creates _visibleAreas based on SplitArea visible Split creates _alignedVisibleAreasSizes based on _visibleAreas and SplitArea size with validation alignments SplitArea _internalSize is based on _alignedVisibleAreasSizes _internalSize is the actual size anything else should use (except validations and normalizations)

Open Graph Description: Drop the validation effect that also updates internal sizes (with allow signal writes) and use computed instead as per the official angular recommendation. The signal flow is now: SplitArea has vi...

X Description: Drop the validation effect that also updates internal sizes (with allow signal writes) and use computed instead as per the official angular recommendation. The signal flow is now: SplitArea has vi...

Opengraph URL: https://github.com/angular-split/angular-split/pull/455

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:53e218bb-932f-d2c6-c372-740e3d45a28d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE84E:928E2:F27074:14459EA:6B010C7E
html-safe-nonce7a974fa21a0e8d28ab1547b4065d553f95e7a693bf3019b5022eb06a785ea850
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFODRFOjkyOEUyOkYyNzA3NDoxNDQ1OUVBOjZCMDEwQzdFIiwidmlzaXRvcl9pZCI6Ijc4NDU4NDY5MDcyMjA5ODcwMDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac5e6363e133597b61da26dc95fd0c57738e33977fdac96a602479952d77c5885c
hovercard-subject-tagpull_request:2075383892
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular-split/angular-split/pull/455/files
twitter:imagehttps://avatars.githubusercontent.com/u/30085989?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/30085989?s=400&v=4
og:image:altDrop the validation effect that also updates internal sizes (with allow signal writes) and use computed instead as per the official angular recommendation. The signal flow is now: SplitArea has vi...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular-split/angular-split git https://github.com/angular-split/angular-split.git
octolytics-dimension-user_id68742971
octolytics-dimension-user_loginangular-split
octolytics-dimension-repository_id76653821
octolytics-dimension-repository_nwoangular-split/angular-split
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id76653821
octolytics-dimension-repository_network_root_nwoangular-split/angular-split
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular-split/angular-split/pull/455/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular-split%2Fangular-split%2Fpull%2F455%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular-split%2Fangular-split%2Fpull%2F455%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular-split%2Fangular-split
Reloadhttps://github.com/angular-split/angular-split/pull/455/files
Reloadhttps://github.com/angular-split/angular-split/pull/455/files
Reloadhttps://github.com/angular-split/angular-split/pull/455/files
angular-splithttps://github.com/angular-split
angular-splithttps://github.com/angular-split/angular-split
Codehttps://github.com/angular-split/angular-split
Issues5 (5)https://github.com/angular-split/angular-split/issues
Pull requests3 (3)https://github.com/angular-split/angular-split/pulls
Discussionshttps://github.com/angular-split/angular-split/discussions
Actionshttps://github.com/angular-split/angular-split/actions
Security and qualityhttps://github.com/angular-split/angular-split/security
Insightshttps://github.com/angular-split/angular-split/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular-split%2Fangular-split%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular-split%2Fangular-split%2Fissues%2Fnew%2Fchoose
Jefioziehttps://github.com/Jefiozie
angular-split:mainhttps://github.com/angular-split/angular-split/tree/main
Harpush:no-signal-writes-effecthttps://github.com/Harpush/angular-split/tree/no-signal-writes-effect
Conversation 4 https://github.com/angular-split/angular-split/pull/455
Commits 1 https://github.com/angular-split/angular-split/pull/455/commits
Checks 0 https://github.com/angular-split/angular-split/pull/455/checks
Files changed https://github.com/angular-split/angular-split/pull/455/files
Please reload this pagehttps://github.com/angular-split/angular-split/pull/455/files
refactor: drop signal writes effect https://github.com/angular-split/angular-split/pull/455/files#top
Show all changes 1 commit https://github.com/angular-split/angular-split/pull/455/files
afd4840 refactor: drop signal writes effect Harpush Jan 18, 2025 https://github.com/angular-split/angular-split/pull/455/commits/afd4840db62524f2560c489f31ddc9e2b7d93cfd
Clear filters https://github.com/angular-split/angular-split/pull/455/files
Please reload this pagehttps://github.com/angular-split/angular-split/pull/455/files
Please reload this pagehttps://github.com/angular-split/angular-split/pull/455/files
split-area.component.ts https://github.com/angular-split/angular-split/pull/455/files#diff-4da9705758d522a5feb466260576f171149cbb903b15961df15df6f171fade1f
split.component.ts https://github.com/angular-split/angular-split/pull/455/files#diff-f7ad3191fbbbe194fc8cc9b4731835076e912fa37f0ef792c0cca329d7c40813
utils.ts https://github.com/angular-split/angular-split/pull/455/files#diff-ad6f433f6524065a59814453ad9f9f7a26dc4e735e848d7d2a0866b4d11ab96d
validations.ts https://github.com/angular-split/angular-split/pull/455/files#diff-f32d4f69900280c33e617e47269637c58eedff4ad27de99c00e28ae28cacd5cc
projects/angular-split/src/lib/split-area/split-area.component.tshttps://github.com/angular-split/angular-split/pull/455/files#diff-4da9705758d522a5feb466260576f171149cbb903b15961df15df6f171fade1f
View file https://github.com/Harpush/angular-split/blob/afd4840db62524f2560c489f31ddc9e2b7d93cfd/projects/angular-split/src/lib/split-area/split-area.component.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular-split/angular-split/pull/455/{{ revealButtonHref }}
https://github.com/angular-split/angular-split/pull/455/files#diff-4da9705758d522a5feb466260576f171149cbb903b15961df15df6f171fade1f
https://github.com/angular-split/angular-split/pull/455/files#diff-4da9705758d522a5feb466260576f171149cbb903b15961df15df6f171fade1f
projects/angular-split/src/lib/split/split.component.tshttps://github.com/angular-split/angular-split/pull/455/files#diff-f7ad3191fbbbe194fc8cc9b4731835076e912fa37f0ef792c0cca329d7c40813
View file https://github.com/Harpush/angular-split/blob/afd4840db62524f2560c489f31ddc9e2b7d93cfd/projects/angular-split/src/lib/split/split.component.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular-split/angular-split/pull/455/{{ revealButtonHref }}
https://github.com/angular-split/angular-split/pull/455/files#diff-f7ad3191fbbbe194fc8cc9b4731835076e912fa37f0ef792c0cca329d7c40813
https://github.com/angular-split/angular-split/pull/455/files#diff-f7ad3191fbbbe194fc8cc9b4731835076e912fa37f0ef792c0cca329d7c40813
https://github.com/angular-split/angular-split/pull/455/files#diff-f7ad3191fbbbe194fc8cc9b4731835076e912fa37f0ef792c0cca329d7c40813
https://github.com/angular-split/angular-split/pull/455/files#diff-f7ad3191fbbbe194fc8cc9b4731835076e912fa37f0ef792c0cca329d7c40813
https://github.com/angular-split/angular-split/pull/455/files#diff-f7ad3191fbbbe194fc8cc9b4731835076e912fa37f0ef792c0cca329d7c40813
https://github.com/angular-split/angular-split/pull/455/files#diff-f7ad3191fbbbe194fc8cc9b4731835076e912fa37f0ef792c0cca329d7c40813
https://github.com/angular-split/angular-split/pull/455/files#diff-f7ad3191fbbbe194fc8cc9b4731835076e912fa37f0ef792c0cca329d7c40813
https://github.com/angular-split/angular-split/pull/455/files#diff-f7ad3191fbbbe194fc8cc9b4731835076e912fa37f0ef792c0cca329d7c40813
https://github.com/angular-split/angular-split/pull/455/files#diff-f7ad3191fbbbe194fc8cc9b4731835076e912fa37f0ef792c0cca329d7c40813
https://github.com/angular-split/angular-split/pull/455/files#diff-f7ad3191fbbbe194fc8cc9b4731835076e912fa37f0ef792c0cca329d7c40813
https://github.com/angular-split/angular-split/pull/455/files#diff-f7ad3191fbbbe194fc8cc9b4731835076e912fa37f0ef792c0cca329d7c40813
projects/angular-split/src/lib/utils.tshttps://github.com/angular-split/angular-split/pull/455/files#diff-ad6f433f6524065a59814453ad9f9f7a26dc4e735e848d7d2a0866b4d11ab96d
View file https://github.com/Harpush/angular-split/blob/afd4840db62524f2560c489f31ddc9e2b7d93cfd/projects/angular-split/src/lib/utils.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular-split/angular-split/pull/455/{{ revealButtonHref }}
https://github.com/angular-split/angular-split/pull/455/files#diff-ad6f433f6524065a59814453ad9f9f7a26dc4e735e848d7d2a0866b4d11ab96d
projects/angular-split/src/lib/validations.tshttps://github.com/angular-split/angular-split/pull/455/files#diff-f32d4f69900280c33e617e47269637c58eedff4ad27de99c00e28ae28cacd5cc
View file https://github.com/Harpush/angular-split/blob/afd4840db62524f2560c489f31ddc9e2b7d93cfd/projects/angular-split/src/lib/validations.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular-split/angular-split/pull/455/{{ revealButtonHref }}
https://github.com/angular-split/angular-split/pull/455/files#diff-f32d4f69900280c33e617e47269637c58eedff4ad27de99c00e28ae28cacd5cc
https://github.com/angular-split/angular-split/pull/455/files#diff-f32d4f69900280c33e617e47269637c58eedff4ad27de99c00e28ae28cacd5cc
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.