René's URL Explorer Experiment


Title: fix: filter non visible areas after indices array slice by Harpush · Pull Request #451 · angular-split/angular-split · GitHub

Open Graph Title: fix: filter non visible areas after indices array slice by Harpush · Pull Request #451 · angular-split/angular-split

X Title: fix: filter non visible areas after indices array slice by Harpush · Pull Request #451 · angular-split/angular-split

Description: The visibility check happened before the slice operation which resulted in non visible areas before visible areas to get mixed up in the slice resulting in unresponsive gutters. The correct approach is filtering after the slice and not before. Fixes #449

Open Graph Description: The visibility check happened before the slice operation which resulted in non visible areas before visible areas to get mixed up in the slice resulting in unresponsive gutters. The correct approac...

X Description: The visibility check happened before the slice operation which resulted in non visible areas before visible areas to get mixed up in the slice resulting in unresponsive gutters. The correct approac...

Opengraph URL: https://github.com/angular-split/angular-split/pull/451

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:67f1ea1c-70c6-427e-c2a9-1bcfb4323fa3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE85A:1201C:FAEF99:14EE5AA:6B010C7E
html-safe-nonceafda5b651c6c73b2406288c5ac34a88afbc2f041703c9dd2f71d35a72a85744b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFODVBOjEyMDFDOkZBRUY5OToxNEVFNUFBOjZCMDEwQzdFIiwidmlzaXRvcl9pZCI6IjQ0NjYyMjQ1NzE5ODcwNTkwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacbc3a449201b460bcf8f7ec8f5d634014bd3619dbe024d9bb28bcd7a29ac37701
hovercard-subject-tagpull_request:2033698591
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular-split/angular-split/pull/451/files
twitter:imagehttps://avatars.githubusercontent.com/u/30085989?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/30085989?s=400&v=4
og:image:altThe visibility check happened before the slice operation which resulted in non visible areas before visible areas to get mixed up in the slice resulting in unresponsive gutters. The correct approac...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular-split/angular-split git https://github.com/angular-split/angular-split.git
octolytics-dimension-user_id68742971
octolytics-dimension-user_loginangular-split
octolytics-dimension-repository_id76653821
octolytics-dimension-repository_nwoangular-split/angular-split
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id76653821
octolytics-dimension-repository_network_root_nwoangular-split/angular-split
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular-split/angular-split/pull/451/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular-split%2Fangular-split%2Fpull%2F451%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular-split%2Fangular-split%2Fpull%2F451%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular-split%2Fangular-split
Reloadhttps://github.com/angular-split/angular-split/pull/451/files
Reloadhttps://github.com/angular-split/angular-split/pull/451/files
Reloadhttps://github.com/angular-split/angular-split/pull/451/files
angular-splithttps://github.com/angular-split
angular-splithttps://github.com/angular-split/angular-split
Codehttps://github.com/angular-split/angular-split
Issues5 (5)https://github.com/angular-split/angular-split/issues
Pull requests3 (3)https://github.com/angular-split/angular-split/pulls
Discussionshttps://github.com/angular-split/angular-split/discussions
Actionshttps://github.com/angular-split/angular-split/actions
Security and qualityhttps://github.com/angular-split/angular-split/security
Insightshttps://github.com/angular-split/angular-split/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular-split%2Fangular-split%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular-split%2Fangular-split%2Fissues%2Fnew%2Fchoose
Jefioziehttps://github.com/Jefiozie
angular-split:mainhttps://github.com/angular-split/angular-split/tree/main
Harpush:fix-visibility-check-in-move-calculationhttps://github.com/Harpush/angular-split/tree/fix-visibility-check-in-move-calculation
Conversation 0 https://github.com/angular-split/angular-split/pull/451
Commits 2 https://github.com/angular-split/angular-split/pull/451/commits
Checks 0 https://github.com/angular-split/angular-split/pull/451/checks
Files changed https://github.com/angular-split/angular-split/pull/451/files
Please reload this pagehttps://github.com/angular-split/angular-split/pull/451/files
fix: filter non visible areas after indices array slice https://github.com/angular-split/angular-split/pull/451/files#top
Show all changes 2 commits https://github.com/angular-split/angular-split/pull/451/files
ecc58c3 fix: filter non visible areas after indices array slice Harpush Aug 23, 2024 https://github.com/angular-split/angular-split/pull/451/commits/ecc58c3553cbb15adeacb0895c2847bc0ca1d0e6
b7ef228 Merge branch 'main' into fix-visibility-check-in-move-calculation Jefiozie Sep 2, 2024 https://github.com/angular-split/angular-split/pull/451/commits/b7ef228db1f2eb39fd20d64bbdab82b155b781b9
Clear filters https://github.com/angular-split/angular-split/pull/451/files
Please reload this pagehttps://github.com/angular-split/angular-split/pull/451/files
Please reload this pagehttps://github.com/angular-split/angular-split/pull/451/files
10.toggle.cy.js https://github.com/angular-split/angular-split/pull/451/files#diff-799e96a6a41b422a0a6df5253b8c5bb76a578ea52677c2555da02778347869fe
splitUtils.js https://github.com/angular-split/angular-split/pull/451/files#diff-84bb41343e50308ebf9a1dc3f2c6d17997b30790e2bdd42e311d6dfe9eb2d8e1
split.component.ts https://github.com/angular-split/angular-split/pull/451/files#diff-f7ad3191fbbbe194fc8cc9b4731835076e912fa37f0ef792c0cca329d7c40813
cypress/e2e/10.toggle.cy.jshttps://github.com/angular-split/angular-split/pull/451/files#diff-799e96a6a41b422a0a6df5253b8c5bb76a578ea52677c2555da02778347869fe
View file https://github.com/Harpush/angular-split/blob/b7ef228db1f2eb39fd20d64bbdab82b155b781b9/cypress/e2e/10.toggle.cy.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular-split/angular-split/pull/451/{{ revealButtonHref }}
cypress/support/splitUtils.jshttps://github.com/angular-split/angular-split/pull/451/files#diff-84bb41343e50308ebf9a1dc3f2c6d17997b30790e2bdd42e311d6dfe9eb2d8e1
View file https://github.com/Harpush/angular-split/blob/b7ef228db1f2eb39fd20d64bbdab82b155b781b9/cypress/support/splitUtils.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular-split/angular-split/pull/451/{{ revealButtonHref }}
https://github.com/angular-split/angular-split/pull/451/files#diff-84bb41343e50308ebf9a1dc3f2c6d17997b30790e2bdd42e311d6dfe9eb2d8e1
https://github.com/angular-split/angular-split/pull/451/files#diff-84bb41343e50308ebf9a1dc3f2c6d17997b30790e2bdd42e311d6dfe9eb2d8e1
https://github.com/angular-split/angular-split/pull/451/files#diff-84bb41343e50308ebf9a1dc3f2c6d17997b30790e2bdd42e311d6dfe9eb2d8e1
projects/angular-split/src/lib/split/split.component.tshttps://github.com/angular-split/angular-split/pull/451/files#diff-f7ad3191fbbbe194fc8cc9b4731835076e912fa37f0ef792c0cca329d7c40813
View file https://github.com/Harpush/angular-split/blob/b7ef228db1f2eb39fd20d64bbdab82b155b781b9/projects/angular-split/src/lib/split/split.component.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular-split/angular-split/pull/451/{{ revealButtonHref }}
https://github.com/angular-split/angular-split/pull/451/files#diff-f7ad3191fbbbe194fc8cc9b4731835076e912fa37f0ef792c0cca329d7c40813
https://github.com/angular-split/angular-split/pull/451/files#diff-f7ad3191fbbbe194fc8cc9b4731835076e912fa37f0ef792c0cca329d7c40813
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.