René's URL Explorer Experiment


Title: fix: change default area size from null to * by Harpush · Pull Request #358 · angular-split/angular-split · GitHub

Open Graph Title: fix: change default area size from null to * by Harpush · Pull Request #358 · angular-split/angular-split

X Title: fix: change default area size from null to * by Harpush · Pull Request #358 · angular-split/angular-split

Description: Currently we don't support more than a single wildcard - but if no area size was provided or wrong area sizes the default logic in percent mode for example is splitting the size equally (kind of multiple wildcards). This change make split areas without size work again even though this is invalid. The problem can be seen in the collapse example which has no tests coverage (another issue for another time). We should think how to handle it - size required? Support multiple wildcards?

Open Graph Description: Currently we don't support more than a single wildcard - but if no area size was provided or wrong area sizes the default logic in percent mode for example is splitting the size equally (kind o...

X Description: Currently we don't support more than a single wildcard - but if no area size was provided or wrong area sizes the default logic in percent mode for example is splitting the size equally (ki...

Opengraph URL: https://github.com/angular-split/angular-split/pull/358

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:10169ef1-363e-6cb3-c949-6766d280e54c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE86A:F7C4C:E8F9FB:138E3FF:6B010C80
html-safe-nonce67782328a1b179f5c8c92886a823d5ae9a7102cbbe01992d41921933ae1daacb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFODZBOkY3QzRDOkU4RjlGQjoxMzhFM0ZGOjZCMDEwQzgwIiwidmlzaXRvcl9pZCI6IjU2MzIxODc0NDI1MDYzMDQ2NDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac00a996a94c2f6d0b7dfbca65dd78754aae1c31e3ba475d445d5bacff6aa2ec4f
hovercard-subject-tagpull_request:1502168957
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular-split/angular-split/pull/358/files
twitter:imagehttps://avatars.githubusercontent.com/u/30085989?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/30085989?s=400&v=4
og:image:altCurrently we don't support more than a single wildcard - but if no area size was provided or wrong area sizes the default logic in percent mode for example is splitting the size equally (kind o...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular-split/angular-split git https://github.com/angular-split/angular-split.git
octolytics-dimension-user_id68742971
octolytics-dimension-user_loginangular-split
octolytics-dimension-repository_id76653821
octolytics-dimension-repository_nwoangular-split/angular-split
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id76653821
octolytics-dimension-repository_network_root_nwoangular-split/angular-split
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular-split/angular-split/pull/358/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular-split%2Fangular-split%2Fpull%2F358%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular-split%2Fangular-split%2Fpull%2F358%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular-split%2Fangular-split
Reloadhttps://github.com/angular-split/angular-split/pull/358/files
Reloadhttps://github.com/angular-split/angular-split/pull/358/files
Reloadhttps://github.com/angular-split/angular-split/pull/358/files
angular-splithttps://github.com/angular-split
angular-splithttps://github.com/angular-split/angular-split
Codehttps://github.com/angular-split/angular-split
Issues5 (5)https://github.com/angular-split/angular-split/issues
Pull requests3 (3)https://github.com/angular-split/angular-split/pulls
Discussionshttps://github.com/angular-split/angular-split/discussions
Actionshttps://github.com/angular-split/angular-split/actions
Security and qualityhttps://github.com/angular-split/angular-split/security
Insightshttps://github.com/angular-split/angular-split/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular-split%2Fangular-split%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular-split%2Fangular-split%2Fissues%2Fnew%2Fchoose
beemanhttps://github.com/beeman
angular-split:mainhttps://github.com/angular-split/angular-split/tree/main
Harpush:fix-default-size-wildcardhttps://github.com/Harpush/angular-split/tree/fix-default-size-wildcard
Conversation 0 https://github.com/angular-split/angular-split/pull/358
Commits 1 https://github.com/angular-split/angular-split/pull/358/commits
Checks 0 https://github.com/angular-split/angular-split/pull/358/checks
Files changed https://github.com/angular-split/angular-split/pull/358/files
Please reload this pagehttps://github.com/angular-split/angular-split/pull/358/files
fix: change default area size from null to * https://github.com/angular-split/angular-split/pull/358/files#top
Show all changes 1 commit https://github.com/angular-split/angular-split/pull/358/files
edcb817 fix: change default area size from null to * Harpush Sep 5, 2023 https://github.com/angular-split/angular-split/pull/358/commits/edcb817378de74ac9542001c77c2377b2b52f6bb
Clear filters https://github.com/angular-split/angular-split/pull/358/files
Please reload this pagehttps://github.com/angular-split/angular-split/pull/358/files
Please reload this pagehttps://github.com/angular-split/angular-split/pull/358/files
projects/angular-split/src/lib/directive/split-area.directive.tshttps://github.com/angular-split/angular-split/pull/358/files#diff-1dd3f1245011a276fa7544150f8b750f05fbd3f8585eceaafd68065593cbe43f
View file https://github.com/Harpush/angular-split/blob/edcb817378de74ac9542001c77c2377b2b52f6bb/projects/angular-split/src/lib/directive/split-area.directive.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular-split/angular-split/pull/358/{{ revealButtonHref }}
https://github.com/angular-split/angular-split/pull/358/files#diff-1dd3f1245011a276fa7544150f8b750f05fbd3f8585eceaafd68065593cbe43f
https://github.com/angular-split/angular-split/pull/358/files#diff-1dd3f1245011a276fa7544150f8b750f05fbd3f8585eceaafd68065593cbe43f
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.