René's URL Explorer Experiment


Title: Add keyboard accessibility by dxbrandon · Pull Request #317 · angular-split/angular-split · GitHub

Open Graph Title: Add keyboard accessibility by dxbrandon · Pull Request #317 · angular-split/angular-split

X Title: Add keyboard accessibility by dxbrandon · Pull Request #317 · angular-split/angular-split

Description: Bringing back an old pull request from Michelle to add keyboard accessibility: #269. From Michelle's PR: Added "startKeyboardDrag", which uses new util functions to calculate the start and end points differently from mouse events. Moved chunks of "startMouseDrag" out into separate functions so that keyboard drag can share the code: this.startDragging(), this.drag();, this.stopDragging(); Consumers are able to optionally add a text for aria-label via @input(). Additional features: Added role="slider" and made the dragger/gutter tab-able. Added aria-orientation, aria-valuemin, aria-valuemax, aria-valuenow, aria-valuetext. Added PageUp and PageDown support. Arrow keys does a step offset of 50. PageUp and PageDown does a step offset of 500. Added util functions to help test keyboard functionality in the e2e tests. Changed "moveGutter" into "moveGutterByMouse" and introduced "moveGutterByKeyboard", "checkGutterAriaLabel", "checkGuttersAriaValueTexts" Issues discovered while developing: Tab order of the gutters is not top-down left-right In screenreader mode, displayed areas with a size of "*" are not supported because size is null in the displayed area. Keyboard support: Screen reader:

Open Graph Description: Bringing back an old pull request from Michelle to add keyboard accessibility: #269. From Michelle's PR: Added "startKeyboardDrag", which uses new util functions to calculate the sta...

X Description: Bringing back an old pull request from Michelle to add keyboard accessibility: #269. From Michelle's PR: Added "startKeyboardDrag", which uses new util functions to calcu...

Opengraph URL: https://github.com/angular-split/angular-split/pull/317

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b1cba08b-e5f3-7952-b665-ea3232586f42
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD7F8:E9D16:4DD997:623B67:6B010C8F
html-safe-nonce66fef0152ee644089f8f56a2ffb734ec0c9a6faf229660f667cadeee86735d3a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEN0Y4OkU5RDE2OjRERDk5Nzo2MjNCNjc6NkIwMTBDOEYiLCJ2aXNpdG9yX2lkIjoiMzc0MzQ4NzkzNTAwNjE4MjU0MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6c8e30e2aee65d18202076ad30a73e0d056bbbce2129e38473d878f2846e098b
hovercard-subject-tagpull_request:829031968
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular-split/angular-split/pull/317/files
twitter:imagehttps://avatars.githubusercontent.com/u/84741633?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/84741633?s=400&v=4
og:image:altBringing back an old pull request from Michelle to add keyboard accessibility: #269. From Michelle's PR: Added "startKeyboardDrag", which uses new util functions to calculate the sta...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular-split/angular-split git https://github.com/angular-split/angular-split.git
octolytics-dimension-user_id68742971
octolytics-dimension-user_loginangular-split
octolytics-dimension-repository_id76653821
octolytics-dimension-repository_nwoangular-split/angular-split
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id76653821
octolytics-dimension-repository_network_root_nwoangular-split/angular-split
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular-split/angular-split/pull/317/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular-split%2Fangular-split%2Fpull%2F317%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular-split%2Fangular-split%2Fpull%2F317%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular-split%2Fangular-split
Reloadhttps://github.com/angular-split/angular-split/pull/317/files
Reloadhttps://github.com/angular-split/angular-split/pull/317/files
Reloadhttps://github.com/angular-split/angular-split/pull/317/files
angular-splithttps://github.com/angular-split
angular-splithttps://github.com/angular-split/angular-split
Codehttps://github.com/angular-split/angular-split
Issues5 (5)https://github.com/angular-split/angular-split/issues
Pull requests3 (3)https://github.com/angular-split/angular-split/pulls
Discussionshttps://github.com/angular-split/angular-split/discussions
Actionshttps://github.com/angular-split/angular-split/actions
Security and qualityhttps://github.com/angular-split/angular-split/security
Insightshttps://github.com/angular-split/angular-split/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular-split%2Fangular-split%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular-split%2Fangular-split%2Fissues%2Fnew%2Fchoose
beemanhttps://github.com/beeman
angular-split:mainhttps://github.com/angular-split/angular-split/tree/main
dxbrandon:keyboardhttps://github.com/dxbrandon/angular-split/tree/keyboard
Conversation 4 https://github.com/angular-split/angular-split/pull/317
Commits 5 https://github.com/angular-split/angular-split/pull/317/commits
Checks 0 https://github.com/angular-split/angular-split/pull/317/checks
Files changed https://github.com/angular-split/angular-split/pull/317/files
Please reload this pagehttps://github.com/angular-split/angular-split/pull/317/files
Add keyboard accessibility https://github.com/angular-split/angular-split/pull/317/files#top
Show all changes 5 commits https://github.com/angular-split/angular-split/pull/317/files
62b424e Add keyboard accessibility dxbrandon Jan 21, 2022 https://github.com/angular-split/angular-split/pull/317/commits/62b424e56a2352a53addb1c60f9681cdfd341835
2c330d4 keyboard offset set to 50 dxbrandon Jan 21, 2022 https://github.com/angular-split/angular-split/pull/317/commits/2c330d4b8038ac1a2cb206b8c75a168522539346
6759080 Cypress tests for keyboard functionality dxbrandon Jan 24, 2022 https://github.com/angular-split/angular-split/pull/317/commits/6759080473dad9baade4935189c85bc8c26092a7
cf5ac3d Update tests dxbrandon Jan 24, 2022 https://github.com/angular-split/angular-split/pull/317/commits/cf5ac3dad4d8cd86a7a5ad057330b767cf503a93
4042206 Fix typo dxbrandon Jan 24, 2022 https://github.com/angular-split/angular-split/pull/317/commits/4042206efc7989630050aa80f5fac519ed4e996c
Clear filters https://github.com/angular-split/angular-split/pull/317/files
Please reload this pagehttps://github.com/angular-split/angular-split/pull/317/files
Please reload this pagehttps://github.com/angular-split/angular-split/pull/317/files
1.simple.spec.js https://github.com/angular-split/angular-split/pull/317/files#diff-52dc37e0f012b08b4920c36efc71a53ba5159a71bc87849313a4896495c8901b
2.minmax.spec.js https://github.com/angular-split/angular-split/pull/317/files#diff-4f2265e108bef3a1441b9a1b10c7b5c7aab29892d08772aae9404ce3b41ade10
3.nested.spec.js https://github.com/angular-split/angular-split/pull/317/files#diff-e43b1cdf0cc3debc45ee44fe367da036368069f97962cd5c154ea29753d2ea39
4.sync.spec.js https://github.com/angular-split/angular-split/pull/317/files#diff-32fa8e4f79083c9c169a75e61eb91f066bf7885fa3eb79c837b609a9265d6336
5.style.spec.js https://github.com/angular-split/angular-split/pull/317/files#diff-f53393d8979cf788677af4931e57adbaabeab4ca436c9c91a73dbb0c5612a04a
7.click.spec.js https://github.com/angular-split/angular-split/pull/317/files#diff-48e7f7e688ba89d5aa6a0ade3b2c8bfc4cdd984fc471ae591e17db6882b19e25
9.geek.spec.js https://github.com/angular-split/angular-split/pull/317/files#diff-1ad842e1cdf70f6918527b189732497e175c7b2fb74d1c0b28312f7d6fb0cae0
splitUtils.js https://github.com/angular-split/angular-split/pull/317/files#diff-84bb41343e50308ebf9a1dc3f2c6d17997b30790e2bdd42e311d6dfe9eb2d8e1
split.component.scss https://github.com/angular-split/angular-split/pull/317/files#diff-ee8ad8b2ba67dbb5c005d1e2161f088a89bdb60293d405ed00e085759431fb80
split.component.ts https://github.com/angular-split/angular-split/pull/317/files#diff-6f5a8917c090bf026afcda2d3e93dfffb49814f0b1b9abfb3c0504c2d3af1693
utils.ts https://github.com/angular-split/angular-split/pull/317/files#diff-ad6f433f6524065a59814453ad9f9f7a26dc4e735e848d7d2a0866b4d11ab96d
simple-split.component.ts https://github.com/angular-split/angular-split/pull/317/files#diff-d0d5762646cefbf15e4982c24ad1baa58c1ea6ece695e703cb4c4b7535cad823
cypress/integration/1.simple.spec.jshttps://github.com/angular-split/angular-split/pull/317/files#diff-52dc37e0f012b08b4920c36efc71a53ba5159a71bc87849313a4896495c8901b
View file https://github.com/dxbrandon/angular-split/blob/4042206efc7989630050aa80f5fac519ed4e996c/cypress/integration/1.simple.spec.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular-split/angular-split/pull/317/{{ revealButtonHref }}
https://github.com/angular-split/angular-split/pull/317/files#diff-52dc37e0f012b08b4920c36efc71a53ba5159a71bc87849313a4896495c8901b
https://github.com/angular-split/angular-split/pull/317/files#diff-52dc37e0f012b08b4920c36efc71a53ba5159a71bc87849313a4896495c8901b
cypress/integration/2.minmax.spec.jshttps://github.com/angular-split/angular-split/pull/317/files#diff-4f2265e108bef3a1441b9a1b10c7b5c7aab29892d08772aae9404ce3b41ade10
View file https://github.com/dxbrandon/angular-split/blob/4042206efc7989630050aa80f5fac519ed4e996c/cypress/integration/2.minmax.spec.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular-split/angular-split/pull/317/{{ revealButtonHref }}
https://github.com/angular-split/angular-split/pull/317/files#diff-4f2265e108bef3a1441b9a1b10c7b5c7aab29892d08772aae9404ce3b41ade10
https://github.com/angular-split/angular-split/pull/317/files#diff-4f2265e108bef3a1441b9a1b10c7b5c7aab29892d08772aae9404ce3b41ade10
https://github.com/angular-split/angular-split/pull/317/files#diff-4f2265e108bef3a1441b9a1b10c7b5c7aab29892d08772aae9404ce3b41ade10
https://github.com/angular-split/angular-split/pull/317/files#diff-4f2265e108bef3a1441b9a1b10c7b5c7aab29892d08772aae9404ce3b41ade10
https://github.com/angular-split/angular-split/pull/317/files#diff-4f2265e108bef3a1441b9a1b10c7b5c7aab29892d08772aae9404ce3b41ade10
https://github.com/angular-split/angular-split/pull/317/files#diff-4f2265e108bef3a1441b9a1b10c7b5c7aab29892d08772aae9404ce3b41ade10
https://github.com/angular-split/angular-split/pull/317/files#diff-4f2265e108bef3a1441b9a1b10c7b5c7aab29892d08772aae9404ce3b41ade10
https://github.com/angular-split/angular-split/pull/317/files#diff-4f2265e108bef3a1441b9a1b10c7b5c7aab29892d08772aae9404ce3b41ade10
https://github.com/angular-split/angular-split/pull/317/files#diff-4f2265e108bef3a1441b9a1b10c7b5c7aab29892d08772aae9404ce3b41ade10
https://github.com/angular-split/angular-split/pull/317/files#diff-4f2265e108bef3a1441b9a1b10c7b5c7aab29892d08772aae9404ce3b41ade10
https://github.com/angular-split/angular-split/pull/317/files#diff-4f2265e108bef3a1441b9a1b10c7b5c7aab29892d08772aae9404ce3b41ade10
https://github.com/angular-split/angular-split/pull/317/files#diff-4f2265e108bef3a1441b9a1b10c7b5c7aab29892d08772aae9404ce3b41ade10
https://github.com/angular-split/angular-split/pull/317/files#diff-4f2265e108bef3a1441b9a1b10c7b5c7aab29892d08772aae9404ce3b41ade10
https://github.com/angular-split/angular-split/pull/317/files#diff-4f2265e108bef3a1441b9a1b10c7b5c7aab29892d08772aae9404ce3b41ade10
https://github.com/angular-split/angular-split/pull/317/files#diff-4f2265e108bef3a1441b9a1b10c7b5c7aab29892d08772aae9404ce3b41ade10
https://github.com/angular-split/angular-split/pull/317/files#diff-4f2265e108bef3a1441b9a1b10c7b5c7aab29892d08772aae9404ce3b41ade10
Please reload this pagehttps://github.com/angular-split/angular-split/pull/317/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.