René's URL Explorer Experiment


Title: Add keyboard accessibility by miffens-dx · Pull Request #269 · angular-split/angular-split · GitHub

Open Graph Title: Add keyboard accessibility by miffens-dx · Pull Request #269 · angular-split/angular-split

X Title: Add keyboard accessibility by miffens-dx · Pull Request #269 · angular-split/angular-split

Description: Fixes issue #98 Changed dragger/ gutter from div to button in template for keyboard focus Added "startKeyboardDrag", which uses new util functions to calculate the start and end points differently from mouse events. Moved chunks of "startMouseDrag" out into separate functions so that keyboard drag can share the code: this.currentlyDragging(), this.drag();, this.stopDragging(); Question: Thoughts on getKeyboardEndpoint doing the "exit early" checks and returning null? Should that be handled by a separate function? Issues discovered while developing: tab order of the gutters is not top-down left-right keyboard resizing does not work while in screenreader mode (stopPropagation could be blocking it) should add a new binding to set an aria label on the gutter. Could be addressed in a quick followup PR targeting screenreader support Note: The vertical splits in the demo gif don't have the smooth animation because they don't have a the useTransition animation binding set to true

Open Graph Description: Fixes issue #98 Changed dragger/ gutter from div to button in template for keyboard focus Added "startKeyboardDrag", which uses new util functions to calculate the start and end points d...

X Description: Fixes issue #98 Changed dragger/ gutter from div to button in template for keyboard focus Added "startKeyboardDrag", which uses new util functions to calculate the start and end ...

Opengraph URL: https://github.com/angular-split/angular-split/pull/269

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c86d5889-7be4-3529-8b56-dc137f51260d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8066:34DB8F:EFB221:140C43B:6B0110C9
html-safe-nonce465a273608879534a7e0b57274d530f8023127104a982fb840c23662d108511a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDY2OjM0REI4RjpFRkIyMjE6MTQwQzQzQjo2QjAxMTBDOSIsInZpc2l0b3JfaWQiOiI1NDU5MjU2ODQyMTAwMjE2MDA5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac8ec77d75d5dcbff5ac68e3613c8ffb6a708a1529a86b323f108c5a8dd4d80d7f
hovercard-subject-tagpull_request:507816124
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular-split/angular-split/pull/269/files
twitter:imagehttps://avatars.githubusercontent.com/u/73202210?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/73202210?s=400&v=4
og:image:altFixes issue #98 Changed dragger/ gutter from div to button in template for keyboard focus Added "startKeyboardDrag", which uses new util functions to calculate the start and end points d...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular-split/angular-split git https://github.com/angular-split/angular-split.git
octolytics-dimension-user_id68742971
octolytics-dimension-user_loginangular-split
octolytics-dimension-repository_id76653821
octolytics-dimension-repository_nwoangular-split/angular-split
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id76653821
octolytics-dimension-repository_network_root_nwoangular-split/angular-split
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular-split/angular-split/pull/269/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular-split%2Fangular-split%2Fpull%2F269%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular-split%2Fangular-split%2Fpull%2F269%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular-split%2Fangular-split
Reloadhttps://github.com/angular-split/angular-split/pull/269/files
Reloadhttps://github.com/angular-split/angular-split/pull/269/files
Reloadhttps://github.com/angular-split/angular-split/pull/269/files
angular-splithttps://github.com/angular-split
angular-splithttps://github.com/angular-split/angular-split
Codehttps://github.com/angular-split/angular-split
Issues5 (5)https://github.com/angular-split/angular-split/issues
Pull requests3 (3)https://github.com/angular-split/angular-split/pulls
Discussionshttps://github.com/angular-split/angular-split/discussions
Actionshttps://github.com/angular-split/angular-split/actions
Security and qualityhttps://github.com/angular-split/angular-split/security
Insightshttps://github.com/angular-split/angular-split/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular-split%2Fangular-split%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular-split%2Fangular-split%2Fissues%2Fnew%2Fchoose
miffens-dxhttps://github.com/miffens-dx
angular-split:mainhttps://github.com/angular-split/angular-split/tree/main
miffens-dx:accessibilityhttps://github.com/miffens-dx/angular-split/tree/accessibility
Conversation 1 https://github.com/angular-split/angular-split/pull/269
Commits 2 https://github.com/angular-split/angular-split/pull/269/commits
Checks 0 https://github.com/angular-split/angular-split/pull/269/checks
Files changed https://github.com/angular-split/angular-split/pull/269/files
Please reload this pagehttps://github.com/angular-split/angular-split/pull/269/files
Add keyboard accessibility https://github.com/angular-split/angular-split/pull/269/files#top
Show all changes 2 commits https://github.com/angular-split/angular-split/pull/269/files
8f8b6ee add keyboard controls miffens-dx Oct 21, 2020 https://github.com/angular-split/angular-split/pull/269/commits/8f8b6ee1b7f652857df60806277bd36e241869b4
847c204 add keyboard controls - address comments miffens-dx Oct 22, 2020 https://github.com/angular-split/angular-split/pull/269/commits/847c2041b63fd072d0c29bd20a4769bdbc1f07f0
Clear filters https://github.com/angular-split/angular-split/pull/269/files
Please reload this pagehttps://github.com/angular-split/angular-split/pull/269/files
Please reload this pagehttps://github.com/angular-split/angular-split/pull/269/files
split.component.scss https://github.com/angular-split/angular-split/pull/269/files#diff-ee8ad8b2ba67dbb5c005d1e2161f088a89bdb60293d405ed00e085759431fb80
split.component.ts https://github.com/angular-split/angular-split/pull/269/files#diff-6f5a8917c090bf026afcda2d3e93dfffb49814f0b1b9abfb3c0504c2d3af1693
utils.ts https://github.com/angular-split/angular-split/pull/269/files#diff-ad6f433f6524065a59814453ad9f9f7a26dc4e735e848d7d2a0866b4d11ab96d
projects/angular-split/src/lib/component/split.component.scsshttps://github.com/angular-split/angular-split/pull/269/files#diff-ee8ad8b2ba67dbb5c005d1e2161f088a89bdb60293d405ed00e085759431fb80
View file https://github.com/miffens-dx/angular-split/blob/847c2041b63fd072d0c29bd20a4769bdbc1f07f0/projects/angular-split/src/lib/component/split.component.scss
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular-split/angular-split/pull/269/{{ revealButtonHref }}
https://github.com/angular-split/angular-split/pull/269/files#diff-ee8ad8b2ba67dbb5c005d1e2161f088a89bdb60293d405ed00e085759431fb80
https://github.com/angular-split/angular-split/pull/269/files#diff-ee8ad8b2ba67dbb5c005d1e2161f088a89bdb60293d405ed00e085759431fb80
projects/angular-split/src/lib/component/split.component.tshttps://github.com/angular-split/angular-split/pull/269/files#diff-6f5a8917c090bf026afcda2d3e93dfffb49814f0b1b9abfb3c0504c2d3af1693
View file https://github.com/miffens-dx/angular-split/blob/847c2041b63fd072d0c29bd20a4769bdbc1f07f0/projects/angular-split/src/lib/component/split.component.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular-split/angular-split/pull/269/{{ revealButtonHref }}
https://github.com/angular-split/angular-split/pull/269/files#diff-6f5a8917c090bf026afcda2d3e93dfffb49814f0b1b9abfb3c0504c2d3af1693
https://github.com/angular-split/angular-split/pull/269/files#diff-6f5a8917c090bf026afcda2d3e93dfffb49814f0b1b9abfb3c0504c2d3af1693
https://github.com/angular-split/angular-split/pull/269/files#diff-6f5a8917c090bf026afcda2d3e93dfffb49814f0b1b9abfb3c0504c2d3af1693
https://github.com/angular-split/angular-split/pull/269/files#diff-6f5a8917c090bf026afcda2d3e93dfffb49814f0b1b9abfb3c0504c2d3af1693
https://github.com/angular-split/angular-split/pull/269/files#diff-6f5a8917c090bf026afcda2d3e93dfffb49814f0b1b9abfb3c0504c2d3af1693
https://github.com/angular-split/angular-split/pull/269/files#diff-6f5a8917c090bf026afcda2d3e93dfffb49814f0b1b9abfb3c0504c2d3af1693
https://github.com/angular-split/angular-split/pull/269/files#diff-6f5a8917c090bf026afcda2d3e93dfffb49814f0b1b9abfb3c0504c2d3af1693
https://github.com/angular-split/angular-split/pull/269/files#diff-6f5a8917c090bf026afcda2d3e93dfffb49814f0b1b9abfb3c0504c2d3af1693
https://github.com/angular-split/angular-split/pull/269/files#diff-6f5a8917c090bf026afcda2d3e93dfffb49814f0b1b9abfb3c0504c2d3af1693
https://github.com/angular-split/angular-split/pull/269/files#diff-6f5a8917c090bf026afcda2d3e93dfffb49814f0b1b9abfb3c0504c2d3af1693
https://github.com/angular-split/angular-split/pull/269/files#diff-6f5a8917c090bf026afcda2d3e93dfffb49814f0b1b9abfb3c0504c2d3af1693
projects/angular-split/src/lib/utils.tshttps://github.com/angular-split/angular-split/pull/269/files#diff-ad6f433f6524065a59814453ad9f9f7a26dc4e735e848d7d2a0866b4d11ab96d
View file https://github.com/miffens-dx/angular-split/blob/847c2041b63fd072d0c29bd20a4769bdbc1f07f0/projects/angular-split/src/lib/utils.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular-split/angular-split/pull/269/{{ revealButtonHref }}
https://github.com/angular-split/angular-split/pull/269/files#diff-ad6f433f6524065a59814453ad9f9f7a26dc4e735e848d7d2a0866b4d11ab96d
https://github.com/angular-split/angular-split/pull/269/files#diff-ad6f433f6524065a59814453ad9f9f7a26dc4e735e848d7d2a0866b4d11ab96d
https://github.com/angular-split/angular-split/pull/269/files#diff-ad6f433f6524065a59814453ad9f9f7a26dc4e735e848d7d2a0866b4d11ab96d
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.