Title: Only reviews by reviewers with write access count towards mergeability · Issue #20 · angular/github-robot · GitHub
Open Graph Title: Only reviews by reviewers with write access count towards mergeability · Issue #20 · angular/github-robot
X Title: Only reviews by reviewers with write access count towards mergeability · Issue #20 · angular/github-robot
Description: I've ran into an issue with angular/angular#25581 where I have a reviewer (alfaproject) who doesn't have write access who suggested changes and this is blocking the PR from going green with: @ngbot ci/angular: merge status Pending — 1 pe...
Open Graph Description: I've ran into an issue with angular/angular#25581 where I have a reviewer (alfaproject) who doesn't have write access who suggested changes and this is blocking the PR from going green with: @ngbot...
X Description: I've ran into an issue with angular/angular#25581 where I have a reviewer (alfaproject) who doesn't have write access who suggested changes and this is blocking the PR from going green with...
Opengraph URL: https://github.com/angular/github-robot/issues/20
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Only reviews by reviewers with write access count towards mergeability","articleBody":"I've ran into an issue with https://github.com/angular/angular/pull/25581 where I have a reviewer (alfaproject) who doesn't have write access who suggested changes and this is blocking the PR from going green with: `@ngbot ci/angular: merge status Pending — 1 pending code review`.\r\n\r\nHowever, there is no way to dismiss his review either in the list of reviewers or in the list of reviews.\r\n\r\nI think the correct behavior is that the bot should follow the same logic as GitHub where only reviews by reviewers with write access count towards mergeability.\r\n\r\n//cc @alexeagle ","author":{"url":"https://github.com/gregmagolan","@type":"Person","name":"gregmagolan"},"datePublished":"2018-08-29T16:32:31Z","url":"https://github.com/angular/github-robot/issues/20"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:166fbac5-6047-521b-2511-67c304b59f8a |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D528:A99C2:164A634:1C7217C:6B01218B |
| html-safe-nonce | 4264d34c7452ff7193a2da067d3760db8814936f49c50f9732766a89810f0e84 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENTI4OkE5OUMyOjE2NEE2MzQ6MUM3MjE3Qzo2QjAxMjE4QiIsInZpc2l0b3JfaWQiOiI5NDcwMTQxNTAzNjk1Mjk3MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 04ab02430444a94006cc38982e7fb5f09730c95033633ca12e28edae70db4f3c |
| hovercard-subject-tag | issue:355240816 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/github-robot/20/issue_layout |
| twitter:image | https://opengraph.githubassets.com/f72a87f7f82af1b42343e7163d57b5b1c21f5025789ffbe3540ae81b7be86fb3/angular/github-robot/issues/20 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f72a87f7f82af1b42343e7163d57b5b1c21f5025789ffbe3540ae81b7be86fb3/angular/github-robot/issues/20 |
| og:image:alt | I've ran into an issue with angular/angular#25581 where I have a reviewer (alfaproject) who doesn't have write access who suggested changes and this is blocking the PR from going green with: @ngbot... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gregmagolan |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/github-robot git https://github.com/angular/github-robot.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 111608678 |
| octolytics-dimension-repository_nwo | angular/github-robot |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 111608678 |
| octolytics-dimension-repository_network_root_nwo | angular/github-robot |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width