René's URL Explorer Experiment


Title: build-optimizer: "logical OR" property assignment is removed · Issue #388 · angular/devkit · GitHub

Open Graph Title: build-optimizer: "logical OR" property assignment is removed · Issue #388 · angular/devkit

X Title: build-optimizer: "logical OR" property assignment is removed · Issue #388 · angular/devkit

Description: Bug Report or Feature Request (mark with an x) - [X] bug report -> please search issues before submitting - [ ] feature request Area - [X] devkit - [ ] schematics Versions `-- @angular/cli@1.6.4 `-- @angular-devkit/build-optimizer@0.0.38...

Open Graph Description: Bug Report or Feature Request (mark with an x) - [X] bug report -> please search issues before submitting - [ ] feature request Area - [X] devkit - [ ] schematics Versions `-- @angular/cli@1.6.4 `-...

X Description: Bug Report or Feature Request (mark with an x) - [X] bug report -> please search issues before submitting - [ ] feature request Area - [X] devkit - [ ] schematics Versions `-- @angular/cli@1.6.4...

Opengraph URL: https://github.com/angular/devkit/issues/388

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"build-optimizer: \"logical OR\" property assignment is removed","articleBody":"### Bug Report or Feature Request (mark with an `x`)\r\n```\r\n- [X] bug report -> please search issues before submitting\r\n- [ ] feature request\r\n```\r\n\r\n### Area\r\n```\r\n- [X] devkit\r\n- [ ] schematics\r\n```\r\n\r\n### Versions\r\n\r\n```\r\n`-- @angular/cli@1.6.4\r\n  `-- @angular-devkit/build-optimizer@0.0.38\r\n\r\nnode -v // 8.5.0\r\nnpm -v // 5.5.1\r\n```\r\n\r\n\r\n### Repro steps\r\n\r\nClone [this reproduction repository](https://github.com/DevVersion/button-build-optimizer-issue) and run the app in two different ways:\r\n\r\n* With the build optimizer (using `-prod --aot`)\r\n* Without the build optimizer (using `-prod --aot --build-optimizer=false`)\r\n\r\n\u003cimg width=\"974\" alt=\"problemexplanation\" src=\"https://user-images.githubusercontent.com/4987015/34905995-1dccb29a-f864-11e7-9e53-51a8567c1558.PNG\">\r\n\r\nThe highlighted code snippet here (picture from the ESM 5 file _button.js_ file) is being removed when running with the build optimizer. If you add a `console.log` before, the `console.log` stays, just the specific code snippet is being removed.\r\n\r\nSwitching to a ternary, or simple if-else will fix the issue. \r\n\r\n\r\n_with build-optimizer disabled_\r\n![image](https://user-images.githubusercontent.com/4987015/34905474-a595eed6-f859-11e7-9863-20d687ba4f0b.png)\r\n\r\n__with build-optimizer enabled_\r\n![image](https://user-images.githubusercontent.com/4987015/34905476-a9cb0ab8-f859-11e7-9feb-76fed96d5a35.png)\r\n\r\n\r\n### Mention any other details that might be useful\r\n\r\nRelated to Angular Material. https://github.com/angular/material2/issues/9360\r\n\r\ncc. @filipesilva ","author":{"url":"https://github.com/devversion","@type":"Person","name":"devversion"},"datePublished":"2018-01-13T12:19:11Z","url":"https://github.com/angular/devkit/issues/388"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:e85befbb-45e2-ca99-ab29-5c8560fb5f14
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA43A:2454CC:1375D8E:18B8912:6B012724
html-safe-nonce4ceec4b208acf37af63b6adf35e29e31e6d1cd6882a17809e19c9e20dadd6e58
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDNBOjI0NTRDQzoxMzc1RDhFOjE4Qjg5MTI6NkIwMTI3MjQiLCJ2aXNpdG9yX2lkIjoiNDAxNTczNjM3MTc1NDUzNDc2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac97dd321a0e4a38e549a09a1782de8911eecd11ec36969eef74628e78d1021572
hovercard-subject-tagissue:288324608
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/devkit/388/issue_layout
twitter:imagehttps://opengraph.githubassets.com/c0411b3473d4001cf828163d64405daa3e60862bdd16efc67bc201782d784617/angular/devkit/issues/388
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c0411b3473d4001cf828163d64405daa3e60862bdd16efc67bc201782d784617/angular/devkit/issues/388
og:image:altBug Report or Feature Request (mark with an x) - [X] bug report -> please search issues before submitting - [ ] feature request Area - [X] devkit - [ ] schematics Versions `-- @angular/cli@1.6.4 `-...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedevversion
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/devkit git https://github.com/angular/devkit.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id88288940
octolytics-dimension-repository_nwoangular/devkit
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id88288940
octolytics-dimension-repository_network_root_nwoangular/devkit
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/devkit/issues/388#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fdevkit%2Fissues%2F388
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fdevkit%2Fissues%2F388
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fdevkit
Reloadhttps://github.com/angular/devkit/issues/388
Reloadhttps://github.com/angular/devkit/issues/388
Reloadhttps://github.com/angular/devkit/issues/388
angularhttps://github.com/angular
devkithttps://github.com/angular/devkit
Codehttps://github.com/angular/devkit
Issueshttps://github.com/angular/devkit/issues
Pull requestshttps://github.com/angular/devkit/pulls
Actionshttps://github.com/angular/devkit/actions
Projectshttps://github.com/angular/devkit/projects
Security and qualityhttps://github.com/angular/devkit/security
Insightshttps://github.com/angular/devkit/insights
https://github.com/angular/devkit
build-optimizer: "logical OR" property assignment is removedhttps://github.com/angular/devkit/issues/388#top
https://github.com/filipesilva
comp: angular-devkit/build-optimizerhttps://github.com/angular/devkit/issues?q=state%3Aopen%20label%3A%22comp%3A%20angular-devkit%2Fbuild-optimizer%22
https://github.com/devversion
devversionhttps://github.com/devversion
on Jan 13, 2018https://github.com/angular/devkit/issues/388#issue-288324608
this reproduction repositoryhttps://github.com/DevVersion/button-build-optimizer-issue
https://user-images.githubusercontent.com/4987015/34905995-1dccb29a-f864-11e7-9e53-51a8567c1558.PNG
https://user-images.githubusercontent.com/4987015/34905474-a595eed6-f859-11e7-9863-20d687ba4f0b.png
https://user-images.githubusercontent.com/4987015/34905476-a9cb0ab8-f859-11e7-9feb-76fed96d5a35.png
angular/components#9360https://github.com/angular/components/issues/9360
@filipesilvahttps://github.com/filipesilva
devversionhttps://github.com/devversion
on Jan 13, 2018https://github.com/angular/devkit/issues/388#event-1422951511
fix(button): accent color not set on fab buttons with build optimizerhttps://github.com/devversion/material2/commit/897062c29d79bcc8a1943a4a4c50f7a798db5b1a
897062chttps://github.com/devversion/material2/commit/897062c29d79bcc8a1943a4a4c50f7a798db5b1a
fix(button): accent color not set on fab buttons with build optimizerhttps://github.com/devversion/material2/commit/10804d1afd42c9fa7b12faf7e619effc20012a17
10804d1https://github.com/devversion/material2/commit/10804d1afd42c9fa7b12faf7e619effc20012a17
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
on Jan 15, 2018https://github.com/angular/devkit/issues/388#issuecomment-357656602
#364https://github.com/angular/devkit/issues/364
scrub-file transformhttps://github.com/angular/devkit/blob/master/packages/angular_devkit/build_optimizer/README.md#scrub-file
prefix-functions transformhttps://github.com/angular/devkit/blob/master/packages/angular_devkit/build_optimizer/README.md#prefix-functions
@IgorMinarhttps://github.com/IgorMinar
@petebacondarwinhttps://github.com/petebacondarwin
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
on Jan 15, 2018https://github.com/angular/devkit/issues/388#issuecomment-357658510
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
on Jan 15, 2018https://github.com/angular/devkit/issues/388#issuecomment-357659668
https://github.com/IgorMinar
IgorMinarhttps://github.com/IgorMinar
on Jan 19, 2018https://github.com/angular/devkit/issues/388#issuecomment-359056319
jelbournhttps://github.com/jelbourn
on Jan 21, 2018https://github.com/angular/devkit/issues/388#event-1433904214
fix(button): accent color not set on fab buttons with build optimizerhttps://github.com/angular/components/commit/f6bd3fb3e37f41183c6ad83461ae9117411394fc
f6bd3fbhttps://github.com/angular/components/commit/f6bd3fb3e37f41183c6ad83461ae9117411394fc
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
on Jan 22, 2018https://github.com/angular/devkit/issues/388#issuecomment-359403638
@IgorMinarhttps://github.com/IgorMinar
https://github.com/angular/material2/blob/45235566588805ebb06f59f9b7826b865429ec3e/src/lib/button/button.ts#L77-L83https://github.com/angular/material2/blob/45235566588805ebb06f59f9b7826b865429ec3e/src/lib/button/button.ts#L77-L83
@devversionhttps://github.com/devversion
angular/components#9376https://github.com/angular/components/pull/9376
@kzchttps://github.com/kzc
https://github.com/kzc
kzchttps://github.com/kzc
on Jan 22, 2018https://github.com/angular/devkit/issues/388#issuecomment-359480251
@filipesilvahttps://github.com/filipesilva
https://github.com/kzc
kzchttps://github.com/kzc
on Jan 22, 2018https://github.com/angular/devkit/issues/388#issuecomment-359485501
mishoo/UglifyJS@0b0eac1https://github.com/mishoo/UglifyJS/commit/0b0eac1d5dc6e1cc1e9bf3682871cafdda59066d
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
on Jan 22, 2018https://github.com/angular/devkit/issues/388#issuecomment-359487087
@kzchttps://github.com/kzc
mishoo/UglifyJS#2838https://github.com/mishoo/UglifyJS/issues/2838
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
on Jan 23, 2018https://github.com/angular/devkit/issues/388#issuecomment-359733884
mishoo/UglifyJS#2839https://github.com/mishoo/UglifyJS/pull/2839
jelbournhttps://github.com/jelbourn
on Jan 23, 2018https://github.com/angular/devkit/issues/388#event-1437603913
fix(button): accent color not set on fab buttons with build optimizer (…https://github.com/angular/components/commit/b3f8a423215b2d8d3690b11b1ceeb4d17faf3867
…https://github.com/angular/components/pull/9376
b3f8a42https://github.com/angular/components/commit/b3f8a423215b2d8d3690b11b1ceeb4d17faf3867
https://github.com/IgorMinar
IgorMinarhttps://github.com/IgorMinar
on Jan 24, 2018https://github.com/angular/devkit/issues/388#issuecomment-360019897
filipesilvahttps://github.com/filipesilva
on Jan 25, 2018https://github.com/angular/devkit/issues/388#event-1441704435
filipesilvahttps://github.com/filipesilva
comp: angular-devkit/build-optimizerhttps://github.com/angular/devkit/issues?q=state%3Aopen%20label%3A%22comp%3A%20angular-devkit%2Fbuild-optimizer%22
on Jan 25, 2018https://github.com/angular/devkit/issues/388#event-1441704583
jelbournhttps://github.com/jelbourn
on Jan 29, 2018https://github.com/angular/devkit/issues/388#event-1447479227
fix(button): accent color not set on fab buttons with build optimizer (…https://github.com/jelbourn/components/commit/f6a59cdde88a21c788fcab8fa2453863dcb342b4
…https://github.com/angular/components/pull/9376
f6a59cdhttps://github.com/jelbourn/components/commit/f6a59cdde88a21c788fcab8fa2453863dcb342b4
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
on Jan 30, 2018https://github.com/angular/devkit/issues/388#issuecomment-361723585
filipesilvahttps://github.com/filipesilva
completedhttps://github.com/angular/devkit/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Jan 30, 2018https://github.com/angular/devkit/issues/388#event-1449406178
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/devkit/issues/388
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/devkit/issues/388
filipesilvahttps://github.com/filipesilva
comp: angular-devkit/build-optimizerhttps://github.com/angular/devkit/issues?q=state%3Aopen%20label%3A%22comp%3A%20angular-devkit%2Fbuild-optimizer%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.