react-profiling 0
react-import-map react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controller voltron_pull_requests_fragments
route-action pull_request_layout
fetch-nonce v2:881213a8-5ac9-9e84-73bb-d8440e2856f9
current-catalog-service-hash ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id 8130:DE490:2293A:2CFE0:6B01A408
html-safe-nonce 90f0d0bae8c4762a29085f55f34e687949505d446ae8509b5d1ef8720b956cd9
visitor-payload eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MTMwOkRFNDkwOjIyOTNBOjJDRkUwOjZCMDFBNDA4IiwidmlzaXRvcl9pZCI6IjcxNDQzMjEzNjcyOTc1OTg0NzIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac fb6a0edd274213b474771847a277480510d4cf52486f0b399931c43fecf4f17c
hovercard-subject-tag pull_request:940565711
github-keyboard-shortcuts repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verification Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-url https://collector.github.com/github/collect
analytics-location ///voltron/pull_requests_fragments/pull_request_layout
fb:app_id 1401488693436528
apple-itunes-app app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/components/24941/pull_request_layout
twitter:image https://opengraph.githubassets.com/ff0ae99e1a4ab52b33f7cfd144349130078bf74e82569da986fdbe3c1177a3eb/angular/components/pull/24941
twitter:card summary_large_image
og:image https://opengraph.githubassets.com/ff0ae99e1a4ab52b33f7cfd144349130078bf74e82569da986fdbe3c1177a3eb/angular/components/pull/24941
og:image:alt This change switches the cdk menu from using constructor injection to using the inject function. This was enabled by angular/angular#45991. This approach has a number of advantages:
We can add and...
og:image:width 1200
og:image:height 600
og:site_name GitHub
og:type object
og:author:username jelbourn
hostname github.com
expected-hostname github.com
None cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-control no-cache
go-import github.com/angular/components git https://github.com/angular/components.git
octolytics-dimension-user_id 139426
octolytics-dimension-user_login angular
octolytics-dimension-repository_id 49016322
octolytics-dimension-repository_nwo angular/components
octolytics-dimension-repository_public true
octolytics-dimension-repository_is_fork false
octolytics-dimension-repository_network_root_id 49016322
octolytics-dimension-repository_network_root_nwo angular/components
turbo-body-classes logged-out env-production page-responsive
disable-turbo false
browser-stats-url https://api.github.com/_private/browser/stats
browser-errors-url https://api.github.com/_private/browser/errors
release 8c77c9e8439031ad54c75a250694842892f693e1
ui-target full
theme-color #1e2327
color-scheme light dark
react-app-name pull-requests
Skip to content https://github.com/angular/components/pull/24941#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fcomponents%2Fpull%2F24941
GitHubRepository hosting, code review, and collaboration https://github.com/platform
CopilotAI coding agent for tasks, projects, and automated work https://github.com/features/copilot
ActionsCI/CD and automation https://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcement https://github.com/features/code-quality
CodespacesCloud development environments https://github.com/features/codespaces
Code SecurityVulnerability detection and remediation https://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak prevention https://github.com/security/advanced-security/secret-protection
All Features https://github.com/features
Documentation https://docs.github.com/en
Training https://learn.github.com/skills
Certifications https://learn.github.com/credentials
Build with Copilot https://github.com/features/ai
Customize Copilot https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrations https://github.com/marketplace
Trending repos https://github.com/trending
GitHub Sponsors https://github.com/open-source/sponsors
Developer articles https://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. https://github.blog/changelog/
Enterprises https://github.com/enterprise
Team https://github.com/team
Startups https://github.com/enterprise/startups
Nonprofits https://github.com/solutions/industry/nonprofits
Healthcare https://github.com/solutions/industry/healthcare
Financial services https://github.com/solutions/industry/financial-services
Manufacturing https://github.com/solutions/industry/manufacturing
Government https://github.com/solutions/industry/government
See all industries https://github.com/solutions/industry
Why GitHub https://github.com/why-github
Customer Stories https://github.com/customer-stories
Business insights https://github.com/solutions/executive-insights
Trust Center https://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code security https://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI features https://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 support https://github.com/enterprise/premium-support
Documentation https://docs.github.com/en
Resource center https://github.com/resources
Blog https://github.blog/
Events & webinars https://github.com/resources/events
Community Forum https://github.com/orgs/community/discussions
Customer Stories https://github.com/customer-stories
Integrations https://github.com/marketplace
Customer support https://help.github.com/
Training https://learn.github.com/skills
GitHub Status https://www.githubstatus.com/
About https://github.com/about
Partners https://github.com/partners
Changelog https://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. https://githubuniverse.com/
Pricing https://github.com/pricing
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fcomponents%2Fpull%2F24941
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fcomponents
Reload https://github.com/angular/components/pull/24941
Reload https://github.com/angular/components/pull/24941
Reload https://github.com/angular/components/pull/24941
angular https://github.com/angular
components https://github.com/angular/components
Code https://github.com/angular/components
Issues1.2k (1.2k) https://github.com/angular/components/issues
Pull requests216 (216) https://github.com/angular/components/pulls
Discussions https://github.com/angular/components/discussions
Actions https://github.com/angular/components/actions
Projects https://github.com/angular/components/projects
Wiki https://github.com/angular/components/wiki
Security and quality https://github.com/angular/components/security
Insights https://github.com/angular/components/insights
https://github.com/angular/components
mmalerba https://github.com/mmalerba
angular:main https://github.com/angular/components/tree/main
jelbourn:menu-injection https://github.com/jelbourn/components/tree/menu-injection
Conversation https://github.com/angular/components/pull/24941
Commits1 (1) https://github.com/angular/components/pull/24941/commits
Checks https://github.com/angular/components/pull/24941/checks
Files changed https://github.com/angular/components/pull/24941/files
refactor(cdk/menu): use inject for all injection https://github.com/angular/components/pull/24941#top
mmalerba https://github.com/mmalerba
angular:main https://github.com/angular/components/tree/main
jelbourn:menu-injection https://github.com/jelbourn/components/tree/menu-injection
https://github.com/jelbourn
jelbourn https://github.com/jelbourn
May 18, 2022 https://github.com/angular/components/pull/24941#issue-1240658141
Please reload this page https://github.com/angular/components/pull/24941
angular/angular#45991 https://github.com/angular/angular/pull/45991
Please reload this page https://github.com/angular/components/pull/24941
https://github.com/jelbourn
jelbourn https://github.com/jelbourn
P2
https://github.com/angular/components/issues?q=state%3Aopen%20label%3AP2
refactoring
https://github.com/angular/components/issues?q=state%3Aopen%20label%3Arefactoring
target: rc
https://github.com/angular/components/issues?q=state%3Aopen%20label%3A%22target%3A%20rc%22
May 18, 2022 https://github.com/angular/components/pull/24941#event-6636472899
https://github.com/jelbourn
jelbourn https://github.com/jelbourn
andrewseguin https://github.com/andrewseguin
May 18, 2022 22:53 https://github.com/angular/components/pull/24941#event-6636472921
https://github.com/jelbourn
jelbourn https://github.com/jelbourn
crisbeto https://github.com/crisbeto
mmalerba https://github.com/mmalerba
code owners https://github.com/angular/components/blob/b2e6d7eb68f698bd5643b3c432ed3dfc5af19470/.github/CODEOWNERS#L80
May 18, 2022 22:53 https://github.com/angular/components/pull/24941#event-6636472966
https://github.com/jelbourn
jelbourn https://github.com/jelbourn
area: cdk/menu
https://github.com/angular/components/issues?q=state%3Aopen%20label%3A%22area%3A%20cdk%2Fmenu%22
May 18, 2022 https://github.com/angular/components/pull/24941#event-6636473701
https://github.com/jelbourn
jelbourn https://github.com/jelbourn
force-pushed https://github.com/angular/components/compare/56eee76a0c0a3401041865284a2f70a047595bbc..52fe2793e71e275c219afcef1bddbf6f62c635db
56eee76 https://github.com/angular/components/commit/56eee76a0c0a3401041865284a2f70a047595bbc
52fe279 https://github.com/angular/components/commit/52fe2793e71e275c219afcef1bddbf6f62c635db
Compare
https://github.com/angular/components/compare/56eee76a0c0a3401041865284a2f70a047595bbc..52fe2793e71e275c219afcef1bddbf6f62c635db
May 18, 2022 22:54 https://github.com/angular/components/pull/24941#event-6636479505
https://github.com/jelbourn
jelbourn https://github.com/jelbourn
May 18, 2022 https://github.com/angular/components/pull/24941#event-6636480847
https://github.com/jelbourn
jelbourn https://github.com/jelbourn
force-pushed https://github.com/angular/components/compare/52fe2793e71e275c219afcef1bddbf6f62c635db..7e0db0442f8adda0a5d7ef4a8b53313b31c440d1
52fe279 https://github.com/angular/components/commit/52fe2793e71e275c219afcef1bddbf6f62c635db
7e0db04 https://github.com/angular/components/commit/7e0db0442f8adda0a5d7ef4a8b53313b31c440d1
Compare
https://github.com/angular/components/compare/52fe2793e71e275c219afcef1bddbf6f62c635db..7e0db0442f8adda0a5d7ef4a8b53313b31c440d1
May 18, 2022 22:55 https://github.com/angular/components/pull/24941#event-6636484309
https://github.com/jelbourn
jelbourn https://github.com/jelbourn
May 18, 2022 https://github.com/angular/components/pull/24941#event-6636484734
https://github.com/jelbourn
jelbourn https://github.com/jelbourn
force-pushed https://github.com/angular/components/compare/0342974db5fc281bda2ae9cd6558be61d82370e4..7403ce899d863db6c68f508ff92c6d635332b75a
0342974 https://github.com/angular/components/commit/0342974db5fc281bda2ae9cd6558be61d82370e4
7403ce8 https://github.com/angular/components/commit/7403ce899d863db6c68f508ff92c6d635332b75a
Compare
https://github.com/angular/components/compare/0342974db5fc281bda2ae9cd6558be61d82370e4..7403ce899d863db6c68f508ff92c6d635332b75a
May 18, 2022 23:18 https://github.com/angular/components/pull/24941#event-6636635441
https://github.com/crisbeto
crisbeto https://github.com/crisbeto
May 19, 2022
https://github.com/angular/components/pull/24941#pullrequestreview-978248093
View reviewed changes
https://github.com/angular/components/pull/24941/files
src/cdk/menu/menu-trigger-base.ts https://github.com/angular/components/pull/24941/files#diff-7dd80f0603c5483987ec8ec6e4a1fe6874e28403cc916dde5ec4d8cffbaccc85
crisbeto https://github.com/crisbeto
May 19, 2022 https://github.com/angular/components/pull/24941#discussion_r876824611
Learn more https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this page https://github.com/angular/components/pull/24941
jelbourn https://github.com/jelbourn
May 19, 2022 https://github.com/angular/components/pull/24941#discussion_r877320057
Learn more https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this page https://github.com/angular/components/pull/24941
https://github.com/jelbourn
jelbourn https://github.com/jelbourn
force-pushed https://github.com/angular/components/compare/3a49f30d94f7fddae9a9a30cbd02b671a002dbea..dc200d7c53e6928a1c7d3f3790cfc7534f063a68
3a49f30 https://github.com/angular/components/commit/3a49f30d94f7fddae9a9a30cbd02b671a002dbea
dc200d7 https://github.com/angular/components/commit/dc200d7c53e6928a1c7d3f3790cfc7534f063a68
Compare
https://github.com/angular/components/compare/3a49f30d94f7fddae9a9a30cbd02b671a002dbea..dc200d7c53e6928a1c7d3f3790cfc7534f063a68
May 19, 2022 17:23 https://github.com/angular/components/pull/24941#event-6644486924
https://github.com/jelbourn
jelbourn https://github.com/jelbourn
May 19, 2022 https://github.com/angular/components/pull/24941#issuecomment-1132265858
Please reload this page https://github.com/angular/components/pull/24941
https://github.com/jelbourn
jelbourn https://github.com/jelbourn
force-pushed https://github.com/angular/components/compare/dc200d7c53e6928a1c7d3f3790cfc7534f063a68..4b1dba0a2f8648f3ce8186faddbcec743d755361
dc200d7 https://github.com/angular/components/commit/dc200d7c53e6928a1c7d3f3790cfc7534f063a68
4b1dba0 https://github.com/angular/components/commit/4b1dba0a2f8648f3ce8186faddbcec743d755361
Compare
https://github.com/angular/components/compare/dc200d7c53e6928a1c7d3f3790cfc7534f063a68..4b1dba0a2f8648f3ce8186faddbcec743d755361
May 20, 2022 18:21 https://github.com/angular/components/pull/24941#event-6652691287
https://github.com/jelbourn
jelbourn https://github.com/jelbourn
May 20, 2022 https://github.com/angular/components/pull/24941#issuecomment-1133190475
Please reload this page https://github.com/angular/components/pull/24941
https://github.com/mmalerba
mmalerba https://github.com/mmalerba
May 20, 2022 https://github.com/angular/components/pull/24941#issuecomment-1133218273
Please reload this page https://github.com/angular/components/pull/24941
https://github.com/jelbourn
jelbourn https://github.com/jelbourn
force-pushed https://github.com/angular/components/compare/4b1dba0a2f8648f3ce8186faddbcec743d755361..8616df8f83b954c97ee5e427b2725d48d190c7d0
4b1dba0 https://github.com/angular/components/commit/4b1dba0a2f8648f3ce8186faddbcec743d755361
8616df8 https://github.com/angular/components/commit/8616df8f83b954c97ee5e427b2725d48d190c7d0
Compare
https://github.com/angular/components/compare/4b1dba0a2f8648f3ce8186faddbcec743d755361..8616df8f83b954c97ee5e427b2725d48d190c7d0
May 20, 2022 20:22 https://github.com/angular/components/pull/24941#event-6653264929
https://github.com/jelbourn
jelbourn https://github.com/jelbourn
May 20, 2022 https://github.com/angular/components/pull/24941#issuecomment-1133326357
Please reload this page https://github.com/angular/components/pull/24941
https://github.com/mmalerba
mmalerba https://github.com/mmalerba
May 20, 2022
https://github.com/angular/components/pull/24941#pullrequestreview-980638397
View reviewed changes
https://github.com/angular/components/pull/24941/files
https://github.com/mmalerba
mmalerba https://github.com/mmalerba
action: merge
https://github.com/angular/components/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
May 20, 2022 https://github.com/angular/components/pull/24941#event-6653269326
https://github.com/mmalerba
mmalerba https://github.com/mmalerba
May 20, 2022 https://github.com/angular/components/pull/24941#event-6653270957
https://github.com/jelbourn
refactor(cdk/menu): use inject for all injection https://github.com/angular/components/pull/24941/commits/759f20da9752a79a12d898faaef2edbe9a049e58
759f20d https://github.com/angular/components/pull/24941/commits/759f20da9752a79a12d898faaef2edbe9a049e58
angular/angular#45991 https://github.com/angular/angular/pull/45991
https://github.com/jelbourn
jelbourn https://github.com/jelbourn
mmalerba https://github.com/mmalerba
stale review https://github.com/angular/components/pull/24941#pullrequestreview-980638397
759f20d https://github.com/angular/components/commit/759f20da9752a79a12d898faaef2edbe9a049e58
May 20, 2022 20:34 https://github.com/angular/components/pull/24941#event-6653326819
https://github.com/jelbourn
jelbourn https://github.com/jelbourn
force-pushed https://github.com/angular/components/compare/8616df8f83b954c97ee5e427b2725d48d190c7d0..759f20da9752a79a12d898faaef2edbe9a049e58
8616df8 https://github.com/angular/components/commit/8616df8f83b954c97ee5e427b2725d48d190c7d0
759f20d https://github.com/angular/components/commit/759f20da9752a79a12d898faaef2edbe9a049e58
Compare
https://github.com/angular/components/compare/8616df8f83b954c97ee5e427b2725d48d190c7d0..759f20da9752a79a12d898faaef2edbe9a049e58
May 20, 2022 20:34 https://github.com/angular/components/pull/24941#event-6653326826
https://github.com/mmalerba
mmalerba https://github.com/mmalerba
May 20, 2022
https://github.com/angular/components/pull/24941#pullrequestreview-980697834
View reviewed changes
https://github.com/angular/components/pull/24941/files/759f20da9752a79a12d898faaef2edbe9a049e58
https://github.com/crisbeto
crisbeto https://github.com/crisbeto
May 21, 2022
https://github.com/angular/components/pull/24941#pullrequestreview-980813655
View reviewed changes
https://github.com/angular/components/pull/24941/files/759f20da9752a79a12d898faaef2edbe9a049e58
crisbeto https://github.com/crisbeto
https://github.com/angular/components/pull/24941#pullrequestreview-980813655
Learn more https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this page https://github.com/angular/components/pull/24941
https://github.com/mmalerba
mmalerba https://github.com/mmalerba
c67a299 https://github.com/angular/components/commit/c67a299a38b713c660b571b9f004168e2a9155db
May 23, 2022 https://github.com/angular/components/pull/24941#event-6662876059
mmalerba https://github.com/mmalerba
May 23, 2022
https://github.com/angular/components/pull/24941#ref-commit-9fb791d
https://github.com/jelbourn
https://github.com/mmalerba
refactor(cdk/menu): use https://github.com/angular/components/commit/9fb791d419d75701d5740e0eeebe50893a856ca3
inject https://github.com/angular/components/commit/9fb791d419d75701d5740e0eeebe50893a856ca3
for all injection ( https://github.com/angular/components/commit/9fb791d419d75701d5740e0eeebe50893a856ca3
#24941 https://github.com/angular/components/pull/24941
) https://github.com/angular/components/commit/9fb791d419d75701d5740e0eeebe50893a856ca3
9fb791d https://github.com/angular/components/commit/9fb791d419d75701d5740e0eeebe50893a856ca3
angular/angular#45991 https://github.com/angular/angular/pull/45991
https://github.com/mmalerba
mmalerba https://github.com/mmalerba
May 26, 2022
https://github.com/angular/components/pull/24941#ref-pullrequest-1243822529
fix(material/datepicker): add aria labels to s for Start/En…
#24949
https://github.com/angular/components/pull/24949
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bot https://github.com/apps/angular-automatic-lock-bot
Jun 23, 2022 https://github.com/angular/components/pull/24941#issuecomment-1163782377
automatic conversation locking policy https://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this page https://github.com/angular/components/pull/24941
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bot https://github.com/apps/angular-automatic-lock-bot
Jun 23, 2022 https://github.com/angular/components/pull/24941#event-6861521238
https://github.co/hiddenchars
https://github.com/angular/components/pull/{{ revealButtonHref }}
Sign up for free https://github.com/join?source=comment-repo
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fcomponents%2Fpull%2F24941
https://github.com/crisbeto
crisbeto
https://github.com/crisbeto
https://github.com/angular/components/pull/24941/files/759f20da9752a79a12d898faaef2edbe9a049e58
https://github.com/andrewseguin
andrewseguin
https://github.com/andrewseguin
https://github.com/mmalerba
mmalerba
https://github.com/mmalerba
https://github.com/angular/components/pull/24941/files/759f20da9752a79a12d898faaef2edbe9a049e58
Please reload this page https://github.com/angular/components/pull/24941
https://github.com/mmalerba
mmalerba
https://github.com/mmalerba
action: merge
https://github.com/angular/components/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: cdk/menu
https://github.com/angular/components/issues?q=state%3Aopen%20label%3A%22area%3A%20cdk%2Fmenu%22
P2
https://github.com/angular/components/issues?q=state%3Aopen%20label%3AP2
refactoring
https://github.com/angular/components/issues?q=state%3Aopen%20label%3Arefactoring
target: rc
https://github.com/angular/components/issues?q=state%3Aopen%20label%3A%22target%3A%20rc%22
Please reload this page https://github.com/angular/components/pull/24941
https://github.com/jelbourn
https://github.com/mmalerba
https://github.com/crisbeto
https://github.com
Terms https://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacy https://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Security https://github.com/security
Status https://www.githubstatus.com/
Community https://github.community/
Docs https://docs.github.com/
Contact https://support.github.com?tags=dotcom-footer