René's URL Explorer Experiment


Title: fix(tabs): avoid template type checking errors with Ivy by crisbeto · Pull Request #17228 · angular/components · GitHub

Open Graph Title: fix(tabs): avoid template type checking errors with Ivy by crisbeto · Pull Request #17228 · angular/components

X Title: fix(tabs): avoid template type checking errors with Ivy by crisbeto · Pull Request #17228 · angular/components

Description: Component infrastructure and Material Design components for Angular - fix(tabs): avoid template type checking errors with Ivy by crisbeto · Pull Request #17228 · angular/components

Open Graph Description: Along the same lines as #17022. Adds annotations to the various base classes that declare inputs, because the Ivy template type checker doesn't handle base defs at the moment. Fixes #17121.

X Description: Along the same lines as #17022. Adds annotations to the various base classes that declare inputs, because the Ivy template type checker doesn't handle base defs at the moment. Fixes #17121.

Opengraph URL: https://github.com/angular/components/pull/17228

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ac641d10-9f0b-1a38-9fee-5a28a884307d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB854:313081:45B412:5BE004:6B01978E
html-safe-noncec6387d69f426332a2b7085ce05684b42ec95a2269be231a5a09f5055f5fd3e8e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCODU0OjMxMzA4MTo0NUI0MTI6NUJFMDA0OjZCMDE5NzhFIiwidmlzaXRvcl9pZCI6IjI2NzI1NTkzMDU5OTUxNjM1MzQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac41d8d6823d669984d21105070e7a7f27e4ff8f9bf3270ee22e5821414b5e642c
hovercard-subject-tagpull_request:322508656
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/components/17228/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1354587c32915a553b4e3f475fe62e71c00fbe3445af3d94f4050c365293b3be/angular/components/pull/17228
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1354587c32915a553b4e3f475fe62e71c00fbe3445af3d94f4050c365293b3be/angular/components/pull/17228
og:image:altAlong the same lines as #17022. Adds annotations to the various base classes that declare inputs, because the Ivy template type checker doesn't handle base defs at the moment. Fixes #17121.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecrisbeto
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/components git https://github.com/angular/components.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id49016322
octolytics-dimension-repository_nwoangular/components
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49016322
octolytics-dimension-repository_network_root_nwoangular/components
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/components/pull/17228#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fcomponents%2Fpull%2F17228
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fcomponents%2Fpull%2F17228
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fcomponents
Reloadhttps://github.com/angular/components/pull/17228
Reloadhttps://github.com/angular/components/pull/17228
Reloadhttps://github.com/angular/components/pull/17228
angularhttps://github.com/angular
componentshttps://github.com/angular/components
Codehttps://github.com/angular/components
Issues1.2k (1.2k)https://github.com/angular/components/issues
Pull requests216 (216)https://github.com/angular/components/pulls
Discussionshttps://github.com/angular/components/discussions
Actionshttps://github.com/angular/components/actions
Projectshttps://github.com/angular/components/projects
Wikihttps://github.com/angular/components/wiki
Security and qualityhttps://github.com/angular/components/security
Insightshttps://github.com/angular/components/insights
https://github.com/angular/components
mmalerbahttps://github.com/mmalerba
angular:masterhttps://github.com/angular/components/tree/master
crisbeto:17121/tabs-ivy-type-checkinghttps://github.com/crisbeto/material2/tree/17121/tabs-ivy-type-checking
Conversationhttps://github.com/angular/components/pull/17228
Commits1 (1)https://github.com/angular/components/pull/17228/commits
Checkshttps://github.com/angular/components/pull/17228/checks
Files changedhttps://github.com/angular/components/pull/17228/files
fix(tabs): avoid template type checking errors with Ivyhttps://github.com/angular/components/pull/17228#top
mmalerbahttps://github.com/mmalerba
angular:masterhttps://github.com/angular/components/tree/master
crisbeto:17121/tabs-ivy-type-checkinghttps://github.com/crisbeto/material2/tree/17121/tabs-ivy-type-checking
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
Sep 29, 2019https://github.com/angular/components/pull/17228#issue-499922909
#17022https://github.com/angular/components/pull/17022
#17121https://github.com/angular/components/issues/17121
Please reload this pagehttps://github.com/angular/components/pull/17228
https://github.com/crisbeto
fix(tabs): avoid template type checking errors with Ivyhttps://github.com/angular/components/pull/17228/commits/bff79f1f6c4966a475eaeb5cf21f9cb2509702e9
bff79f1https://github.com/angular/components/pull/17228/commits/bff79f1f6c4966a475eaeb5cf21f9cb2509702e9
angular#17022https://github.com/angular/components/pull/17022
angular#17121https://github.com/angular/components/issues/17121
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
P2 https://github.com/angular/components/issues?q=state%3Aopen%20label%3AP2
target: patch https://github.com/angular/components/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Sep 29, 2019https://github.com/angular/components/pull/17228#event-2671236408
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
andrewseguinhttps://github.com/andrewseguin
code ownerhttps://github.com/angular/components/blob/8e141efee17ceaf19df73de81050daa35bceb853/.github/CODEOWNERS#L35
September 29, 2019 14:08https://github.com/angular/components/pull/17228#event-2671236412
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
jelbournhttps://github.com/jelbourn
Sep 29, 2019https://github.com/angular/components/pull/17228#event-2671236414
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/components/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Sep 29, 2019https://github.com/angular/components/pull/17228#event-2671236605
https://github.com/Splaktar
Splaktarhttps://github.com/Splaktar
Sep 29, 2019 https://github.com/angular/components/pull/17228#pullrequestreview-294706537
View reviewed changes https://github.com/angular/components/pull/17228/files/bff79f1f6c4966a475eaeb5cf21f9cb2509702e9
Splaktarhttps://github.com/Splaktar
https://github.com/angular/components/pull/17228#pullrequestreview-294706537
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/components/pull/17228
https://github.com/Splaktar
Splaktarhttps://github.com/Splaktar
Sep 29, 2019 https://github.com/angular/components/pull/17228#ref-issue-494863529
tabs(ivy): ivy-ngcc can't handle Inputs from an abstract class w/o a decorator like _MatTabGroupBase #17121 https://github.com/angular/components/issues/17121
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
P1 https://github.com/angular/components/issues?q=state%3Aopen%20label%3AP1
P2 https://github.com/angular/components/issues?q=state%3Aopen%20label%3AP2
Sep 30, 2019https://github.com/angular/components/pull/17228#event-2673770505
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
9.0.0https://github.com/angular/components/milestone/24
Sep 30, 2019https://github.com/angular/components/pull/17228#event-2673774392
https://github.com/jelbourn
jelbournhttps://github.com/jelbourn
Sep 30, 2019 https://github.com/angular/components/pull/17228#pullrequestreview-295090254
View reviewed changes https://github.com/angular/components/pull/17228/files/bff79f1f6c4966a475eaeb5cf21f9cb2509702e9
jelbournhttps://github.com/jelbourn
https://github.com/angular/components/pull/17228#pullrequestreview-295090254
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/components/pull/17228
https://github.com/jelbourn
jelbournhttps://github.com/jelbourn
pr: lgtm https://github.com/angular/components/issues?q=state%3Aopen%20label%3A%22pr%3A%20lgtm%22
action: merge https://github.com/angular/components/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
Sep 30, 2019https://github.com/angular/components/pull/17228#event-2673889841
https://github.com/mmalerba
mmalerbahttps://github.com/mmalerba
8c98013https://github.com/angular/components/commit/8c9801398c9593cc29c292d65bd206463909a432
Oct 1, 2019https://github.com/angular/components/pull/17228#event-2678558681
https://github.com/Splaktar
Splaktarhttps://github.com/Splaktar
Oct 3, 2019https://github.com/angular/components/pull/17228#issuecomment-537885671
components/src/material/tabs/tab-nav-bar/tab-nav-bar.tshttps://github.com/angular/components/blob/8c9801398c9593cc29c292d65bd206463909a432/src/material/tabs/tab-nav-bar/tab-nav-bar.ts#L195-L204
8c98013https://github.com/angular/components/commit/8c9801398c9593cc29c292d65bd206463909a432
Please reload this pagehttps://github.com/angular/components/pull/17228
crisbetohttps://github.com/crisbeto
Oct 3, 2019 https://github.com/angular/components/pull/17228#ref-commit-83ecf4d
https://github.com/crisbeto
fix(tabs): avoid Ivy template type checking errors in tab linkhttps://github.com/crisbeto/material2/commit/83ecf4d12b8fd67f08191ab1cfe6187c31a63695
83ecf4dhttps://github.com/crisbeto/material2/commit/83ecf4d12b8fd67f08191ab1cfe6187c31a63695
angular#17228https://github.com/angular/components/pull/17228
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
Oct 3, 2019 https://github.com/angular/components/pull/17228#ref-pullrequest-502072904
fix(tabs): avoid Ivy template type checking errors in tab link #17282 https://github.com/angular/components/pull/17282
mmalerbahttps://github.com/mmalerba
Oct 3, 2019 https://github.com/angular/components/pull/17228#ref-commit-ef5d9cb
https://github.com/crisbeto
https://github.com/mmalerba
fix(tabs): avoid Ivy template type checking errors in tab link (https://github.com/angular/components/commit/ef5d9cbf2670b5e1deb333669ccf6fa6e6ad9103
#17282https://github.com/angular/components/pull/17282
)https://github.com/angular/components/commit/ef5d9cbf2670b5e1deb333669ccf6fa6e6ad9103
ef5d9cbhttps://github.com/angular/components/commit/ef5d9cbf2670b5e1deb333669ccf6fa6e6ad9103
#17228https://github.com/angular/components/pull/17228
mmalerbahttps://github.com/mmalerba
Oct 8, 2019 https://github.com/angular/components/pull/17228#ref-commit-1bfa1ea
https://github.com/crisbeto
https://github.com/mmalerba
fix(tabs): avoid template type checking errors with Ivy (https://github.com/angular/components/commit/1bfa1ea7df7c8b18a1e1bfd307b3d971d636920a
#17228https://github.com/angular/components/pull/17228
)https://github.com/angular/components/commit/1bfa1ea7df7c8b18a1e1bfd307b3d971d636920a
1bfa1eahttps://github.com/angular/components/commit/1bfa1ea7df7c8b18a1e1bfd307b3d971d636920a
#17022https://github.com/angular/components/pull/17022
#17121https://github.com/angular/components/issues/17121
8c98013https://github.com/angular/components/commit/8c9801398c9593cc29c292d65bd206463909a432
mmalerbahttps://github.com/mmalerba
Oct 8, 2019 https://github.com/angular/components/pull/17228#ref-commit-cd11ae5
https://github.com/crisbeto
https://github.com/mmalerba
fix(tabs): avoid Ivy template type checking errors in tab link (https://github.com/angular/components/commit/cd11ae57ef1e6079a51820a87f843998df1f66ac
#17282https://github.com/angular/components/pull/17282
)https://github.com/angular/components/commit/cd11ae57ef1e6079a51820a87f843998df1f66ac
cd11ae5https://github.com/angular/components/commit/cd11ae57ef1e6079a51820a87f843998df1f66ac
#17228https://github.com/angular/components/pull/17228
ef5d9cbhttps://github.com/angular/components/commit/ef5d9cbf2670b5e1deb333669ccf6fa6e6ad9103
https://github.com/Splaktar
Splaktarhttps://github.com/Splaktar
Oct 10, 2019 https://github.com/angular/components/pull/17228#ref-pullrequest-505529477
build: enable Ivy for 8.x angular/material.angular.io#647 https://github.com/angular/material.angular.io/pull/647
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Nov 3, 2019https://github.com/angular/components/pull/17228#issuecomment-549092119
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/components/pull/17228
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Nov 3, 2019https://github.com/angular/components/pull/17228#event-2765655932
https://github.co/hiddenchars
https://github.com/angular/components/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fcomponents%2Fpull%2F17228
https://github.com/andrewseguin
andrewseguin https://github.com/andrewseguin
https://github.com/jelbourn
jelbourn https://github.com/jelbourn
https://github.com/angular/components/pull/17228/files/bff79f1f6c4966a475eaeb5cf21f9cb2509702e9
https://github.com/Splaktar
Splaktar https://github.com/Splaktar
https://github.com/angular/components/pull/17228/files/bff79f1f6c4966a475eaeb5cf21f9cb2509702e9
Please reload this pagehttps://github.com/angular/components/pull/17228
https://github.com/jelbourn
jelbourn https://github.com/jelbourn
action: merge https://github.com/angular/components/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
cla: yes https://github.com/angular/components/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
P1 https://github.com/angular/components/issues?q=state%3Aopen%20label%3AP1
target: patch https://github.com/angular/components/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
9.0.0 https://github.com/angular/components/milestone/24
tabs(ivy): ivy-ngcc can't handle Inputs from an abstract class w/o a decorator like _MatTabGroupBase https://github.com/angular/components/issues/17121
Please reload this pagehttps://github.com/angular/components/pull/17228
https://github.com/crisbeto
https://github.com/Splaktar
https://github.com/jelbourn
https://github.com/googlebot
https://github.com/mmalerba
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.