René's URL Explorer Experiment


Title: fix(tabs): only use aria-current on active links by jelbourn · Pull Request #16562 · angular/components · GitHub

Open Graph Title: fix(tabs): only use aria-current on active links by jelbourn · Pull Request #16562 · angular/components

X Title: fix(tabs): only use aria-current on active links by jelbourn · Pull Request #16562 · angular/components

Description: Component infrastructure and Material Design components for Angular - fix(tabs): only use aria-current on active links by jelbourn · Pull Request #16562 · angular/components

Open Graph Description: We previously set aria-current to either "true" or "false" for each matTabLink. This change now only applies the attribute to the active tab, omitting it for inactive tabs. Addi...

X Description: We previously set aria-current to either "true" or "false" for each matTabLink. This change now only applies the attribute to the active tab, omitting it for ina...

Opengraph URL: https://github.com/angular/components/pull/16562

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1070588b-c0c5-bb38-d236-c2812c326b16
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB000:2454CC:1C8A427:2431023:6B015AC2
html-safe-nonced218e02fccdc4f1e2087bf09c78c471efcd0c4cd94f786d6553c92a0394a5abd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMDAwOjI0NTRDQzoxQzhBNDI3OjI0MzEwMjM6NkIwMTVBQzIiLCJ2aXNpdG9yX2lkIjoiMTk5MzEzOTA3Njk1ODM1ODQyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace92df8f87b7d745888db92f4277beb60885ad1b7d5ba3ead9a26ac19b0dbcff8
hovercard-subject-tagpull_request:299042241
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/components/16562/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/67087db8dfd7f475015af74ec4b7842bec86d1a187bc9e5faba5a77ed1174c27/angular/components/pull/16562
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/67087db8dfd7f475015af74ec4b7842bec86d1a187bc9e5faba5a77ed1174c27/angular/components/pull/16562
og:image:altWe previously set aria-current to either "true" or "false" for each matTabLink. This change now only applies the attribute to the active tab, omitting it for inactive tabs. Addi...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejelbourn
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/components git https://github.com/angular/components.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id49016322
octolytics-dimension-repository_nwoangular/components
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49016322
octolytics-dimension-repository_network_root_nwoangular/components
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/components/pull/16562#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fcomponents%2Fpull%2F16562
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fcomponents%2Fpull%2F16562
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fcomponents
Reloadhttps://github.com/angular/components/pull/16562
Reloadhttps://github.com/angular/components/pull/16562
Reloadhttps://github.com/angular/components/pull/16562
angularhttps://github.com/angular
componentshttps://github.com/angular/components
Codehttps://github.com/angular/components
Issues1.2k (1.2k)https://github.com/angular/components/issues
Pull requests216 (216)https://github.com/angular/components/pulls
Discussionshttps://github.com/angular/components/discussions
Actionshttps://github.com/angular/components/actions
Projectshttps://github.com/angular/components/projects
Wikihttps://github.com/angular/components/wiki
Security and qualityhttps://github.com/angular/components/security
Insightshttps://github.com/angular/components/insights
https://github.com/angular/components
jelbournhttps://github.com/jelbourn
angular:masterhttps://github.com/angular/components/tree/master
jelbourn:nav-link-aria-currenthttps://github.com/jelbourn/components/tree/nav-link-aria-current
Conversationhttps://github.com/angular/components/pull/16562
Commits1 (1)https://github.com/angular/components/pull/16562/commits
Checkshttps://github.com/angular/components/pull/16562/checks
Files changedhttps://github.com/angular/components/pull/16562/files
fix(tabs): only use aria-current on active linkshttps://github.com/angular/components/pull/16562#top
jelbournhttps://github.com/jelbourn
angular:masterhttps://github.com/angular/components/tree/master
jelbourn:nav-link-aria-currenthttps://github.com/jelbourn/components/tree/nav-link-aria-current
https://github.com/jelbourn
jelbournhttps://github.com/jelbourn
Jul 18, 2019https://github.com/angular/components/pull/16562#issue-469929160
#16557https://github.com/angular/components/issues/16557
Please reload this pagehttps://github.com/angular/components/pull/16562
https://github.com/jelbourn
jelbournhttps://github.com/jelbourn
P3 https://github.com/angular/components/issues?q=state%3Aopen%20label%3AP3
Accessibility https://github.com/angular/components/issues?q=state%3Aopen%20label%3AAccessibility
target: patch https://github.com/angular/components/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Jul 18, 2019https://github.com/angular/components/pull/16562#event-2493661927
https://github.com/jelbourn
jelbournhttps://github.com/jelbourn
andrewseguinhttps://github.com/andrewseguin
code ownerhttps://github.com/angular/components/blob/036729dc1a7b41236fcda9b23c578f9ef65b484c/.github/CODEOWNERS#L35
July 18, 2019 18:42https://github.com/angular/components/pull/16562#event-2493661946
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/components/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Jul 18, 2019https://github.com/angular/components/pull/16562#event-2493662055
https://github.com/jelbourn
jelbournhttps://github.com/jelbourn
crisbetohttps://github.com/crisbeto
July 18, 2019 18:42https://github.com/angular/components/pull/16562#event-2493662220
https://github.com/jelbourn
jelbournhttps://github.com/jelbourn
Jul 18, 2019 https://github.com/angular/components/pull/16562#ref-issue-469442484
Screen readers assume tabs are always selected irrespective of the aria-current value #16557 https://github.com/angular/components/issues/16557
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
Jul 18, 2019 https://github.com/angular/components/pull/16562#pullrequestreview-263841080
View reviewed changes https://github.com/angular/components/pull/16562/files
src/material/tabs/tab-nav-bar/tab-nav-bar.tshttps://github.com/angular/components/pull/16562/files#diff-a045708f8e95de25c4f121b6b88f7de514fe1139c3e18c2ec802b4df71339552
Please reload this pagehttps://github.com/angular/components/pull/16562
https://github.com/jelbourn
fix(tabs): only use aria-current on active linkshttps://github.com/angular/components/pull/16562/commits/6464b7362593addab2693056c0e86399eedd8469
6464b73https://github.com/angular/components/pull/16562/commits/6464b7362593addab2693056c0e86399eedd8469
angular#16557https://github.com/angular/components/issues/16557
https://github.com/jelbourn
jelbournhttps://github.com/jelbourn
force-pushedhttps://github.com/angular/components/compare/87207158d255076ad1e624103e1be042db3e3102..6464b7362593addab2693056c0e86399eedd8469
8720715https://github.com/angular/components/commit/87207158d255076ad1e624103e1be042db3e3102
6464b73https://github.com/angular/components/commit/6464b7362593addab2693056c0e86399eedd8469
Compare https://github.com/angular/components/compare/87207158d255076ad1e624103e1be042db3e3102..6464b7362593addab2693056c0e86399eedd8469
July 18, 2019 21:09https://github.com/angular/components/pull/16562#event-2494035956
https://github.com/jelbourn
jelbournhttps://github.com/jelbourn
Jul 18, 2019https://github.com/angular/components/pull/16562#issuecomment-512988798
Please reload this pagehttps://github.com/angular/components/pull/16562
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
Jul 18, 2019 https://github.com/angular/components/pull/16562#pullrequestreview-263915164
View reviewed changes https://github.com/angular/components/pull/16562/files/6464b7362593addab2693056c0e86399eedd8469
crisbetohttps://github.com/crisbeto
https://github.com/angular/components/pull/16562#pullrequestreview-263915164
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/components/pull/16562
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
pr: lgtm https://github.com/angular/components/issues?q=state%3Aopen%20label%3A%22pr%3A%20lgtm%22
action: merge https://github.com/angular/components/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
Jul 18, 2019https://github.com/angular/components/pull/16562#event-2494067113
https://github.com/jelbourn
jelbournhttps://github.com/jelbourn
9aa326ehttps://github.com/angular/components/commit/9aa326e1499ea5d885b4619e598b54d26210d737
Jul 19, 2019https://github.com/angular/components/pull/16562#event-2496011452
andrewseguinhttps://github.com/andrewseguin
Jul 29, 2019 https://github.com/angular/components/pull/16562#ref-commit-b0937dc
https://github.com/jelbourn
https://github.com/andrewseguin
fix(tabs): only use aria-current on active links (https://github.com/angular/components/commit/b0937dc3d103d7d5ba33ce3a58e855b9e94b545a
#16562https://github.com/angular/components/pull/16562
)https://github.com/angular/components/commit/b0937dc3d103d7d5ba33ce3a58e855b9e94b545a
b0937dchttps://github.com/angular/components/commit/b0937dc3d103d7d5ba33ce3a58e855b9e94b545a
#16557https://github.com/angular/components/issues/16557
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 11, 2019https://github.com/angular/components/pull/16562#issuecomment-530188005
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/components/pull/16562
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 11, 2019https://github.com/angular/components/pull/16562#event-2624180305
https://github.co/hiddenchars
https://github.com/angular/components/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fcomponents%2Fpull%2F16562
https://github.com/crisbeto
crisbeto https://github.com/crisbeto
https://github.com/angular/components/pull/16562/files/6464b7362593addab2693056c0e86399eedd8469
https://github.com/andrewseguin
andrewseguin https://github.com/andrewseguin
Please reload this pagehttps://github.com/angular/components/pull/16562
Accessibility https://github.com/angular/components/issues?q=state%3Aopen%20label%3AAccessibility
action: merge https://github.com/angular/components/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
cla: yes https://github.com/angular/components/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
P3 https://github.com/angular/components/issues?q=state%3Aopen%20label%3AP3
target: patch https://github.com/angular/components/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Screen readers assume tabs are always selected irrespective of the aria-current value https://github.com/angular/components/issues/16557
Please reload this pagehttps://github.com/angular/components/pull/16562
https://github.com/jelbourn
https://github.com/crisbeto
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.