| route-pattern | /:user_id/:repository/pull/*id(.:format) |
| route-controller | pull_requests |
| route-action | show |
| fetch-nonce | v2:075850f1-db4e-5fe9-db73-afee4d762d53 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E42C:103FB4:91E2A9:C3782E:6A5B46DA |
| html-safe-nonce | 04d2adbd0881c2df2afa3e8d21b44b5e02556bbb3631e263b36864c76be16667 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNDJDOjEwM0ZCNDo5MUUyQTk6QzM3ODJFOjZBNUI0NkRBIiwidmlzaXRvcl9pZCI6IjM1NzYwMzAwMTYyNzc1MzAzMzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 8bf50b25f463175b6e68df11cea88e8f3b11943e283c7b788fc9c91a1f37ed03 |
| hovercard-subject-tag | pull_request:122086031 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angularfire/pull/996 |
| twitter:image | https://opengraph.githubassets.com/8f117ff494f36b7c52d0cdf2799ca8ab19b63933b5a8c46f3f80ccbf44fa93c5/angular/angularfire/pull/996 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8f117ff494f36b7c52d0cdf2799ca8ab19b63933b5a8c46f3f80ccbf44fa93c5/angular/angularfire/pull/996 |
| og:image:alt | Checklist
Issue number for this PR: Proposal: Upgrade to Firebase JS SDK 4.0 #995
Docs included?: yes
Test units included?: yes
e2e tests included?: no
In a clean directory, npm install, npm run b... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jamesdaniels |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angularfire git https://github.com/angular/angularfire.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 49453413 |
| octolytics-dimension-repository_nwo | angular/angularfire |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 49453413 |
| octolytics-dimension-repository_network_root_nwo | angular/angularfire |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c975978430e9ad293956f2bbdaf153b1bd84a99 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/angular/angularfire/pull/996#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F996 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F996 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=angular%2Fangularfire |
| Reload | https://github.com/angular/angularfire/pull/996 |
| Reload | https://github.com/angular/angularfire/pull/996 |
| Reload | https://github.com/angular/angularfire/pull/996 |
| Please reload this page | https://github.com/angular/angularfire/pull/996 |
|
angular
| https://github.com/angular |
| angularfire | https://github.com/angular/angularfire |
|
Notifications
| https://github.com/login?return_to=%2Fangular%2Fangularfire |
|
Fork
2.2k
| https://github.com/login?return_to=%2Fangular%2Fangularfire |
|
Star
7.8k
| https://github.com/login?return_to=%2Fangular%2Fangularfire |
|
Code
| https://github.com/angular/angularfire |
|
Issues
294
| https://github.com/angular/angularfire/issues |
|
Pull requests
21
| https://github.com/angular/angularfire/pulls |
|
Discussions
| https://github.com/angular/angularfire/discussions |
|
Actions
| https://github.com/angular/angularfire/actions |
|
Projects
| https://github.com/angular/angularfire/projects |
|
Security and quality
0
| https://github.com/angular/angularfire/security |
|
Insights
| https://github.com/angular/angularfire/pulse |
|
Code
| https://github.com/angular/angularfire |
|
Issues
| https://github.com/angular/angularfire/issues |
|
Pull requests
| https://github.com/angular/angularfire/pulls |
|
Discussions
| https://github.com/angular/angularfire/discussions |
|
Actions
| https://github.com/angular/angularfire/actions |
|
Projects
| https://github.com/angular/angularfire/projects |
|
Security and quality
| https://github.com/angular/angularfire/security |
|
Insights
| https://github.com/angular/angularfire/pulse |
| davideast | https://github.com/davideast |
| angular:master | https://github.com/angular/angularfire/tree/master |
| jamesdaniels:update_firebase_dep | https://github.com/jamesdaniels/angularfire2/tree/update_firebase_dep |
| Conversation | https://github.com/angular/angularfire/pull/996 |
| Commits3 (3) | https://github.com/angular/angularfire/pull/996/commits |
| Checks | https://github.com/angular/angularfire/pull/996/checks |
| Files changed | https://github.com/angular/angularfire/pull/996/files |
| chore(sdk): Update to Firebase JS SDK 4.0 (breaking changes) | https://github.com/angular/angularfire/pull/996#top |
| davideast | https://github.com/davideast |
| angular:master | https://github.com/angular/angularfire/tree/master |
| jamesdaniels:update_firebase_dep | https://github.com/jamesdaniels/angularfire2/tree/update_firebase_dep |
|
| https://github.com/jamesdaniels |
| jamesdaniels | https://github.com/jamesdaniels |
| May 23, 2017 | https://github.com/angular/angularfire/pull/996#issue-230831265 |
| Proposal: Upgrade to Firebase JS SDK 4.0 #995 | https://github.com/angular/angularfire/issues/995 |
| See the Firebase JS SDK changelog for more information. | https://firebase.google.com/support/release-notes/js#4.0.0 |
| Please reload this page | https://github.com/angular/angularfire/pull/996 |
| jamesdaniels | https://github.com/jamesdaniels |
| May 22, 2017 14:03 | https://github.com/angular/angularfire/pull/996#commits-pushed-4afd00a |
|
| https://github.com/jamesdaniels |
| Upgrading to Firebase 4.0 | https://github.com/angular/angularfire/pull/996/commits/4afd00aed97bcac43e1f7857d0d8045c6c2073d4 |
| 4afd00a | https://github.com/angular/angularfire/pull/996/commits/4afd00aed97bcac43e1f7857d0d8045c6c2073d4 |
|
| https://github.com/jamesdaniels |
| Adding an idToken Observable to Auth | https://github.com/angular/angularfire/pull/996/commits/eb975b879d038ab7815e5715502a1b43363ce3c4 |
| eb975b8 | https://github.com/angular/angularfire/pull/996/commits/eb975b879d038ab7815e5715502a1b43363ce3c4 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| May 23, 2017 | https://github.com/angular/angularfire/pull/996#event-1094414385 |
| https://github.com/jamesdaniels |
| jamesdaniels | https://github.com/jamesdaniels |
| May 23, 2017 | https://github.com/angular/angularfire/pull/996#event-1094415322 |
|
| https://github.com/jamesdaniels |
| Upgrade guide changes | https://github.com/angular/angularfire/pull/996/commits/09970e7d763dda28062b7fd16d6a86f9d3203aca |
| 09970e7 | https://github.com/angular/angularfire/pull/996/commits/09970e7d763dda28062b7fd16d6a86f9d3203aca |
| https://github.com/markgoho |
| markgoho | https://github.com/markgoho |
|
May 24, 2017
| https://github.com/angular/angularfire/pull/996#pullrequestreview-40014225 |
|
View reviewed changes
| https://github.com/angular/angularfire/pull/996/files/09970e7d763dda28062b7fd16d6a86f9d3203aca |
| docs/version-4-upgrade.md | https://github.com/angular/angularfire/pull/996/files/eb975b879d038ab7815e5715502a1b43363ce3c4..09970e7d763dda28062b7fd16d6a86f9d3203aca#diff-facf20ab81d57926b8cd84c880e3b4c1534d9013b4e8b324ac45afee4697f1b6 |
| markgoho | https://github.com/markgoho |
| May 24, 2017 | https://github.com/angular/angularfire/pull/996#discussion_r118242642 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angularfire/pull/996 |
| davideast | https://github.com/davideast |
| May 24, 2017 | https://github.com/angular/angularfire/pull/996#discussion_r118338408 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angularfire/pull/996 |
| https://github.com/davideast |
| davideast | https://github.com/davideast |
| May 24, 2017 | https://github.com/angular/angularfire/pull/996#event-1096165915 |
| https://github.com/davideast |
| davideast | https://github.com/davideast |
| 9642f58 | https://github.com/angular/angularfire/commit/9642f589ba73add6d49a5818a1109028f8c7729b |
| May 24, 2017 | https://github.com/angular/angularfire/pull/996#event-1096166293 |
| https://github.com/jamesdaniels |
| jamesdaniels | https://github.com/jamesdaniels |
| May 24, 2017 20:33 | https://github.com/angular/angularfire/pull/996#event-1096304965 |
| https://github.com/jamesdaniels |
| jamesdaniels | https://github.com/jamesdaniels |
|
May 24, 2017
| https://github.com/angular/angularfire/pull/996#ref-pullrequest-231163556 |
|
chore(release): Version bump
#999
| https://github.com/angular/angularfire/pull/999 |
| https://github.com/jamesdaniels |
| jamesdaniels | https://github.com/jamesdaniels |
|
Jun 2, 2017
| https://github.com/angular/angularfire/pull/996#ref-pullrequest-233304783 |
|
chore(release): Changelog
#1018
| https://github.com/angular/angularfire/pull/1018 |
| https://github.co/hiddenchars |
| https://github.com/angular/angularfire/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F996 |
|
| https://github.com/davideast |
|
davideast
| https://github.com/davideast |
|
| https://github.com/angular/angularfire/pull/996/files/09970e7d763dda28062b7fd16d6a86f9d3203aca |
|
| https://github.com/markgoho |
|
markgoho
| https://github.com/markgoho |
|
| https://github.com/angular/angularfire/pull/996/files/09970e7d763dda28062b7fd16d6a86f9d3203aca |
|
cla: yes
| https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Please reload this page | https://github.com/angular/angularfire/pull/996 |
|
| https://github.com/jamesdaniels |
|
| https://github.com/davideast |
|
| https://github.com/markgoho |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |