Title: feat(database): support the optional startAt key by cartant · Pull Request #821 · angular/angularfire · GitHub
Open Graph Title: feat(database): support the optional startAt key by cartant · Pull Request #821 · angular/angularfire
X Title: feat(database): support the optional startAt key by cartant · Pull Request #821 · angular/angularfire
Description: Checklist Issue number for this PR: #362 Docs included?: yes Test units included?: yes e2e tests included?: no In a clean directory, npm install, npm run build, and npm test run successfully? yes Description This PR introduces support for the optional key parameter that can be passed to the SDK's startAt method. According to the SDK documentation, the parameter is "allowed if ordering by child, value, or priority". There was some discussion in the linked (and closed) issue regarding the key parameter only being supported and useful when ordering by priority, but the documentation suggests that it is also supported - by startAt - when ordering by child and value. Indeed, were it not to be supported, it would not be possible to reliably page through lists that are ordered by child when there are large numbers of items with the same child value. This is an issue that I currently have with an implementation of a FirebaseListObservable-based infinite list. There is a plunk here that demonstrates the use of key with the SDK to page when ordering by child. Code sample The key parameter is really only useful when paging through results, so this code sample is contrived and not particularly sensible: let list = angularFire.database.list('some/data', { query: { orderByChild: 'some-child', startAt: { value: 'some-value', key: 'some-key' }, limitToFirst: 10 } });
Open Graph Description: Checklist Issue number for this PR: #362 Docs included?: yes Test units included?: yes e2e tests included?: no In a clean directory, npm install, npm run build, and npm test run successfully? yes ...
X Description: Checklist Issue number for this PR: #362 Docs included?: yes Test units included?: yes e2e tests included?: no In a clean directory, npm install, npm run build, and npm test run successfully? yes ...
Opengraph URL: https://github.com/angular/angularfire/pull/821
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:a7f525cc-462f-3079-fe44-70fba9131cde |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8D42:2100CB:155C0ED:1CB369B:6A5B8BAA |
| html-safe-nonce | c4c906f235e176c7f7d03b0a08d9ff40aba574e417e93dc6b3203321f757383e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RDQyOjIxMDBDQjoxNTVDMEVEOjFDQjM2OUI6NkE1QjhCQUEiLCJ2aXNpdG9yX2lkIjoiODIyNDcwOTM3ODI5OTM2NjMxNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 09a7921110312d96dedf81c2cab80a041b193dcea6675a363eba6e337f37ff4b |
| hovercard-subject-tag | pull_request:105737458 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angularfire/pull/821/files |
| twitter:image | https://avatars.githubusercontent.com/u/3878593?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/3878593?s=400&v=4 |
| og:image:alt | Checklist Issue number for this PR: #362 Docs included?: yes Test units included?: yes e2e tests included?: no In a clean directory, npm install, npm run build, and npm test run successfully? yes ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angularfire git https://github.com/angular/angularfire.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 49453413 |
| octolytics-dimension-repository_nwo | angular/angularfire |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 49453413 |
| octolytics-dimension-repository_network_root_nwo | angular/angularfire |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c975978430e9ad293956f2bbdaf153b1bd84a99 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width