René's URL Explorer Experiment


Title: fix(database): allow null values for equalTo, etc. by cartant · Pull Request #809 · angular/angularfire · GitHub

Open Graph Title: fix(database): allow null values for equalTo, etc. by cartant · Pull Request #809 · angular/angularfire

X Title: fix(database): allow null values for equalTo, etc. by cartant · Pull Request #809 · angular/angularfire

Description: Checklist Issue number for this PR: #704 and #715 Docs included?: no Test units included?: yes e2e tests included?: no In a clean directory, npm install, npm run build, and npm test run successfully? yes Description The previous PR for #704 did not include tests and did not completely fix the issue, as null values were swallowed with the query observable. This PR addresses that and includes tests. Also, this PR ensures that the query observable emits undefined if values are not specified for equalTo, startAt or endAt - as null has a specific meaning.

Open Graph Description: Checklist Issue number for this PR: #704 and #715 Docs included?: no Test units included?: yes e2e tests included?: no In a clean directory, npm install, npm run build, and npm test run successful...

X Description: Checklist Issue number for this PR: #704 and #715 Docs included?: no Test units included?: yes e2e tests included?: no In a clean directory, npm install, npm run build, and npm test run successful...

Opengraph URL: https://github.com/angular/angularfire/pull/809

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9f5eae96-03f0-df22-5b8e-bab3103e601c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE91A:1CA2B7:5CD83E:79B2E3:6A5AE215
html-safe-nonce0515812cdb89b757404d9d424fca10caf283f2fb71f0f7dd8ee8fc2453e3f98c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOTFBOjFDQTJCNzo1Q0Q4M0U6NzlCMkUzOjZBNUFFMjE1IiwidmlzaXRvcl9pZCI6Ijg5NzE4MTEzNzE3MDYxNDczNDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac93f2615bd54ffb61cdc5c52a8c92ff5de0304d42584cf594a8a6aa6ed0789c64
hovercard-subject-tagpull_request:104685440
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angularfire/pull/809/files
twitter:imagehttps://avatars.githubusercontent.com/u/3878593?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/3878593?s=400&v=4
og:image:altChecklist Issue number for this PR: #704 and #715 Docs included?: no Test units included?: yes e2e tests included?: no In a clean directory, npm install, npm run build, and npm test run successful...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angularfire git https://github.com/angular/angularfire.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id49453413
octolytics-dimension-repository_nwoangular/angularfire
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49453413
octolytics-dimension-repository_network_root_nwoangular/angularfire
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c975978430e9ad293956f2bbdaf153b1bd84a99
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angularfire/pull/809/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F809%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F809%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangularfire
Reloadhttps://github.com/angular/angularfire/pull/809/files
Reloadhttps://github.com/angular/angularfire/pull/809/files
Reloadhttps://github.com/angular/angularfire/pull/809/files
Please reload this pagehttps://github.com/angular/angularfire/pull/809/files
angular https://github.com/angular
angularfirehttps://github.com/angular/angularfire
Notifications https://github.com/login?return_to=%2Fangular%2Fangularfire
Fork 2.2k https://github.com/login?return_to=%2Fangular%2Fangularfire
Star 7.8k https://github.com/login?return_to=%2Fangular%2Fangularfire
Code https://github.com/angular/angularfire
Issues 295 https://github.com/angular/angularfire/issues
Pull requests 20 https://github.com/angular/angularfire/pulls
Discussions https://github.com/angular/angularfire/discussions
Actions https://github.com/angular/angularfire/actions
Projects https://github.com/angular/angularfire/projects
Security and quality 0 https://github.com/angular/angularfire/security
Insights https://github.com/angular/angularfire/pulse
Code https://github.com/angular/angularfire
Issues https://github.com/angular/angularfire/issues
Pull requests https://github.com/angular/angularfire/pulls
Discussions https://github.com/angular/angularfire/discussions
Actions https://github.com/angular/angularfire/actions
Projects https://github.com/angular/angularfire/projects
Security and quality https://github.com/angular/angularfire/security
Insights https://github.com/angular/angularfire/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangularfire%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangularfire%2Fissues%2Fnew%2Fchoose
davideasthttps://github.com/davideast
angular:masterhttps://github.com/angular/angularfire/tree/master
cartant:issue-704-part-2https://github.com/cartant/angularfire/tree/issue-704-part-2
Conversation 0 https://github.com/angular/angularfire/pull/809
Commits 2 https://github.com/angular/angularfire/pull/809/commits
Checks 0 https://github.com/angular/angularfire/pull/809/checks
Files changed https://github.com/angular/angularfire/pull/809/files
Please reload this pagehttps://github.com/angular/angularfire/pull/809/files
fix(database): allow null values for equalTo, etc. https://github.com/angular/angularfire/pull/809/files#top
Show all changes 2 commits https://github.com/angular/angularfire/pull/809/files
df3028b fix(database): allow null values for equalTo, etc. cartant Feb 5, 2017 https://github.com/angular/angularfire/pull/809/commits/df3028b0472740a0f720ca2fdec9f04d60456a85
2701983 Merge branch 'master' into issue-704-part-2 davideast Feb 9, 2017 https://github.com/angular/angularfire/pull/809/commits/270198391de51bfb48e6ef9baadc66f8567e6752
Clear filters https://github.com/angular/angularfire/pull/809/files
Please reload this pagehttps://github.com/angular/angularfire/pull/809/files
Please reload this pagehttps://github.com/angular/angularfire/pull/809/files
firebase_list_factory.spec.ts https://github.com/angular/angularfire/pull/809/files#diff-27f9535eb7d022ed814cd52b2035697a1a6faf39f9810bcd7f5a865814fd6d0e
query_observable.spec.ts https://github.com/angular/angularfire/pull/809/files#diff-aad5a589ceeb0a2af6be8cbe49e577a2d556aaacb27588927fd222a36ef7cb20
query_observable.ts https://github.com/angular/angularfire/pull/809/files#diff-ef5460040dd2061e24e453c4da604f0e25c6d596237097e912b167ae868a91e9
src/database/firebase_list_factory.spec.tshttps://github.com/angular/angularfire/pull/809/files#diff-27f9535eb7d022ed814cd52b2035697a1a6faf39f9810bcd7f5a865814fd6d0e
View file https://github.com/cartant/angularfire/blob/270198391de51bfb48e6ef9baadc66f8567e6752/src/database/firebase_list_factory.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angularfire/pull/809/{{ revealButtonHref }}
https://github.com/angular/angularfire/pull/809/files#diff-27f9535eb7d022ed814cd52b2035697a1a6faf39f9810bcd7f5a865814fd6d0e
https://github.com/angular/angularfire/pull/809/files#diff-27f9535eb7d022ed814cd52b2035697a1a6faf39f9810bcd7f5a865814fd6d0e
src/database/query_observable.spec.tshttps://github.com/angular/angularfire/pull/809/files#diff-aad5a589ceeb0a2af6be8cbe49e577a2d556aaacb27588927fd222a36ef7cb20
View file https://github.com/cartant/angularfire/blob/270198391de51bfb48e6ef9baadc66f8567e6752/src/database/query_observable.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angularfire/pull/809/{{ revealButtonHref }}
https://github.com/angular/angularfire/pull/809/files#diff-aad5a589ceeb0a2af6be8cbe49e577a2d556aaacb27588927fd222a36ef7cb20
https://github.com/angular/angularfire/pull/809/files#diff-aad5a589ceeb0a2af6be8cbe49e577a2d556aaacb27588927fd222a36ef7cb20
src/database/query_observable.tshttps://github.com/angular/angularfire/pull/809/files#diff-ef5460040dd2061e24e453c4da604f0e25c6d596237097e912b167ae868a91e9
View file https://github.com/cartant/angularfire/blob/270198391de51bfb48e6ef9baadc66f8567e6752/src/database/query_observable.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angularfire/pull/809/{{ revealButtonHref }}
https://github.com/angular/angularfire/pull/809/files#diff-ef5460040dd2061e24e453c4da604f0e25c6d596237097e912b167ae868a91e9
https://github.com/angular/angularfire/pull/809/files#diff-ef5460040dd2061e24e453c4da604f0e25c6d596237097e912b167ae868a91e9
https://github.com/angular/angularfire/pull/809/files#diff-ef5460040dd2061e24e453c4da604f0e25c6d596237097e912b167ae868a91e9
https://github.com/angular/angularfire/pull/809/files#diff-ef5460040dd2061e24e453c4da604f0e25c6d596237097e912b167ae868a91e9
https://github.com/angular/angularfire/pull/809/files#diff-ef5460040dd2061e24e453c4da604f0e25c6d596237097e912b167ae868a91e9
https://github.com/angular/angularfire/pull/809/files#diff-ef5460040dd2061e24e453c4da604f0e25c6d596237097e912b167ae868a91e9
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.