Title: fix(database): allow null values for equalTo, etc. by cartant · Pull Request #715 · angular/angularfire · GitHub
Open Graph Title: fix(database): allow null values for equalTo, etc. by cartant · Pull Request #715 · angular/angularfire
X Title: fix(database): allow null values for equalTo, etc. by cartant · Pull Request #715 · angular/angularfire
Description: Checklist Issue number for this PR: #704 Docs included?: no Test units included?: no e2e tests included?: no In a clean directory, npm install, npm run build, and npm test run successfully? no After following the steps in the contribution guide, the generated test-root.umd.js bundle was empty - apart from the boilerplate. This could have something to do with Windows being my OS. Hopefully, Travis will run the tests for me. Description This PR includes a refactor to rename a method that was considered to be misleading and a fix to allow the equalTo, startAt and endAt options for list queries to be null - as the current AngularFire2 behaviour differs from that of the underlying SDK (see the repro in the associated issue). I've renamed the method to isNil - rather than the suggested isEmpty - as isNil is the name that's used in lodash (for an identical method) and using isEmpty would make the implementation of isEmptyObject too confusing: export function isEmptyObject(obj: Object): boolean { // If the variable is considered empty, the object isn't? Huh? // What does empty mean? if (isEmpty(obj)) { return false; } return Object.keys(obj).length === 0 && JSON.stringify(obj) === JSON.stringify({}); }
Open Graph Description: Checklist Issue number for this PR: #704 Docs included?: no Test units included?: no e2e tests included?: no In a clean directory, npm install, npm run build, and npm test run successfully? no Af...
X Description: Checklist Issue number for this PR: #704 Docs included?: no Test units included?: no e2e tests included?: no In a clean directory, npm install, npm run build, and npm test run successfully? no Af...
Opengraph URL: https://github.com/angular/angularfire/pull/715
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:0e338d4d-e3bd-9bf5-ecc1-224c18ef29ed |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D88C:129FD3:72751D:981C11:6A5B4D02 |
| html-safe-nonce | 33d70676b533b98146bf362d93c82f1eb1289d276ab72ad1dbff3c77e7c03b18 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEODhDOjEyOUZEMzo3Mjc1MUQ6OTgxQzExOjZBNUI0RDAyIiwidmlzaXRvcl9pZCI6IjQyNDY1MDYxMDM3NDY4MDkwOTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | c7bee8c99f13a64dc0d3161464ea633c30d074b0051e561c287e1c1cef2eaf9a |
| hovercard-subject-tag | pull_request:97415649 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angularfire/pull/715/files |
| twitter:image | https://avatars.githubusercontent.com/u/3878593?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/3878593?s=400&v=4 |
| og:image:alt | Checklist Issue number for this PR: #704 Docs included?: no Test units included?: no e2e tests included?: no In a clean directory, npm install, npm run build, and npm test run successfully? no Af... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angularfire git https://github.com/angular/angularfire.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 49453413 |
| octolytics-dimension-repository_nwo | angular/angularfire |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 49453413 |
| octolytics-dimension-repository_network_root_nwo | angular/angularfire |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c975978430e9ad293956f2bbdaf153b1bd84a99 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width