René's URL Explorer Experiment


Title: build(firestore): stop zone-wrapping functions that schedule no work by armando-navarro · Pull Request #3842 · angular/angularfire · GitHub

Open Graph Title: build(firestore): stop zone-wrapping functions that schedule no work by armando-navarro · Pull Request #3842 · angular/angularfire

X Title: build(firestore): stop zone-wrapping functions that schedule no work by armando-navarro · Pull Request #3842 · angular/angularfire

Description: Checklist Issue number for this PR: #3841 Docs included?: in #3835, the docs PR for 22.0.0-rc.1. The commit there updates docs/zones.md. Test units included?: yes. src/firestore/unwrapped.spec.ts, new specs in src/firestore/lite/lite.spec.ts, shared helpers in src/firestore/zone-wrap-spec-support.ts. Breaking change?: no. In a clean directory, yarn install, yarn test run successfully?: yes, with npm: npm ci, then the build, lint and spec runs under Verification. Description Fixes #3841. Refs #3611, #3607. Twenty-five synchronous Firestore functions are re-exported without the zone wrapper, in @angular/fire/firestore and @angular/fire/firestore/lite. They only build or compare values, so the wrapper did nothing for them except print a false injection-context warning. The full list and the functions that stay wrapped are in #3841. Wrapping every function is a safeguard, in case a function that looks synchronous starts a timer inside the SDK. So this PR does not rely on reading the source alone: the new specs record every task each function schedules, on every CI run, against both firebase 12 and firebase 13. If one of these functions starts scheduling work, CI fails and says which one. Changes tools/build.ts: null entries in firestoreOverrides for the 25 functions. null makes the generator skip the wrapped re-export, so export * from 'firebase/firestore' hands out the SDK's own function. src/firestore/firebase.ts, src/firestore/lite/firebase.ts: regenerated. 25 wrapped exports removed from each, nothing added. src/firestore/zone-wrap-spec-support.ts: records the tasks a call schedules in a child zone, checks every unwrapped function with one sample call each, and checks that the set of functions AngularFire hands out unwrapped is exactly the listed set. src/firestore/unwrapped.spec.ts, src/firestore/lite/lite.spec.ts: run those checks for the full SDK (38 functions) and Lite (32), plus controls showing the recorder sees a timer, a promise callback, a late promise callback and an event listener, and that a still-wrapped function still warns. Behavior to know These functions no longer print the injection-context warning, at any log level. In a zone.js app, calling one inside an injection context but outside the Angular zone no longer triggers an extra unneeded change detection pass, which had nothing to update. ensureFirestoreConfigured and executeWrite, internal exports of firebase/firestore that its type declarations omit, were already re-exported unwrapped and are unchanged. Verification Build, ng lint, test:node (401 specs, 0 failures) pass. Chrome headless through firebase-tools emulators:exec: 185 of 233 executed, 48 skipped by pending(), all passing. With main's tools/build.ts and the new specs, 3 specs fail: both checks that the functions are the SDK's own, and the check that where does not warn.

Open Graph Description: Checklist Issue number for this PR: #3841 Docs included?: in #3835, the docs PR for 22.0.0-rc.1. The commit there updates docs/zones.md. Test units included?: yes. src/firestore/unwrapped.spec.ts,...

X Description: Checklist Issue number for this PR: #3841 Docs included?: in #3835, the docs PR for 22.0.0-rc.1. The commit there updates docs/zones.md. Test units included?: yes. src/firestore/unwrapped.spec.ts,...

Opengraph URL: https://github.com/angular/angularfire/pull/3842

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.113.4

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:397fa361-84eb-dc55-fbf9-1f2d8de4646c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEB12:9286A:2B950D3:39C3F6E:6B0363C0
html-safe-noncedb085c913aff981f74e2bfacf99049d27a89088dee5e99802434f89c39647191
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQjEyOjkyODZBOjJCOTUwRDM6MzlDM0Y2RTo2QjAzNjNDMCIsInZpc2l0b3JfaWQiOiIzMTE1MzQ4Mjc1NDU1MTkwNDEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacef51d0417785b3d30ebe6fcbd3cd14d0af3b03e7dcdc40c4fd4eb3e74554e695
hovercard-subject-tagpull_request:5196988414
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angularfire/pull/3842/files
twitter:imagehttps://avatars.githubusercontent.com/u/13904589?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/13904589?s=400&v=4
og:image:altChecklist Issue number for this PR: #3841 Docs included?: in #3835, the docs PR for 22.0.0-rc.1. The commit there updates docs/zones.md. Test units included?: yes. src/firestore/unwrapped.spec.ts,...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angularfire git https://github.com/angular/angularfire.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id49453413
octolytics-dimension-repository_nwoangular/angularfire
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49453413
octolytics-dimension-repository_network_root_nwoangular/angularfire
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angularfire/pull/3842/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F3842%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F3842%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangularfire
Reloadhttps://github.com/angular/angularfire/pull/3842/files
Reloadhttps://github.com/angular/angularfire/pull/3842/files
Reloadhttps://github.com/angular/angularfire/pull/3842/files
angularhttps://github.com/angular
angularfirehttps://github.com/angular/angularfire
Codehttps://github.com/angular/angularfire
Issues162 (162)https://github.com/angular/angularfire/issues
Pull requests5 (5)https://github.com/angular/angularfire/pulls
Discussionshttps://github.com/angular/angularfire/discussions
Actionshttps://github.com/angular/angularfire/actions
Projectshttps://github.com/angular/angularfire/projects
Security and qualityhttps://github.com/angular/angularfire/security
Insightshttps://github.com/angular/angularfire/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangularfire%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangularfire%2Fissues%2Fnew%2Fchoose
armando-navarrohttps://github.com/armando-navarro
angular:mainhttps://github.com/angular/angularfire/tree/main
armando-navarro:a45-unwrap-firestorehttps://github.com/armando-navarro/angularfire/tree/a45-unwrap-firestore
Conversation 0 https://github.com/angular/angularfire/pull/3842
Commits 1 https://github.com/angular/angularfire/pull/3842/commits
Checks 25 https://github.com/angular/angularfire/pull/3842/checks
Files changed https://github.com/angular/angularfire/pull/3842/files
Please reload this pagehttps://github.com/angular/angularfire/pull/3842/files
build(firestore): stop zone-wrapping functions that schedule no work https://github.com/angular/angularfire/pull/3842/files#top
Show all changes 1 commit https://github.com/angular/angularfire/pull/3842/files
8aa0209 build(firestore): stop zone-wrapping functions that schedule no work armando-navarro Nov 7, 2026 https://github.com/angular/angularfire/pull/3842/commits/8aa0209ae407bdbd51a0f5b00f6d8b186aebba10
Clear filters https://github.com/angular/angularfire/pull/3842/files
Please reload this pagehttps://github.com/angular/angularfire/pull/3842/files
Please reload this pagehttps://github.com/angular/angularfire/pull/3842/files
firebase.ts https://github.com/angular/angularfire/pull/3842/files#diff-ff611b3530f2510e5113f69088aa15a7bfab31d8e2c95347df01c893d10ac49d
firebase.ts https://github.com/angular/angularfire/pull/3842/files#diff-2024ed7f711784636bfcd0471862aa03423aa6bfb810250e8c626a75f22166d5
lite.spec.ts https://github.com/angular/angularfire/pull/3842/files#diff-9b2f88515fd4cb9a1d43941ee2b2f1872ef3e590104e0a4d6096364856143cff
unwrapped.spec.ts https://github.com/angular/angularfire/pull/3842/files#diff-fcc68736b1991d364cfe1f2645253bb5e42a29472c8ef3ee801068802a29bf21
zone-wrap-spec-support.ts https://github.com/angular/angularfire/pull/3842/files#diff-a3af6579b10cd79079773e56a4cdec4b6594d3db58a32b53047bc0d7f7d3f897
build.ts https://github.com/angular/angularfire/pull/3842/files#diff-1a7c808f53c100a839513de5b7bffe4aec260620e6f444071f92a143816de975
src/firestore/firebase.tshttps://github.com/angular/angularfire/pull/3842/files#diff-ff611b3530f2510e5113f69088aa15a7bfab31d8e2c95347df01c893d10ac49d
View file https://github.com/armando-navarro/angularfire/blob/8aa0209ae407bdbd51a0f5b00f6d8b186aebba10/src/firestore/firebase.ts
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/angular/angularfire/pull/3842/files
src/firestore/lite/firebase.tshttps://github.com/angular/angularfire/pull/3842/files#diff-2024ed7f711784636bfcd0471862aa03423aa6bfb810250e8c626a75f22166d5
View file https://github.com/armando-navarro/angularfire/blob/8aa0209ae407bdbd51a0f5b00f6d8b186aebba10/src/firestore/lite/firebase.ts
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/angular/angularfire/pull/3842/files
src/firestore/lite/lite.spec.tshttps://github.com/angular/angularfire/pull/3842/files#diff-9b2f88515fd4cb9a1d43941ee2b2f1872ef3e590104e0a4d6096364856143cff
View file https://github.com/armando-navarro/angularfire/blob/8aa0209ae407bdbd51a0f5b00f6d8b186aebba10/src/firestore/lite/lite.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angularfire/pull/3842/{{ revealButtonHref }}
https://github.com/angular/angularfire/pull/3842/files#diff-9b2f88515fd4cb9a1d43941ee2b2f1872ef3e590104e0a4d6096364856143cff
https://github.com/angular/angularfire/pull/3842/files#diff-9b2f88515fd4cb9a1d43941ee2b2f1872ef3e590104e0a4d6096364856143cff
Please reload this pagehttps://github.com/angular/angularfire/pull/3842/files
Please reload this pagehttps://github.com/angular/angularfire/pull/3842/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlno-cache

Viewport: width=device-width


URLs of crawlers that visited me.