| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:c1ab4c3e-fd18-19ec-f65b-bf6b72ae8cc2 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B238:302CFA:22436CD:2D8E14B:6B036984 |
| html-safe-nonce | 652722e270b4dded5eb926f28ddcdf9f15e9bd3e343ffd59eb3122862e5e4fec |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMjM4OjMwMkNGQToyMjQzNkNEOjJEOEUxNEI6NkIwMzY5ODQiLCJ2aXNpdG9yX2lkIjoiNjM3OTcwMjIyNTIyMDEwMjUzMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | d7ef479081ae3e43312ea14fac4610e77be7fd1080738ea3c3341bb118140e71 |
| hovercard-subject-tag | pull_request:5178048167 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angularfire/pull/3840/files |
| twitter:image | https://avatars.githubusercontent.com/u/13904589?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/13904589?s=400&v=4 |
| og:image:alt | Fixes #3839
The Branch protection job is main's required CI check, and it was skipped, which GitHub counts as passing, whenever one of the jobs it waits on failed. The evidence and the proof ru... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angularfire git https://github.com/angular/angularfire.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 49453413 |
| octolytics-dimension-repository_nwo | angular/angularfire |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 49453413 |
| octolytics-dimension-repository_network_root_nwo | angular/angularfire |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/angular/angularfire/pull/3840/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F3840%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F3840%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangularfire |
| Reload | https://github.com/angular/angularfire/pull/3840/files |
| Reload | https://github.com/angular/angularfire/pull/3840/files |
| Reload | https://github.com/angular/angularfire/pull/3840/files |
| angular | https://github.com/angular |
| angularfire | https://github.com/angular/angularfire |
| Code | https://github.com/angular/angularfire |
| Issues162 (162) | https://github.com/angular/angularfire/issues |
| Pull requests5 (5) | https://github.com/angular/angularfire/pulls |
| Discussions | https://github.com/angular/angularfire/discussions |
| Actions | https://github.com/angular/angularfire/actions |
| Projects | https://github.com/angular/angularfire/projects |
| Security and quality | https://github.com/angular/angularfire/security |
| Insights | https://github.com/angular/angularfire/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fangular%2Fangularfire%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fangular%2Fangularfire%2Fissues%2Fnew%2Fchoose |
| armando-navarro | https://github.com/armando-navarro |
| angular:main | https://github.com/angular/angularfire/tree/main |
| armando-navarro:ci-branch-protection-always-runs | https://github.com/armando-navarro/angularfire/tree/ci-branch-protection-always-runs |
|
Conversation
0
| https://github.com/angular/angularfire/pull/3840 |
|
Commits
2
| https://github.com/angular/angularfire/pull/3840/commits |
|
Checks
25
| https://github.com/angular/angularfire/pull/3840/checks |
|
Files changed
| https://github.com/angular/angularfire/pull/3840/files |
| Please reload this page | https://github.com/angular/angularfire/pull/3840/files |
|
ci: fail the Branch protection check when a job it waits on does not succeed
| https://github.com/angular/angularfire/pull/3840/files#top |
|
Show all changes
2 commits
| https://github.com/angular/angularfire/pull/3840/files |
|
30efd6c
ci: fail the Branch protection check when a job it waits on does not …
armando-navarro Nov 5, 2026
| https://github.com/angular/angularfire/pull/3840/commits/30efd6cb1ea3645d72de424eb46c4244259cbf3f |
|
99c7c92
Merge branch 'main' into ci-branch-protection-always-runs
armando-navarro Nov 6, 2026
| https://github.com/angular/angularfire/pull/3840/commits/99c7c9274d3ddc535d012511fc37ef4ce3549705 |
|
Clear filters
| https://github.com/angular/angularfire/pull/3840/files |
| Please reload this page | https://github.com/angular/angularfire/pull/3840/files |
| Please reload this page | https://github.com/angular/angularfire/pull/3840/files |
| .github/workflows/test.yml | https://github.com/angular/angularfire/pull/3840/files#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88 |
|
View file
| https://github.com/armando-navarro/angularfire/blob/99c7c9274d3ddc535d012511fc37ef4ce3549705/.github/workflows/test.yml |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angularfire/pull/3840/{{ revealButtonHref }} |
|
| https://github.com/angular/angularfire/pull/3840/files#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88 |
|
| https://github.com/angular/angularfire/pull/3840/files#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88 |
|
| https://github.com/angular/angularfire/pull/3840/files#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88 |
|
| https://github.com/angular/angularfire/actions/runs/42134507108/job/127622508646?pr=3840 |
|
| https://github.com/angular/angularfire/pull/3840/files#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88 |
| Please reload this page | https://github.com/angular/angularfire/pull/3840/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |