René's URL Explorer Experiment


Title: ci: fail the Branch protection check when a job it waits on does not succeed by armando-navarro · Pull Request #3840 · angular/angularfire · GitHub

Open Graph Title: ci: fail the Branch protection check when a job it waits on does not succeed by armando-navarro · Pull Request #3840 · angular/angularfire

X Title: ci: fail the Branch protection check when a job it waits on does not succeed by armando-navarro · Pull Request #3840 · angular/angularfire

Description: Fixes #3839 The Branch protection job is main's required CI check, and it was skipped, which GitHub counts as passing, whenever one of the jobs it waits on failed. The evidence and the proof runs are in #3839. Changes if: ${{ always() }} on the job, so it runs on every outcome of test, contribute, browser and firebase-13. One step that exits 1 when any of those results is failure, cancelled or skipped. skipped is included because a failed build skips three of the four jobs rather than failing them. A two-line comment saying why the job uses always() and not !cancelled(). The job name is unchanged, so the branch protection setting does not change. Behavior to know A cancelled run now leaves the check red instead of skipped. A failed build now leaves the check red. Before, contribute could pass on its own and the check would be skipped. Verified The same job on a throwaway repository with the same job graph: red on a failed test leg, a failed build and a cancelled run, green when everything passes, and the old job skipped on a failed test leg. This pull request's own run exercises the all-pass case.

Open Graph Description: Fixes #3839 The Branch protection job is main's required CI check, and it was skipped, which GitHub counts as passing, whenever one of the jobs it waits on failed. The evidence and the proof ru...

X Description: Fixes #3839 The Branch protection job is main's required CI check, and it was skipped, which GitHub counts as passing, whenever one of the jobs it waits on failed. The evidence and the proo...

Opengraph URL: https://github.com/angular/angularfire/pull/3840

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.113.3

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c1ab4c3e-fd18-19ec-f65b-bf6b72ae8cc2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB238:302CFA:22436CD:2D8E14B:6B036984
html-safe-nonce652722e270b4dded5eb926f28ddcdf9f15e9bd3e343ffd59eb3122862e5e4fec
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMjM4OjMwMkNGQToyMjQzNkNEOjJEOEUxNEI6NkIwMzY5ODQiLCJ2aXNpdG9yX2lkIjoiNjM3OTcwMjIyNTIyMDEwMjUzMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd7ef479081ae3e43312ea14fac4610e77be7fd1080738ea3c3341bb118140e71
hovercard-subject-tagpull_request:5178048167
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angularfire/pull/3840/files
twitter:imagehttps://avatars.githubusercontent.com/u/13904589?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/13904589?s=400&v=4
og:image:altFixes #3839 The Branch protection job is main's required CI check, and it was skipped, which GitHub counts as passing, whenever one of the jobs it waits on failed. The evidence and the proof ru...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angularfire git https://github.com/angular/angularfire.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id49453413
octolytics-dimension-repository_nwoangular/angularfire
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49453413
octolytics-dimension-repository_network_root_nwoangular/angularfire
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angularfire/pull/3840/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F3840%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F3840%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangularfire
Reloadhttps://github.com/angular/angularfire/pull/3840/files
Reloadhttps://github.com/angular/angularfire/pull/3840/files
Reloadhttps://github.com/angular/angularfire/pull/3840/files
angularhttps://github.com/angular
angularfirehttps://github.com/angular/angularfire
Codehttps://github.com/angular/angularfire
Issues162 (162)https://github.com/angular/angularfire/issues
Pull requests5 (5)https://github.com/angular/angularfire/pulls
Discussionshttps://github.com/angular/angularfire/discussions
Actionshttps://github.com/angular/angularfire/actions
Projectshttps://github.com/angular/angularfire/projects
Security and qualityhttps://github.com/angular/angularfire/security
Insightshttps://github.com/angular/angularfire/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangularfire%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangularfire%2Fissues%2Fnew%2Fchoose
armando-navarrohttps://github.com/armando-navarro
angular:mainhttps://github.com/angular/angularfire/tree/main
armando-navarro:ci-branch-protection-always-runshttps://github.com/armando-navarro/angularfire/tree/ci-branch-protection-always-runs
Conversation 0 https://github.com/angular/angularfire/pull/3840
Commits 2 https://github.com/angular/angularfire/pull/3840/commits
Checks 25 https://github.com/angular/angularfire/pull/3840/checks
Files changed https://github.com/angular/angularfire/pull/3840/files
Please reload this pagehttps://github.com/angular/angularfire/pull/3840/files
ci: fail the Branch protection check when a job it waits on does not succeed https://github.com/angular/angularfire/pull/3840/files#top
Show all changes 2 commits https://github.com/angular/angularfire/pull/3840/files
30efd6c ci: fail the Branch protection check when a job it waits on does not … armando-navarro Nov 5, 2026 https://github.com/angular/angularfire/pull/3840/commits/30efd6cb1ea3645d72de424eb46c4244259cbf3f
99c7c92 Merge branch 'main' into ci-branch-protection-always-runs armando-navarro Nov 6, 2026 https://github.com/angular/angularfire/pull/3840/commits/99c7c9274d3ddc535d012511fc37ef4ce3549705
Clear filters https://github.com/angular/angularfire/pull/3840/files
Please reload this pagehttps://github.com/angular/angularfire/pull/3840/files
Please reload this pagehttps://github.com/angular/angularfire/pull/3840/files
.github/workflows/test.ymlhttps://github.com/angular/angularfire/pull/3840/files#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88
View file https://github.com/armando-navarro/angularfire/blob/99c7c9274d3ddc535d012511fc37ef4ce3549705/.github/workflows/test.yml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angularfire/pull/3840/{{ revealButtonHref }}
https://github.com/angular/angularfire/pull/3840/files#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88
https://github.com/angular/angularfire/pull/3840/files#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88
https://github.com/angular/angularfire/pull/3840/files#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88
https://github.com/angular/angularfire/actions/runs/42134507108/job/127622508646?pr=3840
https://github.com/angular/angularfire/pull/3840/files#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88
Please reload this pagehttps://github.com/angular/angularfire/pull/3840/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlno-cache

Viewport: width=device-width


URLs of crawlers that visited me.