| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:acd26231-09db-0828-1791-d30157f87aa0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A382:14F885:664AD2:829700:6B036612 |
| html-safe-nonce | 6dc370717472ea8caebb18d02b778a0a186dbec4bdbd6b160f46761cf0c0d8ed |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMzgyOjE0Rjg4NTo2NjRBRDI6ODI5NzAwOjZCMDM2NjEyIiwidmlzaXRvcl9pZCI6IjczNDIwODI5MTMxMDM3MzQyOTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 8528ecc2789d152daf1b226979f3febb288303e80d1a09a1d99965eeabec050e |
| hovercard-subject-tag | pull_request:5178048167 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angularfire/3840/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/da981ce34c2a025d070cfea0b680f09ee655ab1dfc75f11372d923f75e006cbc/angular/angularfire/pull/3840 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/da981ce34c2a025d070cfea0b680f09ee655ab1dfc75f11372d923f75e006cbc/angular/angularfire/pull/3840 |
| og:image:alt | Fixes #3839
The Branch protection job is main's required CI check, and it was skipped, which GitHub counts as passing, whenever one of the jobs it waits on failed. The evidence and the proof ru... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | armando-navarro |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angularfire git https://github.com/angular/angularfire.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 49453413 |
| octolytics-dimension-repository_nwo | angular/angularfire |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 49453413 |
| octolytics-dimension-repository_network_root_nwo | angular/angularfire |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angularfire/pull/3840#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F3840 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F3840 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangularfire |
| Reload | https://github.com/angular/angularfire/pull/3840 |
| Reload | https://github.com/angular/angularfire/pull/3840 |
| Reload | https://github.com/angular/angularfire/pull/3840 |
| angular | https://github.com/angular |
| angularfire | https://github.com/angular/angularfire |
| Code | https://github.com/angular/angularfire |
| Issues162 (162) | https://github.com/angular/angularfire/issues |
| Pull requests5 (5) | https://github.com/angular/angularfire/pulls |
| Discussions | https://github.com/angular/angularfire/discussions |
| Actions | https://github.com/angular/angularfire/actions |
| Projects | https://github.com/angular/angularfire/projects |
| Security and quality | https://github.com/angular/angularfire/security |
| Insights | https://github.com/angular/angularfire/insights |
| https://github.com/angular/angularfire |
| armando-navarro | https://github.com/armando-navarro |
| angular:main | https://github.com/angular/angularfire/tree/main |
| armando-navarro:ci-branch-protection-always-runs | https://github.com/armando-navarro/angularfire/tree/ci-branch-protection-always-runs |
| Conversation | https://github.com/angular/angularfire/pull/3840 |
| Commits2 (2) | https://github.com/angular/angularfire/pull/3840/commits |
| Checks | https://github.com/angular/angularfire/pull/3840/checks |
| Files changed | https://github.com/angular/angularfire/pull/3840/files |
| ci: fail the Branch protection check when a job it waits on does not succeed | https://github.com/angular/angularfire/pull/3840#top |
| armando-navarro | https://github.com/armando-navarro |
| angular:main | https://github.com/angular/angularfire/tree/main |
| armando-navarro:ci-branch-protection-always-runs | https://github.com/armando-navarro/angularfire/tree/ci-branch-protection-always-runs |
|
| https://github.com/armando-navarro |
| armando-navarro | https://github.com/armando-navarro |
| Nov 5, 2026 | https://github.com/angular/angularfire/pull/3840#issue-6230867980 |
| #3839 | https://github.com/angular/angularfire/issues/3839 |
| #3839 | https://github.com/angular/angularfire/issues/3839 |
| Please reload this page | https://github.com/angular/angularfire/pull/3840 |
|
| https://github.com/armando-navarro |
| ci: fail the Branch protection check when a job it waits on does not … | https://github.com/angular/angularfire/pull/3840/commits/30efd6cb1ea3645d72de424eb46c4244259cbf3f |
| 30efd6c | https://github.com/angular/angularfire/pull/3840/commits/30efd6cb1ea3645d72de424eb46c4244259cbf3f |
| angular#3762 | https://github.com/angular/angularfire/pull/3762 |
| https://github.com/armando-navarro |
| armando-navarro | https://github.com/armando-navarro |
| tyler-reitz | https://github.com/tyler-reitz |
| November 5, 2026 20:15 | https://github.com/angular/angularfire/pull/3840#event-35282654859 |
| https://github.com/armando-navarro |
| armando-navarro | https://github.com/armando-navarro |
|
comp: build/pipeline
| https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22comp%3A%20build%2Fpipeline%22 |
|
type: bug
| https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%22 |
| Nov 5, 2026 | https://github.com/angular/angularfire/pull/3840#event-35282657537 |
| https://github.com/armando-navarro |
| armando-navarro | https://github.com/armando-navarro |
| 22.0.0-rc.1 | https://github.com/angular/angularfire/milestone/35 |
| Nov 5, 2026 | https://github.com/angular/angularfire/pull/3840#event-35282661652 |
| https://github.com/tyler-reitz |
| tyler-reitz | https://github.com/tyler-reitz |
|
Nov 5, 2026
| https://github.com/angular/angularfire/pull/3840#pullrequestreview-5793545925 |
|
View reviewed changes
| https://github.com/angular/angularfire/pull/3840/files/99c7c9274d3ddc535d012511fc37ef4ce3549705 |
|
| https://github.com/armando-navarro |
| Merge branch 'main' into ci-branch-protection-always-runs | https://github.com/angular/angularfire/pull/3840/commits/99c7c9274d3ddc535d012511fc37ef4ce3549705 |
| 99c7c92 | https://github.com/angular/angularfire/pull/3840/commits/99c7c9274d3ddc535d012511fc37ef4ce3549705 |
| https://github.com/armando-navarro |
| armando-navarro | https://github.com/armando-navarro |
| 419db92 | https://github.com/angular/angularfire/commit/419db92f5621c5aa462b8299f277a05701251505 |
| Nov 6, 2026 | https://github.com/angular/angularfire/pull/3840#event-35300995588 |
| Please reload this page | https://github.com/angular/angularfire/pull/3840 |
| https://github.com/armando-navarro |
| armando-navarro | https://github.com/armando-navarro |
| November 6, 2026 00:28 | https://github.com/angular/angularfire/pull/3840#event-35301043861 |
| https://github.co/hiddenchars |
| https://github.com/angular/angularfire/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F3840 |
|
| https://github.com/tyler-reitz |
|
tyler-reitz
| https://github.com/tyler-reitz |
|
| https://github.com/angular/angularfire/pull/3840/files/99c7c9274d3ddc535d012511fc37ef4ce3549705 |
| Please reload this page | https://github.com/angular/angularfire/pull/3840 |
|
comp: build/pipeline
| https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22comp%3A%20build%2Fpipeline%22 |
|
type: bug
| https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%22 |
|
22.0.0-rc.1
| https://github.com/angular/angularfire/milestone/35 |
|
Branch protection is skipped, and counts as passing, when a job it waits on fails
| https://github.com/angular/angularfire/issues/3839 |
| Please reload this page | https://github.com/angular/angularfire/pull/3840 |
|
| https://github.com/armando-navarro |
|
| https://github.com/tyler-reitz |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |