René's URL Explorer Experiment


Title: feat(zones)!: remove callback pending tasks right after the callback by armando-navarro · Pull Request #3837 · angular/angularfire · GitHub

Open Graph Title: feat(zones)!: remove callback pending tasks right after the callback by armando-navarro · Pull Request #3837 · angular/angularfire

X Title: feat(zones)!: remove callback pending tasks right after the callback by armando-navarro · Pull Request #3837 · angular/angularfire

Description: Checklist Issue number for this PR: #3836 Docs included?: no, the upgrade-guide entry lands on the rc.1 docs PR #3835. Test units included?: yes Breaking change?: yes In a clean directory, yarn install, yarn test run successfully? yes, as npm ci and npm test Description Removes the pending task a callback-taking wrapper registers in a finally right after the callback body, and right after the unsubscribe call, instead of through setTimeout(taskDone, 0) in src/zones.ts. Deletes the 2021 TODO next to the wrapping call that asked for this. The finally runs whether the callback returns or throws, so a throwing callback does not leave its task behind, which the timer also guaranteed. This is the same way Angular's own pendingUntilEvent works: it forwards the value and then removes its task synchronously. Nothing else in the wrapper changes: the task is still registered at call time, the callback still runs inside the Angular zone and the injection context, and the Observable and Promise branches are untouched. What this grants, measured on Angular 22.2 zone.js and zoneless apps, before and after: The task is gone before any setTimeout(fn, 0) callback registered at delivery, in every run: a synthetic callback in Chrome and Firefox, the unsubscribe path, and the real onSnapshot against the Firestore emulator. With Realtime Database on cached data, where the SDK invokes the callback inside the registering call, the task is removed inside that call. A zone.js server render reports stable about a millisecond sooner after a single callback read's first value. In a zoneless render the difference is within noise: the callback's own signal write already schedules Angular's tick, which bounds stability either way. In a zone.js app, a callback delivered inside the Angular zone no longer causes a third change-detection pass. What does not change: The DOM updates on delivery, and the number of change-detection passes for a callback delivered from outside Angular. No task is left behind in the four callback cases probed for #3827 against the emulators. When whenStable() resolves under fake timers. Angular's change-detection tick is itself a timer, so a test that advances fake timers before awaiting whenStable() still needs the advance, before and after. What upgrading apps may notice: whenStable() and server rendering follow a callback read's first value one setTimeout(fn, 0) delay sooner. A test that inspects pending tasks directly sees the wrapper's task gone as soon as the callback has run, without a timer advance. Verification: Four new specs in src/zones.spec.ts, each observing the remover function PendingTasks.add() returns. All four fail on main and pass here: the task is removed after the callback body and before any microtask the body queued, before a setTimeout(fn, 0) callback registered just before delivery the same when the SDK invokes the callback inside the registering call the same on unsubscribe a throwing callback does not leave its task behind npm run lint, npm run test:node, npm run test:chrome-headless and npm run test:firefox-headless pass on the branch.

Open Graph Description: Checklist Issue number for this PR: #3836 Docs included?: no, the upgrade-guide entry lands on the rc.1 docs PR #3835. Test units included?: yes Breaking change?: yes In a clean directory, yarn in...

X Description: Checklist Issue number for this PR: #3836 Docs included?: no, the upgrade-guide entry lands on the rc.1 docs PR #3835. Test units included?: yes Breaking change?: yes In a clean directory, yarn in...

Opengraph URL: https://github.com/angular/angularfire/pull/3837

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.113.3

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6fa44d04-151f-049b-61a8-4a4a6d44b8dd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE3A6:3C1C49:2581EF5:314CB98:6B0362EC
html-safe-noncede8ae6df1763ff7ac988d68598d13af055550dfb3d1eec1cbcc8d067e2bc4d92
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFM0E2OjNDMUM0OToyNTgxRUY1OjMxNENCOTg6NkIwMzYyRUMiLCJ2aXNpdG9yX2lkIjoiMTc3ODQ4ODU5NDQ2NDM2NTg4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2d8df4c5216eb58ab046204e5ed37909dd28a64a09242b0ee5e9633d63633271
hovercard-subject-tagpull_request:5165317365
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angularfire/pull/3837/files
twitter:imagehttps://avatars.githubusercontent.com/u/13904589?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/13904589?s=400&v=4
og:image:altChecklist Issue number for this PR: #3836 Docs included?: no, the upgrade-guide entry lands on the rc.1 docs PR #3835. Test units included?: yes Breaking change?: yes In a clean directory, yarn in...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angularfire git https://github.com/angular/angularfire.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id49453413
octolytics-dimension-repository_nwoangular/angularfire
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49453413
octolytics-dimension-repository_network_root_nwoangular/angularfire
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angularfire/pull/3837/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F3837%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F3837%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangularfire
Reloadhttps://github.com/angular/angularfire/pull/3837/files
Reloadhttps://github.com/angular/angularfire/pull/3837/files
Reloadhttps://github.com/angular/angularfire/pull/3837/files
angularhttps://github.com/angular
angularfirehttps://github.com/angular/angularfire
Codehttps://github.com/angular/angularfire
Issues162 (162)https://github.com/angular/angularfire/issues
Pull requests5 (5)https://github.com/angular/angularfire/pulls
Discussionshttps://github.com/angular/angularfire/discussions
Actionshttps://github.com/angular/angularfire/actions
Projectshttps://github.com/angular/angularfire/projects
Security and qualityhttps://github.com/angular/angularfire/security
Insightshttps://github.com/angular/angularfire/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangularfire%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangularfire%2Fissues%2Fnew%2Fchoose
armando-navarrohttps://github.com/armando-navarro
angular:mainhttps://github.com/angular/angularfire/tree/main
armando-navarro:a95-callback-task-microtaskhttps://github.com/armando-navarro/angularfire/tree/a95-callback-task-microtask
Conversation 2 https://github.com/angular/angularfire/pull/3837
Commits 4 https://github.com/angular/angularfire/pull/3837/commits
Checks 25 https://github.com/angular/angularfire/pull/3837/checks
Files changed https://github.com/angular/angularfire/pull/3837/files
Please reload this pagehttps://github.com/angular/angularfire/pull/3837/files
feat(zones)!: remove callback pending tasks right after the callback https://github.com/angular/angularfire/pull/3837/files#top
Show all changes 4 commits https://github.com/angular/angularfire/pull/3837/files
29d9f01 feat(zones)!: remove callback pending tasks right after the callback armando-navarro Nov 5, 2026 https://github.com/angular/angularfire/pull/3837/commits/29d9f0175ec5427971c424324667b91c03a099aa
f0b8be6 Merge remote-tracking branch 'origin/main' into a95-callback-task-mic… armando-navarro Nov 5, 2026 https://github.com/angular/angularfire/pull/3837/commits/f0b8be6e668f13a7f2d27df4b5559f8702751c43
991e362 test(zones): fail the pending-task specs when the task is never removed armando-navarro Nov 5, 2026 https://github.com/angular/angularfire/pull/3837/commits/991e362b96cd19e0877f7e3fd6ba4c81b7e1b6d8
99215a7 Merge branch 'main' into a95-callback-task-microtask armando-navarro Nov 6, 2026 https://github.com/angular/angularfire/pull/3837/commits/99215a7f648a55cf4c39448e0d7fc5e7b8b51cd1
Clear filters https://github.com/angular/angularfire/pull/3837/files
Please reload this pagehttps://github.com/angular/angularfire/pull/3837/files
Please reload this pagehttps://github.com/angular/angularfire/pull/3837/files
zones.spec.ts https://github.com/angular/angularfire/pull/3837/files#diff-a4d464c99ddd4dba3556da9e413e461a987499810098e655417216b292c761f3
zones.ts https://github.com/angular/angularfire/pull/3837/files#diff-773e71ddabd544410ec64c113754c7f30c2d78b5ce055c1e20d42b8d4a47a640
src/zones.spec.tshttps://github.com/angular/angularfire/pull/3837/files#diff-a4d464c99ddd4dba3556da9e413e461a987499810098e655417216b292c761f3
View file https://github.com/armando-navarro/angularfire/blob/99215a7f648a55cf4c39448e0d7fc5e7b8b51cd1/src/zones.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angularfire/pull/3837/{{ revealButtonHref }}
https://github.com/angular/angularfire/pull/3837/files#diff-a4d464c99ddd4dba3556da9e413e461a987499810098e655417216b292c761f3
https://github.com/angular/angularfire/pull/3837/files#diff-a4d464c99ddd4dba3556da9e413e461a987499810098e655417216b292c761f3
https://github.com/angular/angularfire/pull/3837/files#diff-a4d464c99ddd4dba3556da9e413e461a987499810098e655417216b292c761f3
https://github.com/angular/angularfire/pull/3837/files#diff-a4d464c99ddd4dba3556da9e413e461a987499810098e655417216b292c761f3
https://github.com/angular/angularfire/pull/3837/files#diff-a4d464c99ddd4dba3556da9e413e461a987499810098e655417216b292c761f3
https://github.com/angular/angularfire/pull/3837/files#diff-a4d464c99ddd4dba3556da9e413e461a987499810098e655417216b292c761f3
https://github.com/angular/angularfire/pull/3837/files#diff-a4d464c99ddd4dba3556da9e413e461a987499810098e655417216b292c761f3
src/zones.tshttps://github.com/angular/angularfire/pull/3837/files#diff-773e71ddabd544410ec64c113754c7f30c2d78b5ce055c1e20d42b8d4a47a640
View file https://github.com/armando-navarro/angularfire/blob/99215a7f648a55cf4c39448e0d7fc5e7b8b51cd1/src/zones.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angularfire/pull/3837/{{ revealButtonHref }}
https://github.com/angular/angularfire/pull/3837/files#diff-773e71ddabd544410ec64c113754c7f30c2d78b5ce055c1e20d42b8d4a47a640
https://github.com/angular/angularfire/pull/3837/files#diff-773e71ddabd544410ec64c113754c7f30c2d78b5ce055c1e20d42b8d4a47a640
https://github.com/angular/angularfire/pull/3837/files#diff-773e71ddabd544410ec64c113754c7f30c2d78b5ce055c1e20d42b8d4a47a640
https://github.com/angular/angularfire/pull/3837/files#diff-773e71ddabd544410ec64c113754c7f30c2d78b5ce055c1e20d42b8d4a47a640
https://github.com/angular/angularfire/pull/3837/files#diff-773e71ddabd544410ec64c113754c7f30c2d78b5ce055c1e20d42b8d4a47a640
https://github.com/angular/angularfire/pull/3837/files#diff-773e71ddabd544410ec64c113754c7f30c2d78b5ce055c1e20d42b8d4a47a640
Please reload this pagehttps://github.com/angular/angularfire/pull/3837/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlno-cache

Viewport: width=device-width


URLs of crawlers that visited me.