Title: feat(zones)!: deliver Observable read values as microtasks by armando-navarro · Pull Request #3833 · angular/angularfire · GitHub
Open Graph Title: feat(zones)!: deliver Observable read values as microtasks by armando-navarro · Pull Request #3833 · angular/angularfire
X Title: feat(zones)!: deliver Observable read values as microtasks by armando-navarro · Pull Request #3833 · angular/angularfire
Description: Checklist Issue number for this PR: #3832 Docs included?: no, the upgrade-guide entry lands in a separate docs PR. Test units included?: yes Breaking change?: yes In a clean directory, yarn install, yarn test run successfully? yes, as npm ci and npm test Description Builds the insideAngular scheduler in src/zones.ts over a private AsapScheduler instance instead of rxjs's asyncScheduler, so every value from an Observable-returning read reaches the subscriber at the next microtask checkpoint instead of after a setInterval turn. The instance is AngularFire's own rather than rxjs's shared asapScheduler because the shared one runs every action scheduled in a turn as one batch and cancels the rest of the batch when one action throws, which would let another library's action drop a delivery. AsapScheduler and AsapAction come from rxjs/internal/scheduler/, a path rxjs 7.8 lists in its exports map but keeps under internal. Nothing else in the wrapper changes: Promise-returning and callback-taking wrappers never used this scheduler. What this grants, measured on Angular 22.2 zone.js and zoneless apps, before and after: Values arrive before a zero-delay timer registered when the source emitted, in every run: a synthetic source in Chrome and Firefox, and collectionData against the Firestore emulator and the compat authState against the Auth emulator in Chrome. A server render reports stable about 1 ms sooner after Firestore's last callback. What does not change: The DOM updates on delivery and the subscriber runs inside the Angular zone. zone.js ticks once per value and zoneless once per burst. Order is preserved. What upgrading apps may notice: A test that waits only for microtasks (a few awaited promises, vitest fake timers without advancing, fakeAsync with flushMicrotasks() alone) now sees a value whose source emits in a microtask, as Auth and a promise-based mock do. Firestore hands its snapshots over in a setTimeout, so Firestore reads still need a timer to advance. Tests that advance timers are unchanged. Code that registers its own setTimeout when a read emits sees that timer run after the value arrives, not before. In a zoneless server render, a value arriving between the app reporting stable and serialization now reaches a hand-written TransferState entry but not the HTML, because the zoneless change-detection pass is itself a later timer. Before this change such a value reached neither. The compat AngularFireAuth streams move with the modular reads. Compat AngularFireFunctions and AngularFireMessaging only hand over their SDK instance through this scheduler, and compat Database and Firestore do not use it. Verification: New spec src/zones.spec.ts: a wrapped Observable's value arrives asynchronously, inside the Angular zone, and before a zero-delay timer registered when the source emitted, and the delivery scheduler is an AsapScheduler that is not rxjs's shared instance. Fails on main, passes here. npm run lint, npm run test:node, npm run test:chrome-headless and npm run test:firefox-headless pass on the branch.
Open Graph Description: Checklist Issue number for this PR: #3832 Docs included?: no, the upgrade-guide entry lands in a separate docs PR. Test units included?: yes Breaking change?: yes In a clean directory, yarn instal...
X Description: Checklist Issue number for this PR: #3832 Docs included?: no, the upgrade-guide entry lands in a separate docs PR. Test units included?: yes Breaking change?: yes In a clean directory, yarn instal...
Opengraph URL: https://github.com/angular/angularfire/pull/3833
X: @github
Domain: github.com
IPv4 address: 140.82.113.4
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:6418fef7-c6d0-b9c5-b8ba-04fe024d6999 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E16C:129351:87B22C:AD44B1:6B03607E |
| html-safe-nonce | 434a222a571d4105badc542c2d23bc0cc8db8db89872b9ae36c01b10969b9298 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMTZDOjEyOTM1MTo4N0IyMkM6QUQ0NEIxOjZCMDM2MDdFIiwidmlzaXRvcl9pZCI6IjE0NTU3MDM5NjYxOTIxOTc3NTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | debbc39670c64c7c6f4daf953482e6cb855906c7ddb20170c0ac47e208e30a4d |
| hovercard-subject-tag | pull_request:5088772992 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angularfire/pull/3833/files |
| twitter:image | https://avatars.githubusercontent.com/u/13904589?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/13904589?s=400&v=4 |
| og:image:alt | Checklist Issue number for this PR: #3832 Docs included?: no, the upgrade-guide entry lands in a separate docs PR. Test units included?: yes Breaking change?: yes In a clean directory, yarn instal... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angularfire git https://github.com/angular/angularfire.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 49453413 |
| octolytics-dimension-repository_nwo | angular/angularfire |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 49453413 |
| octolytics-dimension-repository_network_root_nwo | angular/angularfire |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
| Server | github.com |
| Content-Type | text/html; charset=utf-8 |
| Cache-Control | no-cache |
Viewport: width=device-width