René's URL Explorer Experiment


Title: feat: accept firebase 13 alongside firebase 12 by armando-navarro · Pull Request #3831 · angular/angularfire · GitHub

Open Graph Title: feat: accept firebase 13 alongside firebase 12 by armando-navarro · Pull Request #3831 · angular/angularfire

X Title: feat: accept firebase 13 alongside firebase 12 by armando-navarro · Pull Request #3831 · angular/angularfire

Description: Fixes #3830 Issue number for this PR: #3830 Docs included?: no. The docs/version-22-upgrade.md changes go on the single rc.1 docs pull request, which merges just before the tag. Test units included?: yes. New specs in src/schematics/common.jasmine.ts. A CI job that runs the specs against firebase 13. Breaking change?: no. Apps on firebase 12 are unaffected. In a clean directory, yarn install, yarn test run successfully? yes, with npm: npm ci, npm run build, npm run lint, npm run test:node and npm run test:chrome-headless. Description This lets @angular/fire 22 accept firebase 13 alongside 12, so ng add stops failing with ERESOLVE on apps that already have firebase 13. The reasoning is in the linked issue. Changes src/package.json: Peer firebase is ^12.18.0 || ^13.0.0. rxfire is ^6.3.0. The repo still builds against firebase 12. alignFirebaseVersion in src/schematics/common.ts, used by ng add and the v21 and v22 migrations: It leaves an entry inside ^12.18.0 || ^13.0.0 alone. When it writes an entry, it writes the range of the firebase major already installed. It looks for node_modules/firebase in the workspace and then in each parent directory, so it also finds a monorepo root install. It ignores an installed copy that the app's own entry excludes, since that copy is stale. With nothing usable installed, an entry that starts at 13 gets ^13.0.0, and anything else gets ^12.18.0. .github/workflows/test.yml has a new "Test firebase 13" job: It runs test:node and test:chrome-headless on Node 24, with firebase 13.1.0 installed over the firebase 12 build. It fails if 13.1.0 is not what got installed. test_and_contribute and publish both wait on it. Behavior to know ng add @angular/fire on a new app with no firebase now writes ^13.0.0, because npm has already installed firebase 13 as the missing peer. The v22 migration on an Angular 21 app that relied on the bundled firebase writes ^12.18.0, so the app stays on 12. pnpm does not link an auto-installed peer at node_modules/firebase, so a new app on pnpm gets ^12.18.0 and one copy of firebase 12. rxfire 6.3.0 now writes the idField onto the object a Firestore converter returns, instead of onto a copy. With idField set, a converter that returns a frozen object now throws in collectionData and docData. A fresh install with ^6.2.0 already resolves to 6.3.0. Verified outside CI ng add in fresh Angular 22 apps ended with one copy of firebase in every starting state I tried: no firebase, firebase 12 or 13 already installed, and entries like >=13.0.0, * and a firebase 13 prerelease. ng update from Angular 21 to 22 kept each app on its existing firebase major. An npm workspaces monorepo and a pnpm app each ended with one copy. Apps on firebase 12 and on 13 ran Auth, Firestore, Realtime Database, Storage, Functions and AI calls against the emulators in Chrome with a clean console. Tyler, the part I'd most like a second look at is the installed-version lookup in alignFirebaseVersion, since it reads outside the schematic tree.

Open Graph Description: Fixes #3830 Issue number for this PR: #3830 Docs included?: no. The docs/version-22-upgrade.md changes go on the single rc.1 docs pull request, which merges just before the tag. Test units include...

X Description: Fixes #3830 Issue number for this PR: #3830 Docs included?: no. The docs/version-22-upgrade.md changes go on the single rc.1 docs pull request, which merges just before the tag. Test units include...

Opengraph URL: https://github.com/angular/angularfire/pull/3831

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.114.4

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c1071d3a-2e71-d9d4-88a6-9037ccc66c4e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idED40:3280A:25260BE:30D9A02:6B036362
html-safe-nonce20c30241509930a855d70c95023b8d3f366c752cd85a29a07d7f1855456ec047
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDQwOjMyODBBOjI1MjYwQkU6MzBEOUEwMjo2QjAzNjM2MiIsInZpc2l0b3JfaWQiOiI3MzA0ODMwMDg5MDYwMTE1Mjk4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac47aab620d2b86cc2f5f62b900dc114252c2b5029f6a66b4cb4a69b807768769e
hovercard-subject-tagpull_request:5088497983
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angularfire/pull/3831/files
twitter:imagehttps://avatars.githubusercontent.com/u/13904589?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/13904589?s=400&v=4
og:image:altFixes #3830 Issue number for this PR: #3830 Docs included?: no. The docs/version-22-upgrade.md changes go on the single rc.1 docs pull request, which merges just before the tag. Test units include...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angularfire git https://github.com/angular/angularfire.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id49453413
octolytics-dimension-repository_nwoangular/angularfire
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49453413
octolytics-dimension-repository_network_root_nwoangular/angularfire
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angularfire/pull/3831/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F3831%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F3831%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangularfire
Reloadhttps://github.com/angular/angularfire/pull/3831/files
Reloadhttps://github.com/angular/angularfire/pull/3831/files
Reloadhttps://github.com/angular/angularfire/pull/3831/files
angularhttps://github.com/angular
angularfirehttps://github.com/angular/angularfire
Codehttps://github.com/angular/angularfire
Issues162 (162)https://github.com/angular/angularfire/issues
Pull requests5 (5)https://github.com/angular/angularfire/pulls
Discussionshttps://github.com/angular/angularfire/discussions
Actionshttps://github.com/angular/angularfire/actions
Projectshttps://github.com/angular/angularfire/projects
Security and qualityhttps://github.com/angular/angularfire/security
Insightshttps://github.com/angular/angularfire/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangularfire%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangularfire%2Fissues%2Fnew%2Fchoose
armando-navarrohttps://github.com/armando-navarro
angular:mainhttps://github.com/angular/angularfire/tree/main
armando-navarro:a93-firebase-13https://github.com/armando-navarro/angularfire/tree/a93-firebase-13
Conversation 1 https://github.com/angular/angularfire/pull/3831
Commits 2 https://github.com/angular/angularfire/pull/3831/commits
Checks 25 https://github.com/angular/angularfire/pull/3831/checks
Files changed https://github.com/angular/angularfire/pull/3831/files
Please reload this pagehttps://github.com/angular/angularfire/pull/3831/files
feat: accept firebase 13 alongside firebase 12 https://github.com/angular/angularfire/pull/3831/files#top
Show all changes 2 commits https://github.com/angular/angularfire/pull/3831/files
fe1e281 feat: accept firebase 13 alongside firebase 12 armando-navarro Oct 30, 2026 https://github.com/angular/angularfire/pull/3831/commits/fe1e281814188255c659afdc2eeeb6635c204614
5c5a8b9 test: remove the monorepo spec's temp directory without rmdirSync's r… armando-navarro Oct 30, 2026 https://github.com/angular/angularfire/pull/3831/commits/5c5a8b9d228aa75c86773e10f2edbc31932fb380
Clear filters https://github.com/angular/angularfire/pull/3831/files
Please reload this pagehttps://github.com/angular/angularfire/pull/3831/files
Please reload this pagehttps://github.com/angular/angularfire/pull/3831/files
test.yml https://github.com/angular/angularfire/pull/3831/files#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88
package-lock.json https://github.com/angular/angularfire/pull/3831/files#diff-053150b640a7ce75eff69d1a22cae7f0f94ad64ce9a855db544dda0929316519
package.json https://github.com/angular/angularfire/pull/3831/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
package.json https://github.com/angular/angularfire/pull/3831/files#diff-cc5a2f170768969f124108ad3be7fdbcbed774c11774d99a87a3a78fef4ab97b
common.jasmine.ts https://github.com/angular/angularfire/pull/3831/files#diff-7659053d05665ba53c881f9f46f8179d177758d7a5ed0650c75973fab061417c
common.ts https://github.com/angular/angularfire/pull/3831/files#diff-a65fe16aec051a6f17358127ac0052378fe257ebf7cb862c82c9547afceb6dec
.github/workflows/test.ymlhttps://github.com/angular/angularfire/pull/3831/files#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88
View file https://github.com/armando-navarro/angularfire/blob/5c5a8b9d228aa75c86773e10f2edbc31932fb380/.github/workflows/test.yml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angularfire/pull/3831/{{ revealButtonHref }}
https://github.com/angular/angularfire/pull/3831/files#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88
https://github.com/angular/angularfire/pull/3831/files#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88
https://github.com/angular/angularfire/pull/3831/files#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88
https://github.com/angular/angularfire/pull/3831/files#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88
https://github.com/angular/angularfire/pull/3831/files#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88
https://github.com/angular/angularfire/actions/runs/41103474158/job/124226595490?pr=3831
https://github.com/angular/angularfire/pull/3831/files#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88
package-lock.jsonhttps://github.com/angular/angularfire/pull/3831/files#diff-053150b640a7ce75eff69d1a22cae7f0f94ad64ce9a855db544dda0929316519
View file https://github.com/armando-navarro/angularfire/blob/5c5a8b9d228aa75c86773e10f2edbc31932fb380/package-lock.json
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/angular/angularfire/pull/3831/files
package.jsonhttps://github.com/angular/angularfire/pull/3831/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
View file https://github.com/armando-navarro/angularfire/blob/5c5a8b9d228aa75c86773e10f2edbc31932fb380/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angularfire/pull/3831/{{ revealButtonHref }}
https://github.com/angular/angularfire/pull/3831/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
https://github.com/angular/angularfire/pull/3831/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
src/package.jsonhttps://github.com/angular/angularfire/pull/3831/files#diff-cc5a2f170768969f124108ad3be7fdbcbed774c11774d99a87a3a78fef4ab97b
View file https://github.com/armando-navarro/angularfire/blob/5c5a8b9d228aa75c86773e10f2edbc31932fb380/src/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angularfire/pull/3831/{{ revealButtonHref }}
https://github.com/angular/angularfire/pull/3831/files#diff-cc5a2f170768969f124108ad3be7fdbcbed774c11774d99a87a3a78fef4ab97b
https://github.com/angular/angularfire/pull/3831/files#diff-cc5a2f170768969f124108ad3be7fdbcbed774c11774d99a87a3a78fef4ab97b
https://github.com/angular/angularfire/pull/3831/files#diff-cc5a2f170768969f124108ad3be7fdbcbed774c11774d99a87a3a78fef4ab97b
src/schematics/common.jasmine.tshttps://github.com/angular/angularfire/pull/3831/files#diff-7659053d05665ba53c881f9f46f8179d177758d7a5ed0650c75973fab061417c
View file https://github.com/armando-navarro/angularfire/blob/5c5a8b9d228aa75c86773e10f2edbc31932fb380/src/schematics/common.jasmine.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angularfire/pull/3831/{{ revealButtonHref }}
https://github.com/angular/angularfire/pull/3831/files#diff-7659053d05665ba53c881f9f46f8179d177758d7a5ed0650c75973fab061417c
https://github.com/angular/angularfire/pull/3831/files#diff-7659053d05665ba53c881f9f46f8179d177758d7a5ed0650c75973fab061417c
https://github.com/angular/angularfire/pull/3831/files#diff-7659053d05665ba53c881f9f46f8179d177758d7a5ed0650c75973fab061417c
https://github.com/angular/angularfire/pull/3831/files#diff-7659053d05665ba53c881f9f46f8179d177758d7a5ed0650c75973fab061417c
https://github.com/angular/angularfire/pull/3831/files#diff-7659053d05665ba53c881f9f46f8179d177758d7a5ed0650c75973fab061417c
Please reload this pagehttps://github.com/angular/angularfire/pull/3831/files
Please reload this pagehttps://github.com/angular/angularfire/pull/3831/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlno-cache

Viewport: width=device-width


URLs of crawlers that visited me.