René's URL Explorer Experiment


Title: build!: make firebase a peer dependency and add the v22 migration by armando-navarro · Pull Request #3805 · angular/angularfire · GitHub

Open Graph Title: build!: make firebase a peer dependency and add the v22 migration by armando-navarro · Pull Request #3805 · angular/angularfire

X Title: build!: make firebase a peer dependency and add the v22 migration by armando-navarro · Pull Request #3805 · angular/angularfire

Description: Checklist Issue number for this PR: #3804 Docs included?: yes. docs/version-22-upgrade.md is new, with its README link. The README and quickstart install commands follow in their own pull request, held until 22.0.0 is published. Test units included?: yes. src/schematics/update/v22/index.jasmine.ts, and the firebaseVersionRange spec now reads the peer entry. Breaking change?: yes. BREAKING CHANGE: footer in the commit, ! in the subject. In a clean directory, yarn install, yarn test run successfully? yes, with npm: npm ci, npm run build, npm run lint, npm run test:node (389 specs) and npm run test:chrome-headless (112 specs) pass. Description Through v21, @angular/fire listed firebase under dependencies, so an app that asked for a different version got a second copy of the SDK nested under @angular/fire, and the two copies rejected each other's objects at runtime. With firebase as a peer dependency there is exactly one copy, and an incompatible version is refused at install time on npm. The reasoning and the alternatives are in #3804. Changes src/package.json: firebase ^12.18.0 moves from dependencies to peerDependencies. src/ng-package.json drops it from allowedNonPeerDependencies. migration-v22 (src/schematics/update/v22/index.ts, registered in migration.json at 22.0.0, tools/build.ts and the schematics tsconfig.json): calls alignFirebaseVersion and schedules an install only when it changed something. ng update rewrites a firebase entry the app already declares before any migration runs, but writes nothing for an app with no entry, so the migration exists for that case. A rerun changes nothing, which ng update relies on across prerelease steps. alignFirebaseVersion: the comment and its two log messages no longer say that @angular/fire bundles firebase, and they no longer describe one package manager's behavior. The firebaseVersionRange comment and spec tie the literal to peerDependencies.firebase. Both migration descriptions say "the range @angular/fire requires" with no version number, since both read the one firebaseVersionRange constant. docs/version-22-upgrade.md: the run-the-update command, what the migration does, and the "Your app now owns the Firebase SDK" section (npm, ERESOLVE, Yarn, pnpm). The commands say @angular/fire@canary, the only installable 22 build today, and move to @next and @22 as those tags exist. Behavior to know npm 7 and later install the missing peer by themselves but write no firebase entry. ng update adds it. npm install @angular/fire@canary by hand leaves the app working with an undeclared dependency, which the guide tells the reader to declare. pnpm and Yarn install an out-of-range firebase as one copy with a warning, and legacy-peer-deps=true in an .npmrc makes npm do the same silently. The ng add and ng update alignment is what corrects those apps. The ng add warning for two installed firebase versions stays. Under a peer dependency, two copies appear only when another package bundles its own firebase. Not in this PR: the README and quickstart install commands (own pull request, held until 22.0.0) the firebase range itself (^12.18.0 today, ^12.19.0 is a separate decision) @schematics/angular and @angular-devkit/schematics in dependencies (#3694) Verification Build, lint, test:node (389 specs, four of them the new migration's) and test:chrome-headless (112 specs) pass. The built package.json and the packed tarball list firebase ^12.18.0 as a peer and no firebase dependency. A fresh Angular 22.2 app with no firebase entry takes the packed tarball (npm 11 installs the peer, writes nothing), then ng update @angular/fire --migrate-only --from 21.0.0 --to 22.0.0 adds firebase ^12.18.0, reinstalls, and npm ls firebase shows one copy. The app builds with the Firestore providers wired in. A second run reports no changes. The same app requesting firebase ^11.0.0 fails npm install of the tarball with ERESOLVE, which reports peer firebase@"^12.18.0" from @angular/fire@22.0.0, nothing installed. The duplicate-firebase warning's acceptance list gained two projects installed from the 22 tarball: a plain install, where it stays silent, and one with a second package that bundles firebase 11, where it warns. All 18 rows pass. firebase 12.19.0, which the repo compiles against, adds no export over 12.18.0 in any of the 14 wrapped entry points, so the peer minimum is safe. Fixes #3804 Refs #3684, #3681, #3682

Open Graph Description: Checklist Issue number for this PR: #3804 Docs included?: yes. docs/version-22-upgrade.md is new, with its README link. The README and quickstart install commands follow in their own pull request,...

X Description: Checklist Issue number for this PR: #3804 Docs included?: yes. docs/version-22-upgrade.md is new, with its README link. The README and quickstart install commands follow in their own pull request,...

Opengraph URL: https://github.com/angular/angularfire/pull/3805

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.114.4

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c43642a7-be04-3159-5ea1-f5b6c1ae75cc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEC92:1D86C4:7CFDD5E:9E79283:6B0360F7
html-safe-nonce0231cc3b1924a79e4f000e08c7a42ef57d225b3260b68bc337ead4d2b706d85f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzkyOjFEODZDNDo3Q0ZERDVFOjlFNzkyODM6NkIwMzYwRjciLCJ2aXNpdG9yX2lkIjoiODEzMTYyMjU3NjQxOTIwMTI3MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac152cb5ff7b60391e76ea9093314af867a97270d1a1de236e0050b5adf6853a22
hovercard-subject-tagpull_request:4987567664
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angularfire/pull/3805/files
twitter:imagehttps://avatars.githubusercontent.com/u/13904589?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/13904589?s=400&v=4
og:image:altChecklist Issue number for this PR: #3804 Docs included?: yes. docs/version-22-upgrade.md is new, with its README link. The README and quickstart install commands follow in their own pull request,...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angularfire git https://github.com/angular/angularfire.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id49453413
octolytics-dimension-repository_nwoangular/angularfire
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49453413
octolytics-dimension-repository_network_root_nwoangular/angularfire
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angularfire/pull/3805/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F3805%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F3805%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangularfire
Reloadhttps://github.com/angular/angularfire/pull/3805/files
Reloadhttps://github.com/angular/angularfire/pull/3805/files
Reloadhttps://github.com/angular/angularfire/pull/3805/files
angularhttps://github.com/angular
angularfirehttps://github.com/angular/angularfire
Codehttps://github.com/angular/angularfire
Issues162 (162)https://github.com/angular/angularfire/issues
Pull requests5 (5)https://github.com/angular/angularfire/pulls
Discussionshttps://github.com/angular/angularfire/discussions
Actionshttps://github.com/angular/angularfire/actions
Projectshttps://github.com/angular/angularfire/projects
Security and qualityhttps://github.com/angular/angularfire/security
Insightshttps://github.com/angular/angularfire/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangularfire%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangularfire%2Fissues%2Fnew%2Fchoose
armando-navarrohttps://github.com/armando-navarro
angular:mainhttps://github.com/angular/angularfire/tree/main
armando-navarro:a76-firebase-peerhttps://github.com/armando-navarro/angularfire/tree/a76-firebase-peer
Conversation 1 https://github.com/angular/angularfire/pull/3805
Commits 2 https://github.com/angular/angularfire/pull/3805/commits
Checks 24 https://github.com/angular/angularfire/pull/3805/checks
Files changed https://github.com/angular/angularfire/pull/3805/files
Please reload this pagehttps://github.com/angular/angularfire/pull/3805/files
build!: make firebase a peer dependency and add the v22 migration https://github.com/angular/angularfire/pull/3805/files#top
Show all changes 2 commits https://github.com/angular/angularfire/pull/3805/files
c07dd7f build!: make firebase a peer dependency and add the v22 migration armando-navarro Oct 23, 2026 https://github.com/angular/angularfire/pull/3805/commits/c07dd7fbf51b72814dc2dbd60aa9063174a43efc
1038553 docs: fix the v22 guide's migration range and pnpm warning text armando-navarro Oct 23, 2026 https://github.com/angular/angularfire/pull/3805/commits/10385539b193c94b3bc3cee11a4d893c9642f4d0
Clear filters https://github.com/angular/angularfire/pull/3805/files
Please reload this pagehttps://github.com/angular/angularfire/pull/3805/files
Please reload this pagehttps://github.com/angular/angularfire/pull/3805/files
README.md https://github.com/angular/angularfire/pull/3805/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
version-22-upgrade.md https://github.com/angular/angularfire/pull/3805/files#diff-a71865fd22c0f104adf6ec77870fcb6b466fa8c9c983495779c151c2683b49f3
ng-package.json https://github.com/angular/angularfire/pull/3805/files#diff-22fb89d5c7a4f25481a2b3c9947f1aa71dd6787b5dbfa162e9ff0ef099836f81
package.json https://github.com/angular/angularfire/pull/3805/files#diff-cc5a2f170768969f124108ad3be7fdbcbed774c11774d99a87a3a78fef4ab97b
common.jasmine.ts https://github.com/angular/angularfire/pull/3805/files#diff-7659053d05665ba53c881f9f46f8179d177758d7a5ed0650c75973fab061417c
common.ts https://github.com/angular/angularfire/pull/3805/files#diff-a65fe16aec051a6f17358127ac0052378fe257ebf7cb862c82c9547afceb6dec
migration.json https://github.com/angular/angularfire/pull/3805/files#diff-433d9ccabf4e95211f1298bc1e5a59ee36d5ce38f2de2d6023a3f2e901f436f6
tsconfig.json https://github.com/angular/angularfire/pull/3805/files#diff-049909c363c970b3deea06a2eb0e8b1797c2731034abb5a0cc8ea058fb4c64d1
index.jasmine.ts https://github.com/angular/angularfire/pull/3805/files#diff-5b10a8c82142588470a25f3813eac50269b7caccda59ef0fd66e84f1b18449ab
index.ts https://github.com/angular/angularfire/pull/3805/files#diff-27dc6f39cc976762e15475b7c28733bd6bf101c34db472fc4c595389580eedde
build.ts https://github.com/angular/angularfire/pull/3805/files#diff-1a7c808f53c100a839513de5b7bffe4aec260620e6f444071f92a143816de975
README.mdhttps://github.com/angular/angularfire/pull/3805/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
View file https://github.com/armando-navarro/angularfire/blob/10385539b193c94b3bc3cee11a4d893c9642f4d0/README.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angularfire/pull/3805/{{ revealButtonHref }}
https://github.com/angular/angularfire/pull/3805/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
https://github.com/angular/angularfire/pull/3805/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
docs/version-22-upgrade.mdhttps://github.com/angular/angularfire/pull/3805/files#diff-a71865fd22c0f104adf6ec77870fcb6b466fa8c9c983495779c151c2683b49f3
View file https://github.com/armando-navarro/angularfire/blob/10385539b193c94b3bc3cee11a4d893c9642f4d0/docs/version-22-upgrade.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angularfire/pull/3805/{{ revealButtonHref }}
src/ng-package.jsonhttps://github.com/angular/angularfire/pull/3805/files#diff-22fb89d5c7a4f25481a2b3c9947f1aa71dd6787b5dbfa162e9ff0ef099836f81
View file https://github.com/armando-navarro/angularfire/blob/10385539b193c94b3bc3cee11a4d893c9642f4d0/src/ng-package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angularfire/pull/3805/{{ revealButtonHref }}
https://github.com/angular/angularfire/pull/3805/files#diff-22fb89d5c7a4f25481a2b3c9947f1aa71dd6787b5dbfa162e9ff0ef099836f81
src/package.jsonhttps://github.com/angular/angularfire/pull/3805/files#diff-cc5a2f170768969f124108ad3be7fdbcbed774c11774d99a87a3a78fef4ab97b
View file https://github.com/armando-navarro/angularfire/blob/10385539b193c94b3bc3cee11a4d893c9642f4d0/src/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angularfire/pull/3805/{{ revealButtonHref }}
https://github.com/angular/angularfire/pull/3805/files#diff-cc5a2f170768969f124108ad3be7fdbcbed774c11774d99a87a3a78fef4ab97b
https://github.com/angular/angularfire/pull/3805/files#diff-cc5a2f170768969f124108ad3be7fdbcbed774c11774d99a87a3a78fef4ab97b
https://github.com/angular/angularfire/pull/3805/files#diff-cc5a2f170768969f124108ad3be7fdbcbed774c11774d99a87a3a78fef4ab97b
src/schematics/common.jasmine.tshttps://github.com/angular/angularfire/pull/3805/files#diff-7659053d05665ba53c881f9f46f8179d177758d7a5ed0650c75973fab061417c
View file https://github.com/armando-navarro/angularfire/blob/10385539b193c94b3bc3cee11a4d893c9642f4d0/src/schematics/common.jasmine.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angularfire/pull/3805/{{ revealButtonHref }}
https://github.com/angular/angularfire/pull/3805/files#diff-7659053d05665ba53c881f9f46f8179d177758d7a5ed0650c75973fab061417c
https://github.com/angular/angularfire/pull/3805/files#diff-7659053d05665ba53c881f9f46f8179d177758d7a5ed0650c75973fab061417c
src/schematics/common.tshttps://github.com/angular/angularfire/pull/3805/files#diff-a65fe16aec051a6f17358127ac0052378fe257ebf7cb862c82c9547afceb6dec
View file https://github.com/armando-navarro/angularfire/blob/10385539b193c94b3bc3cee11a4d893c9642f4d0/src/schematics/common.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angularfire/pull/3805/{{ revealButtonHref }}
https://github.com/angular/angularfire/pull/3805/files#diff-a65fe16aec051a6f17358127ac0052378fe257ebf7cb862c82c9547afceb6dec
https://github.com/angular/angularfire/pull/3805/files#diff-a65fe16aec051a6f17358127ac0052378fe257ebf7cb862c82c9547afceb6dec
https://github.com/angular/angularfire/pull/3805/files#diff-a65fe16aec051a6f17358127ac0052378fe257ebf7cb862c82c9547afceb6dec
https://github.com/angular/angularfire/pull/3805/files#diff-a65fe16aec051a6f17358127ac0052378fe257ebf7cb862c82c9547afceb6dec
src/schematics/migration.jsonhttps://github.com/angular/angularfire/pull/3805/files#diff-433d9ccabf4e95211f1298bc1e5a59ee36d5ce38f2de2d6023a3f2e901f436f6
View file https://github.com/armando-navarro/angularfire/blob/10385539b193c94b3bc3cee11a4d893c9642f4d0/src/schematics/migration.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angularfire/pull/3805/{{ revealButtonHref }}
https://github.com/angular/angularfire/pull/3805/files#diff-433d9ccabf4e95211f1298bc1e5a59ee36d5ce38f2de2d6023a3f2e901f436f6
src/schematics/tsconfig.jsonhttps://github.com/angular/angularfire/pull/3805/files#diff-049909c363c970b3deea06a2eb0e8b1797c2731034abb5a0cc8ea058fb4c64d1
View file https://github.com/armando-navarro/angularfire/blob/10385539b193c94b3bc3cee11a4d893c9642f4d0/src/schematics/tsconfig.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angularfire/pull/3805/{{ revealButtonHref }}
https://github.com/angular/angularfire/pull/3805/files#diff-049909c363c970b3deea06a2eb0e8b1797c2731034abb5a0cc8ea058fb4c64d1
src/schematics/update/v22/index.jasmine.tshttps://github.com/angular/angularfire/pull/3805/files#diff-5b10a8c82142588470a25f3813eac50269b7caccda59ef0fd66e84f1b18449ab
View file https://github.com/armando-navarro/angularfire/blob/10385539b193c94b3bc3cee11a4d893c9642f4d0/src/schematics/update/v22/index.jasmine.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angularfire/pull/3805/{{ revealButtonHref }}
src/schematics/update/v22/index.tshttps://github.com/angular/angularfire/pull/3805/files#diff-27dc6f39cc976762e15475b7c28733bd6bf101c34db472fc4c595389580eedde
View file https://github.com/armando-navarro/angularfire/blob/10385539b193c94b3bc3cee11a4d893c9642f4d0/src/schematics/update/v22/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angularfire/pull/3805/{{ revealButtonHref }}
tools/build.tshttps://github.com/angular/angularfire/pull/3805/files#diff-1a7c808f53c100a839513de5b7bffe4aec260620e6f444071f92a143816de975
View file https://github.com/armando-navarro/angularfire/blob/10385539b193c94b3bc3cee11a4d893c9642f4d0/tools/build.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angularfire/pull/3805/{{ revealButtonHref }}
https://github.com/angular/angularfire/pull/3805/files#diff-1a7c808f53c100a839513de5b7bffe4aec260620e6f444071f92a143816de975
https://github.com/angular/angularfire/pull/3805/files#diff-1a7c808f53c100a839513de5b7bffe4aec260620e6f444071f92a143816de975
Please reload this pagehttps://github.com/angular/angularfire/pull/3805/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlno-cache

Viewport: width=device-width


URLs of crawlers that visited me.