René's URL Explorer Experiment


Title: style: use the optional chains typescript-eslint 8.71 asks for by armando-navarro · Pull Request #3797 · angular/angularfire · GitHub

Open Graph Title: style: use the optional chains typescript-eslint 8.71 asks for by armando-navarro · Pull Request #3797 · angular/angularfire

X Title: style: use the optional chains typescript-eslint 8.71 asks for by armando-navarro · Pull Request #3797 · angular/angularfire

Description: Caution Do not merge until the 21.0.x branch is cut This is part of the Angular 22 upgrade and ships in 22.0.0-rc.0. Merge it after 21.0.x is cut from main. Refs #3696 This rewrites two checks as optional chains, so lint keeps passing once the Angular 22 upgrade brings in a newer @typescript-eslint. Changes src/app/app.module.ts: provided && provided.length === 1 becomes provided?.length === 1. src/compat/firebase.app.module.ts: app && app.name === config.name becomes app?.name === config.name. Both rewrites keep behavior. An undefined provided still falls through to getApp(), and since config.name is set to a non-empty string two lines above the check, a missing app still never matches it. Why Angular 22 requires TypeScript 6. @typescript-eslint 8.46, the version in today's lockfile, accepts only TypeScript below 6.0, so the Angular 22 upgrade moves it to 8.71. 8.71 reports @typescript-eslint/prefer-optional-chain on these two lines, so npm run lint fails. Verification With @typescript-eslint 8.71.1 on the Angular 22 upgrade, eslint reports exactly these two errors on the old lines and none on the new ones. There are no new tests, since the existing specs already run both lines through provideFirebaseApp and AngularFireModule.initializeApp.

Open Graph Description: Caution Do not merge until the 21.0.x branch is cut This is part of the Angular 22 upgrade and ships in 22.0.0-rc.0. Merge it after 21.0.x is cut from main. Refs #3696 This rewrites two checks as ...

X Description: Caution Do not merge until the 21.0.x branch is cut This is part of the Angular 22 upgrade and ships in 22.0.0-rc.0. Merge it after 21.0.x is cut from main. Refs #3696 This rewrites two checks as ...

Opengraph URL: https://github.com/angular/angularfire/pull/3797

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.114.4

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f6554d07-9aa8-0431-509e-554507b0239f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD0C2:2CA452:93B3F8:BC04E7:6B036496
html-safe-noncecaf54d3227a6c805edd058d2c4e57381dc7488a81ee5214a3d4b637077b827b3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMEMyOjJDQTQ1Mjo5M0IzRjg6QkMwNEU3OjZCMDM2NDk2IiwidmlzaXRvcl9pZCI6IjQxMTcyNjI0OTc2NDI0MDcwNjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4e44a4c852dc58c0b300a8c7d200bf3c287bd8b27dfc830de179b84910a5a244
hovercard-subject-tagpull_request:4780035389
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angularfire/pull/3797/files
twitter:imagehttps://avatars.githubusercontent.com/u/13904589?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/13904589?s=400&v=4
og:image:altCaution Do not merge until the 21.0.x branch is cut This is part of the Angular 22 upgrade and ships in 22.0.0-rc.0. Merge it after 21.0.x is cut from main. Refs #3696 This rewrites two checks as ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angularfire git https://github.com/angular/angularfire.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id49453413
octolytics-dimension-repository_nwoangular/angularfire
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49453413
octolytics-dimension-repository_network_root_nwoangular/angularfire
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angularfire/pull/3797/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F3797%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F3797%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangularfire
Reloadhttps://github.com/angular/angularfire/pull/3797/files
Reloadhttps://github.com/angular/angularfire/pull/3797/files
Reloadhttps://github.com/angular/angularfire/pull/3797/files
angularhttps://github.com/angular
angularfirehttps://github.com/angular/angularfire
Codehttps://github.com/angular/angularfire
Issues162 (162)https://github.com/angular/angularfire/issues
Pull requests5 (5)https://github.com/angular/angularfire/pulls
Discussionshttps://github.com/angular/angularfire/discussions
Actionshttps://github.com/angular/angularfire/actions
Projectshttps://github.com/angular/angularfire/projects
Security and qualityhttps://github.com/angular/angularfire/security
Insightshttps://github.com/angular/angularfire/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangularfire%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangularfire%2Fissues%2Fnew%2Fchoose
armando-navarrohttps://github.com/armando-navarro
angular:mainhttps://github.com/angular/angularfire/tree/main
armando-navarro:a69-optional-chain-linthttps://github.com/armando-navarro/angularfire/tree/a69-optional-chain-lint
Conversation 2 https://github.com/angular/angularfire/pull/3797
Commits 1 https://github.com/angular/angularfire/pull/3797/commits
Checks 24 https://github.com/angular/angularfire/pull/3797/checks
Files changed https://github.com/angular/angularfire/pull/3797/files
Please reload this pagehttps://github.com/angular/angularfire/pull/3797/files
style: use the optional chains typescript-eslint 8.71 asks for https://github.com/angular/angularfire/pull/3797/files#top
Show all changes 1 commit https://github.com/angular/angularfire/pull/3797/files
0d2ab6d style: use the optional chains typescript-eslint 8.71 asks for armando-navarro Oct 7, 2026 https://github.com/angular/angularfire/pull/3797/commits/0d2ab6d643e3df421e8fdcd2413f567ed2ef15d4
Clear filters https://github.com/angular/angularfire/pull/3797/files
Please reload this pagehttps://github.com/angular/angularfire/pull/3797/files
Please reload this pagehttps://github.com/angular/angularfire/pull/3797/files
app.module.ts https://github.com/angular/angularfire/pull/3797/files#diff-502d295b435b10ba99f5377504ca51149312e3cbebbbaa78ac5d925cb04cbfb0
firebase.app.module.ts https://github.com/angular/angularfire/pull/3797/files#diff-2942dff9f002c3d6504b2af9177e8c128257aace8c10850f303744df728c90e2
src/app/app.module.tshttps://github.com/angular/angularfire/pull/3797/files#diff-502d295b435b10ba99f5377504ca51149312e3cbebbbaa78ac5d925cb04cbfb0
View file https://github.com/armando-navarro/angularfire/blob/0d2ab6d643e3df421e8fdcd2413f567ed2ef15d4/src/app/app.module.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angularfire/pull/3797/{{ revealButtonHref }}
https://github.com/angular/angularfire/pull/3797/files#diff-502d295b435b10ba99f5377504ca51149312e3cbebbbaa78ac5d925cb04cbfb0
https://github.com/angular/angularfire/pull/3797/files#diff-502d295b435b10ba99f5377504ca51149312e3cbebbbaa78ac5d925cb04cbfb0
src/compat/firebase.app.module.tshttps://github.com/angular/angularfire/pull/3797/files#diff-2942dff9f002c3d6504b2af9177e8c128257aace8c10850f303744df728c90e2
View file https://github.com/armando-navarro/angularfire/blob/0d2ab6d643e3df421e8fdcd2413f567ed2ef15d4/src/compat/firebase.app.module.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angularfire/pull/3797/{{ revealButtonHref }}
https://github.com/angular/angularfire/pull/3797/files#diff-2942dff9f002c3d6504b2af9177e8c128257aace8c10850f303744df728c90e2
https://github.com/angular/angularfire/pull/3797/files#diff-2942dff9f002c3d6504b2af9177e8c128257aace8c10850f303744df728c90e2
Please reload this pagehttps://github.com/angular/angularfire/pull/3797/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlno-cache

Viewport: width=device-width


URLs of crawlers that visited me.