René's URL Explorer Experiment


Title: build: require firebase ^12.18.0 and wrap the functions it adds by armando-navarro · Pull Request #3761 · angular/angularfire · GitHub

Open Graph Title: build: require firebase ^12.18.0 and wrap the functions it adds by armando-navarro · Pull Request #3761 · angular/angularfire

X Title: build: require firebase ^12.18.0 and wrap the functions it adds by armando-navarro · Pull Request #3761 · angular/angularfire

Description: Checklist Issue number for this PR: #3756 (required) Docs included?: yes (docs/version-21-upgrade.md, docs/messaging.md) Test units included?: no new ones, two existing ones rewritten, see Testing below In a clean directory, yarn install, yarn test run successfully? yes, via the npm equivalents Description tools/build.ts writes src//firebase.ts from the type declarations of whatever firebase is installed, so which functions @angular/fire wraps is decided by the version the build resolves rather than by a list anyone maintains. This raises that version, and regenerates. #3756 has the background. Three things follow from the way the generator works: The version the build resolves has been 12.4.0 while npm latest reached 12.18.0. Everything Firebase added in between still reaches callers through the export * line, but arrives with none of the wrapper's behavior and nothing saying it is different. The range the repository builds against, the range the published package declares and the schematics constant all have to move together, or alignFirebaseVersion starts writing a range the library does not install against. What regenerating changes src/messaging/firebase.ts is the only generated file that moves. It gains onRegistered, onUnregistered, register and unregister. Nothing else changes, because #3759 already classified every other symbol the raise makes visible. Those entries keep their symbols out of the generated files while the export * line continues to carry them to callers. What comes out getImagenModel carried an override entry so the generator would not emit a named import for a symbol firebase deleted in 12.18.0 (#3749, fixed by #3750). At this version the generator cannot see the symbol at all, so the entry has nothing left to do and goes. That empties overridesFirebaseDoesNotDeclare, which stays in place as the list the next unclassified name goes into. What this means for someone upgrading @angular/fire declares firebase as a regular dependency rather than a peer, so a workspace holding an older firebase that upgrades @angular/fire without running a schematic now resolves two copies instead of one, and the two reject each other's objects at runtime. Measured under Testing rather than assumed. alignFirebaseVersion rewrites the declared range for anyone who runs ng add or ng update, and it picks up the new range with no further change. #3754 covers telling the people who run neither. Specs Two alignFirebaseVersion specs used ^12.6.0 to stand for a range a workspace declares that is already inside what the library requires. ^12.6.0 stops being inside that range at 12.18.0, so both specs would have started asserting the opposite of what they say. They now derive that value from firebaseVersionRange, so the next raise cannot leave them wrong. Docs docs/messaging.md wrote the firebase version into two gstatic service worker URLs, which is only correct on the day it is written. It now uses a placeholder, matching docs/compat/messaging/messaging.md. docs/version-21-upgrade.md names the new range, and no longer implies that only a firebase 11 workspace ends up with two copies. Testing npm run build && npm run build:jasmine && npm run test:node 227 specs, 0 failures. npx ng lint passes. The karma suite passes against the emulators: 107 executed, 48 skipped, 0 failures. Two results are worth stating separately, because neither is visible in the diff. The override entries are doing the work, not the version Every symbol #3759 marked unwrapped is absent from every generated file. Each of those five is a live function in the installed firebase 12.18.0, so their absence is those entries working rather than the version simply not having them. getImagenModel is undefined there, which is why its entry could go. The duplicate copy was measured, not assumed A fresh ng new app, firebase set to 12.10.0, this build of @angular/fire installed, no schematic run: ├─┬ @angular/fire@21.0.0-rc.0 │ ├── firebase@12.18.0 │ └─┬ rxfire@6.2.0 │ └── firebase@12.10.0 deduped └── firebase@12.10.0 The split runs through the library's own dependencies: @angular/fire gets 12.18.0 while rxfire, which @angular/fire depends on, gets the app's 12.10.0. The same app with no firebase of its own resolves a single 12.18.0 for everything. One judgment call I would particularly like a second opinion on: register is wrapped with blockUntilFirst at its default, which means a call made before notification permission is granted holds the application unstable while the browser prompt is open. getToken has done the same for years, and setting false would drop zone and injection-context re-entry from the returned promise rather than just the pending task, so I left it alone. If you would rather that not ship, say so and I will take it out of this PR. Fixes #3756

Open Graph Description: Checklist Issue number for this PR: #3756 (required) Docs included?: yes (docs/version-21-upgrade.md, docs/messaging.md) Test units included?: no new ones, two existing ones rewritten, see Testing...

X Description: Checklist Issue number for this PR: #3756 (required) Docs included?: yes (docs/version-21-upgrade.md, docs/messaging.md) Test units included?: no new ones, two existing ones rewritten, see Testing...

Opengraph URL: https://github.com/angular/angularfire/pull/3761

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.114.4

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0705bcd4-fc95-f920-9f6f-98d46796e853
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAE38:52410:5FED54:7960AF:6B03632D
html-safe-nonce8b74315c811a2b8d5e9859ed2b59a56e5abed5efaa0286e2cf6593dd88b1c84b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRTM4OjUyNDEwOjVGRUQ1NDo3OTYwQUY6NkIwMzYzMkQiLCJ2aXNpdG9yX2lkIjoiNzI1NjQ0MTM4NTQ4MDU3NzgzNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4823aa943ebff6729606d599c70b120ae329bf6070303b48816dcf930afd117a
hovercard-subject-tagpull_request:4410302750
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angularfire/pull/3761/files
twitter:imagehttps://avatars.githubusercontent.com/u/13904589?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/13904589?s=400&v=4
og:image:altChecklist Issue number for this PR: #3756 (required) Docs included?: yes (docs/version-21-upgrade.md, docs/messaging.md) Test units included?: no new ones, two existing ones rewritten, see Testing...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angularfire git https://github.com/angular/angularfire.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id49453413
octolytics-dimension-repository_nwoangular/angularfire
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49453413
octolytics-dimension-repository_network_root_nwoangular/angularfire
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angularfire/pull/3761/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F3761%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F3761%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangularfire
Reloadhttps://github.com/angular/angularfire/pull/3761/files
Reloadhttps://github.com/angular/angularfire/pull/3761/files
Reloadhttps://github.com/angular/angularfire/pull/3761/files
angularhttps://github.com/angular
angularfirehttps://github.com/angular/angularfire
Codehttps://github.com/angular/angularfire
Issues162 (162)https://github.com/angular/angularfire/issues
Pull requests5 (5)https://github.com/angular/angularfire/pulls
Discussionshttps://github.com/angular/angularfire/discussions
Actionshttps://github.com/angular/angularfire/actions
Projectshttps://github.com/angular/angularfire/projects
Security and qualityhttps://github.com/angular/angularfire/security
Insightshttps://github.com/angular/angularfire/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangularfire%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangularfire%2Fissues%2Fnew%2Fchoose
armando-navarrohttps://github.com/armando-navarro
angular:mainhttps://github.com/angular/angularfire/tree/main
armando-navarro:a38-pr-b-firebase-floorhttps://github.com/armando-navarro/angularfire/tree/a38-pr-b-firebase-floor
Conversation 1 https://github.com/angular/angularfire/pull/3761
Commits 3 https://github.com/angular/angularfire/pull/3761/commits
Checks 24 https://github.com/angular/angularfire/pull/3761/checks
Files changed https://github.com/angular/angularfire/pull/3761/files
Please reload this pagehttps://github.com/angular/angularfire/pull/3761/files
build: require firebase ^12.18.0 and wrap the functions it adds https://github.com/angular/angularfire/pull/3761/files#top
Show all changes 3 commits https://github.com/angular/angularfire/pull/3761/files
128bfda build: require firebase ^12.18.0 and wrap the functions it adds armando-navarro Sep 1, 2026 https://github.com/angular/angularfire/pull/3761/commits/128bfdad66d33e3f8e936c685d2db9c443abd31a
5eecb71 docs(messaging): move the guide off the deprecated token APIs armando-navarro Sep 2, 2026 https://github.com/angular/angularfire/pull/3761/commits/5eecb71cb3ff4ef700ba8fd1be29cf566d054945
dcf5923 build: say what the undeclared-override list is really keyed by armando-navarro Sep 2, 2026 https://github.com/angular/angularfire/pull/3761/commits/dcf59231d7ed92570a6c1f9a17c1ef5204445c4a
Clear filters https://github.com/angular/angularfire/pull/3761/files
Please reload this pagehttps://github.com/angular/angularfire/pull/3761/files
Please reload this pagehttps://github.com/angular/angularfire/pull/3761/files
messaging.md https://github.com/angular/angularfire/pull/3761/files#diff-57b9554afb0daa3c41fcd435ec665f56fb2fb588e2e5da45a0deca98ad74f4d8
version-21-upgrade.md https://github.com/angular/angularfire/pull/3761/files#diff-97e0e61da19fe9f4d918df3038ddffddf70a56ea26b53a9650fcdb6e97c1f4b5
package-lock.json https://github.com/angular/angularfire/pull/3761/files#diff-053150b640a7ce75eff69d1a22cae7f0f94ad64ce9a855db544dda0929316519
package.json https://github.com/angular/angularfire/pull/3761/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
package-lock.json https://github.com/angular/angularfire/pull/3761/files#diff-58b632485a6caac41a5fa0a0feb46d8efc2d744bdd4478af0c9dab7c9ad44e23
package.json https://github.com/angular/angularfire/pull/3761/files#diff-5dec6eb863b466eafeca10c5b7785c4a02ec70313949f7bb468403c272195ba1
firebase.ts https://github.com/angular/angularfire/pull/3761/files#diff-ed44ffc919aa0ffe0b2b7632ad958796050e38594c7308b7a9c346d4a83865b9
package.json https://github.com/angular/angularfire/pull/3761/files#diff-cc5a2f170768969f124108ad3be7fdbcbed774c11774d99a87a3a78fef4ab97b
common.jasmine.ts https://github.com/angular/angularfire/pull/3761/files#diff-7659053d05665ba53c881f9f46f8179d177758d7a5ed0650c75973fab061417c
common.ts https://github.com/angular/angularfire/pull/3761/files#diff-a65fe16aec051a6f17358127ac0052378fe257ebf7cb862c82c9547afceb6dec
build.ts https://github.com/angular/angularfire/pull/3761/files#diff-1a7c808f53c100a839513de5b7bffe4aec260620e6f444071f92a143816de975
docs/messaging.mdhttps://github.com/angular/angularfire/pull/3761/files#diff-57b9554afb0daa3c41fcd435ec665f56fb2fb588e2e5da45a0deca98ad74f4d8
View file https://github.com/armando-navarro/angularfire/blob/dcf59231d7ed92570a6c1f9a17c1ef5204445c4a/docs/messaging.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angularfire/pull/3761/{{ revealButtonHref }}
https://github.com/angular/angularfire/pull/3761/files#diff-57b9554afb0daa3c41fcd435ec665f56fb2fb588e2e5da45a0deca98ad74f4d8
https://github.com/angular/angularfire/pull/3761/files#diff-57b9554afb0daa3c41fcd435ec665f56fb2fb588e2e5da45a0deca98ad74f4d8
https://github.com/angular/angularfire/pull/3761/files#diff-57b9554afb0daa3c41fcd435ec665f56fb2fb588e2e5da45a0deca98ad74f4d8
https://github.com/angular/angularfire/pull/3761/files#diff-57b9554afb0daa3c41fcd435ec665f56fb2fb588e2e5da45a0deca98ad74f4d8
https://github.com/angular/angularfire/pull/3761/files#diff-57b9554afb0daa3c41fcd435ec665f56fb2fb588e2e5da45a0deca98ad74f4d8
https://github.com/angular/angularfire/pull/3761/files#diff-57b9554afb0daa3c41fcd435ec665f56fb2fb588e2e5da45a0deca98ad74f4d8
https://github.com/angular/angularfire/pull/3761/files#diff-57b9554afb0daa3c41fcd435ec665f56fb2fb588e2e5da45a0deca98ad74f4d8
https://github.com/angular/angularfire/pull/3761/files#diff-57b9554afb0daa3c41fcd435ec665f56fb2fb588e2e5da45a0deca98ad74f4d8
docs/version-21-upgrade.mdhttps://github.com/angular/angularfire/pull/3761/files#diff-97e0e61da19fe9f4d918df3038ddffddf70a56ea26b53a9650fcdb6e97c1f4b5
View file https://github.com/armando-navarro/angularfire/blob/dcf59231d7ed92570a6c1f9a17c1ef5204445c4a/docs/version-21-upgrade.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angularfire/pull/3761/{{ revealButtonHref }}
https://github.com/angular/angularfire/pull/3761/files#diff-97e0e61da19fe9f4d918df3038ddffddf70a56ea26b53a9650fcdb6e97c1f4b5
https://github.com/angular/angularfire/pull/3761/files#diff-97e0e61da19fe9f4d918df3038ddffddf70a56ea26b53a9650fcdb6e97c1f4b5
Please reload this pagehttps://github.com/angular/angularfire/pull/3761/files
Please reload this pagehttps://github.com/angular/angularfire/pull/3761/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlno-cache

Viewport: width=device-width


URLs of crawlers that visited me.