René's URL Explorer Experiment


Title: build: classify the firebase symbols a version raise would newly wrap by armando-navarro · Pull Request #3759 · angular/angularfire · GitHub

Open Graph Title: build: classify the firebase symbols a version raise would newly wrap by armando-navarro · Pull Request #3759 · angular/angularfire

X Title: build: classify the firebase symbols a version raise would newly wrap by armando-navarro · Pull Request #3759 · angular/angularfire

Description: Checklist Issue number for this PR: #3756 (required) Docs included?: yes (docs/zones.md) Test units included?: no, see Testing below In a clean directory, yarn install, yarn test run successfully? yes, via the npm equivalents Description @angular/fire does not hand-write its wrapper files. tools/build.ts regenerates src//firebase.ts from the type declarations of whatever firebase is installed, wrapping every exported function whose name starts with a lowercase letter. Raising the installed version therefore wraps every function Firebase has added in between, all at once, whether or not wrapping does anything useful for a given one. #3756 has the background. One of them does not merely gain nothing, it breaks. The auth persistence exports are classes, and Firebase constructs whichever one it is given with new. Wrapping replaces the class with an ordinary function, and calling it without new throws. #3550 is a user hitting exactly that on browserLocalPersistence, which is why that one and its three neighbors already carry an entry. browserCookiePersistence is the fifth, and it becomes visible when the version rises. This PR settles the classification while the installed version is still 12.4.0, so the version raise stays a small change rather than a behavior change bundled with it. Nothing here alters generated output, because the generator builds its export list from the installed declarations, so an entry naming a symbol that version does not have is never consulted. What each entry decides: maximum, minimum, getTemplateGenerativeModel and makeMemoryCacheProvider stay unwrapped. Each is synchronous, takes no callback and returns a plain value, so wrapping only adds an out-of-injection-context warning to a call that cannot destabilize anything. browserCookiePersistence stays unwrapped, for the new reason above. onRegistered and onUnregistered are wrapped with blockUntilFirst off, matching onMessage. With it on, subscribing registers a pending task that clears only when the callback fires or the caller unsubscribes, and these fire on a Cloud Messaging registration change that may never happen. unregister is quieted to match deleteToken. register keeps the default, matching its counterpart getToken. Two supporting changes: tools/build.ts no longer runs itself on import, and exports the generator, so npm run generate can regenerate the files without ng build. That is what makes a regenerate-and-compare check runnable in CI. The generator now fails on an override key its entry point does not declare. Overrides are matched by name, so a misspelled or misfiled key is otherwise ignored in silence and the symbol quietly keeps the default. That had already happened once, and is fixed here. Two smaller items ride along: ngPostUpdate, an ng update migration that took a Tree and returned it unchanged, is removed. It was registered in four places, one of which spelled it ng-post-upgate. docs/zones.md gains a section on what AngularFire asks Angular for when you call a wrapped API, and what is lost when that call happens outside an injection context. #3629 asked for that detail. Testing No unit tests, because nothing here changes runtime behavior: the generated files are byte-identical before and after. The check that matters is that regenerating produces no diff, which is what shows the entries are inert against firebase 12.4.0. npm run generate && git status --porcelain -- src/ That is empty on this branch. Two further results: Adding an entry that does change output produces the expected diff, so the check is capable of failing. Regenerating against firebase 12.18.0 in a scratch checkout changes only src/messaging/firebase.ts, and every entry lands as described above. If any of this reads wrong to you, particularly the four I am leaving unwrapped, say so and I will revisit before the version raise goes up. Refs #3756

Open Graph Description: Checklist Issue number for this PR: #3756 (required) Docs included?: yes (docs/zones.md) Test units included?: no, see Testing below In a clean directory, yarn install, yarn test run successfully?...

X Description: Checklist Issue number for this PR: #3756 (required) Docs included?: yes (docs/zones.md) Test units included?: no, see Testing below In a clean directory, yarn install, yarn test run successfully?...

Opengraph URL: https://github.com/angular/angularfire/pull/3759

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.114.3

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7a2e81d9-c86e-ac3e-574e-2663ae1d9b7a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE16A:2C911E:588F81:70418F:6B03607E
html-safe-nonced49a6bd125d470dde50a8ceccfbced581ae5433910201a564fbd5209e9aaca7c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMTZBOjJDOTExRTo1ODhGODE6NzA0MThGOjZCMDM2MDdFIiwidmlzaXRvcl9pZCI6Ijg4MjM3MDE5OTE4ODM2NTQzOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace2c246a8210dd1b4be42cea109beecc6eb85cf299bf99e47254b14125f167009
hovercard-subject-tagpull_request:4409040647
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angularfire/pull/3759/files
twitter:imagehttps://avatars.githubusercontent.com/u/13904589?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/13904589?s=400&v=4
og:image:altChecklist Issue number for this PR: #3756 (required) Docs included?: yes (docs/zones.md) Test units included?: no, see Testing below In a clean directory, yarn install, yarn test run successfully?...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angularfire git https://github.com/angular/angularfire.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id49453413
octolytics-dimension-repository_nwoangular/angularfire
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49453413
octolytics-dimension-repository_network_root_nwoangular/angularfire
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angularfire/pull/3759/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F3759%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F3759%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangularfire
Reloadhttps://github.com/angular/angularfire/pull/3759/files
Reloadhttps://github.com/angular/angularfire/pull/3759/files
Reloadhttps://github.com/angular/angularfire/pull/3759/files
angularhttps://github.com/angular
angularfirehttps://github.com/angular/angularfire
Codehttps://github.com/angular/angularfire
Issues162 (162)https://github.com/angular/angularfire/issues
Pull requests5 (5)https://github.com/angular/angularfire/pulls
Discussionshttps://github.com/angular/angularfire/discussions
Actionshttps://github.com/angular/angularfire/actions
Projectshttps://github.com/angular/angularfire/projects
Security and qualityhttps://github.com/angular/angularfire/security
Insightshttps://github.com/angular/angularfire/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangularfire%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangularfire%2Fissues%2Fnew%2Fchoose
armando-navarrohttps://github.com/armando-navarro
angular:mainhttps://github.com/angular/angularfire/tree/main
armando-navarro:a38-pr-a-override-entrieshttps://github.com/armando-navarro/angularfire/tree/a38-pr-a-override-entries
Conversation 1 https://github.com/angular/angularfire/pull/3759
Commits 3 https://github.com/angular/angularfire/pull/3759/commits
Checks 24 https://github.com/angular/angularfire/pull/3759/checks
Files changed https://github.com/angular/angularfire/pull/3759/files
Please reload this pagehttps://github.com/angular/angularfire/pull/3759/files
build: classify the firebase symbols a version raise would newly wrap https://github.com/angular/angularfire/pull/3759/files#top
Show all changes 3 commits https://github.com/angular/angularfire/pull/3759/files
b3b774e chore(schematics): remove the post-update migration that never did an… armando-navarro Aug 31, 2026 https://github.com/angular/angularfire/pull/3759/commits/b3b774ed135433248007a46e4d43380507884623
8137518 build: leave the newly visible firebase symbols unwrapped, and expose… armando-navarro Sep 1, 2026 https://github.com/angular/angularfire/pull/3759/commits/813751806f42c46207ac9ae5dd91a2d6f1422f4d
bc981ca docs(zones): explain why the injection context is required armando-navarro Sep 1, 2026 https://github.com/angular/angularfire/pull/3759/commits/bc981ca0f62147c890a68a0b97dec138b6c564c0
Clear filters https://github.com/angular/angularfire/pull/3759/files
Please reload this pagehttps://github.com/angular/angularfire/pull/3759/files
Please reload this pagehttps://github.com/angular/angularfire/pull/3759/files
zones.md https://github.com/angular/angularfire/pull/3759/files#diff-74a36e9dace095c81fc6ce90001dce43e05ad0326d42620238ae6f73a87817dd
package.json https://github.com/angular/angularfire/pull/3759/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
migration.json https://github.com/angular/angularfire/pull/3759/files#diff-433d9ccabf4e95211f1298bc1e5a59ee36d5ce38f2de2d6023a3f2e901f436f6
tsconfig.json https://github.com/angular/angularfire/pull/3759/files#diff-049909c363c970b3deea06a2eb0e8b1797c2731034abb5a0cc8ea058fb4c64d1
index.ts https://github.com/angular/angularfire/pull/3759/files#diff-979bb34eff4d660ecbd2a71143d94111dcc8d7ab6fa4a0ff8605da1872b1cfb9
build.ts https://github.com/angular/angularfire/pull/3759/files#diff-1a7c808f53c100a839513de5b7bffe4aec260620e6f444071f92a143816de975
docs/zones.mdhttps://github.com/angular/angularfire/pull/3759/files#diff-74a36e9dace095c81fc6ce90001dce43e05ad0326d42620238ae6f73a87817dd
View file https://github.com/armando-navarro/angularfire/blob/bc981ca0f62147c890a68a0b97dec138b6c564c0/docs/zones.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angularfire/pull/3759/{{ revealButtonHref }}
https://github.com/angular/angularfire/pull/3759/files#diff-74a36e9dace095c81fc6ce90001dce43e05ad0326d42620238ae6f73a87817dd
https://github.com/angular/angularfire/pull/3759/files#diff-74a36e9dace095c81fc6ce90001dce43e05ad0326d42620238ae6f73a87817dd
package.jsonhttps://github.com/angular/angularfire/pull/3759/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
View file https://github.com/armando-navarro/angularfire/blob/bc981ca0f62147c890a68a0b97dec138b6c564c0/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angularfire/pull/3759/{{ revealButtonHref }}
https://github.com/angular/angularfire/pull/3759/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
https://github.com/angular/angularfire/pull/3759/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
src/schematics/migration.jsonhttps://github.com/angular/angularfire/pull/3759/files#diff-433d9ccabf4e95211f1298bc1e5a59ee36d5ce38f2de2d6023a3f2e901f436f6
View file https://github.com/armando-navarro/angularfire/blob/bc981ca0f62147c890a68a0b97dec138b6c564c0/src/schematics/migration.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angularfire/pull/3759/{{ revealButtonHref }}
https://github.com/angular/angularfire/pull/3759/files#diff-433d9ccabf4e95211f1298bc1e5a59ee36d5ce38f2de2d6023a3f2e901f436f6
src/schematics/tsconfig.jsonhttps://github.com/angular/angularfire/pull/3759/files#diff-049909c363c970b3deea06a2eb0e8b1797c2731034abb5a0cc8ea058fb4c64d1
View file https://github.com/armando-navarro/angularfire/blob/bc981ca0f62147c890a68a0b97dec138b6c564c0/src/schematics/tsconfig.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angularfire/pull/3759/{{ revealButtonHref }}
https://github.com/angular/angularfire/pull/3759/files#diff-049909c363c970b3deea06a2eb0e8b1797c2731034abb5a0cc8ea058fb4c64d1
https://github.com/angular/angularfire/pull/3759/files#diff-049909c363c970b3deea06a2eb0e8b1797c2731034abb5a0cc8ea058fb4c64d1
src/schematics/update/index.tshttps://github.com/angular/angularfire/pull/3759/files#diff-979bb34eff4d660ecbd2a71143d94111dcc8d7ab6fa4a0ff8605da1872b1cfb9
View file https://github.com/angular/angularfire/blob/b83343df612f3f20cc82f6817276ecb21f189d9e/src/schematics/update/index.ts
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/angular/angularfire/pull/3759/files
tools/build.tshttps://github.com/angular/angularfire/pull/3759/files#diff-1a7c808f53c100a839513de5b7bffe4aec260620e6f444071f92a143816de975
View file https://github.com/armando-navarro/angularfire/blob/bc981ca0f62147c890a68a0b97dec138b6c564c0/tools/build.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angularfire/pull/3759/{{ revealButtonHref }}
https://github.com/angular/angularfire/pull/3759/files#diff-1a7c808f53c100a839513de5b7bffe4aec260620e6f444071f92a143816de975
https://github.com/angular/angularfire/pull/3759/files#diff-1a7c808f53c100a839513de5b7bffe4aec260620e6f444071f92a143816de975
https://github.com/angular/angularfire/pull/3759/files#diff-1a7c808f53c100a839513de5b7bffe4aec260620e6f444071f92a143816de975
https://github.com/angular/angularfire/pull/3759/files#diff-1a7c808f53c100a839513de5b7bffe4aec260620e6f444071f92a143816de975
https://github.com/angular/angularfire/pull/3759/files#diff-1a7c808f53c100a839513de5b7bffe4aec260620e6f444071f92a143816de975
https://github.com/angular/angularfire/pull/3759/files#diff-1a7c808f53c100a839513de5b7bffe4aec260620e6f444071f92a143816de975
https://github.com/angular/angularfire/pull/3759/files#diff-1a7c808f53c100a839513de5b7bffe4aec260620e6f444071f92a143816de975
https://github.com/angular/angularfire/pull/3759/files#diff-1a7c808f53c100a839513de5b7bffe4aec260620e6f444071f92a143816de975
https://github.com/angular/angularfire/pull/3759/files#diff-1a7c808f53c100a839513de5b7bffe4aec260620e6f444071f92a143816de975
https://github.com/angular/angularfire/pull/3759/files#diff-1a7c808f53c100a839513de5b7bffe4aec260620e6f444071f92a143816de975
https://github.com/angular/angularfire/pull/3759/files#diff-1a7c808f53c100a839513de5b7bffe4aec260620e6f444071f92a143816de975
https://github.com/angular/angularfire/pull/3759/files#diff-1a7c808f53c100a839513de5b7bffe4aec260620e6f444071f92a143816de975
https://github.com/angular/angularfire/pull/3759/files#diff-1a7c808f53c100a839513de5b7bffe4aec260620e6f444071f92a143816de975
https://github.com/angular/angularfire/pull/3759/files#diff-1a7c808f53c100a839513de5b7bffe4aec260620e6f444071f92a143816de975
Please reload this pagehttps://github.com/angular/angularfire/pull/3759/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlno-cache

Viewport: width=device-width


URLs of crawlers that visited me.