Title: fix(schematics): declare the runtime dependencies the schematics bundle requires by armando-navarro · Pull Request #3747 · angular/angularfire · GitHub
Open Graph Title: fix(schematics): declare the runtime dependencies the schematics bundle requires by armando-navarro · Pull Request #3747 · angular/angularfire
X Title: fix(schematics): declare the runtime dependencies the schematics bundle requires by armando-navarro · Pull Request #3747 · angular/angularfire
Description: Checklist Issue number for this PR: #3746 (required) Docs included?: No, none affected (dependency manifests only) Test units included?: No. The existing suite passes (156 specs). The fix was verified by building the package and confirming the dist manifest declares all three ranges, and by locating the require calls for all three packages in the built schematics bundles. In a clean directory, yarn install, yarn test run successfully?: yes Description Fixes #3746. The shipped schematics require jsonc-parser, @angular-devkit/core, and @angular-devkit/architect at runtime, but the published manifest never declared them. The first two resolve today only because npm hoists them from the declared @angular-devkit/schematics and @schematics/angular. Architect is not in the package's dependency closure at all and resolves from the app's own @angular/cli install, so ng deploy breaks under pnpm's isolated layout or Yarn Plug'n'Play. The architect range (>= 0.2100.0 < 0.2200.0) is the comparator pair matching its 0.YYMM version scheme, the same shape other packages shipping architect builders use. A caret on a 0.x version would restrict consumers to Angular 21.0.x only. The change also prunes allowedNonPeerDependencies in src/ng-package.json to the seven names actually declared, dropping ten entries for dependencies removed long ago and a duplicate @schematics/angular entry. Refs #3694: that issue proposes moving schematic dependencies out of dependencies entirely. This fix runs the other way in the short term because the shipped bundles genuinely require these packages at runtime, so leaving them undeclared is a correctness bug today. The structural question of where schematic dependencies should live stays open in #3694.
Open Graph Description: Checklist Issue number for this PR: #3746 (required) Docs included?: No, none affected (dependency manifests only) Test units included?: No. The existing suite passes (156 specs). The fix was veri...
X Description: Checklist Issue number for this PR: #3746 (required) Docs included?: No, none affected (dependency manifests only) Test units included?: No. The existing suite passes (156 specs). The fix was veri...
Opengraph URL: https://github.com/angular/angularfire/pull/3747
X: @github
Domain: github.com
IPv4 address: 140.82.113.4
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:914bf00b-6267-3792-b0a5-9398905f52a1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BA62:15289F:2331348:2E8CCF2:6B03636A |
| html-safe-nonce | 875bcc45a989ec766efd47a822675e5b0425df9df6794e3a7da3922a8f38a0e7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTYyOjE1Mjg5RjoyMzMxMzQ4OjJFOENDRjI6NkIwMzYzNkEiLCJ2aXNpdG9yX2lkIjoiNjM2ODcyNDExMjcxNzg2NTgzNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | ea5d31fab066fcc844c9ae9e680450b2fb84467ca2e56b786222f96f0272d75e |
| hovercard-subject-tag | pull_request:4298795618 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angularfire/pull/3747/files |
| twitter:image | https://avatars.githubusercontent.com/u/13904589?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/13904589?s=400&v=4 |
| og:image:alt | Checklist Issue number for this PR: #3746 (required) Docs included?: No, none affected (dependency manifests only) Test units included?: No. The existing suite passes (156 specs). The fix was veri... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angularfire git https://github.com/angular/angularfire.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 49453413 |
| octolytics-dimension-repository_nwo | angular/angularfire |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 49453413 |
| octolytics-dimension-repository_network_root_nwo | angular/angularfire |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
| Server | github.com |
| Content-Type | text/html; charset=utf-8 |
| Cache-Control | no-cache |
Viewport: width=device-width