René's URL Explorer Experiment


Title: fix(schematics): declare the runtime dependencies the schematics bundle requires by armando-navarro · Pull Request #3747 · angular/angularfire · GitHub

Open Graph Title: fix(schematics): declare the runtime dependencies the schematics bundle requires by armando-navarro · Pull Request #3747 · angular/angularfire

X Title: fix(schematics): declare the runtime dependencies the schematics bundle requires by armando-navarro · Pull Request #3747 · angular/angularfire

Description: Checklist Issue number for this PR: #3746 (required) Docs included?: No, none affected (dependency manifests only) Test units included?: No. The existing suite passes (156 specs). The fix was verified by building the package and confirming the dist manifest declares all three ranges, and by locating the require calls for all three packages in the built schematics bundles. In a clean directory, yarn install, yarn test run successfully?: yes Description Fixes #3746. The shipped schematics require jsonc-parser, @angular-devkit/core, and @angular-devkit/architect at runtime, but the published manifest never declared them. The first two resolve today only because npm hoists them from the declared @angular-devkit/schematics and @schematics/angular. Architect is not in the package's dependency closure at all and resolves from the app's own @angular/cli install, so ng deploy breaks under pnpm's isolated layout or Yarn Plug'n'Play. The architect range (>= 0.2100.0 < 0.2200.0) is the comparator pair matching its 0.YYMM version scheme, the same shape other packages shipping architect builders use. A caret on a 0.x version would restrict consumers to Angular 21.0.x only. The change also prunes allowedNonPeerDependencies in src/ng-package.json to the seven names actually declared, dropping ten entries for dependencies removed long ago and a duplicate @schematics/angular entry. Refs #3694: that issue proposes moving schematic dependencies out of dependencies entirely. This fix runs the other way in the short term because the shipped bundles genuinely require these packages at runtime, so leaving them undeclared is a correctness bug today. The structural question of where schematic dependencies should live stays open in #3694.

Open Graph Description: Checklist Issue number for this PR: #3746 (required) Docs included?: No, none affected (dependency manifests only) Test units included?: No. The existing suite passes (156 specs). The fix was veri...

X Description: Checklist Issue number for this PR: #3746 (required) Docs included?: No, none affected (dependency manifests only) Test units included?: No. The existing suite passes (156 specs). The fix was veri...

Opengraph URL: https://github.com/angular/angularfire/pull/3747

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.113.4

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:914bf00b-6267-3792-b0a5-9398905f52a1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBA62:15289F:2331348:2E8CCF2:6B03636A
html-safe-nonce875bcc45a989ec766efd47a822675e5b0425df9df6794e3a7da3922a8f38a0e7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTYyOjE1Mjg5RjoyMzMxMzQ4OjJFOENDRjI6NkIwMzYzNkEiLCJ2aXNpdG9yX2lkIjoiNjM2ODcyNDExMjcxNzg2NTgzNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacea5d31fab066fcc844c9ae9e680450b2fb84467ca2e56b786222f96f0272d75e
hovercard-subject-tagpull_request:4298795618
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angularfire/pull/3747/files
twitter:imagehttps://avatars.githubusercontent.com/u/13904589?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/13904589?s=400&v=4
og:image:altChecklist Issue number for this PR: #3746 (required) Docs included?: No, none affected (dependency manifests only) Test units included?: No. The existing suite passes (156 specs). The fix was veri...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angularfire git https://github.com/angular/angularfire.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id49453413
octolytics-dimension-repository_nwoangular/angularfire
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49453413
octolytics-dimension-repository_network_root_nwoangular/angularfire
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angularfire/pull/3747/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F3747%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F3747%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangularfire
Reloadhttps://github.com/angular/angularfire/pull/3747/files
Reloadhttps://github.com/angular/angularfire/pull/3747/files
Reloadhttps://github.com/angular/angularfire/pull/3747/files
angularhttps://github.com/angular
angularfirehttps://github.com/angular/angularfire
Codehttps://github.com/angular/angularfire
Issues162 (162)https://github.com/angular/angularfire/issues
Pull requests5 (5)https://github.com/angular/angularfire/pulls
Discussionshttps://github.com/angular/angularfire/discussions
Actionshttps://github.com/angular/angularfire/actions
Projectshttps://github.com/angular/angularfire/projects
Security and qualityhttps://github.com/angular/angularfire/security
Insightshttps://github.com/angular/angularfire/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangularfire%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangularfire%2Fissues%2Fnew%2Fchoose
armando-navarrohttps://github.com/armando-navarro
angular:mainhttps://github.com/angular/angularfire/tree/main
armando-navarro:a20-dependency-declarationshttps://github.com/armando-navarro/angularfire/tree/a20-dependency-declarations
Conversation 1 https://github.com/angular/angularfire/pull/3747
Commits 2 https://github.com/angular/angularfire/pull/3747/commits
Checks 24 https://github.com/angular/angularfire/pull/3747/checks
Files changed https://github.com/angular/angularfire/pull/3747/files
Please reload this pagehttps://github.com/angular/angularfire/pull/3747/files
fix(schematics): declare the runtime dependencies the schematics bundle requires https://github.com/angular/angularfire/pull/3747/files#top
Show all changes 2 commits https://github.com/angular/angularfire/pull/3747/files
9e21c25 fix(schematics): declare the runtime dependencies the schematics bund… armando-navarro Aug 17, 2026 https://github.com/angular/angularfire/pull/3747/commits/9e21c25bffe90089f2e198c8947b5cdb94131759
deb882f Merge branch 'main' into a20-dependency-declarations armando-navarro Aug 18, 2026 https://github.com/angular/angularfire/pull/3747/commits/deb882f937a5bec38cb0e5f15b600e68ff6f35fc
Clear filters https://github.com/angular/angularfire/pull/3747/files
Please reload this pagehttps://github.com/angular/angularfire/pull/3747/files
Please reload this pagehttps://github.com/angular/angularfire/pull/3747/files
ng-package.json https://github.com/angular/angularfire/pull/3747/files#diff-22fb89d5c7a4f25481a2b3c9947f1aa71dd6787b5dbfa162e9ff0ef099836f81
package.json https://github.com/angular/angularfire/pull/3747/files#diff-cc5a2f170768969f124108ad3be7fdbcbed774c11774d99a87a3a78fef4ab97b
src/ng-package.jsonhttps://github.com/angular/angularfire/pull/3747/files#diff-22fb89d5c7a4f25481a2b3c9947f1aa71dd6787b5dbfa162e9ff0ef099836f81
View file https://github.com/armando-navarro/angularfire/blob/deb882f937a5bec38cb0e5f15b600e68ff6f35fc/src/ng-package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angularfire/pull/3747/{{ revealButtonHref }}
https://github.com/angular/angularfire/pull/3747/files#diff-22fb89d5c7a4f25481a2b3c9947f1aa71dd6787b5dbfa162e9ff0ef099836f81
src/package.jsonhttps://github.com/angular/angularfire/pull/3747/files#diff-cc5a2f170768969f124108ad3be7fdbcbed774c11774d99a87a3a78fef4ab97b
View file https://github.com/armando-navarro/angularfire/blob/deb882f937a5bec38cb0e5f15b600e68ff6f35fc/src/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angularfire/pull/3747/{{ revealButtonHref }}
https://github.com/angular/angularfire/pull/3747/files#diff-cc5a2f170768969f124108ad3be7fdbcbed774c11774d99a87a3a78fef4ab97b
https://github.com/angular/angularfire/pull/3747/files#diff-cc5a2f170768969f124108ad3be7fdbcbed774c11774d99a87a3a78fef4ab97b
Please reload this pagehttps://github.com/angular/angularfire/pull/3747/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlno-cache

Viewport: width=device-width


URLs of crawlers that visited me.