René's URL Explorer Experiment


Title: fix(deploy): declare firebase-admin in the generated Cloud Functions manifest by armando-navarro · Pull Request #3745 · angular/angularfire · GitHub

Open Graph Title: fix(deploy): declare firebase-admin in the generated Cloud Functions manifest by armando-navarro · Pull Request #3745 · angular/angularfire

X Title: fix(deploy): declare firebase-admin in the generated Cloud Functions manifest by armando-navarro · Pull Request #3745 · angular/angularfire

Description: Checklist Issue number for this PR: #3744 (required) Docs included?: no, none affected (dependency manifests only) Test units included?: no. The existing Node suite passes (117 specs). The fix was verified end to end: the generated ranges install under both plain npm install and --legacy-peer-deps and both function entry points load, while today's generated manifest under --legacy-peer-deps crashes with Cannot find module 'firebase-admin/app-check'. In a clean directory, yarn install, yarn test run successfully?: yes Description Fixes #3744. Two dependency changes so the generated Cloud Functions manifest actually runs: Add firebase-admin: ^13.0.0 to the root package.json. The build resolves the generated manifest's versions from the root package.json. With no entry there, firebase-admin resolved to undefined and was silently dropped from the manifest. firebase-functions 6.x declares firebase-admin as a required peer and requires it eagerly at module load, so the deployed function crashed at cold start wherever the package manager did not auto-install peers (--legacy-peer-deps, yarn 1, pnpm). ^13.0.0 because firebase-functions 6.x accepts ^11.10.0 || ^12.0.0 || ^13.0.0 and nothing newer (firebase-admin 14 is outside the range). Raise firebase-functions from ^6.1.0 to ^6.1.1. 6.1.0's peer range excludes firebase-admin 13. 6.1.1 is the first release that accepts it, so the floor moves with the new entry. These defects also affect the v20 line and are planned for cherry-pick onto the 20.0.x release branch after this lands.

Open Graph Description: Checklist Issue number for this PR: #3744 (required) Docs included?: no, none affected (dependency manifests only) Test units included?: no. The existing Node suite passes (117 specs). The fix was...

X Description: Checklist Issue number for this PR: #3744 (required) Docs included?: no, none affected (dependency manifests only) Test units included?: no. The existing Node suite passes (117 specs). The fix was...

Opengraph URL: https://github.com/angular/angularfire/pull/3745

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.112.4

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8517ac52-a887-6999-ba1b-12ce66434813
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id904A:3C1C49:26B8C4E:32E4F9B:6B036987
html-safe-nonce1fba120f35ce30bdf0977bb213722e3b2f51e408e082cb1f8c11649013fe77de
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDRBOjNDMUM0OToyNkI4QzRFOjMyRTRGOUI6NkIwMzY5ODciLCJ2aXNpdG9yX2lkIjoiNjI0NDIxMzEyNjc3MDk0NDM5MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac532d6ebe834d4a0e40dedc2a0cf36f28dc422dcad45b859a6924011900fb2111
hovercard-subject-tagpull_request:4256591195
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angularfire/pull/3745/files
twitter:imagehttps://avatars.githubusercontent.com/u/13904589?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/13904589?s=400&v=4
og:image:altChecklist Issue number for this PR: #3744 (required) Docs included?: no, none affected (dependency manifests only) Test units included?: no. The existing Node suite passes (117 specs). The fix was...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angularfire git https://github.com/angular/angularfire.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id49453413
octolytics-dimension-repository_nwoangular/angularfire
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49453413
octolytics-dimension-repository_network_root_nwoangular/angularfire
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angularfire/pull/3745/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F3745%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F3745%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangularfire
Reloadhttps://github.com/angular/angularfire/pull/3745/files
Reloadhttps://github.com/angular/angularfire/pull/3745/files
Reloadhttps://github.com/angular/angularfire/pull/3745/files
angularhttps://github.com/angular
angularfirehttps://github.com/angular/angularfire
Codehttps://github.com/angular/angularfire
Issues162 (162)https://github.com/angular/angularfire/issues
Pull requests5 (5)https://github.com/angular/angularfire/pulls
Discussionshttps://github.com/angular/angularfire/discussions
Actionshttps://github.com/angular/angularfire/actions
Projectshttps://github.com/angular/angularfire/projects
Security and qualityhttps://github.com/angular/angularfire/security
Insightshttps://github.com/angular/angularfire/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangularfire%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangularfire%2Fissues%2Fnew%2Fchoose
armando-navarrohttps://github.com/armando-navarro
angular:mainhttps://github.com/angular/angularfire/tree/main
armando-navarro:fix/functions-manifest-admin-dephttps://github.com/armando-navarro/angularfire/tree/fix/functions-manifest-admin-dep
Conversation 1 https://github.com/angular/angularfire/pull/3745
Commits 3 https://github.com/angular/angularfire/pull/3745/commits
Checks 24 https://github.com/angular/angularfire/pull/3745/checks
Files changed https://github.com/angular/angularfire/pull/3745/files
Please reload this pagehttps://github.com/angular/angularfire/pull/3745/files
fix(deploy): declare firebase-admin in the generated Cloud Functions manifest https://github.com/angular/angularfire/pull/3745/files#top
Show all changes 3 commits https://github.com/angular/angularfire/pull/3745/files
8dc9c0c fix(deploy): declare firebase-admin in the generated Cloud Functions … armando-navarro Aug 11, 2026 https://github.com/angular/angularfire/pull/3745/commits/8dc9c0c077cd0e580eb71abb53aad5991816673c
211819a build: fail the build when a schematic dependency version is missing armando-navarro Aug 12, 2026 https://github.com/angular/angularfire/pull/3745/commits/211819a900e6995e4539d5033d22f0eb5ad2e38c
6f594b8 Merge branch 'main' into fix/functions-manifest-admin-dep armando-navarro Aug 12, 2026 https://github.com/angular/angularfire/pull/3745/commits/6f594b8385e04234bd49b90c02e50d1895dbaf1c
Clear filters https://github.com/angular/angularfire/pull/3745/files
Please reload this pagehttps://github.com/angular/angularfire/pull/3745/files
Please reload this pagehttps://github.com/angular/angularfire/pull/3745/files
package-lock.json https://github.com/angular/angularfire/pull/3745/files#diff-053150b640a7ce75eff69d1a22cae7f0f94ad64ce9a855db544dda0929316519
package.json https://github.com/angular/angularfire/pull/3745/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
build.ts https://github.com/angular/angularfire/pull/3745/files#diff-1a7c808f53c100a839513de5b7bffe4aec260620e6f444071f92a143816de975
Please reload this pagehttps://github.com/angular/angularfire/pull/3745/files
Please reload this pagehttps://github.com/angular/angularfire/pull/3745/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlno-cache

Viewport: width=device-width


URLs of crawlers that visited me.