Title: fix(deploy): declare firebase-admin in the generated Cloud Functions manifest by armando-navarro · Pull Request #3745 · angular/angularfire · GitHub
Open Graph Title: fix(deploy): declare firebase-admin in the generated Cloud Functions manifest by armando-navarro · Pull Request #3745 · angular/angularfire
X Title: fix(deploy): declare firebase-admin in the generated Cloud Functions manifest by armando-navarro · Pull Request #3745 · angular/angularfire
Description: Checklist Issue number for this PR: #3744 (required) Docs included?: no, none affected (dependency manifests only) Test units included?: no. The existing Node suite passes (117 specs). The fix was verified end to end: the generated ranges install under both plain npm install and --legacy-peer-deps and both function entry points load, while today's generated manifest under --legacy-peer-deps crashes with Cannot find module 'firebase-admin/app-check'. In a clean directory, yarn install, yarn test run successfully?: yes Description Fixes #3744. Two dependency changes so the generated Cloud Functions manifest actually runs: Add firebase-admin: ^13.0.0 to the root package.json. The build resolves the generated manifest's versions from the root package.json. With no entry there, firebase-admin resolved to undefined and was silently dropped from the manifest. firebase-functions 6.x declares firebase-admin as a required peer and requires it eagerly at module load, so the deployed function crashed at cold start wherever the package manager did not auto-install peers (--legacy-peer-deps, yarn 1, pnpm). ^13.0.0 because firebase-functions 6.x accepts ^11.10.0 || ^12.0.0 || ^13.0.0 and nothing newer (firebase-admin 14 is outside the range). Raise firebase-functions from ^6.1.0 to ^6.1.1. 6.1.0's peer range excludes firebase-admin 13. 6.1.1 is the first release that accepts it, so the floor moves with the new entry. These defects also affect the v20 line and are planned for cherry-pick onto the 20.0.x release branch after this lands.
Open Graph Description: Checklist Issue number for this PR: #3744 (required) Docs included?: no, none affected (dependency manifests only) Test units included?: no. The existing Node suite passes (117 specs). The fix was...
X Description: Checklist Issue number for this PR: #3744 (required) Docs included?: no, none affected (dependency manifests only) Test units included?: no. The existing Node suite passes (117 specs). The fix was...
Opengraph URL: https://github.com/angular/angularfire/pull/3745
X: @github
Domain: github.com
IPv4 address: 140.82.112.4
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:8517ac52-a887-6999-ba1b-12ce66434813 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 904A:3C1C49:26B8C4E:32E4F9B:6B036987 |
| html-safe-nonce | 1fba120f35ce30bdf0977bb213722e3b2f51e408e082cb1f8c11649013fe77de |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDRBOjNDMUM0OToyNkI4QzRFOjMyRTRGOUI6NkIwMzY5ODciLCJ2aXNpdG9yX2lkIjoiNjI0NDIxMzEyNjc3MDk0NDM5MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 532d6ebe834d4a0e40dedc2a0cf36f28dc422dcad45b859a6924011900fb2111 |
| hovercard-subject-tag | pull_request:4256591195 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angularfire/pull/3745/files |
| twitter:image | https://avatars.githubusercontent.com/u/13904589?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/13904589?s=400&v=4 |
| og:image:alt | Checklist Issue number for this PR: #3744 (required) Docs included?: no, none affected (dependency manifests only) Test units included?: no. The existing Node suite passes (117 specs). The fix was... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angularfire git https://github.com/angular/angularfire.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 49453413 |
| octolytics-dimension-repository_nwo | angular/angularfire |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 49453413 |
| octolytics-dimension-repository_network_root_nwo | angular/angularfire |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
| Server | github.com |
| Content-Type | text/html; charset=utf-8 |
| Cache-Control | no-cache |
Viewport: width=device-width