René's URL Explorer Experiment


Title: fix(deploy): prevent command injection from angular.json in ng deploy by herdiyana256 · Pull Request #3738 · angular/angularfire · GitHub

Open Graph Title: fix(deploy): prevent command injection from angular.json in ng deploy by herdiyana256 · Pull Request #3738 · angular/angularfire

X Title: fix(deploy): prevent command injection from angular.json in ng deploy by herdiyana256 · Pull Request #3738 · angular/angularfire

Description: The SSR to Cloud Functions deploy builder shells out with values taken verbatim from the workspace angular.json. findPackageVersion builds `${packageManager} list ${name}` and passes it to execSync. packageManager comes from cli.packageManager and name from each architect..server.options.externalDependencies entry. Both are read with a raw JSON.parse(readFileSync('angular.json')), so the Angular CLI's own packageManager enum validation never applies. deployToFunction similarly runs `npm --prefix ${functionsOut} install`, where functionsOut derives from the outputPath deploy option. Any of these lets a malicious or cloned Angular workspace execute arbitrary commands the moment a developer runs ng deploy, for example externalDependencies: ["x; #"]. This is the same threat model as the recently addressed deploy argv-injection, on distinct sinks that fix did not cover. The fix stops running these values through a shell. cli.packageManager is validated against the supported set and each externalDependencies entry is rejected unless it is a plain package specifier, then the package manager and npm are launched with argument arrays through cross-spawn (v7). cross-spawn escapes each argument and, on Windows, launches the package manager's .cmd/.bat shim through cmd.exe, which child_process.execFile cannot do, so the fix is cross-platform and never falls back to shell: true (whose args-array form Node runtime-deprecates under DEP0190). Both calls funnel through a single processHost.runPackageBin, and tests assert the deploy code shells out only through that shell-free runner and validates its inputs first, so a later regression to a shell or a dropped validator call fails the suite. Scope: this closes the shell-execution sinks on the Cloud Functions path (findPackageVersion and the functions npm install). The Cloud Run path still interpolates angular.json values into the gcloud commands that spawnAsync splits on whitespace; that is argument injection rather than shell execution and overlaps #3726, so it is left as follow-up. The outputPath schema pattern was dropped: it rejected legitimate path characters ((, ), $) yet never excluded the whitespace the Cloud Run path actually splits on, so it added false negatives on the one path it touched and false positives everywhere. npm run test:node passes (154 specs, 0 failures); lint and typecheck clean.

Open Graph Description: The SSR to Cloud Functions deploy builder shells out with values taken verbatim from the workspace angular.json. findPackageVersion builds `${packageManager} list ${name}` and passes it to execSync...

X Description: The SSR to Cloud Functions deploy builder shells out with values taken verbatim from the workspace angular.json. findPackageVersion builds `${packageManager} list ${name}` and passes it to execSync...

Opengraph URL: https://github.com/angular/angularfire/pull/3738

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.114.3

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:aa76d827-c949-dd95-28dc-944d32c1c780
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA9AC:1827E:2581485:3186BEF:6B036E43
html-safe-nonced4a62e2f7bcde686415a08d48d95254c9be92e8a0db3bd2986eea396467ab2ec
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOUFDOjE4MjdFOjI1ODE0ODU6MzE4NkJFRjo2QjAzNkU0MyIsInZpc2l0b3JfaWQiOiI4MjE4MjIwMjQxMDcxODYxMzE2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd3f02e21a546cfcef8f519c2bcf797060781ddab92c9dd44b679e205b9220d83
hovercard-subject-tagpull_request:4246434502
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angularfire/pull/3738/files
twitter:imagehttps://avatars.githubusercontent.com/u/82978131?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/82978131?s=400&v=4
og:image:altThe SSR to Cloud Functions deploy builder shells out with values taken verbatim from the workspace angular.json. findPackageVersion builds `${packageManager} list ${name}` and passes it to execSync...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angularfire git https://github.com/angular/angularfire.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id49453413
octolytics-dimension-repository_nwoangular/angularfire
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49453413
octolytics-dimension-repository_network_root_nwoangular/angularfire
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angularfire/pull/3738/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F3738%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F3738%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangularfire
Reloadhttps://github.com/angular/angularfire/pull/3738/files
Reloadhttps://github.com/angular/angularfire/pull/3738/files
Reloadhttps://github.com/angular/angularfire/pull/3738/files
angularhttps://github.com/angular
angularfirehttps://github.com/angular/angularfire
Codehttps://github.com/angular/angularfire
Issues162 (162)https://github.com/angular/angularfire/issues
Pull requests5 (5)https://github.com/angular/angularfire/pulls
Discussionshttps://github.com/angular/angularfire/discussions
Actionshttps://github.com/angular/angularfire/actions
Projectshttps://github.com/angular/angularfire/projects
Security and qualityhttps://github.com/angular/angularfire/security
Insightshttps://github.com/angular/angularfire/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangularfire%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangularfire%2Fissues%2Fnew%2Fchoose
armando-navarrohttps://github.com/armando-navarro
angular:mainhttps://github.com/angular/angularfire/tree/main
herdiyana256:fix/deploy-execsync-command-injectionhttps://github.com/herdiyana256/angularfire/tree/fix/deploy-execsync-command-injection
Conversation 5 https://github.com/angular/angularfire/pull/3738
Commits 4 https://github.com/angular/angularfire/pull/3738/commits
Checks 24 https://github.com/angular/angularfire/pull/3738/checks
Files changed https://github.com/angular/angularfire/pull/3738/files
Please reload this pagehttps://github.com/angular/angularfire/pull/3738/files
fix(deploy): prevent command injection from angular.json in ng deploy https://github.com/angular/angularfire/pull/3738/files#top
Show all changes 4 commits https://github.com/angular/angularfire/pull/3738/files
ed6b8b4 fix(deploy): prevent command injection from angular.json in ng deploy herdiyana256 Aug 10, 2026 https://github.com/angular/angularfire/pull/3738/commits/ed6b8b46ce5acc65d623626ef1a8c53906befadf
2ce37b4 fix(deploy): launch package managers cross-platform via cross-spawn herdiyana256 Aug 12, 2026 https://github.com/angular/angularfire/pull/3738/commits/2ce37b4b1f063525dd3cec7c4fe6fb2480c7e949
b7747c3 build(deploy): move cross-spawn to devDependencies herdiyana256 Aug 13, 2026 https://github.com/angular/angularfire/pull/3738/commits/b7747c38f20f94a550e60fdf6b46bf2b70b7c7f5
bd59c44 Merge branch 'main' into fix/deploy-execsync-command-injection armando-navarro Aug 13, 2026 https://github.com/angular/angularfire/pull/3738/commits/bd59c446fbdc7630826a5d3b8091e3c377455d31
Clear filters https://github.com/angular/angularfire/pull/3738/files
Please reload this pagehttps://github.com/angular/angularfire/pull/3738/files
Please reload this pagehttps://github.com/angular/angularfire/pull/3738/files
package-lock.json https://github.com/angular/angularfire/pull/3738/files#diff-053150b640a7ce75eff69d1a22cae7f0f94ad64ce9a855db544dda0929316519
package.json https://github.com/angular/angularfire/pull/3738/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
actions.jasmine.ts https://github.com/angular/angularfire/pull/3738/files#diff-fd8fa896f712c72d1c7d5ea794bc3adce7b7e37508e19576a8a120fadeac5d05
actions.ts https://github.com/angular/angularfire/pull/3738/files#diff-3ec0840be66029e0f049b9b68fd66805766a1ba221d1c7afe66e7dc8dee2592e
package-lock.jsonhttps://github.com/angular/angularfire/pull/3738/files#diff-053150b640a7ce75eff69d1a22cae7f0f94ad64ce9a855db544dda0929316519
View file https://github.com/herdiyana256/angularfire/blob/bd59c446fbdc7630826a5d3b8091e3c377455d31/package-lock.json
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/angular/angularfire/pull/3738/files
package.jsonhttps://github.com/angular/angularfire/pull/3738/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
View file https://github.com/herdiyana256/angularfire/blob/bd59c446fbdc7630826a5d3b8091e3c377455d31/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angularfire/pull/3738/{{ revealButtonHref }}
https://github.com/angular/angularfire/pull/3738/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
https://github.com/angular/angularfire/pull/3738/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
src/schematics/deploy/actions.jasmine.tshttps://github.com/angular/angularfire/pull/3738/files#diff-fd8fa896f712c72d1c7d5ea794bc3adce7b7e37508e19576a8a120fadeac5d05
View file https://github.com/herdiyana256/angularfire/blob/bd59c446fbdc7630826a5d3b8091e3c377455d31/src/schematics/deploy/actions.jasmine.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angularfire/pull/3738/{{ revealButtonHref }}
https://github.com/angular/angularfire/pull/3738/files#diff-fd8fa896f712c72d1c7d5ea794bc3adce7b7e37508e19576a8a120fadeac5d05
https://github.com/angular/angularfire/pull/3738/files#diff-fd8fa896f712c72d1c7d5ea794bc3adce7b7e37508e19576a8a120fadeac5d05
https://github.com/angular/angularfire/pull/3738/files#diff-fd8fa896f712c72d1c7d5ea794bc3adce7b7e37508e19576a8a120fadeac5d05
src/schematics/deploy/actions.tshttps://github.com/angular/angularfire/pull/3738/files#diff-3ec0840be66029e0f049b9b68fd66805766a1ba221d1c7afe66e7dc8dee2592e
View file https://github.com/herdiyana256/angularfire/blob/bd59c446fbdc7630826a5d3b8091e3c377455d31/src/schematics/deploy/actions.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angularfire/pull/3738/{{ revealButtonHref }}
https://github.com/angular/angularfire/pull/3738/files#diff-3ec0840be66029e0f049b9b68fd66805766a1ba221d1c7afe66e7dc8dee2592e
https://github.com/angular/angularfire/pull/3738/files#diff-3ec0840be66029e0f049b9b68fd66805766a1ba221d1c7afe66e7dc8dee2592e
https://github.com/angular/angularfire/pull/3738/files#diff-3ec0840be66029e0f049b9b68fd66805766a1ba221d1c7afe66e7dc8dee2592e
https://github.com/angular/angularfire/pull/3738/files#diff-3ec0840be66029e0f049b9b68fd66805766a1ba221d1c7afe66e7dc8dee2592e
https://github.com/angular/angularfire/pull/3738/files#diff-3ec0840be66029e0f049b9b68fd66805766a1ba221d1c7afe66e7dc8dee2592e
Please reload this pagehttps://github.com/angular/angularfire/pull/3738/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlno-cache

Viewport: width=device-width


URLs of crawlers that visited me.