René's URL Explorer Experiment


Title: fix(deploy): prevent command injection from angular.json in ng deploy by herdiyana256 · Pull Request #3738 · angular/angularfire · GitHub

Open Graph Title: fix(deploy): prevent command injection from angular.json in ng deploy by herdiyana256 · Pull Request #3738 · angular/angularfire

X Title: fix(deploy): prevent command injection from angular.json in ng deploy by herdiyana256 · Pull Request #3738 · angular/angularfire

Description: Angular + Firebase = ❤️. Contribute to angular/angularfire development by creating an account on GitHub.

Open Graph Description: The SSR to Cloud Functions deploy builder shells out with values taken verbatim from the workspace angular.json. findPackageVersion builds `${packageManager} list ${name}` and passes it to execSync...

X Description: The SSR to Cloud Functions deploy builder shells out with values taken verbatim from the workspace angular.json. findPackageVersion builds `${packageManager} list ${name}` and passes it to execSync...

Opengraph URL: https://github.com/angular/angularfire/pull/3738

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.112.3

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:59ce9347-9bb6-15aa-a41a-ff52eed2c465
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEB7A:3BD392:65DCA:8579A:6B0369A3
html-safe-nonce089d4621e770e2784f2ac7538c04ae74721dabf20de559d6556d1a8d9d5a66a5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQjdBOjNCRDM5Mjo2NURDQTo4NTc5QTo2QjAzNjlBMyIsInZpc2l0b3JfaWQiOiIzMzIyMjgxOTU2ODcxNDY1Mzc5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac9ffc83b894ac02fc0f1f58c43ce57ef13e094ce4b71620203f4abfa385578bc0
hovercard-subject-tagpull_request:4246434502
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angularfire/3738/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9771b8e6938c1fff62d4be67039f334550ed114ed24e75247c84c0edb76b23f0/angular/angularfire/pull/3738
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9771b8e6938c1fff62d4be67039f334550ed114ed24e75247c84c0edb76b23f0/angular/angularfire/pull/3738
og:image:altThe SSR to Cloud Functions deploy builder shells out with values taken verbatim from the workspace angular.json. findPackageVersion builds `${packageManager} list ${name}` and passes it to execSync...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameherdiyana256
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/angular/angularfire git https://github.com/angular/angularfire.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id49453413
octolytics-dimension-repository_nwoangular/angularfire
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49453413
octolytics-dimension-repository_network_root_nwoangular/angularfire
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angularfire/pull/3738#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F3738
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F3738
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangularfire
Reloadhttps://github.com/angular/angularfire/pull/3738
Reloadhttps://github.com/angular/angularfire/pull/3738
Reloadhttps://github.com/angular/angularfire/pull/3738
angularhttps://github.com/angular
angularfirehttps://github.com/angular/angularfire
Codehttps://github.com/angular/angularfire
Issues162 (162)https://github.com/angular/angularfire/issues
Pull requests5 (5)https://github.com/angular/angularfire/pulls
Discussionshttps://github.com/angular/angularfire/discussions
Actionshttps://github.com/angular/angularfire/actions
Projectshttps://github.com/angular/angularfire/projects
Security and qualityhttps://github.com/angular/angularfire/security
Insightshttps://github.com/angular/angularfire/insights
https://github.com/angular/angularfire
armando-navarrohttps://github.com/armando-navarro
angular:mainhttps://github.com/angular/angularfire/tree/main
herdiyana256:fix/deploy-execsync-command-injectionhttps://github.com/herdiyana256/angularfire/tree/fix/deploy-execsync-command-injection
Conversationhttps://github.com/angular/angularfire/pull/3738
Commits4 (4)https://github.com/angular/angularfire/pull/3738/commits
Checkshttps://github.com/angular/angularfire/pull/3738/checks
Files changedhttps://github.com/angular/angularfire/pull/3738/files
fix(deploy): prevent command injection from angular.json in ng deployhttps://github.com/angular/angularfire/pull/3738#top
armando-navarrohttps://github.com/armando-navarro
angular:mainhttps://github.com/angular/angularfire/tree/main
herdiyana256:fix/deploy-execsync-command-injectionhttps://github.com/herdiyana256/angularfire/tree/fix/deploy-execsync-command-injection
https://github.com/herdiyana256
herdiyana256https://github.com/herdiyana256
Aug 10, 2026https://github.com/angular/angularfire/pull/3738#issue-5112182621
Please reload this pagehttps://github.com/angular/angularfire/pull/3738
#3726https://github.com/angular/angularfire/pull/3726
Please reload this pagehttps://github.com/angular/angularfire/pull/3738
https://github.com/herdiyana256
fix(deploy): prevent command injection from angular.json in ng deployhttps://github.com/angular/angularfire/pull/3738/commits/ed6b8b46ce5acc65d623626ef1a8c53906befadf
ed6b8b4https://github.com/angular/angularfire/pull/3738/commits/ed6b8b46ce5acc65d623626ef1a8c53906befadf
https://github.com/armando-navarro
armando-navarrohttps://github.com/armando-navarro
bump: patch https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22bump%3A%20patch%22
comp: schematics https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22comp%3A%20schematics%22
type: bug https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%22
Aug 11, 2026https://github.com/angular/angularfire/pull/3738#event-29301839859
https://github.com/armando-navarro
armando-navarrohttps://github.com/armando-navarro
Aug 11, 2026 https://github.com/angular/angularfire/pull/3738#pullrequestreview-4911684455
View reviewed changes https://github.com/angular/angularfire/pull/3738/files/ed6b8b46ce5acc65d623626ef1a8c53906befadf
armando-navarrohttps://github.com/armando-navarro
Please reload this pagehttps://github.com/angular/angularfire/pull/3738
https://github.com/angular/angularfire/pull/3738#pullrequestreview-4911684455
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
child_process docshttps://nodejs.org/api/child_process.html
DEP0190https://nodejs.org/api/deprecations.html#DEP0190
#3726https://github.com/angular/angularfire/pull/3726
Please reload this pagehttps://github.com/angular/angularfire/pull/3738
https://github.com/herdiyana256
fix(deploy): launch package managers cross-platform via cross-spawnhttps://github.com/angular/angularfire/pull/3738/commits/2ce37b4b1f063525dd3cec7c4fe6fb2480c7e949
2ce37b4https://github.com/angular/angularfire/pull/3738/commits/2ce37b4b1f063525dd3cec7c4fe6fb2480c7e949
angular#3726https://github.com/angular/angularfire/pull/3726
https://github.com/herdiyana256
herdiyana256https://github.com/herdiyana256
Aug 12, 2026https://github.com/angular/angularfire/pull/3738#issuecomment-5260950445
2ce37b4https://github.com/angular/angularfire/commit/2ce37b4b1f063525dd3cec7c4fe6fb2480c7e949
#3726https://github.com/angular/angularfire/pull/3726
Please reload this pagehttps://github.com/angular/angularfire/pull/3738
herdiyana256https://github.com/herdiyana256
Aug 12, 2026 https://github.com/angular/angularfire/pull/3738#ref-commit-4abf2eb
https://github.com/herdiyana256
fix(deploy): prevent code-generation injection from angular.json valueshttps://github.com/herdiyana256/angularfire/commit/4abf2ebb62aaf181037001bf145908b6fa011369
4abf2ebhttps://github.com/herdiyana256/angularfire/commit/4abf2ebb62aaf181037001bf145908b6fa011369
angular#3726https://github.com/angular/angularfire/pull/3726
angular#3738https://github.com/angular/angularfire/pull/3738
https://github.com/armando-navarro
armando-navarrohttps://github.com/armando-navarro
Aug 13, 2026 https://github.com/angular/angularfire/pull/3738#pullrequestreview-4922604210
View reviewed changes https://github.com/angular/angularfire/pull/3738/files/2ce37b4b1f063525dd3cec7c4fe6fb2480c7e949
armando-navarrohttps://github.com/armando-navarro
Please reload this pagehttps://github.com/angular/angularfire/pull/3738
https://github.com/angular/angularfire/pull/3738#pullrequestreview-4922604210
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angularfire/pull/3738
https://github.com/herdiyana256
build(deploy): move cross-spawn to devDependencieshttps://github.com/angular/angularfire/pull/3738/commits/b7747c38f20f94a550e60fdf6b46bf2b70b7c7f5
b7747c3https://github.com/angular/angularfire/pull/3738/commits/b7747c38f20f94a550e60fdf6b46bf2b70b7c7f5
https://github.com/herdiyana256
herdiyana256https://github.com/herdiyana256
Aug 13, 2026https://github.com/angular/angularfire/pull/3738#issuecomment-5281129697
b7747c3https://github.com/angular/angularfire/commit/b7747c38f20f94a550e60fdf6b46bf2b70b7c7f5
Please reload this pagehttps://github.com/angular/angularfire/pull/3738
https://github.com/armando-navarro
armando-navarrohttps://github.com/armando-navarro
Aug 13, 2026 https://github.com/angular/angularfire/pull/3738#pullrequestreview-4928930745
View reviewed changes https://github.com/angular/angularfire/pull/3738/files/bd59c446fbdc7630826a5d3b8091e3c377455d31
armando-navarrohttps://github.com/armando-navarro
https://github.com/angular/angularfire/pull/3738#pullrequestreview-4928930745
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angularfire/pull/3738
https://github.com/armando-navarro
Merge branch 'main' into fix/deploy-execsync-command-injectionhttps://github.com/angular/angularfire/pull/3738/commits/bd59c446fbdc7630826a5d3b8091e3c377455d31
bd59c44https://github.com/angular/angularfire/pull/3738/commits/bd59c446fbdc7630826a5d3b8091e3c377455d31
https://github.com/armando-navarro
armando-navarrohttps://github.com/armando-navarro
0e8ed0chttps://github.com/angular/angularfire/commit/0e8ed0cb130b227118180190056a00990db2ee1e
Aug 13, 2026https://github.com/angular/angularfire/pull/3738#event-29410381657
Please reload this pagehttps://github.com/angular/angularfire/pull/3738
https://github.com/herdiyana256
herdiyana256https://github.com/herdiyana256
Aug 13, 2026 https://github.com/angular/angularfire/pull/3738#ref-pullrequest-5032493640
fix(deploy): pass gcloud arguments as an array instead of a joined string #3726 https://github.com/angular/angularfire/pull/3726
https://github.com/armando-navarro
armando-navarrohttps://github.com/armando-navarro
21.0.0-rc.1https://github.com/angular/angularfire/milestone/29
Oct 1, 2026https://github.com/angular/angularfire/pull/3738#event-32219496882
https://github.com/armando-navarro
armando-navarrohttps://github.com/armando-navarro
Oct 9, 2026 https://github.com/angular/angularfire/pull/3738#ref-pullrequest-5784668442
Backport ten fixes to 20.1.x for 20.1.1 #3798 https://github.com/angular/angularfire/pull/3798
https://github.com/armando-navarro
armando-navarrohttps://github.com/armando-navarro
backport: 20.1.x https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22backport%3A%2020.1.x%22
Oct 9, 2026https://github.com/angular/angularfire/pull/3738#event-32909390464
armando-navarrohttps://github.com/armando-navarro
Oct 10, 2026 https://github.com/angular/angularfire/pull/3738#ref-commit-5ddc4bf
https://github.com/herdiyana256
https://github.com/armando-navarro
fix(deploy): prevent command injection from angular.json in ng deploy (https://github.com/angular/angularfire/commit/5ddc4bf10c8d5acde3dc27832796f46fd976894f
…https://github.com/angular/angularfire/pull/3738
5ddc4bfhttps://github.com/angular/angularfire/commit/5ddc4bf10c8d5acde3dc27832796f46fd976894f
…#3738https://github.com/angular/angularfire/pull/3738
0e8ed0chttps://github.com/angular/angularfire/commit/0e8ed0cb130b227118180190056a00990db2ee1e
https://github.co/hiddenchars
https://github.com/angular/angularfire/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F3738
https://github.com/armando-navarro
armando-navarro https://github.com/armando-navarro
https://github.com/angular/angularfire/pull/3738/files/bd59c446fbdc7630826a5d3b8091e3c377455d31
Please reload this pagehttps://github.com/angular/angularfire/pull/3738
backport: 20.1.x https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22backport%3A%2020.1.x%22
bump: patch https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22bump%3A%20patch%22
comp: schematics https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22comp%3A%20schematics%22
type: bug https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%22
21.0.0-rc.1 https://github.com/angular/angularfire/milestone/29
Please reload this pagehttps://github.com/angular/angularfire/pull/3738
https://github.com/herdiyana256
https://github.com/armando-navarro
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlno-cache

Viewport: width=device-width


URLs of crawlers that visited me.