| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:645a841c-69ff-b07f-2d5a-0b4b8f60acd7 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EAAA:29D479:1739AC:1EA297:6B036E53 |
| html-safe-nonce | ee4687fbaf32b4d62d31cb059555588bcfb2257d7f3f4e23b4257d6ca140377b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQUFBOjI5RDQ3OToxNzM5QUM6MUVBMjk3OjZCMDM2RTUzIiwidmlzaXRvcl9pZCI6IjIzNTQyMjc1MTQxMTA2MDI4MzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 17c8255ed93c25384acad68c716bf9017fab1fb55afbb204f54d68dcc00fc49e |
| hovercard-subject-tag | pull_request:4180169819 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angularfire/pull/3726/files |
| twitter:image | https://avatars.githubusercontent.com/u/82978131?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/82978131?s=400&v=4 |
| og:image:alt | `spawnAsync` built the gcloud command as a single template-literal string and split it on whitespace (`command.split(/\s+/)`) before handing it to `spawn()`. Any deploy option containing a space (`... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angularfire git https://github.com/angular/angularfire.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 49453413 |
| octolytics-dimension-repository_nwo | angular/angularfire |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 49453413 |
| octolytics-dimension-repository_network_root_nwo | angular/angularfire |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/angular/angularfire/pull/3726/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F3726%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F3726%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangularfire |
| Reload | https://github.com/angular/angularfire/pull/3726/files |
| Reload | https://github.com/angular/angularfire/pull/3726/files |
| Reload | https://github.com/angular/angularfire/pull/3726/files |
| angular | https://github.com/angular |
| angularfire | https://github.com/angular/angularfire |
| Code | https://github.com/angular/angularfire |
| Issues162 (162) | https://github.com/angular/angularfire/issues |
| Pull requests5 (5) | https://github.com/angular/angularfire/pulls |
| Discussions | https://github.com/angular/angularfire/discussions |
| Actions | https://github.com/angular/angularfire/actions |
| Projects | https://github.com/angular/angularfire/projects |
| Security and quality | https://github.com/angular/angularfire/security |
| Insights | https://github.com/angular/angularfire/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fangular%2Fangularfire%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fangular%2Fangularfire%2Fissues%2Fnew%2Fchoose |
| armando-navarro | https://github.com/armando-navarro |
| angular:main | https://github.com/angular/angularfire/tree/main |
| herdiyana256:fix-deploy-cloudrun-argv-injection | https://github.com/herdiyana256/angularfire/tree/fix-deploy-cloudrun-argv-injection |
|
Conversation
5
| https://github.com/angular/angularfire/pull/3726 |
|
Commits
7
| https://github.com/angular/angularfire/pull/3726/commits |
|
Checks
24
| https://github.com/angular/angularfire/pull/3726/checks |
|
Files changed
| https://github.com/angular/angularfire/pull/3726/files |
| Please reload this page | https://github.com/angular/angularfire/pull/3726/files |
|
fix(deploy): pass gcloud arguments as an array instead of a joined string
| https://github.com/angular/angularfire/pull/3726/files#top |
|
Show all changes
7 commits
| https://github.com/angular/angularfire/pull/3726/files |
|
8859c46
fix(deploy): pass gcloud arguments as an array instead of a joined st…
herdiyana256 Jul 31, 2026
| https://github.com/angular/angularfire/pull/3726/commits/8859c46a85aec587f494ccc81683989f998f480b |
|
7c2668e
fix(deploy): treat any non-zero gcloud exit code as failure, add argv…
herdiyana256 Aug 3, 2026
| https://github.com/angular/angularfire/pull/3726/commits/7c2668eef5a7f5245e5953002c5511ae468d71bb |
|
b7ca88a
Merge remote-tracking branch 'origin/main' into fix-deploy-cloudrun-a…
herdiyana256 Aug 7, 2026
| https://github.com/angular/angularfire/pull/3726/commits/b7ca88a8f94e9e00c878dee4fd9b5d5a4dba90eb |
|
530af9b
fix(deploy): constrain functionName and region in the deploy schema
herdiyana256 Aug 7, 2026
| https://github.com/angular/angularfire/pull/3726/commits/530af9b1be7191e38a803cc79626b55b8e36dfd4 |
|
09b3bc7
Merge remote-tracking branch 'origin/main' into fix-deploy-cloudrun-a…
herdiyana256 Aug 13, 2026
| https://github.com/angular/angularfire/pull/3726/commits/09b3bc7ad8c4df762c66b77a10c3a5ed7157c886 |
|
900d670
fix(deploy): clarify functionName description, drop redundant cast
herdiyana256 Aug 17, 2026
| https://github.com/angular/angularfire/pull/3726/commits/900d670f702ff4b7fa5964972c2f0491e4dae6d1 |
|
d1a9a22
Merge branch 'main' into fix-deploy-cloudrun-argv-injection
armando-navarro Aug 17, 2026
| https://github.com/angular/angularfire/pull/3726/commits/d1a9a22cdcd7e0b52b5a889c36406a5b0da3e40d |
|
Clear filters
| https://github.com/angular/angularfire/pull/3726/files |
| Please reload this page | https://github.com/angular/angularfire/pull/3726/files |
| Please reload this page | https://github.com/angular/angularfire/pull/3726/files |
|
actions.jasmine.ts
| https://github.com/angular/angularfire/pull/3726/files#diff-fd8fa896f712c72d1c7d5ea794bc3adce7b7e37508e19576a8a120fadeac5d05 |
|
actions.ts
| https://github.com/angular/angularfire/pull/3726/files#diff-3ec0840be66029e0f049b9b68fd66805766a1ba221d1c7afe66e7dc8dee2592e |
|
schema.json
| https://github.com/angular/angularfire/pull/3726/files#diff-038c5f6b3cc13ef6da28d649eabe9ce28d76b50d7f27b2037d1d37fc9d465c4b |
| src/schematics/deploy/actions.jasmine.ts | https://github.com/angular/angularfire/pull/3726/files#diff-fd8fa896f712c72d1c7d5ea794bc3adce7b7e37508e19576a8a120fadeac5d05 |
|
View file
| https://github.com/herdiyana256/angularfire/blob/d1a9a22cdcd7e0b52b5a889c36406a5b0da3e40d/src/schematics/deploy/actions.jasmine.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angularfire/pull/3726/{{ revealButtonHref }} |
|
| https://github.com/angular/angularfire/pull/3726/files#diff-fd8fa896f712c72d1c7d5ea794bc3adce7b7e37508e19576a8a120fadeac5d05 |
|
| https://github.com/angular/angularfire/pull/3726/files#diff-fd8fa896f712c72d1c7d5ea794bc3adce7b7e37508e19576a8a120fadeac5d05 |
|
| https://github.com/angular/angularfire/pull/3726/files#diff-fd8fa896f712c72d1c7d5ea794bc3adce7b7e37508e19576a8a120fadeac5d05 |
|
| https://github.com/angular/angularfire/pull/3726/files#diff-fd8fa896f712c72d1c7d5ea794bc3adce7b7e37508e19576a8a120fadeac5d05 |
| src/schematics/deploy/actions.ts | https://github.com/angular/angularfire/pull/3726/files#diff-3ec0840be66029e0f049b9b68fd66805766a1ba221d1c7afe66e7dc8dee2592e |
|
View file
| https://github.com/herdiyana256/angularfire/blob/d1a9a22cdcd7e0b52b5a889c36406a5b0da3e40d/src/schematics/deploy/actions.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angularfire/pull/3726/{{ revealButtonHref }} |
|
| https://github.com/angular/angularfire/pull/3726/files#diff-3ec0840be66029e0f049b9b68fd66805766a1ba221d1c7afe66e7dc8dee2592e |
|
| https://github.com/angular/angularfire/pull/3726/files#diff-3ec0840be66029e0f049b9b68fd66805766a1ba221d1c7afe66e7dc8dee2592e |
|
| https://github.com/angular/angularfire/pull/3726/files#diff-3ec0840be66029e0f049b9b68fd66805766a1ba221d1c7afe66e7dc8dee2592e |
|
| https://github.com/angular/angularfire/pull/3726/files#diff-3ec0840be66029e0f049b9b68fd66805766a1ba221d1c7afe66e7dc8dee2592e |
|
| https://github.com/angular/angularfire/pull/3726/files#diff-3ec0840be66029e0f049b9b68fd66805766a1ba221d1c7afe66e7dc8dee2592e |
|
| https://github.com/angular/angularfire/pull/3726/files#diff-3ec0840be66029e0f049b9b68fd66805766a1ba221d1c7afe66e7dc8dee2592e |
|
| https://github.com/angular/angularfire/pull/3726/files#diff-3ec0840be66029e0f049b9b68fd66805766a1ba221d1c7afe66e7dc8dee2592e |
|
| https://github.com/angular/angularfire/pull/3726/files#diff-3ec0840be66029e0f049b9b68fd66805766a1ba221d1c7afe66e7dc8dee2592e |
|
| https://github.com/angular/angularfire/pull/3726/files#diff-3ec0840be66029e0f049b9b68fd66805766a1ba221d1c7afe66e7dc8dee2592e |
| src/schematics/deploy/schema.json | https://github.com/angular/angularfire/pull/3726/files#diff-038c5f6b3cc13ef6da28d649eabe9ce28d76b50d7f27b2037d1d37fc9d465c4b |
|
View file
| https://github.com/herdiyana256/angularfire/blob/d1a9a22cdcd7e0b52b5a889c36406a5b0da3e40d/src/schematics/deploy/schema.json |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angularfire/pull/3726/{{ revealButtonHref }} |
|
| https://github.com/angular/angularfire/pull/3726/files#diff-038c5f6b3cc13ef6da28d649eabe9ce28d76b50d7f27b2037d1d37fc9d465c4b |
|
| https://github.com/angular/angularfire/pull/3726/files#diff-038c5f6b3cc13ef6da28d649eabe9ce28d76b50d7f27b2037d1d37fc9d465c4b |
|
| https://github.com/angular/angularfire/pull/3726/files#diff-038c5f6b3cc13ef6da28d649eabe9ce28d76b50d7f27b2037d1d37fc9d465c4b |
| Please reload this page | https://github.com/angular/angularfire/pull/3726/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |