René's URL Explorer Experiment


Title: fix(deploy): pass gcloud arguments as an array instead of a joined string by herdiyana256 · Pull Request #3726 · angular/angularfire · GitHub

Open Graph Title: fix(deploy): pass gcloud arguments as an array instead of a joined string by herdiyana256 · Pull Request #3726 · angular/angularfire

X Title: fix(deploy): pass gcloud arguments as an array instead of a joined string by herdiyana256 · Pull Request #3726 · angular/angularfire

Description: `spawnAsync` built the gcloud command as a single template-literal string and split it on whitespace (`command.split(/\s+/)`) before handing it to `spawn()`. Any deploy option containing a space (`region`, `firebaseProject`, `functionName`, `cloudRunOptions.vpcConnector`, none of which have a schema `pattern`) would be split into extra argv entries, letting a value from `angular.json` add unintended flags to the `gcloud builds submit` / `gcloud run deploy` / `gcloud auth activate-service-account` invocations. `spawnAsync` now takes `command` and `args` separately, matching `child_process.spawn`'s own signature, and the three call sites build their argument lists as arrays instead of interpolating into one string. This removes the join/split round-trip entirely rather than trying to validate each field individually, addressing the existing `// TODO validate serviceId, firebaseProject, and vpcConnector both to limit errors and opp for injection` comment. Verified with a standalone repro pointing `spawnAsync` at a fake `gcloud` binary that records its argv: a `region` value of `"us-central1 --update-env-vars=..."` previously landed as two separate argv tokens (the injected flag reaching `gcloud` as its own argument); after this change it lands as a single `--region` value. `npx tsc --noEmit` and `npx eslint src/schematics/deploy/actions.ts` both pass clean.

Open Graph Description: `spawnAsync` built the gcloud command as a single template-literal string and split it on whitespace (`command.split(/\s+/)`) before handing it to `spawn()`. Any deploy option containing a space (`...

X Description: `spawnAsync` built the gcloud command as a single template-literal string and split it on whitespace (`command.split(/\s+/)`) before handing it to `spawn()`. Any deploy option containing a space (`...

Opengraph URL: https://github.com/angular/angularfire/pull/3726

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.112.3

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:645a841c-69ff-b07f-2d5a-0b4b8f60acd7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEAAA:29D479:1739AC:1EA297:6B036E53
html-safe-nonceee4687fbaf32b4d62d31cb059555588bcfb2257d7f3f4e23b4257d6ca140377b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQUFBOjI5RDQ3OToxNzM5QUM6MUVBMjk3OjZCMDM2RTUzIiwidmlzaXRvcl9pZCI6IjIzNTQyMjc1MTQxMTA2MDI4MzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac17c8255ed93c25384acad68c716bf9017fab1fb55afbb204f54d68dcc00fc49e
hovercard-subject-tagpull_request:4180169819
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angularfire/pull/3726/files
twitter:imagehttps://avatars.githubusercontent.com/u/82978131?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/82978131?s=400&v=4
og:image:alt`spawnAsync` built the gcloud command as a single template-literal string and split it on whitespace (`command.split(/\s+/)`) before handing it to `spawn()`. Any deploy option containing a space (`...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angularfire git https://github.com/angular/angularfire.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id49453413
octolytics-dimension-repository_nwoangular/angularfire
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49453413
octolytics-dimension-repository_network_root_nwoangular/angularfire
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angularfire/pull/3726/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F3726%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F3726%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangularfire
Reloadhttps://github.com/angular/angularfire/pull/3726/files
Reloadhttps://github.com/angular/angularfire/pull/3726/files
Reloadhttps://github.com/angular/angularfire/pull/3726/files
angularhttps://github.com/angular
angularfirehttps://github.com/angular/angularfire
Codehttps://github.com/angular/angularfire
Issues162 (162)https://github.com/angular/angularfire/issues
Pull requests5 (5)https://github.com/angular/angularfire/pulls
Discussionshttps://github.com/angular/angularfire/discussions
Actionshttps://github.com/angular/angularfire/actions
Projectshttps://github.com/angular/angularfire/projects
Security and qualityhttps://github.com/angular/angularfire/security
Insightshttps://github.com/angular/angularfire/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangularfire%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangularfire%2Fissues%2Fnew%2Fchoose
armando-navarrohttps://github.com/armando-navarro
angular:mainhttps://github.com/angular/angularfire/tree/main
herdiyana256:fix-deploy-cloudrun-argv-injectionhttps://github.com/herdiyana256/angularfire/tree/fix-deploy-cloudrun-argv-injection
Conversation 5 https://github.com/angular/angularfire/pull/3726
Commits 7 https://github.com/angular/angularfire/pull/3726/commits
Checks 24 https://github.com/angular/angularfire/pull/3726/checks
Files changed https://github.com/angular/angularfire/pull/3726/files
Please reload this pagehttps://github.com/angular/angularfire/pull/3726/files
fix(deploy): pass gcloud arguments as an array instead of a joined string https://github.com/angular/angularfire/pull/3726/files#top
Show all changes 7 commits https://github.com/angular/angularfire/pull/3726/files
8859c46 fix(deploy): pass gcloud arguments as an array instead of a joined st… herdiyana256 Jul 31, 2026 https://github.com/angular/angularfire/pull/3726/commits/8859c46a85aec587f494ccc81683989f998f480b
7c2668e fix(deploy): treat any non-zero gcloud exit code as failure, add argv… herdiyana256 Aug 3, 2026 https://github.com/angular/angularfire/pull/3726/commits/7c2668eef5a7f5245e5953002c5511ae468d71bb
b7ca88a Merge remote-tracking branch 'origin/main' into fix-deploy-cloudrun-a… herdiyana256 Aug 7, 2026 https://github.com/angular/angularfire/pull/3726/commits/b7ca88a8f94e9e00c878dee4fd9b5d5a4dba90eb
530af9b fix(deploy): constrain functionName and region in the deploy schema herdiyana256 Aug 7, 2026 https://github.com/angular/angularfire/pull/3726/commits/530af9b1be7191e38a803cc79626b55b8e36dfd4
09b3bc7 Merge remote-tracking branch 'origin/main' into fix-deploy-cloudrun-a… herdiyana256 Aug 13, 2026 https://github.com/angular/angularfire/pull/3726/commits/09b3bc7ad8c4df762c66b77a10c3a5ed7157c886
900d670 fix(deploy): clarify functionName description, drop redundant cast herdiyana256 Aug 17, 2026 https://github.com/angular/angularfire/pull/3726/commits/900d670f702ff4b7fa5964972c2f0491e4dae6d1
d1a9a22 Merge branch 'main' into fix-deploy-cloudrun-argv-injection armando-navarro Aug 17, 2026 https://github.com/angular/angularfire/pull/3726/commits/d1a9a22cdcd7e0b52b5a889c36406a5b0da3e40d
Clear filters https://github.com/angular/angularfire/pull/3726/files
Please reload this pagehttps://github.com/angular/angularfire/pull/3726/files
Please reload this pagehttps://github.com/angular/angularfire/pull/3726/files
actions.jasmine.ts https://github.com/angular/angularfire/pull/3726/files#diff-fd8fa896f712c72d1c7d5ea794bc3adce7b7e37508e19576a8a120fadeac5d05
actions.ts https://github.com/angular/angularfire/pull/3726/files#diff-3ec0840be66029e0f049b9b68fd66805766a1ba221d1c7afe66e7dc8dee2592e
schema.json https://github.com/angular/angularfire/pull/3726/files#diff-038c5f6b3cc13ef6da28d649eabe9ce28d76b50d7f27b2037d1d37fc9d465c4b
src/schematics/deploy/actions.jasmine.tshttps://github.com/angular/angularfire/pull/3726/files#diff-fd8fa896f712c72d1c7d5ea794bc3adce7b7e37508e19576a8a120fadeac5d05
View file https://github.com/herdiyana256/angularfire/blob/d1a9a22cdcd7e0b52b5a889c36406a5b0da3e40d/src/schematics/deploy/actions.jasmine.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angularfire/pull/3726/{{ revealButtonHref }}
https://github.com/angular/angularfire/pull/3726/files#diff-fd8fa896f712c72d1c7d5ea794bc3adce7b7e37508e19576a8a120fadeac5d05
https://github.com/angular/angularfire/pull/3726/files#diff-fd8fa896f712c72d1c7d5ea794bc3adce7b7e37508e19576a8a120fadeac5d05
https://github.com/angular/angularfire/pull/3726/files#diff-fd8fa896f712c72d1c7d5ea794bc3adce7b7e37508e19576a8a120fadeac5d05
https://github.com/angular/angularfire/pull/3726/files#diff-fd8fa896f712c72d1c7d5ea794bc3adce7b7e37508e19576a8a120fadeac5d05
src/schematics/deploy/actions.tshttps://github.com/angular/angularfire/pull/3726/files#diff-3ec0840be66029e0f049b9b68fd66805766a1ba221d1c7afe66e7dc8dee2592e
View file https://github.com/herdiyana256/angularfire/blob/d1a9a22cdcd7e0b52b5a889c36406a5b0da3e40d/src/schematics/deploy/actions.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angularfire/pull/3726/{{ revealButtonHref }}
https://github.com/angular/angularfire/pull/3726/files#diff-3ec0840be66029e0f049b9b68fd66805766a1ba221d1c7afe66e7dc8dee2592e
https://github.com/angular/angularfire/pull/3726/files#diff-3ec0840be66029e0f049b9b68fd66805766a1ba221d1c7afe66e7dc8dee2592e
https://github.com/angular/angularfire/pull/3726/files#diff-3ec0840be66029e0f049b9b68fd66805766a1ba221d1c7afe66e7dc8dee2592e
https://github.com/angular/angularfire/pull/3726/files#diff-3ec0840be66029e0f049b9b68fd66805766a1ba221d1c7afe66e7dc8dee2592e
https://github.com/angular/angularfire/pull/3726/files#diff-3ec0840be66029e0f049b9b68fd66805766a1ba221d1c7afe66e7dc8dee2592e
https://github.com/angular/angularfire/pull/3726/files#diff-3ec0840be66029e0f049b9b68fd66805766a1ba221d1c7afe66e7dc8dee2592e
https://github.com/angular/angularfire/pull/3726/files#diff-3ec0840be66029e0f049b9b68fd66805766a1ba221d1c7afe66e7dc8dee2592e
https://github.com/angular/angularfire/pull/3726/files#diff-3ec0840be66029e0f049b9b68fd66805766a1ba221d1c7afe66e7dc8dee2592e
https://github.com/angular/angularfire/pull/3726/files#diff-3ec0840be66029e0f049b9b68fd66805766a1ba221d1c7afe66e7dc8dee2592e
src/schematics/deploy/schema.jsonhttps://github.com/angular/angularfire/pull/3726/files#diff-038c5f6b3cc13ef6da28d649eabe9ce28d76b50d7f27b2037d1d37fc9d465c4b
View file https://github.com/herdiyana256/angularfire/blob/d1a9a22cdcd7e0b52b5a889c36406a5b0da3e40d/src/schematics/deploy/schema.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angularfire/pull/3726/{{ revealButtonHref }}
https://github.com/angular/angularfire/pull/3726/files#diff-038c5f6b3cc13ef6da28d649eabe9ce28d76b50d7f27b2037d1d37fc9d465c4b
https://github.com/angular/angularfire/pull/3726/files#diff-038c5f6b3cc13ef6da28d649eabe9ce28d76b50d7f27b2037d1d37fc9d465c4b
https://github.com/angular/angularfire/pull/3726/files#diff-038c5f6b3cc13ef6da28d649eabe9ce28d76b50d7f27b2037d1d37fc9d465c4b
Please reload this pagehttps://github.com/angular/angularfire/pull/3726/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlno-cache

Viewport: width=device-width


URLs of crawlers that visited me.