Title: fix(schematics): log the caught error when dataconnect.yaml parsing fails by armando-navarro · Pull Request #3711 · angular/angularfire · GitHub
Open Graph Title: fix(schematics): log the caught error when dataconnect.yaml parsing fails by armando-navarro · Pull Request #3711 · angular/angularfire
X Title: fix(schematics): log the caught error when dataconnect.yaml parsing fails by armando-navarro · Pull Request #3711 · angular/angularfire
Description: Fixes #3710 One-line fix: the catch handler in parseDataConnectConfig names its error variable _ but logs e, which is undefined — so the intended soft-fail path (warn and return null) instead crashes the schematic with a ReferenceError. Renaming the variable to e makes the handler do what it was written to do. No behavior change on the success path. The file isn't covered by any typecheck today (the library build excludes the schematics; esbuild doesn't check types), which is how this survived — a tsc --noEmit pass over src/schematics would catch this class of bug at build time.
Open Graph Description: Fixes #3710 One-line fix: the catch handler in parseDataConnectConfig names its error variable _ but logs e, which is undefined — so the intended soft-fail path (warn and return null) instead crash...
X Description: Fixes #3710 One-line fix: the catch handler in parseDataConnectConfig names its error variable _ but logs e, which is undefined — so the intended soft-fail path (warn and return null) instead crash...
Opengraph URL: https://github.com/angular/angularfire/pull/3711
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:91ba51d1-434d-154b-83f2-2912fdda4c8c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B630:277ED1:1227E52:1778114:6A5C3FD7 |
| html-safe-nonce | 90d0d86a5b7ef7b36d6b05c6e138d295216ea15a3251ff3cd19fa2e788870b6b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNjMwOjI3N0VEMToxMjI3RTUyOjE3NzgxMTQ6NkE1QzNGRDciLCJ2aXNpdG9yX2lkIjoiNjY0NDk5MDYwNDA1MjU0NTQ5NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 101969bf62184e7fe80029e4b8ddb972c5cf94dc9d850daba0674ec139caec77 |
| hovercard-subject-tag | pull_request:4023763427 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angularfire/pull/3711/files |
| twitter:image | https://avatars.githubusercontent.com/u/13904589?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/13904589?s=400&v=4 |
| og:image:alt | Fixes #3710 One-line fix: the catch handler in parseDataConnectConfig names its error variable _ but logs e, which is undefined — so the intended soft-fail path (warn and return null) instead crash... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angularfire git https://github.com/angular/angularfire.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 49453413 |
| octolytics-dimension-repository_nwo | angular/angularfire |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 49453413 |
| octolytics-dimension-repository_network_root_nwo | angular/angularfire |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c975978430e9ad293956f2bbdaf153b1bd84a99 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width