Title: fix(firestore): do not return idField on valueChanges if no document by KingDarBoja · Pull Request #2777 · angular/angularfire · GitHub
Open Graph Title: fix(firestore): do not return idField on valueChanges if no document by KingDarBoja · Pull Request #2777 · angular/angularfire
X Title: fix(firestore): do not return idField on valueChanges if no document by KingDarBoja · Pull Request #2777 · angular/angularfire
Description: Checklist Issue number for this PR: #2753 (required) Docs included?: no Test units included?: yes In a clean directory, yarn install, yarn test run successfully? no (needs some fix for Windows) Description This should provide a safe way of returning the idField on document method valueChanges as the current behaviour is explained at the linked issue. In this case, the idField should only ever be returned if the document exists. Code sample
Open Graph Description: Checklist Issue number for this PR: #2753 (required) Docs included?: no Test units included?: yes In a clean directory, yarn install, yarn test run successfully? no (needs some fix for Windows) D...
X Description: Checklist Issue number for this PR: #2753 (required) Docs included?: no Test units included?: yes In a clean directory, yarn install, yarn test run successfully? no (needs some fix for Windows) D...
Opengraph URL: https://github.com/angular/angularfire/pull/2777
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:48b66731-6a40-41fb-1bb5-dcb570d45df5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E04C:225DC1:628AE2C:821F24F:6A5DD33C |
| html-safe-nonce | bfcc285b7a9d7696aebb5e4c1ed6117d5e2f2db5e8f42bea413e31ec02a18461 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMDRDOjIyNURDMTo2MjhBRTJDOjgyMUYyNEY6NkE1REQzM0MiLCJ2aXNpdG9yX2lkIjoiMzE0OTM1MDA4NTE0NDIwNDA5MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | cdb781b9c91d584e05782a240bbe8916b0a08768cdc4f331c76b623989b12484 |
| hovercard-subject-tag | pull_request:592449684 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angularfire/pull/2777/files |
| twitter:image | https://avatars.githubusercontent.com/u/30560560?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/30560560?s=400&v=4 |
| og:image:alt | Checklist Issue number for this PR: #2753 (required) Docs included?: no Test units included?: yes In a clean directory, yarn install, yarn test run successfully? no (needs some fix for Windows) D... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angularfire git https://github.com/angular/angularfire.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 49453413 |
| octolytics-dimension-repository_nwo | angular/angularfire |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 49453413 |
| octolytics-dimension-repository_network_root_nwo | angular/angularfire |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c975978430e9ad293956f2bbdaf153b1bd84a99 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width