Title: Adjusted permission check by nmggithub · Pull Request #2763 · angular/angularfire · GitHub
Open Graph Title: Adjusted permission check by nmggithub · Pull Request #2763 · angular/angularfire
X Title: Adjusted permission check by nmggithub · Pull Request #2763 · angular/angularfire
Description: Since late 2019, getToken() has automatically requested permission, so no need to check if it is granted here Checklist Issue number for this PR: #2762 (required) Docs included?: no (this is not a functional change that requires documentation, as it simply bring angularfire in line with the underlying library) Test units included?: no In a clean directory, yarn install, yarn test run successfully? yes Description As explained in the commit: since late 2019, getToken() has automatically requested permission, so no need to check if it is granted here.
Open Graph Description: Since late 2019, getToken() has automatically requested permission, so no need to check if it is granted here Checklist Issue number for this PR: #2762 (required) Docs included?: no (this is not ...
X Description: Since late 2019, getToken() has automatically requested permission, so no need to check if it is granted here Checklist Issue number for this PR: #2762 (required) Docs included?: no (this is not ...
Opengraph URL: https://github.com/angular/angularfire/pull/2763
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:137e228c-df73-636a-5110-88486aa4abd0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AA70:2E5B3A:12F89EE:1944162:6A5BB83F |
| html-safe-nonce | 3c20ed5a008dc656a1ed6a051e784c0cba44743b8bb33afda1cc349c7ffdd327 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQTcwOjJFNUIzQToxMkY4OUVFOjE5NDQxNjI6NkE1QkI4M0YiLCJ2aXNpdG9yX2lkIjoiNTM2NDk1MzYzNjc0MDUxMTgwOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 16c2b9d1c6a810ede1d6c3e43860e6814bd22e079a25de89dfc248df7bb48c23 |
| hovercard-subject-tag | pull_request:577049083 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angularfire/pull/2763/files |
| twitter:image | https://avatars.githubusercontent.com/u/7817452?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/7817452?s=400&v=4 |
| og:image:alt | Since late 2019, getToken() has automatically requested permission, so no need to check if it is granted here Checklist Issue number for this PR: #2762 (required) Docs included?: no (this is not ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angularfire git https://github.com/angular/angularfire.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 49453413 |
| octolytics-dimension-repository_nwo | angular/angularfire |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 49453413 |
| octolytics-dimension-repository_network_root_nwo | angular/angularfire |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c975978430e9ad293956f2bbdaf153b1bd84a99 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width