| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:9c892149-b4a6-4db9-9b8b-92a7a8a6332d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8C76:1F5D45:10C4A1F:1693EA4:6A5AA93A |
| html-safe-nonce | 53a21b284337dd74b7c324592a3340840ab754c960a910027aff3f8e3af3b51e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Qzc2OjFGNUQ0NToxMEM0QTFGOjE2OTNFQTQ6NkE1QUE5M0EiLCJ2aXNpdG9yX2lkIjoiMjIyNTk2NTkzNTA3NjQ4NTQzNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 1efad0c3e99e9a4dfbbb15a33f0e0294f3cbe59e94d1772eadaabed32ffe1dbb |
| hovercard-subject-tag | pull_request:385933819 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angularfire/2347/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/43f386b71924d0b8ee92597c7ba3bdbe6a78d99b7e4bc83c9f1e85141c6515f0/angular/angularfire/pull/2347 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/43f386b71924d0b8ee92597c7ba3bdbe6a78d99b7e4bc83c9f1e85141c6515f0/angular/angularfire/pull/2347 |
| og:image:alt | Checklist
Issue number for this PR: #nnn (required)
Docs included?: (yes/no; required for all API/functional changes)
Test units included?: (yes/no; required)
In a clean directory, yarn install, y... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jamesdaniels |
| hostname | github.com |
| expected-hostname | github.com |
| None | 17a57ee6ab03686731c491fccb57e6a97c066a29d7cdf1a7d83c46f5c56684fc |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angularfire git https://github.com/angular/angularfire.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 49453413 |
| octolytics-dimension-repository_nwo | angular/angularfire |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 49453413 |
| octolytics-dimension-repository_network_root_nwo | angular/angularfire |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5cb870aa6b86b87be75e23ca7caec54726a25af9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/angular/angularfire/pull/2347#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F2347 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F2347 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangularfire |
| Reload | https://github.com/angular/angularfire/pull/2347 |
| Reload | https://github.com/angular/angularfire/pull/2347 |
| Reload | https://github.com/angular/angularfire/pull/2347 |
| Please reload this page | https://github.com/angular/angularfire/pull/2347 |
|
angular
| https://github.com/angular |
| angularfire | https://github.com/angular/angularfire |
|
Notifications
| https://github.com/login?return_to=%2Fangular%2Fangularfire |
|
Fork
2.2k
| https://github.com/login?return_to=%2Fangular%2Fangularfire |
|
Star
7.8k
| https://github.com/login?return_to=%2Fangular%2Fangularfire |
|
Code
| https://github.com/angular/angularfire |
|
Issues
295
| https://github.com/angular/angularfire/issues |
|
Pull requests
20
| https://github.com/angular/angularfire/pulls |
|
Discussions
| https://github.com/angular/angularfire/discussions |
|
Actions
| https://github.com/angular/angularfire/actions |
|
Projects
| https://github.com/angular/angularfire/projects |
|
Security and quality
0
| https://github.com/angular/angularfire/security |
|
Insights
| https://github.com/angular/angularfire/pulse |
|
Code
| https://github.com/angular/angularfire |
|
Issues
| https://github.com/angular/angularfire/issues |
|
Pull requests
| https://github.com/angular/angularfire/pulls |
|
Discussions
| https://github.com/angular/angularfire/discussions |
|
Actions
| https://github.com/angular/angularfire/actions |
|
Projects
| https://github.com/angular/angularfire/projects |
|
Security and quality
| https://github.com/angular/angularfire/security |
|
Insights
| https://github.com/angular/angularfire/pulse |
| jamesdaniels | https://github.com/jamesdaniels |
| master | https://github.com/angular/angularfire/tree/master |
| rc1-fixes | https://github.com/angular/angularfire/tree/rc1-fixes |
| Conversation | https://github.com/angular/angularfire/pull/2347 |
| Commits6 (6) | https://github.com/angular/angularfire/pull/2347/commits |
| Checks | https://github.com/angular/angularfire/pull/2347/checks |
| Files changed | https://github.com/angular/angularfire/pull/2347/files |
| Fixing some stuff since rc-1 | https://github.com/angular/angularfire/pull/2347#top |
| jamesdaniels | https://github.com/jamesdaniels |
| master | https://github.com/angular/angularfire/tree/master |
| rc1-fixes | https://github.com/angular/angularfire/tree/rc1-fixes |
|
| https://github.com/jamesdaniels |
| jamesdaniels | https://github.com/jamesdaniels |
| Mar 10, 2020 | https://github.com/angular/angularfire/pull/2347#issue-578332880 |
| Please reload this page | https://github.com/angular/angularfire/pull/2347 |
|
| https://github.com/jamesdaniels |
| Fixing some stuff since rc-1 | https://github.com/angular/angularfire/pull/2347/commits/dd3125238ed9bb7d759eafc32cc36fe0fbfee51a |
| dd31252 | https://github.com/angular/angularfire/pull/2347/commits/dd3125238ed9bb7d759eafc32cc36fe0fbfee51a |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Mar 10, 2020 | https://github.com/angular/angularfire/pull/2347#event-3113234624 |
| https://github.com/jamesdaniels |
| jamesdaniels | https://github.com/jamesdaniels |
|
Mar 10, 2020
| https://github.com/angular/angularfire/pull/2347#pullrequestreview-371681340 |
|
View reviewed changes
| https://github.com/angular/angularfire/pull/2347/files/dd3125238ed9bb7d759eafc32cc36fe0fbfee51a |
| src/storage/ref.ts | https://github.com/angular/angularfire/pull/2347/files/dd3125238ed9bb7d759eafc32cc36fe0fbfee51a#diff-ada97e2e27f41636c89d284cd5f77b9bb1c1dd41ed10de4d9eab85264582867a |
| jamesdaniels | https://github.com/jamesdaniels |
| Mar 10, 2020 | https://github.com/angular/angularfire/pull/2347#discussion_r390094873 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angularfire/pull/2347 |
| https://github.com/jamesdaniels |
| jamesdaniels | https://github.com/jamesdaniels |
|
Mar 10, 2020
| https://github.com/angular/angularfire/pull/2347#pullrequestreview-371681491 |
|
View reviewed changes
| https://github.com/angular/angularfire/pull/2347/files/dd3125238ed9bb7d759eafc32cc36fe0fbfee51a |
| src/core/angularfire2.ts | https://github.com/angular/angularfire/pull/2347/files/dd3125238ed9bb7d759eafc32cc36fe0fbfee51a#diff-2ce7227e9f2284851cb129eee23823d15c9eb813f633cf608e58644946fb95f5 |
| jamesdaniels | https://github.com/jamesdaniels |
| Mar 10, 2020 | https://github.com/angular/angularfire/pull/2347#discussion_r390094985 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angularfire/pull/2347 |
| https://github.com/jamesdaniels |
| jamesdaniels | https://github.com/jamesdaniels |
|
Mar 10, 2020
| https://github.com/angular/angularfire/pull/2347#ref-pullrequest-567131518 |
|
Explicitly say that 'firebase/firestore' must be imported
#2333
| https://github.com/angular/angularfire/pull/2333 |
|
| https://github.com/jamesdaniels |
| Adding a sample repo | https://github.com/angular/angularfire/pull/2347/commits/2f26a6d0bc82891194166061a1a84a140d2e740d |
| 2f26a6d | https://github.com/angular/angularfire/pull/2347/commits/2f26a6d0bc82891194166061a1a84a140d2e740d |
|
universal prerendering fails with: import 'firebase/firestore'
#2350
| https://github.com/angular/angularfire/issues/2350 |
|
Version 5.4.2 breaks Angular Universal server rendering
#2341
| https://github.com/angular/angularfire/issues/2341 |
| https://github.com/jamesdaniels |
| jamesdaniels | https://github.com/jamesdaniels |
| March 30, 2020 16:58 | https://github.com/angular/angularfire/pull/2347#event-3179585987 |
| jamesdaniels | https://github.com/jamesdaniels |
| March 30, 2020 15:50 | https://github.com/angular/angularfire/pull/2347#commits-pushed-968ffd1 |
|
| https://github.com/jamesdaniels |
| Drop updateMetatdata | https://github.com/angular/angularfire/pull/2347/commits/968ffd17ef9c18982d728ea6ac186d0b9cda4aa4 |
| 968ffd1 | https://github.com/angular/angularfire/pull/2347/commits/968ffd17ef9c18982d728ea6ac186d0b9cda4aa4 |
|
| https://github.com/jamesdaniels |
| Merged master. | https://github.com/angular/angularfire/pull/2347/commits/8092aeeed2e1892c4512f111b12a1ef6439ffb44 |
| 8092aee | https://github.com/angular/angularfire/pull/2347/commits/8092aeeed2e1892c4512f111b12a1ef6439ffb44 |
|
| https://github.com/jamesdaniels |
| Fix the zone tests | https://github.com/angular/angularfire/pull/2347/commits/de8f05f8e9e683bc23ad322f2b3c8ec1014a0f04 |
| de8f05f | https://github.com/angular/angularfire/pull/2347/commits/de8f05f8e9e683bc23ad322f2b3c8ec1014a0f04 |
|
| https://github.com/jamesdaniels |
| Drop the manual side-effect imports | https://github.com/angular/angularfire/pull/2347/commits/4c1820d182f4296c00657b69bd2af6b3fe511347 |
| 4c1820d | https://github.com/angular/angularfire/pull/2347/commits/4c1820d182f4296c00657b69bd2af6b3fe511347 |
| https://github.com/jamesdaniels |
| jamesdaniels | https://github.com/jamesdaniels |
| d91965e | https://github.com/angular/angularfire/commit/d91965ed9e9b3918387a40c8bf5b2c3ab604054d |
| Mar 30, 2020 | https://github.com/angular/angularfire/pull/2347#event-3180462442 |
| https://github.com/jamesdaniels |
| jamesdaniels | https://github.com/jamesdaniels |
| March 30, 2020 20:56 | https://github.com/angular/angularfire/pull/2347#event-3180462504 |
| https://github.co/hiddenchars |
| https://github.com/angular/angularfire/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F2347 |
|
cla: yes
| https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Please reload this page | https://github.com/angular/angularfire/pull/2347 |
|
| https://github.com/jamesdaniels |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |