René's URL Explorer Experiment


Title: Fixing some stuff since rc-1 by jamesdaniels · Pull Request #2347 · angular/angularfire · GitHub

Open Graph Title: Fixing some stuff since rc-1 by jamesdaniels · Pull Request #2347 · angular/angularfire

X Title: Fixing some stuff since rc-1 by jamesdaniels · Pull Request #2347 · angular/angularfire

Description: Angular + Firebase = ❤️. Contribute to angular/angularfire development by creating an account on GitHub.

Open Graph Description: Checklist Issue number for this PR: #nnn (required) Docs included?: (yes/no; required for all API/functional changes) Test units included?: (yes/no; required) In a clean directory, yarn install, y...

X Description: Checklist Issue number for this PR: #nnn (required) Docs included?: (yes/no; required for all API/functional changes) Test units included?: (yes/no; required) In a clean directory, yarn install, y...

Opengraph URL: https://github.com/angular/angularfire/pull/2347

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9c892149-b4a6-4db9-9b8b-92a7a8a6332d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8C76:1F5D45:10C4A1F:1693EA4:6A5AA93A
html-safe-nonce53a21b284337dd74b7c324592a3340840ab754c960a910027aff3f8e3af3b51e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Qzc2OjFGNUQ0NToxMEM0QTFGOjE2OTNFQTQ6NkE1QUE5M0EiLCJ2aXNpdG9yX2lkIjoiMjIyNTk2NTkzNTA3NjQ4NTQzNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1efad0c3e99e9a4dfbbb15a33f0e0294f3cbe59e94d1772eadaabed32ffe1dbb
hovercard-subject-tagpull_request:385933819
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angularfire/2347/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/43f386b71924d0b8ee92597c7ba3bdbe6a78d99b7e4bc83c9f1e85141c6515f0/angular/angularfire/pull/2347
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/43f386b71924d0b8ee92597c7ba3bdbe6a78d99b7e4bc83c9f1e85141c6515f0/angular/angularfire/pull/2347
og:image:altChecklist Issue number for this PR: #nnn (required) Docs included?: (yes/no; required for all API/functional changes) Test units included?: (yes/no; required) In a clean directory, yarn install, y...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejamesdaniels
hostnamegithub.com
expected-hostnamegithub.com
None17a57ee6ab03686731c491fccb57e6a97c066a29d7cdf1a7d83c46f5c56684fc
turbo-cache-controlno-cache
go-importgithub.com/angular/angularfire git https://github.com/angular/angularfire.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id49453413
octolytics-dimension-repository_nwoangular/angularfire
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49453413
octolytics-dimension-repository_network_root_nwoangular/angularfire
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5cb870aa6b86b87be75e23ca7caec54726a25af9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angularfire/pull/2347#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F2347
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F2347
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangularfire
Reloadhttps://github.com/angular/angularfire/pull/2347
Reloadhttps://github.com/angular/angularfire/pull/2347
Reloadhttps://github.com/angular/angularfire/pull/2347
Please reload this pagehttps://github.com/angular/angularfire/pull/2347
angular https://github.com/angular
angularfirehttps://github.com/angular/angularfire
Notifications https://github.com/login?return_to=%2Fangular%2Fangularfire
Fork 2.2k https://github.com/login?return_to=%2Fangular%2Fangularfire
Star 7.8k https://github.com/login?return_to=%2Fangular%2Fangularfire
Code https://github.com/angular/angularfire
Issues 295 https://github.com/angular/angularfire/issues
Pull requests 20 https://github.com/angular/angularfire/pulls
Discussions https://github.com/angular/angularfire/discussions
Actions https://github.com/angular/angularfire/actions
Projects https://github.com/angular/angularfire/projects
Security and quality 0 https://github.com/angular/angularfire/security
Insights https://github.com/angular/angularfire/pulse
Code https://github.com/angular/angularfire
Issues https://github.com/angular/angularfire/issues
Pull requests https://github.com/angular/angularfire/pulls
Discussions https://github.com/angular/angularfire/discussions
Actions https://github.com/angular/angularfire/actions
Projects https://github.com/angular/angularfire/projects
Security and quality https://github.com/angular/angularfire/security
Insights https://github.com/angular/angularfire/pulse
jamesdanielshttps://github.com/jamesdaniels
masterhttps://github.com/angular/angularfire/tree/master
rc1-fixeshttps://github.com/angular/angularfire/tree/rc1-fixes
Conversationhttps://github.com/angular/angularfire/pull/2347
Commits6 (6)https://github.com/angular/angularfire/pull/2347/commits
Checkshttps://github.com/angular/angularfire/pull/2347/checks
Files changedhttps://github.com/angular/angularfire/pull/2347/files
Fixing some stuff since rc-1https://github.com/angular/angularfire/pull/2347#top
jamesdanielshttps://github.com/jamesdaniels
masterhttps://github.com/angular/angularfire/tree/master
rc1-fixeshttps://github.com/angular/angularfire/tree/rc1-fixes
https://github.com/jamesdaniels
jamesdanielshttps://github.com/jamesdaniels
Mar 10, 2020https://github.com/angular/angularfire/pull/2347#issue-578332880
Please reload this pagehttps://github.com/angular/angularfire/pull/2347
https://github.com/jamesdaniels
Fixing some stuff since rc-1https://github.com/angular/angularfire/pull/2347/commits/dd3125238ed9bb7d759eafc32cc36fe0fbfee51a
dd31252https://github.com/angular/angularfire/pull/2347/commits/dd3125238ed9bb7d759eafc32cc36fe0fbfee51a
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Mar 10, 2020https://github.com/angular/angularfire/pull/2347#event-3113234624
https://github.com/jamesdaniels
jamesdanielshttps://github.com/jamesdaniels
Mar 10, 2020 https://github.com/angular/angularfire/pull/2347#pullrequestreview-371681340
View reviewed changes https://github.com/angular/angularfire/pull/2347/files/dd3125238ed9bb7d759eafc32cc36fe0fbfee51a
src/storage/ref.tshttps://github.com/angular/angularfire/pull/2347/files/dd3125238ed9bb7d759eafc32cc36fe0fbfee51a#diff-ada97e2e27f41636c89d284cd5f77b9bb1c1dd41ed10de4d9eab85264582867a
jamesdanielshttps://github.com/jamesdaniels
Mar 10, 2020https://github.com/angular/angularfire/pull/2347#discussion_r390094873
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angularfire/pull/2347
https://github.com/jamesdaniels
jamesdanielshttps://github.com/jamesdaniels
Mar 10, 2020 https://github.com/angular/angularfire/pull/2347#pullrequestreview-371681491
View reviewed changes https://github.com/angular/angularfire/pull/2347/files/dd3125238ed9bb7d759eafc32cc36fe0fbfee51a
src/core/angularfire2.tshttps://github.com/angular/angularfire/pull/2347/files/dd3125238ed9bb7d759eafc32cc36fe0fbfee51a#diff-2ce7227e9f2284851cb129eee23823d15c9eb813f633cf608e58644946fb95f5
jamesdanielshttps://github.com/jamesdaniels
Mar 10, 2020https://github.com/angular/angularfire/pull/2347#discussion_r390094985
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angularfire/pull/2347
https://github.com/jamesdaniels
jamesdanielshttps://github.com/jamesdaniels
Mar 10, 2020 https://github.com/angular/angularfire/pull/2347#ref-pullrequest-567131518
Explicitly say that 'firebase/firestore' must be imported #2333 https://github.com/angular/angularfire/pull/2333
https://github.com/jamesdaniels
Adding a sample repohttps://github.com/angular/angularfire/pull/2347/commits/2f26a6d0bc82891194166061a1a84a140d2e740d
2f26a6dhttps://github.com/angular/angularfire/pull/2347/commits/2f26a6d0bc82891194166061a1a84a140d2e740d
universal prerendering fails with: import 'firebase/firestore' #2350 https://github.com/angular/angularfire/issues/2350
Version 5.4.2 breaks Angular Universal server rendering #2341 https://github.com/angular/angularfire/issues/2341
https://github.com/jamesdaniels
jamesdanielshttps://github.com/jamesdaniels
March 30, 2020 16:58https://github.com/angular/angularfire/pull/2347#event-3179585987
jamesdanielshttps://github.com/jamesdaniels
March 30, 2020 15:50https://github.com/angular/angularfire/pull/2347#commits-pushed-968ffd1
https://github.com/jamesdaniels
Drop updateMetatdatahttps://github.com/angular/angularfire/pull/2347/commits/968ffd17ef9c18982d728ea6ac186d0b9cda4aa4
968ffd1https://github.com/angular/angularfire/pull/2347/commits/968ffd17ef9c18982d728ea6ac186d0b9cda4aa4
https://github.com/jamesdaniels
Merged master.https://github.com/angular/angularfire/pull/2347/commits/8092aeeed2e1892c4512f111b12a1ef6439ffb44
8092aeehttps://github.com/angular/angularfire/pull/2347/commits/8092aeeed2e1892c4512f111b12a1ef6439ffb44
https://github.com/jamesdaniels
Fix the zone testshttps://github.com/angular/angularfire/pull/2347/commits/de8f05f8e9e683bc23ad322f2b3c8ec1014a0f04
de8f05fhttps://github.com/angular/angularfire/pull/2347/commits/de8f05f8e9e683bc23ad322f2b3c8ec1014a0f04
https://github.com/jamesdaniels
Drop the manual side-effect importshttps://github.com/angular/angularfire/pull/2347/commits/4c1820d182f4296c00657b69bd2af6b3fe511347
4c1820dhttps://github.com/angular/angularfire/pull/2347/commits/4c1820d182f4296c00657b69bd2af6b3fe511347
https://github.com/jamesdaniels
jamesdanielshttps://github.com/jamesdaniels
d91965ehttps://github.com/angular/angularfire/commit/d91965ed9e9b3918387a40c8bf5b2c3ab604054d
Mar 30, 2020https://github.com/angular/angularfire/pull/2347#event-3180462442
https://github.com/jamesdaniels
jamesdanielshttps://github.com/jamesdaniels
March 30, 2020 20:56https://github.com/angular/angularfire/pull/2347#event-3180462504
https://github.co/hiddenchars
https://github.com/angular/angularfire/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F2347
cla: yes https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Please reload this pagehttps://github.com/angular/angularfire/pull/2347
https://github.com/jamesdaniels
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.