| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:358cfa1b-3f05-9816-c29c-4bb49aa66a1e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 99B6:84D9B:1A70EEE:259AB43:6A5A3BF1 |
| html-safe-nonce | 1b35b950ed2517215483a7dbe15a798e3d00446db0430a084635b3bdb9eab8d6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OUI2Ojg0RDlCOjFBNzBFRUU6MjU5QUI0Mzo2QTVBM0JGMSIsInZpc2l0b3JfaWQiOiIxODkzMTk3NzI3MzE3NzY5MjAxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | f401129669fb0ceed56473b1231ef35a2afb6063d65b038cc149026c30d54021 |
| hovercard-subject-tag | pull_request:223639404 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angularfire/1920/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/76eb6d25dc3863f3f1deda0d36c8c5e6da184919f946f340b3d0fdb4935c941a/angular/angularfire/pull/1920 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/76eb6d25dc3863f3f1deda0d36c8c5e6da184919f946f340b3d0fdb4935c941a/angular/angularfire/pull/1920 |
| og:image:alt | Checklist
Issue number for this PR: Support for multiple tabs #1907, Support functions region #1874 (required)
Docs included?: no, beta feature & don't have advanced config docs yet
Test u... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jamesdaniels |
| hostname | github.com |
| expected-hostname | github.com |
| None | 19c67ad7579d2401ff06e88a32ef45460fbb40fab3191c7f7582d5e166f326fc |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angularfire git https://github.com/angular/angularfire.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 49453413 |
| octolytics-dimension-repository_nwo | angular/angularfire |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 49453413 |
| octolytics-dimension-repository_network_root_nwo | angular/angularfire |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e618485bff22dab2ef1ffb4e34e4e6626688df69 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/angular/angularfire/pull/1920#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F1920 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F1920 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangularfire |
| Reload | https://github.com/angular/angularfire/pull/1920 |
| Reload | https://github.com/angular/angularfire/pull/1920 |
| Reload | https://github.com/angular/angularfire/pull/1920 |
| Please reload this page | https://github.com/angular/angularfire/pull/1920 |
|
angular
| https://github.com/angular |
| angularfire | https://github.com/angular/angularfire |
|
Notifications
| https://github.com/login?return_to=%2Fangular%2Fangularfire |
|
Fork
2.2k
| https://github.com/login?return_to=%2Fangular%2Fangularfire |
|
Star
7.8k
| https://github.com/login?return_to=%2Fangular%2Fangularfire |
|
Code
| https://github.com/angular/angularfire |
|
Issues
295
| https://github.com/angular/angularfire/issues |
|
Pull requests
20
| https://github.com/angular/angularfire/pulls |
|
Discussions
| https://github.com/angular/angularfire/discussions |
|
Actions
| https://github.com/angular/angularfire/actions |
|
Projects
| https://github.com/angular/angularfire/projects |
|
Security and quality
0
| https://github.com/angular/angularfire/security |
|
Insights
| https://github.com/angular/angularfire/pulse |
|
Code
| https://github.com/angular/angularfire |
|
Issues
| https://github.com/angular/angularfire/issues |
|
Pull requests
| https://github.com/angular/angularfire/pulls |
|
Discussions
| https://github.com/angular/angularfire/discussions |
|
Actions
| https://github.com/angular/angularfire/actions |
|
Projects
| https://github.com/angular/angularfire/projects |
|
Security and quality
| https://github.com/angular/angularfire/security |
|
Insights
| https://github.com/angular/angularfire/pulse |
| davideast | https://github.com/davideast |
| master | https://github.com/angular/angularfire/tree/master |
| firebase_5_5 | https://github.com/angular/angularfire/tree/firebase_5_5 |
| Conversation | https://github.com/angular/angularfire/pull/1920 |
| Commits9 (9) | https://github.com/angular/angularfire/pull/1920/commits |
| Checks | https://github.com/angular/angularfire/pull/1920/checks |
| Files changed | https://github.com/angular/angularfire/pull/1920/files |
| 5.1 release: support Firebase 5.5, multi-tab sync, function region selection, and Angular 7 | https://github.com/angular/angularfire/pull/1920#top |
| davideast | https://github.com/davideast |
| master | https://github.com/angular/angularfire/tree/master |
| firebase_5_5 | https://github.com/angular/angularfire/tree/firebase_5_5 |
|
| https://github.com/jamesdaniels |
| jamesdaniels | https://github.com/jamesdaniels |
| Oct 17, 2018 | https://github.com/angular/angularfire/pull/1920#issue-371122332 |
| Please reload this page | https://github.com/angular/angularfire/pull/1920 |
| Support for multiple tabs #1907 | https://github.com/angular/angularfire/issues/1907 |
| Support functions region #1874 | https://github.com/angular/angularfire/issues/1874 |
| Please reload this page | https://github.com/angular/angularfire/pull/1920 |
| jamesdaniels | https://github.com/jamesdaniels |
| October 17, 2018 15:43 | https://github.com/angular/angularfire/pull/1920#commits-pushed-a9cf1ca |
|
| https://github.com/jamesdaniels |
| feat(afs): Support Firebase 5.5 and Firestore PersistenceSettings | https://github.com/angular/angularfire/pull/1920/commits/a9cf1ca010c859761cb0ca546a5e4b861782a250 |
| a9cf1ca | https://github.com/angular/angularfire/pull/1920/commits/a9cf1ca010c859761cb0ca546a5e4b861782a250 |
|
| https://github.com/jamesdaniels |
| chore(): Now that app types are mostly fixed, pull from those | https://github.com/angular/angularfire/pull/1920/commits/d1b4852a517465c1d56be9d6e519633194ca9f21 |
| d1b4852 | https://github.com/angular/angularfire/pull/1920/commits/d1b4852a517465c1d56be9d6e519633194ca9f21 |
|
| https://github.com/jamesdaniels |
| chore(): Changelog entry for 5.1 | https://github.com/angular/angularfire/pull/1920/commits/32d8a3ddfbf43956d6c4c26c88e2a98400f46244 |
| 32d8a3d | https://github.com/angular/angularfire/pull/1920/commits/32d8a3ddfbf43956d6c4c26c88e2a98400f46244 |
| https://github.com/jamesdaniels |
| jamesdaniels | https://github.com/jamesdaniels |
| Oct 17, 2018 | https://github.com/angular/angularfire/pull/1920#event-1909816003 |
| https://github.com/jamesdaniels |
| jamesdaniels | https://github.com/jamesdaniels |
| davideast | https://github.com/davideast |
| October 17, 2018 14:59 | https://github.com/angular/angularfire/pull/1920#event-1909816012 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Oct 17, 2018 | https://github.com/angular/angularfire/pull/1920#event-1909816154 |
| https://github.com/jamesdaniels |
| jamesdaniels | https://github.com/jamesdaniels |
|
Oct 17, 2018
| https://github.com/angular/angularfire/pull/1920#pullrequestreview-165679982 |
|
View reviewed changes
| https://github.com/angular/angularfire/pull/1920/files/32d8a3ddfbf43956d6c4c26c88e2a98400f46244 |
| src/firestore/firestore.module.ts | https://github.com/angular/angularfire/pull/1920/files/32d8a3ddfbf43956d6c4c26c88e2a98400f46244#diff-49298a864f2fabd4c66baf78d702135c8ff8a9909468d6bc0c97a51b012b56af |
| jamesdaniels | https://github.com/jamesdaniels |
| Oct 17, 2018 | https://github.com/angular/angularfire/pull/1920#discussion_r225968577 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angularfire/pull/1920 |
|
| https://github.com/jamesdaniels |
| chore(): Use PersistenceSettings from interfaces, also fix types in f… | https://github.com/angular/angularfire/pull/1920/commits/fa9212479979491227ea4f1d8de85e69c65ac3e8 |
| fa92124 | https://github.com/angular/angularfire/pull/1920/commits/fa9212479979491227ea4f1d8de85e69c65ac3e8 |
| https://github.com/lehno |
| lehno | https://github.com/lehno |
| Oct 18, 2018 | https://github.com/angular/angularfire/pull/1920#issuecomment-430968429 |
| Please reload this page | https://github.com/angular/angularfire/pull/1920 |
| jamesdaniels | https://github.com/jamesdaniels |
| October 19, 2018 01:49 | https://github.com/angular/angularfire/pull/1920#commits-pushed-cfb92e5 |
|
| https://github.com/jamesdaniels |
| fix(afs): Fix constructor ordering so this isn't a break | https://github.com/angular/angularfire/pull/1920/commits/cfb92e53d72df0e95d8f42223964c57a0f982016 |
| cfb92e5 | https://github.com/angular/angularfire/pull/1920/commits/cfb92e53d72df0e95d8f42223964c57a0f982016 |
|
| https://github.com/jamesdaniels |
| feat(functions): Support region configuration via FunctionsRegionToken | https://github.com/angular/angularfire/pull/1920/commits/89016173d65b455c7545d1c79439533b035448e5 |
| 8901617 | https://github.com/angular/angularfire/pull/1920/commits/89016173d65b455c7545d1c79439533b035448e5 |
|
| https://github.com/jamesdaniels |
| chore(): Changelog entry for region selection | https://github.com/angular/angularfire/pull/1920/commits/db31f3154e97e149efe19178ca58604c9bb5edc4 |
| db31f31 | https://github.com/angular/angularfire/pull/1920/commits/db31f3154e97e149efe19178ca58604c9bb5edc4 |
| https://github.com/jamesdaniels |
| jamesdaniels | https://github.com/jamesdaniels |
| Oct 19, 2018 | https://github.com/angular/angularfire/pull/1920#event-1913670869 |
| jamesdaniels | https://github.com/jamesdaniels |
| October 19, 2018 02:24 | https://github.com/angular/angularfire/pull/1920#commits-pushed-ed92c45 |
|
| https://github.com/jamesdaniels |
| chore(): Support Angular 7 without peer dependency warnings | https://github.com/angular/angularfire/pull/1920/commits/ed92c45ef352a83363461387c3c07846f00fcd13 |
| ed92c45 | https://github.com/angular/angularfire/pull/1920/commits/ed92c45ef352a83363461387c3c07846f00fcd13 |
|
| https://github.com/jamesdaniels |
| chore(): Changelog for Angular 7 | https://github.com/angular/angularfire/pull/1920/commits/4eb34f95990a06d0261b7f1b3976361bda9e8625 |
| 4eb34f9 | https://github.com/angular/angularfire/pull/1920/commits/4eb34f95990a06d0261b7f1b3976361bda9e8625 |
| https://github.com/jamesdaniels |
| jamesdaniels | https://github.com/jamesdaniels |
| Oct 19, 2018 | https://github.com/angular/angularfire/pull/1920#event-1913702386 |
| https://github.com/jamesdaniels |
| jamesdaniels | https://github.com/jamesdaniels |
|
Oct 19, 2018
| https://github.com/angular/angularfire/pull/1920#ref-pullrequest-371759950 |
|
6.0 release: Angular 7
#1922
| https://github.com/angular/angularfire/pull/1922 |
| https://github.com/Splaktar |
| Splaktar | https://github.com/Splaktar |
|
Oct 19, 2018
| https://github.com/angular/angularfire/pull/1920#pullrequestreview-166460763 |
|
View reviewed changes
| https://github.com/angular/angularfire/pull/1920/files/4eb34f95990a06d0261b7f1b3976361bda9e8625 |
| package.json | https://github.com/angular/angularfire/pull/1920/files/4eb34f95990a06d0261b7f1b3976361bda9e8625#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519 |
| Splaktar | https://github.com/Splaktar |
| Oct 19, 2018 | https://github.com/angular/angularfire/pull/1920#discussion_r226598464 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angularfire/pull/1920 |
| https://github.com/davideast |
| davideast | https://github.com/davideast |
|
Oct 19, 2018
| https://github.com/angular/angularfire/pull/1920#pullrequestreview-166569401 |
|
View reviewed changes
| https://github.com/angular/angularfire/pull/1920/files/4eb34f95990a06d0261b7f1b3976361bda9e8625 |
| davideast | https://github.com/davideast |
| https://github.com/angular/angularfire/pull/1920#pullrequestreview-166569401 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angularfire/pull/1920 |
| https://github.com/davideast |
| davideast | https://github.com/davideast |
| 23464c2 | https://github.com/angular/angularfire/commit/23464c29088602f05bc869226d2120920146bb6a |
| Oct 19, 2018 | https://github.com/angular/angularfire/pull/1920#event-1915023344 |
| https://github.com/davideast |
| davideast | https://github.com/davideast |
| October 19, 2018 15:11 | https://github.com/angular/angularfire/pull/1920#event-1915023450 |
| https://github.com/GulajavaMinistudio |
| GulajavaMinistudio | https://github.com/GulajavaMinistudio |
|
Oct 20, 2018
| https://github.com/angular/angularfire/pull/1920#ref-pullrequest-372229595 |
|
e2e manifests
TypescriptID/angularfire2#50
| https://github.com/TypescriptID/angularfire2/pull/50 |
| https://github.com/achendrick |
| achendrick | https://github.com/achendrick |
|
Oct 25, 2018
| https://github.com/angular/angularfire/pull/1920#ref-issue-373259469 |
|
Calling AngularFireFunctions.httpsCallable results to error 404 because
#1933
| https://github.com/angular/angularfire/issues/1933 |
| https://github.co/hiddenchars |
| https://github.com/angular/angularfire/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F1920 |
|
| https://github.com/davideast |
|
davideast
| https://github.com/davideast |
|
| https://github.com/angular/angularfire/pull/1920/files/4eb34f95990a06d0261b7f1b3976361bda9e8625 |
|
| https://github.com/Splaktar |
|
Splaktar
| https://github.com/Splaktar |
|
| https://github.com/angular/angularfire/pull/1920/files/4eb34f95990a06d0261b7f1b3976361bda9e8625 |
|
| https://github.com/jamesdaniels |
|
jamesdaniels
| https://github.com/jamesdaniels |
|
cla: yes
| https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Please reload this page | https://github.com/angular/angularfire/pull/1920 |
|
| https://github.com/jamesdaniels |
|
| https://github.com/lehno |
|
| https://github.com/Splaktar |
|
| https://github.com/davideast |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |