Title: chore(): lean only on `firebase` types and compatibility with 5.0.4 by jamesdaniels · Pull Request #1729 · angular/angularfire · GitHub
Open Graph Title: chore(): lean only on `firebase` types and compatibility with 5.0.4 by jamesdaniels · Pull Request #1729 · angular/angularfire
X Title: chore(): lean only on `firebase` types and compatibility with 5.0.4 by jamesdaniels · Pull Request #1729 · angular/angularfire
Description: Checklist
Issue number for this PR: #1705
Docs included?: n/a
Test units included?: yes
In a clean directory, yarn install, yarn test run successfully? yes
Description
Was mistakenly using types exported from firebase/* which are pulled in from @firebase/*-types hence unstable, now using the more verbose but public firebase types
Similarly importing apps and initializeApp from firebase/app is reaching through to @firebase/app which isn't stable (and the exports aren't available in all the entry-points). Again here use the public firebase.apps and firebase.initializeApp. #1705
Sprinkled some
Open Graph Description: Checklist Issue number for this PR: #1705 Docs included?: n/a Test units included?: yes In a clean directory, yarn install, yarn test run successfully? yes Description Was mistakenly using types...
X Description: Checklist Issue number for this PR: #1705 Docs included?: n/a Test units included?: yes In a clean directory, yarn install, yarn test run successfully? yes Description Was mistakenly using types...
Opengraph URL: https://github.com/angular/angularfire/pull/1729
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:d6985ace-6514-0831-69eb-8b0101db00d9 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AFD6:26889C:4FA21F:681D4A:6A5B7391 |
| html-safe-nonce | ebf97c7d32fe69424243447af80288fd5cf691fc4457c9bd764b8baf895efdec |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRkQ2OjI2ODg5Qzo0RkEyMUY6NjgxRDRBOjZBNUI3MzkxIiwidmlzaXRvcl9pZCI6IjUzMjc1OTc4NTgwMzU4MjM1MDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 7e8a49f63acf477e8d0a38d7d2ab1ec2338c83fe8f4220d56d7e9a8414d23c9b |
| hovercard-subject-tag | pull_request:194741319 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angularfire/pull/1729/files |
| twitter:image | https://avatars.githubusercontent.com/u/44975?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/44975?s=400&v=4 |
| og:image:alt | Checklist Issue number for this PR: #1705 Docs included?: n/a Test units included?: yes In a clean directory, yarn install, yarn test run successfully? yes Description Was mistakenly using types... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angularfire git https://github.com/angular/angularfire.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 49453413 |
| octolytics-dimension-repository_nwo | angular/angularfire |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 49453413 |
| octolytics-dimension-repository_network_root_nwo | angular/angularfire |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c975978430e9ad293956f2bbdaf153b1bd84a99 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width