| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:2efc0e9a-8d44-8011-727f-7cb2053534e2 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8072:315591:1FE3D9:29CC76:6A5ACAF2 |
| html-safe-nonce | 3dd58122cdf81e6f61ec3282dafbb291139bbc28ffd761c83a35ec6979fd164a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDcyOjMxNTU5MToxRkUzRDk6MjlDQzc2OjZBNUFDQUYyIiwidmlzaXRvcl9pZCI6IjcwNTAzMDE3NDU3NDM0NDg4MTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 92c824f338610ccf868f2828b61d2b3f7cc0ff33e83b7ea76f8baccb5ed4da3a |
| hovercard-subject-tag | pull_request:194741319 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angularfire/1729/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/2b9f97f98807efb939ecc3d86e3e420b7102d85930c2eaf32f2e872a2404b8a1/angular/angularfire/pull/1729 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2b9f97f98807efb939ecc3d86e3e420b7102d85930c2eaf32f2e872a2404b8a1/angular/angularfire/pull/1729 |
| og:image:alt | Checklist
Issue number for this PR: Angular 6 SSR build issue #1705
Docs included?: n/a
Test units included?: yes
In a clean directory, yarn install, yarn test run successfully? yes
Description
... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jamesdaniels |
| hostname | github.com |
| expected-hostname | github.com |
| None | 887a0902ea4987c46dd44cbc73dfadecb93a29560d7519a576fcecd81716148c |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angularfire git https://github.com/angular/angularfire.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 49453413 |
| octolytics-dimension-repository_nwo | angular/angularfire |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 49453413 |
| octolytics-dimension-repository_network_root_nwo | angular/angularfire |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2606513ce6b72f8b775db6a60283f9cf7d4d70a5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/angular/angularfire/pull/1729#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F1729 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F1729 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangularfire |
| Reload | https://github.com/angular/angularfire/pull/1729 |
| Reload | https://github.com/angular/angularfire/pull/1729 |
| Reload | https://github.com/angular/angularfire/pull/1729 |
| Please reload this page | https://github.com/angular/angularfire/pull/1729 |
|
angular
| https://github.com/angular |
| angularfire | https://github.com/angular/angularfire |
|
Notifications
| https://github.com/login?return_to=%2Fangular%2Fangularfire |
|
Fork
2.2k
| https://github.com/login?return_to=%2Fangular%2Fangularfire |
|
Star
7.8k
| https://github.com/login?return_to=%2Fangular%2Fangularfire |
|
Code
| https://github.com/angular/angularfire |
|
Issues
295
| https://github.com/angular/angularfire/issues |
|
Pull requests
20
| https://github.com/angular/angularfire/pulls |
|
Discussions
| https://github.com/angular/angularfire/discussions |
|
Actions
| https://github.com/angular/angularfire/actions |
|
Projects
| https://github.com/angular/angularfire/projects |
|
Security and quality
0
| https://github.com/angular/angularfire/security |
|
Insights
| https://github.com/angular/angularfire/pulse |
|
Code
| https://github.com/angular/angularfire |
|
Issues
| https://github.com/angular/angularfire/issues |
|
Pull requests
| https://github.com/angular/angularfire/pulls |
|
Discussions
| https://github.com/angular/angularfire/discussions |
|
Actions
| https://github.com/angular/angularfire/actions |
|
Projects
| https://github.com/angular/angularfire/projects |
|
Security and quality
| https://github.com/angular/angularfire/security |
|
Insights
| https://github.com/angular/angularfire/pulse |
| davideast | https://github.com/davideast |
| master | https://github.com/angular/angularfire/tree/master |
| 504_and_type_fixes | https://github.com/angular/angularfire/tree/504_and_type_fixes |
| Conversation | https://github.com/angular/angularfire/pull/1729 |
| Commits2 (2) | https://github.com/angular/angularfire/pull/1729/commits |
| Checks | https://github.com/angular/angularfire/pull/1729/checks |
| Files changed | https://github.com/angular/angularfire/pull/1729/files |
| chore(): lean only on firebase types and compatibility with 5.0.4 | https://github.com/angular/angularfire/pull/1729#top |
| davideast | https://github.com/davideast |
| master | https://github.com/angular/angularfire/tree/master |
| 504_and_type_fixes | https://github.com/angular/angularfire/tree/504_and_type_fixes |
|
| https://github.com/jamesdaniels |
| jamesdaniels | https://github.com/jamesdaniels |
| Jun 13, 2018 | https://github.com/angular/angularfire/pull/1729#issue-332198710 |
| Please reload this page | https://github.com/angular/angularfire/pull/1729 |
| Angular 6 SSR build issue #1705 | https://github.com/angular/angularfire/issues/1705 |
| Angular 6 SSR build issue #1705 | https://github.com/angular/angularfire/issues/1705 |
| Please reload this page | https://github.com/angular/angularfire/pull/1729 |
|
| https://github.com/jamesdaniels |
| chore(): lean only on firebase types and compatibility with 5.0.4 | https://github.com/angular/angularfire/pull/1729/commits/eed5802d920c5f9fa0dba9b052409daf981c5389 |
| eed5802 | https://github.com/angular/angularfire/pull/1729/commits/eed5802d920c5f9fa0dba9b052409daf981c5389 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Jun 13, 2018 | https://github.com/angular/angularfire/pull/1729#event-1679958621 |
|
| https://github.com/jamesdaniels |
| chore(): rc.11 version bump and changelog entry | https://github.com/angular/angularfire/pull/1729/commits/f239cc280d91befdb24a60a4180edfd9946098d6 |
| f239cc2 | https://github.com/angular/angularfire/pull/1729/commits/f239cc280d91befdb24a60a4180edfd9946098d6 |
| https://github.com/jamesdaniels |
| jamesdaniels | https://github.com/jamesdaniels |
| davideast | https://github.com/davideast |
| June 13, 2018 23:24 | https://github.com/angular/angularfire/pull/1729#event-1679964762 |
| https://github.com/jamesdaniels |
| jamesdaniels | https://github.com/jamesdaniels |
| Jun 13, 2018 | https://github.com/angular/angularfire/pull/1729#issuecomment-397119363 |
| @davideast | https://github.com/davideast |
| Please reload this page | https://github.com/angular/angularfire/pull/1729 |
| https://github.com/hiepxanh |
| hiepxanh | https://github.com/hiepxanh |
| Jun 14, 2018 | https://github.com/angular/angularfire/pull/1729#issuecomment-397142733 |
| Please reload this page | https://github.com/angular/angularfire/pull/1729 |
| this error | https://github.com/angular/angularfire2/issues/1728 |
| Please reload this page | https://github.com/angular/angularfire/pull/1729 |
| https://github.com/yharaskrik |
| yharaskrik | https://github.com/yharaskrik |
| Jun 15, 2018 | https://github.com/angular/angularfire/pull/1729#issuecomment-397478181 |
| Please reload this page | https://github.com/angular/angularfire/pull/1729 |
| https://github.com/davideast |
| davideast | https://github.com/davideast |
|
Jun 20, 2018
| https://github.com/angular/angularfire/pull/1729#pullrequestreview-130349465 |
|
View reviewed changes
| https://github.com/angular/angularfire/pull/1729/files/f239cc280d91befdb24a60a4180edfd9946098d6 |
| davideast | https://github.com/davideast |
| https://github.com/angular/angularfire/pull/1729#pullrequestreview-130349465 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angularfire/pull/1729 |
| https://github.com/davideast |
| davideast | https://github.com/davideast |
| 30db0aa | https://github.com/angular/angularfire/commit/30db0aac528e4e5df7aa29711dd8bab677b2adf5 |
| Jun 20, 2018 | https://github.com/angular/angularfire/pull/1729#event-1690893600 |
| https://github.com/davideast |
| davideast | https://github.com/davideast |
| June 20, 2018 11:31 | https://github.com/angular/angularfire/pull/1729#event-1690893714 |
| https://github.com/GulajavaMinistudio |
| GulajavaMinistudio | https://github.com/GulajavaMinistudio |
|
Jun 21, 2018
| https://github.com/angular/angularfire/pull/1729#ref-pullrequest-334485400 |
|
Update upstream
TypescriptID/angularfire2#42
| https://github.com/TypescriptID/angularfire2/pull/42 |
| https://github.co/hiddenchars |
| https://github.com/angular/angularfire/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F1729 |
|
| https://github.com/davideast |
|
davideast
| https://github.com/davideast |
|
| https://github.com/angular/angularfire/pull/1729/files/f239cc280d91befdb24a60a4180edfd9946098d6 |
|
cla: yes
| https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Please reload this page | https://github.com/angular/angularfire/pull/1729 |
|
| https://github.com/jamesdaniels |
|
| https://github.com/hiepxanh |
|
| https://github.com/yharaskrik |
|
| https://github.com/davideast |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |