René's URL Explorer Experiment


Title: fix(core): only import typing from zone.js by JiaLiPassion · Pull Request #1599 · angular/angularfire · GitHub

Open Graph Title: fix(core): only import typing from zone.js by JiaLiPassion · Pull Request #1599 · angular/angularfire

X Title: fix(core): only import typing from zone.js by JiaLiPassion · Pull Request #1599 · angular/angularfire

Description: Checklist Issue number for this PR: #1597 (required) Docs included?: no (yes/no; required for all API/functional changes) Test units included?: no (yes/no; required) In a clean directory, yarn install, yarn test run successfully? yes (yes/no; required) Description Should only import {} from 'zone.js' to import typing, but not import zone.js again, otherwise it will report Zone is already loaded error. Code sample @jamesdaniels , please review, thank you.

Open Graph Description: Checklist Issue number for this PR: #1597 (required) Docs included?: no (yes/no; required for all API/functional changes) Test units included?: no (yes/no; required) In a clean directory, yarn in...

X Description: Checklist Issue number for this PR: #1597 (required) Docs included?: no (yes/no; required for all API/functional changes) Test units included?: no (yes/no; required) In a clean directory, yarn in...

Opengraph URL: https://github.com/angular/angularfire/pull/1599

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:73d41276-b49c-a973-e1f9-4255ae462388
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAE82:EA06E:E89808:12AFD7A:6B00F674
html-safe-nonce976a2acf92d6925b60f5cae07bc8118b5d744810f7a870940f46581e1e22b63d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRTgyOkVBMDZFOkU4OTgwODoxMkFGRDdBOjZCMDBGNjc0IiwidmlzaXRvcl9pZCI6IjU3MzA4NzQyNjMyNzYxNTY1MzIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb8ef2093c27377af5f8906de4317a6b27463268b3b1688f2bd2d5c14693c0504
hovercard-subject-tagpull_request:186167178
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angularfire/pull/1599/files
twitter:imagehttps://avatars.githubusercontent.com/u/1442575?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1442575?s=400&v=4
og:image:altChecklist Issue number for this PR: #1597 (required) Docs included?: no (yes/no; required for all API/functional changes) Test units included?: no (yes/no; required) In a clean directory, yarn in...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angularfire git https://github.com/angular/angularfire.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id49453413
octolytics-dimension-repository_nwoangular/angularfire
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49453413
octolytics-dimension-repository_network_root_nwoangular/angularfire
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angularfire/pull/1599/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F1599%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fpull%2F1599%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangularfire
Reloadhttps://github.com/angular/angularfire/pull/1599/files
Reloadhttps://github.com/angular/angularfire/pull/1599/files
Reloadhttps://github.com/angular/angularfire/pull/1599/files
angularhttps://github.com/angular
angularfirehttps://github.com/angular/angularfire
Codehttps://github.com/angular/angularfire
Issues162 (162)https://github.com/angular/angularfire/issues
Pull requests5 (5)https://github.com/angular/angularfire/pulls
Discussionshttps://github.com/angular/angularfire/discussions
Actionshttps://github.com/angular/angularfire/actions
Projectshttps://github.com/angular/angularfire/projects
Security and qualityhttps://github.com/angular/angularfire/security
Insightshttps://github.com/angular/angularfire/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangularfire%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangularfire%2Fissues%2Fnew%2Fchoose
jamesdanielshttps://github.com/jamesdaniels
angular:masterhttps://github.com/angular/angularfire/tree/master
JiaLiPassion:issue-1597https://github.com/JiaLiPassion/angularfire2/tree/issue-1597
Conversation 8 https://github.com/angular/angularfire/pull/1599
Commits 1 https://github.com/angular/angularfire/pull/1599/commits
Checks 0 https://github.com/angular/angularfire/pull/1599/checks
Files changed https://github.com/angular/angularfire/pull/1599/files
Please reload this pagehttps://github.com/angular/angularfire/pull/1599/files
fix(core): only import typing from zone.js https://github.com/angular/angularfire/pull/1599/files#top
Show all changes 1 commit https://github.com/angular/angularfire/pull/1599/files
aefedc2 fix(core): only import typing from zone.js JiaLiPassion May 5, 2018 https://github.com/angular/angularfire/pull/1599/commits/aefedc2af5026e00b6344ff3d9249ecf7dbf6c7b
Clear filters https://github.com/angular/angularfire/pull/1599/files
Please reload this pagehttps://github.com/angular/angularfire/pull/1599/files
Please reload this pagehttps://github.com/angular/angularfire/pull/1599/files
src/core/angularfire2.tshttps://github.com/angular/angularfire/pull/1599/files#diff-2ce7227e9f2284851cb129eee23823d15c9eb813f633cf608e58644946fb95f5
View file https://github.com/JiaLiPassion/angularfire2/blob/aefedc2af5026e00b6344ff3d9249ecf7dbf6c7b/src/core/angularfire2.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angularfire/pull/1599/{{ revealButtonHref }}
https://github.com/angular/angularfire/pull/1599/files#diff-2ce7227e9f2284851cb129eee23823d15c9eb813f633cf608e58644946fb95f5
https://github.com/angular/angularfire/pull/1599/files#diff-2ce7227e9f2284851cb129eee23823d15c9eb813f633cf608e58644946fb95f5
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.