René's URL Explorer Experiment


Title: `Branch protection` is skipped, and counts as passing, when a job it waits on fails · Issue #3839 · angular/angularfire · GitHub

Open Graph Title: `Branch protection` is skipped, and counts as passing, when a job it waits on fails · Issue #3839 · angular/angularfire

X Title: `Branch protection` is skipped, and counts as passing, when a job it waits on fails · Issue #3839 · angular/angularfire

Description: While reviewing #3762, @tyler-reitz noticed that the pull request's test jobs had failed while the Branch protection check showed as skipping, and nothing marked the pull request as blocked. I looked into it and it's real. Here is what I...

Open Graph Description: While reviewing #3762, @tyler-reitz noticed that the pull request's test jobs had failed while the Branch protection check showed as skipping, and nothing marked the pull request as blocked. I look...

X Description: While reviewing #3762, @tyler-reitz noticed that the pull request's test jobs had failed while the Branch protection check showed as skipping, and nothing marked the pull request as blocked. I ...

Opengraph URL: https://github.com/angular/angularfire/issues/3839

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.112.3


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`Branch protection` is skipped, and counts as passing, when a job it waits on fails","articleBody":"While reviewing #3762, @tyler-reitz noticed that the pull request's test jobs had failed while the `Branch protection` check showed as skipping, and nothing marked the pull request as blocked. I looked into it and it's real. Here is what I found and the fix I propose.\n\n### What happens\n\n- `.github/workflows/test.yml` ends with a job named `Branch protection` whose only purpose is to wait on `test`, `contribute`, `browser` and `firebase-13` and then run `true`. Together with the CLA check it is the required status check on `main`.\n\n- The job has no `if:` condition. When a job it waits on fails, GitHub skips it instead of failing it.\n\n- GitHub treats a skipped required check as satisfied. Its page on required status checks says \"Successful check statuses are success, skipped, and neutral\", and lists \"a job depends on a failed job\" as a case where \"the dependent job is skipped and may not block merging\".\n\n- `main` also requires one approving review, and a review is not dismissed when later commits are pushed. So a pull request that was approved and then goes red stays mergeable for anyone the protection applies to.\n\n### Where it has shown up\n\n- #3762: on commit 40537e5, 12 test jobs failed and `Branch protection` concluded `skipped`. The approving review was submitted between that commit and the next. The next commit, 77a056f, had 4 failing jobs and the check was skipped again. Only 452c501 turned it green.\n\n- #3831: on commit fe1e281, the three `Test Node 26` jobs failed and `Branch protection` concluded `skipped`.\n\n- No pull request has merged in this state. Each of the last 40 merged pull requests had the check at `success` on its merged head. The gap is latent, but on #3762 it was open for about eleven hours.\n\n### The fix\n\nMake the job run on every outcome and fail itself unless every job it waits on succeeded:\n\n```yaml\n  test_and_contribute:\n    runs-on: ubuntu-latest\n    name: Branch protection\n    needs: ['test', 'contribute', 'browser', 'firebase-13']\n    if: ${{ always() }}\n    steps:\n      - name: Fail unless every needed job succeeded\n        if: ${{ contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled') || contains(needs.*.result, 'skipped') }}\n        run: exit 1\n```\n\nThree details matter:\n\n- `skipped` has to count as a failure. `test`, `browser` and `firebase-13` depend on `build`, so when `build` fails they are skipped rather than failed, while `contribute` builds on its own and can still pass.\n  - Without `skipped` in the condition a broken build would still turn the check green.\n  - On a pull request none of the four jobs can be skipped for any other reason, since none has an `if:` of its own and the `pull_request` trigger has no path filter.\n\n- `always()` rather than the usually recommended `!cancelled()`.\n  - A cancelled run must leave the check red, and with `!cancelled()` the aggregator itself would be skipped on cancellation, which brings the gap back.\n  - GitHub's warning against `always()` is about steps that fetch sources and could hang, which this job does not do.\n\n- The job name does not change, so the branch protection setting needs no edit and no admin.\n\n### Verified\n\nI reproduced both the gap and the fix in a throwaway repository with the same job graph (build, a three-leg test matrix with `fail-fast: false`, browser, an independent contribute, and this job), one pull request per case:\n\n- Old job, one test leg fails: `Branch protection` is `skipped`.\n- Fixed job, one test leg fails: `failure`.\n- Fixed job, build fails: `failure`, through the `skipped` results.\n- Fixed job, run cancelled while the test legs ran: `failure`, through the `cancelled` results.\n- Fixed job, everything passes: `success`.\n\nWith `main` in that repository protected by `Branch protection` as its only required check, GitHub's own merge state per pull request confirms the effect:\n\n- Old job, one test leg fails: `UNSTABLE`, which still allows the merge. Only a non-required check failed, and the skipped required one counts as satisfied.\n- Fixed job, the three failure cases: `BLOCKED`.\n- Fixed job, everything passes: `CLEAN`.\n\nThe same three-condition step is used in public by other projects, for example `ublue-os/akmods`.\n\n### Out of scope here, noted for a separate look\n\n- The release branches `21.1.x`, `21.0.x` and `20.1.x` have no branch protection at all, so a cherry-pick pull request into them needs no green check to merge. Changing that needs an admin.\n\n- `Publish (NPM)` does not wait on `contribute`, so a `contribute`-only failure on `main` still publishes a canary.\n\nThanks to @tyler-reitz for spotting this.\n","author":{"url":"https://github.com/armando-navarro","@type":"Person","name":"armando-navarro"},"datePublished":"2026-11-05T20:14:54Z","url":"https://github.com/angular/angularfire/issues/3839"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:63186e04-ab36-04f8-eb96-7bd15060333c
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA948:187983:3466549:4516E80:6B03601F
html-safe-nonceb87061f078a7d96c7c8d2b34e19895f355f6da2cf2d3590826a6465223f052f2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOTQ4OjE4Nzk4MzozNDY2NTQ5OjQ1MTZFODA6NkIwMzYwMUYiLCJ2aXNpdG9yX2lkIjoiODAyNjY1OTIyNjg2MDUwMzM1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac58e4973a69a7f6d8bc3fbe24b3e61ad7eafda2c8a89c3fd368cea289b51b9889
hovercard-subject-tagissue:6230862496
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angularfire/3839/issue_layout
twitter:imagehttps://opengraph.githubassets.com/d3f0c3c594b2c66f768ba56a00ace0517de843a9d3ba9e562a410ff3fb1798fa/angular/angularfire/issues/3839
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d3f0c3c594b2c66f768ba56a00ace0517de843a9d3ba9e562a410ff3fb1798fa/angular/angularfire/issues/3839
og:image:altWhile reviewing #3762, @tyler-reitz noticed that the pull request's test jobs had failed while the Branch protection check showed as skipping, and nothing marked the pull request as blocked. I look...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamearmando-navarro
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/angular/angularfire git https://github.com/angular/angularfire.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id49453413
octolytics-dimension-repository_nwoangular/angularfire
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49453413
octolytics-dimension-repository_network_root_nwoangular/angularfire
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angularfire/issues/3839#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fissues%2F3839
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fissues%2F3839
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangularfire
Reloadhttps://github.com/angular/angularfire/issues/3839
Reloadhttps://github.com/angular/angularfire/issues/3839
Reloadhttps://github.com/angular/angularfire/issues/3839
angularhttps://github.com/angular
angularfirehttps://github.com/angular/angularfire
Codehttps://github.com/angular/angularfire
Issues162 (162)https://github.com/angular/angularfire/issues
Pull requests5 (5)https://github.com/angular/angularfire/pulls
Discussionshttps://github.com/angular/angularfire/discussions
Actionshttps://github.com/angular/angularfire/actions
Projectshttps://github.com/angular/angularfire/projects
Security and qualityhttps://github.com/angular/angularfire/security
Insightshttps://github.com/angular/angularfire/insights
https://github.com/angular/angularfire
New issuehttps://github.com/login?return_to=https://github.com/angular/angularfire/issues/3839
New issuehttps://github.com/login?return_to=https://github.com/angular/angularfire/issues/3839
#3840https://github.com/angular/angularfire/pull/3840
Branch protection is skipped, and counts as passing, when a job it waits on failshttps://github.com/angular/angularfire/issues/3839#top
#3840https://github.com/angular/angularfire/pull/3840
comp: build/pipelineBuild, bundling, packaging, release pipeline.https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22comp%3A%20build%2Fpipeline%22
type: bugDefect: expected behavior doesn't happen.https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%22
22.0.0-rc.1https://github.com/angular/angularfire/milestone/35
https://github.com/armando-navarro
armando-navarrohttps://github.com/armando-navarro
on Nov 5, 2026https://github.com/angular/angularfire/issues/3839#issue-6230862496
#3762https://github.com/angular/angularfire/pull/3762
@tyler-reitzhttps://github.com/tyler-reitz
fix(schematics): emit AgentPlatformBackend from the v21 AI migration #3762https://github.com/angular/angularfire/pull/3762
40537e5https://github.com/angular/angularfire/commit/40537e596b5a51c6c0933c127ebd16c05d5a1498
77a056fhttps://github.com/angular/angularfire/commit/77a056f473c72f4d9dda88b5e8b9554bc103ec20
452c501https://github.com/angular/angularfire/commit/452c50168bfeb7dd8231e9ce8d30f2be09a5b65f
feat: accept firebase 13 alongside firebase 12 #3831https://github.com/angular/angularfire/pull/3831
fe1e281https://github.com/angular/angularfire/commit/fe1e281814188255c659afdc2eeeb6635c204614
fix(schematics): emit AgentPlatformBackend from the v21 AI migration #3762https://github.com/angular/angularfire/pull/3762
@tyler-reitzhttps://github.com/tyler-reitz
armando-navarrohttps://github.com/armando-navarro
comp: build/pipelineBuild, bundling, packaging, release pipeline.https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22comp%3A%20build%2Fpipeline%22
type: bugDefect: expected behavior doesn't happen.https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%22
on Nov 5, 2026https://github.com/angular/angularfire/issues/3839#event-35282625641
armando-navarrohttps://github.com/armando-navarro
22.0.0-rc.1https://github.com/angular/angularfire/milestone/35
on Nov 5, 2026https://github.com/angular/angularfire/issues/3839#event-35282628379
armando-navarrohttps://github.com/armando-navarro
completedhttps://github.com/angular/angularfire/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#3840https://github.com/angular/angularfire/pull/3840
on Nov 6, 2026https://github.com/angular/angularfire/issues/3839#event-35300999094
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angularfire/issues/3839
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angularfire/issues/3839
comp: build/pipelineBuild, bundling, packaging, release pipeline.https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22comp%3A%20build%2Fpipeline%22
type: bugDefect: expected behavior doesn't happen.https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%22
22.0.0-rc.1https://github.com/angular/angularfire/milestone/35
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlmax-age=0, private, must-revalidate

Viewport: width=device-width


URLs of crawlers that visited me.