René's URL Explorer Experiment


Title: `ɵzoneWrap` ignores a handler passed as an observer object, and holds a wrapped promise forever once its injector is destroyed · Issue #3828 · angular/angularfire · GitHub

Open Graph Title: `ɵzoneWrap` ignores a handler passed as an observer object, and holds a wrapped promise forever once its injector is destroyed · Issue #3828 · angular/angularfire

X Title: `ɵzoneWrap` ignores a handler passed as an observer object, and holds a wrapped promise forever once its injector is destroyed · Issue #3828 · angular/angularfire

Description: Version info Angular: 22.2 Firebase: 12.19.0 AngularFire: 22.0.0-rc.0, and main Description Two defects in ɵzoneWrap (src/zones.ts), the function the generated @angular/fire/* wrappers go through. 1. A handler passed as an object is not ...

Open Graph Description: Version info Angular: 22.2 Firebase: 12.19.0 AngularFire: 22.0.0-rc.0, and main Description Two defects in ɵzoneWrap (src/zones.ts), the function the generated @angular/fire/* wrappers go through. ...

X Description: Version info Angular: 22.2 Firebase: 12.19.0 AngularFire: 22.0.0-rc.0, and main Description Two defects in ɵzoneWrap (src/zones.ts), the function the generated @angular/fire/* wrappers go through. ...

Opengraph URL: https://github.com/angular/angularfire/issues/3828

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.112.4


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`ɵzoneWrap` ignores a handler passed as an observer object, and holds a wrapped promise forever once its injector is destroyed","articleBody":"### Version info\n\n**Angular:** 22.2\n\n**Firebase:** 12.19.0\n\n**AngularFire:** 22.0.0-rc.0, and `main`\n\n### Description\n\nTwo defects in `ɵzoneWrap` (`src/zones.ts`), the function the generated `@angular/fire/*` wrappers go through.\n\n**1. A handler passed as an object is not wrapped.** Firebase accepts a subscription handler either as a function, `onSnapshot(ref, snapshot => ...)`, or as an observer object, `onSnapshot(ref, { next: snapshot => ... })`. The wrapper rewrites an argument only when `typeof` is `'function'`, so the object form reaches the SDK untouched:\n\n- No pending task is registered, so server rendering does not wait for the first value.\n- `inject()` throws inside the handler, because nothing re-enters the injection context.\n- In a zone.js app the handler runs outside the Angular zone, because the wrapper calls Firebase inside `runOutsideAngular` and then never brings the object's members back in. The unwrapped Firebase call made from in-zone code keeps its handler in the zone, so the wrapper makes the object form worse than not wrapping at all.\n\nEleven wrapped functions accept the object form: `onAuthStateChanged`, `onIdTokenChanged`, `onTokenChanged`, `onSnapshot`, `onSnapshotResume`, `onSnapshotsInSync`, `onMessage`, `onRegistered`, `onUnregistered`, `onConfigUpdate` (which accepts only the object form) and data-connect's `subscribe` (whose object uses `onNext`, `onErr` and `onComplete`). The three messaging functions are generated with `blockUntilFirst: false`, so the pending task point does not apply to them.\n\n**2. A wrapped promise never settles after its injector is destroyed.**\n\n- When a wrapped call returns a Promise, the wrapper resolves its own promise through `runInInjectionContext(injector, () => run(() => resolve(value)))`.\n- Neither layer reaches the caller: a `.then` callback runs as a later microtask after the injection context is torn down, and zone.js runs it in the zone where `.then` was attached, not where `resolve` was called.\n- The one thing the layers do is throw: `runInInjectionContext` checks `assertNotDestroyed`, so when the Firebase promise settles after `ApplicationRef.destroy()` or a `TestBed` reset, the callback throws `NG0205` before `resolve` runs and the caller's promise never settles.\n\n### How to reproduce these conditions\n\nOn a zone.js Angular 22.2 app and a zoneless one, against the Firestore emulator, call the real functions through `ɵzoneWrap` the way a constructor does, inside the Angular zone and an injection context, and record inside the handler whether a pending task was registered, whether `inject()` works and whether `NgZone.isInAngularZone()` is true:\n\n- `onSnapshot(ref, { next, error })` and `onSnapshotsInSync(firestore, { next, error })`: no task in either app, `inject()` throws in both, and in the zone.js app the handler runs outside the Angular zone. A plain property written from the handler does not render there, in a component with default change detection.\n- `onSnapshot(ref, next)`, the function form: one task, released when the handler ran, `inject()` works, and in the zone.js app the handler runs inside the zone.\n- The unwrapped `onSnapshot` with either form of handler, called from the same place: `inject()` throws, but in the zone.js app the handler stays inside the zone.\n\nFor the promise defect, a spec: wrap a function that resolves after 20 ms with `ɵzoneWrap(fn, true)`, call it inside `TestBed.runInInjectionContext`, call `TestBed.resetTestingModule()`, then await the returned promise. It never settles and the spec times out after 5 seconds.\n\n### Expected behavior\n\nA handler passed as an observer object gets what a handler passed as a function gets: the pending task, the Angular zone and a working `inject()`. A wrapped promise settles whenever the Firebase promise settles.\n\n### Actual behavior\n\nThe object form gets none of the three, and a wrapped promise that settles after its injector is destroyed never settles.\n","author":{"url":"https://github.com/armando-navarro","@type":"Person","name":"armando-navarro"},"datePublished":"2026-10-30T15:25:03Z","url":"https://github.com/angular/angularfire/issues/3828"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:c6842fa9-453d-61da-8d1b-a9723f9737d0
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC6DE:19AA62:7CE895C:9E0DC63:6B035C25
html-safe-nonce6e14ac6ebe448baf296946bb27908d9e848521b0bdee5179aaf8fce8ad815131
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNkRFOjE5QUE2Mjo3Q0U4OTVDOjlFMERDNjM6NkIwMzVDMjUiLCJ2aXNpdG9yX2lkIjoiMjY0MjYyMDk0NDQwMDczNTI3MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca5513f29da6e913432d712333cb9538444005f676fd72fe5be35fa892a0fb3b6
hovercard-subject-tagissue:6121915278
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angularfire/3828/issue_layout
twitter:imagehttps://opengraph.githubassets.com/2b7cfa1e6d864211e49a7db9e52b5bbdd344f8f97182ca8a5f24884ec48380a4/angular/angularfire/issues/3828
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2b7cfa1e6d864211e49a7db9e52b5bbdd344f8f97182ca8a5f24884ec48380a4/angular/angularfire/issues/3828
og:image:altVersion info Angular: 22.2 Firebase: 12.19.0 AngularFire: 22.0.0-rc.0, and main Description Two defects in ɵzoneWrap (src/zones.ts), the function the generated @angular/fire/* wrappers go through. ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamearmando-navarro
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/angular/angularfire git https://github.com/angular/angularfire.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id49453413
octolytics-dimension-repository_nwoangular/angularfire
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49453413
octolytics-dimension-repository_network_root_nwoangular/angularfire
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angularfire/issues/3828#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fissues%2F3828
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangularfire%2Fissues%2F3828
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangularfire
Reloadhttps://github.com/angular/angularfire/issues/3828
Reloadhttps://github.com/angular/angularfire/issues/3828
Reloadhttps://github.com/angular/angularfire/issues/3828
angularhttps://github.com/angular
angularfirehttps://github.com/angular/angularfire
Codehttps://github.com/angular/angularfire
Issues162 (162)https://github.com/angular/angularfire/issues
Pull requests5 (5)https://github.com/angular/angularfire/pulls
Discussionshttps://github.com/angular/angularfire/discussions
Actionshttps://github.com/angular/angularfire/actions
Projectshttps://github.com/angular/angularfire/projects
Security and qualityhttps://github.com/angular/angularfire/security
Insightshttps://github.com/angular/angularfire/insights
https://github.com/angular/angularfire
New issuehttps://github.com/login?return_to=https://github.com/angular/angularfire/issues/3828
New issuehttps://github.com/login?return_to=https://github.com/angular/angularfire/issues/3828
#3829https://github.com/angular/angularfire/pull/3829
ɵzoneWrap ignores a handler passed as an observer object, and holds a wrapped promise forever once its injector is destroyedhttps://github.com/angular/angularfire/issues/3828#top
#3829https://github.com/angular/angularfire/pull/3829
comp: app-checkApp Check (src/app-check).https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22comp%3A%20app-check%22
comp: coreFirebaseApp DI core (src/app).https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22comp%3A%20core%22
comp: firestoreCloud Firestore (src/firestore).https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22comp%3A%20firestore%22
comp: remote-configRemote Config (src/remote-config).https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22comp%3A%20remote-config%22
comp: zonesChange detection / zone.js / zoneless.https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22comp%3A%20zones%22
type: bugDefect: expected behavior doesn't happen.https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%22
version: current (v17+)Targets the current modular API (v17+).https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22version%3A%20current%20(v17%2B)%22
22.0.0-rc.1https://github.com/angular/angularfire/milestone/35
https://github.com/armando-navarro
armando-navarrohttps://github.com/armando-navarro
on Oct 30, 2026https://github.com/angular/angularfire/issues/3828#issue-6121915278
armando-navarrohttps://github.com/armando-navarro
comp: app-checkApp Check (src/app-check).https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22comp%3A%20app-check%22
comp: coreFirebaseApp DI core (src/app).https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22comp%3A%20core%22
comp: firestoreCloud Firestore (src/firestore).https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22comp%3A%20firestore%22
comp: remote-configRemote Config (src/remote-config).https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22comp%3A%20remote-config%22
comp: zonesChange detection / zone.js / zoneless.https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22comp%3A%20zones%22
type: bugDefect: expected behavior doesn't happen.https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%22
version: current (v17+)Targets the current modular API (v17+).https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22version%3A%20current%20(v17%2B)%22
on Oct 30, 2026https://github.com/angular/angularfire/issues/3828#event-34705074909
armando-navarrohttps://github.com/armando-navarro
22.0.0-rc.1https://github.com/angular/angularfire/milestone/35
on Nov 5, 2026https://github.com/angular/angularfire/issues/3828#event-35276690175
armando-navarrohttps://github.com/armando-navarro
completedhttps://github.com/angular/angularfire/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#3829https://github.com/angular/angularfire/pull/3829
on Nov 5, 2026https://github.com/angular/angularfire/issues/3828#event-35287337423
armando-navarrohttps://github.com/armando-navarro
on Nov 5, 2026https://github.com/angular/angularfire/issues/3828#event-35293004848
docs: say a handler passed as an observer object is wrapped toohttps://github.com/armando-navarro/angularfire/commit/1c85fbe1d0e0e77618b98cbbaf8478b71953f7c3
1c85fbehttps://github.com/armando-navarro/angularfire/commit/1c85fbe1d0e0e77618b98cbbaf8478b71953f7c3
armando-navarrohttps://github.com/armando-navarro
on Nov 13, 2026https://github.com/angular/angularfire/issues/3828#event-36059251361
docs: document the 22.0.0-rc.1 changes (#3835)https://github.com/angular/angularfire/commit/ba0721848232d59ed9268347bbe5fbea34484a0e
#3835https://github.com/angular/angularfire/pull/3835
ba07218https://github.com/angular/angularfire/commit/ba0721848232d59ed9268347bbe5fbea34484a0e
docs: cover zone fixes, the server app helper and compat setup (#3835)https://github.com/angular/angularfire/commit/f4d5c2c6486afcec822a1e6fa7100687c97c89a9
#3835https://github.com/angular/angularfire/pull/3835
f4d5c2chttps://github.com/angular/angularfire/commit/f4d5c2c6486afcec822a1e6fa7100687c97c89a9
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angularfire/issues/3828
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angularfire/issues/3828
comp: app-checkApp Check (src/app-check).https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22comp%3A%20app-check%22
comp: coreFirebaseApp DI core (src/app).https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22comp%3A%20core%22
comp: firestoreCloud Firestore (src/firestore).https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22comp%3A%20firestore%22
comp: remote-configRemote Config (src/remote-config).https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22comp%3A%20remote-config%22
comp: zonesChange detection / zone.js / zoneless.https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22comp%3A%20zones%22
type: bugDefect: expected behavior doesn't happen.https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%22
version: current (v17+)Targets the current modular API (v17+).https://github.com/angular/angularfire/issues?q=state%3Aopen%20label%3A%22version%3A%20current%20(v17%2B)%22
22.0.0-rc.1https://github.com/angular/angularfire/milestone/35
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlmax-age=0, private, must-revalidate

Viewport: width=device-width


URLs of crawlers that visited me.