Title: `ɵzoneWrap` ignores a handler passed as an observer object, and holds a wrapped promise forever once its injector is destroyed · Issue #3828 · angular/angularfire · GitHub
Open Graph Title: `ɵzoneWrap` ignores a handler passed as an observer object, and holds a wrapped promise forever once its injector is destroyed · Issue #3828 · angular/angularfire
X Title: `ɵzoneWrap` ignores a handler passed as an observer object, and holds a wrapped promise forever once its injector is destroyed · Issue #3828 · angular/angularfire
Description: Version info Angular: 22.2 Firebase: 12.19.0 AngularFire: 22.0.0-rc.0, and main Description Two defects in ɵzoneWrap (src/zones.ts), the function the generated @angular/fire/* wrappers go through. 1. A handler passed as an object is not ...
Open Graph Description: Version info Angular: 22.2 Firebase: 12.19.0 AngularFire: 22.0.0-rc.0, and main Description Two defects in ɵzoneWrap (src/zones.ts), the function the generated @angular/fire/* wrappers go through. ...
X Description: Version info Angular: 22.2 Firebase: 12.19.0 AngularFire: 22.0.0-rc.0, and main Description Two defects in ɵzoneWrap (src/zones.ts), the function the generated @angular/fire/* wrappers go through. ...
Opengraph URL: https://github.com/angular/angularfire/issues/3828
X: @github
Domain: github.com
IPv4 address: 140.82.112.4
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`ɵzoneWrap` ignores a handler passed as an observer object, and holds a wrapped promise forever once its injector is destroyed","articleBody":"### Version info\n\n**Angular:** 22.2\n\n**Firebase:** 12.19.0\n\n**AngularFire:** 22.0.0-rc.0, and `main`\n\n### Description\n\nTwo defects in `ɵzoneWrap` (`src/zones.ts`), the function the generated `@angular/fire/*` wrappers go through.\n\n**1. A handler passed as an object is not wrapped.** Firebase accepts a subscription handler either as a function, `onSnapshot(ref, snapshot => ...)`, or as an observer object, `onSnapshot(ref, { next: snapshot => ... })`. The wrapper rewrites an argument only when `typeof` is `'function'`, so the object form reaches the SDK untouched:\n\n- No pending task is registered, so server rendering does not wait for the first value.\n- `inject()` throws inside the handler, because nothing re-enters the injection context.\n- In a zone.js app the handler runs outside the Angular zone, because the wrapper calls Firebase inside `runOutsideAngular` and then never brings the object's members back in. The unwrapped Firebase call made from in-zone code keeps its handler in the zone, so the wrapper makes the object form worse than not wrapping at all.\n\nEleven wrapped functions accept the object form: `onAuthStateChanged`, `onIdTokenChanged`, `onTokenChanged`, `onSnapshot`, `onSnapshotResume`, `onSnapshotsInSync`, `onMessage`, `onRegistered`, `onUnregistered`, `onConfigUpdate` (which accepts only the object form) and data-connect's `subscribe` (whose object uses `onNext`, `onErr` and `onComplete`). The three messaging functions are generated with `blockUntilFirst: false`, so the pending task point does not apply to them.\n\n**2. A wrapped promise never settles after its injector is destroyed.**\n\n- When a wrapped call returns a Promise, the wrapper resolves its own promise through `runInInjectionContext(injector, () => run(() => resolve(value)))`.\n- Neither layer reaches the caller: a `.then` callback runs as a later microtask after the injection context is torn down, and zone.js runs it in the zone where `.then` was attached, not where `resolve` was called.\n- The one thing the layers do is throw: `runInInjectionContext` checks `assertNotDestroyed`, so when the Firebase promise settles after `ApplicationRef.destroy()` or a `TestBed` reset, the callback throws `NG0205` before `resolve` runs and the caller's promise never settles.\n\n### How to reproduce these conditions\n\nOn a zone.js Angular 22.2 app and a zoneless one, against the Firestore emulator, call the real functions through `ɵzoneWrap` the way a constructor does, inside the Angular zone and an injection context, and record inside the handler whether a pending task was registered, whether `inject()` works and whether `NgZone.isInAngularZone()` is true:\n\n- `onSnapshot(ref, { next, error })` and `onSnapshotsInSync(firestore, { next, error })`: no task in either app, `inject()` throws in both, and in the zone.js app the handler runs outside the Angular zone. A plain property written from the handler does not render there, in a component with default change detection.\n- `onSnapshot(ref, next)`, the function form: one task, released when the handler ran, `inject()` works, and in the zone.js app the handler runs inside the zone.\n- The unwrapped `onSnapshot` with either form of handler, called from the same place: `inject()` throws, but in the zone.js app the handler stays inside the zone.\n\nFor the promise defect, a spec: wrap a function that resolves after 20 ms with `ɵzoneWrap(fn, true)`, call it inside `TestBed.runInInjectionContext`, call `TestBed.resetTestingModule()`, then await the returned promise. It never settles and the spec times out after 5 seconds.\n\n### Expected behavior\n\nA handler passed as an observer object gets what a handler passed as a function gets: the pending task, the Angular zone and a working `inject()`. A wrapped promise settles whenever the Firebase promise settles.\n\n### Actual behavior\n\nThe object form gets none of the three, and a wrapped promise that settles after its injector is destroyed never settles.\n","author":{"url":"https://github.com/armando-navarro","@type":"Person","name":"armando-navarro"},"datePublished":"2026-10-30T15:25:03Z","url":"https://github.com/angular/angularfire/issues/3828"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:c6842fa9-453d-61da-8d1b-a9723f9737d0 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C6DE:19AA62:7CE895C:9E0DC63:6B035C25 |
| html-safe-nonce | 6e14ac6ebe448baf296946bb27908d9e848521b0bdee5179aaf8fce8ad815131 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNkRFOjE5QUE2Mjo3Q0U4OTVDOjlFMERDNjM6NkIwMzVDMjUiLCJ2aXNpdG9yX2lkIjoiMjY0MjYyMDk0NDQwMDczNTI3MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | a5513f29da6e913432d712333cb9538444005f676fd72fe5be35fa892a0fb3b6 |
| hovercard-subject-tag | issue:6121915278 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angularfire/3828/issue_layout |
| twitter:image | https://opengraph.githubassets.com/2b7cfa1e6d864211e49a7db9e52b5bbdd344f8f97182ca8a5f24884ec48380a4/angular/angularfire/issues/3828 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2b7cfa1e6d864211e49a7db9e52b5bbdd344f8f97182ca8a5f24884ec48380a4/angular/angularfire/issues/3828 |
| og:image:alt | Version info Angular: 22.2 Firebase: 12.19.0 AngularFire: 22.0.0-rc.0, and main Description Two defects in ɵzoneWrap (src/zones.ts), the function the generated @angular/fire/* wrappers go through. ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | armando-navarro |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angularfire git https://github.com/angular/angularfire.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 49453413 |
| octolytics-dimension-repository_nwo | angular/angularfire |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 49453413 |
| octolytics-dimension-repository_network_root_nwo | angular/angularfire |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
| Server | github.com |
| Content-Type | text/html; charset=utf-8 |
| Cache-Control | max-age=0, private, must-revalidate |
Viewport: width=device-width