René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"ivy-ngcc is unable to compile AngularFire due to AngularFire not following APF","articleBody":"\u003c!--\r\n\r\nIMPORTANT! YOU MUST FOLLOW THESE INSTRUCTIONS OR YOUR ISSUE WILL BE CLOSED.\r\n\r\nThank you for contributing to the Angular and Firebase communities!\r\n\r\nHave a usage question?\r\n=======================\r\nWe get lots of those and we love helping you, but GitHub is not the best place for them and they will be closed. Here are some resources to get help:\r\n\r\n- Go through the Developer's Guide: https://github.com/angular/angularfire2#developer-guide\r\n\r\nIf the official documentation doesn't help, try asking through our officially supported channels:\r\n\r\n- Firebase Google Group: https://groups.google.com/forum/#!forum/firebase-talk\r\n- Stack Overflow: https://stackoverflow.com/questions/tagged/angular (include the firebase and angularfire tags, too!)\r\n\r\n*Please avoid double posting across multiple channels!*\r\n\r\nThink you found a bug?\r\n=======================\r\nYeah, we're definitely not perfect! Please use the bug report template below and include a minimal repro when opening the issue.\r\n\r\nHave a feature request?\r\n========================\r\nGreat, we love hearing how we can improve our products! Remove the template below and\r\nprovide an explanation of your feature request. Provide code samples if applicable. Try to\r\nthink about what it will allow you to do that you can't do today? How will it make current\r\nworkarounds straightforward? What potential bugs and edge cases does it help to avoid?\r\n\r\n--\u003e\r\n\r\n\r\n### Version info\r\n\r\n\u003c!-- What versions of the following libraries are you using? Note that your issue may already\r\nbe fixed in the latest versions. --\u003e\r\n\r\n**Angular:** 8.0.0-beta.6\r\n\r\n**Firebase:** 5.8.4\r\n\r\n**AngularFire:** 5.1.1\r\n\r\n**Other (e.g. Ionic/Cordova, Node, browser, operating system):** N/A\r\n\r\nSee AngularFire code structure: https://unpkg.com/@angular/fire@5.1.1/\r\n\r\nI tried using Angular Compatibility Compiler to compile AngularFire. The ES2015 is compiled correctly. But ESM5 is not compiled.\r\n\r\nDuring FESM5 pass, `ivy-ngcc` will parse index.js in the library root, because that is specify in `module` field in `package.json`.\r\n\r\nUnfortunately, during `ts.createProgram` call in `makeBundleProgram`, TypeScript cannot load file `public_api.js` that is specified in `index.js`. This is due to the resolve order of TypeScript. It goes `.ts`, `.tsx`, `.d.ts`, `.js`, `.jsx`. (Reference [1](https://github.com/Microsoft/TypeScript/blob/b534fb4849eca0a792199fb6c0cb8849fece1cfd/src/compiler/moduleNameResolver.ts#L868) and [2](https://github.com/Microsoft/TypeScript/blob/b534fb4849eca0a792199fb6c0cb8849fece1cfd/src/compiler/moduleNameResolver.ts#L878)) TypeScript finds `public_api.d.ts` first, as it also resides in the library root.\r\n\r\nThis problem will not occur if AngularFire decide to follow Angular Package Format.\r\n\r\n1. `module` key is meant for **flattened ESM5**.\r\n2. Keep the flattened ESM5 in a separate folder\r\n\r\nI believe this cannot be fixed in the `ivy-ngcc` itself, since the order of file resolving is hard coded in TypeScript library. So, the best course of action would be turning AngularFire to match the Angular Package Format.\r\n\r\nI can do the PR to fix this, but I want some approval before doing so.\r\n\r\nPlease take a look and let me know what I can help. ","author":{"url":"https://github.com/sarunint","@type":"Person","name":"sarunint"},"datePublished":"2019-03-05T21:12:10.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":5},"url":"https://github.com/2021/angularfire/issues/2021"}