René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Messaging: TypeError: this.onTokenRefreshInternal is not a function","articleBody":"### Version info\r\n\r\nAngular: 6.0.9\r\nFirebase: 5.4.1\r\nAngularFire: 5.0.0-rc.12\r\n\r\n### How to reproduce these conditions\r\n\r\n```\r\n            const msg: AngularFireMessaging = this.msg;\r\n            msg.tokenChanges.subscribe(\r\n                (token) =\u003e console.log('@@@ tokenchange', token),\r\n                (err) =\u003e console.log('@@@ tokenchange ERROR', err),\r\n            );\r\n```\r\n\r\n### Debug output\r\n\r\n** Errors in the JavaScript console **\r\n```\r\n@@@ tokenchange ERROR TypeError: this.onTokenRefreshInternal is not a function\r\n    at Observable.push../node_modules/@firebase/messaging/dist/index.esm.js.WindowController.onTokenRefresh [as _subscribe] (index.esm.js:1883)\r\n    at Observable.push../node_modules/rxjs/_esm5/internal/Observable.js.Observable._trySubscribe (Observable.js:42)\r\n    at Observable.push../node_modules/rxjs/_esm5/internal/Observable.js.Observable.subscribe (Observable.js:28)\r\n    at subscribeTo.js:21\r\n    at subscribeToResult (subscribeToResult.js:6)\r\n    at SwitchMapSubscriber.push../node_modules/rxjs/_esm5/internal/operators/switchMap.js.SwitchMapSubscriber._innerSub (switchMap.js:47)\r\n    at SwitchMapSubscriber.push../node_modules/rxjs/_esm5/internal/operators/switchMap.js.SwitchMapSubscriber._next (switchMap.js:40)\r\n    at SwitchMapSubscriber.push../node_modules/rxjs/_esm5/internal/Subscriber.js.Subscriber.next (Subscriber.js:54)\r\n    at angularfire2.js:59\r\n    at ZoneDelegate.push../node_modules/zone.js/dist/zone.js.ZoneDelegate.invoke (zone.js:388)\r\n```\r\n\r\n### Expected behavior\r\n\r\nNo error. Problem seems to be in messaging.ts: https://github.com/angular/angularfire2/blob/185943f60012d8c3dcf7cc26413e3278f9e426be/src/messaging/messaging.ts#L56\r\n```\r\n    const tokenChanges = this.messaging.pipe(\r\n      switchMap(messaging =\u003e new Observable(messaging.onTokenRefresh)),\r\n      runOutsideAngular(zone)\r\n    );\r\n```\r\n\r\nmessaging.onTokenRefresh is not bound. As a workaround I've done this myself and this fixes the issue:\r\n```\r\n                const _messaging = app.messaging();\r\n                _messaging.onTokenRefresh = _messaging.onTokenRefresh.bind(_messaging);\r\n\r\n```\r\n\r\nPS. other observables in messaging.ts seem to follow the same pattern and do not bind to this","author":{"url":"https://github.com/wvanderdeijl","@type":"Person","name":"wvanderdeijl"},"datePublished":"2018-09-05T10:34:06.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":12},"url":"https://github.com/1855/angularfire/issues/1855"}