René's URL Explorer Experiment


Title: fix(filterFilter) deeply-nested predicate objects + multiple conditions were not giving expected results by albertboada · Pull Request #7329 · angular/angular.js · GitHub

Open Graph Title: fix(filterFilter) deeply-nested predicate objects + multiple conditions were not giving expected results by albertboada · Pull Request #7329 · angular/angular.js

X Title: fix(filterFilter) deeply-nested predicate objects + multiple conditions were not giving expected results by albertboada · Pull Request #7329 · angular/angular.js

Description: Request Type: bug How to reproduce: http://plnkr.co/edit/Yd705mYbqKJ3n79TXLmx?p=preview Component(s): misc core Impact: medium Complexity: small Detailed Description: Fixes current filterFilter's implementation (introduced in 1.2.13 as a result of #6215) for deeply-nested predicate objects + multiple conditions scenarios. Problem: when using deeply nested predicate objects, filterFilter is currently behaving as if it was using OR operators (i.e. it doesn't matter if some conditions don't match as long as one does), and should be behaving as if it used AND operators in order to be consistent with the original implementation for non-deeply-nested predicate objects.

Open Graph Description: Request Type: bug How to reproduce: http://plnkr.co/edit/Yd705mYbqKJ3n79TXLmx?p=preview Component(s): misc core Impact: medium Complexity: small Detailed Description: Fixes current filterFilter'...

X Description: Request Type: bug How to reproduce: http://plnkr.co/edit/Yd705mYbqKJ3n79TXLmx?p=preview Component(s): misc core Impact: medium Complexity: small Detailed Description: Fixes current filterFilter&...

Opengraph URL: https://github.com/angular/angular.js/pull/7329

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0ef35326-25e4-8ab2-f1ee-2aac757d384e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9558:DC5C6:205B51:2E51B1:6A58AAA1
html-safe-nonce0539453c7b6374b0f2215663f2c8aff8be662c8dba1ddee03e0d0ade786981cf
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NTU4OkRDNUM2OjIwNUI1MToyRTUxQjE6NkE1OEFBQTEiLCJ2aXNpdG9yX2lkIjoiODQ0ODc2NTY0NTg5OTIxMzQ3MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac196e224f22a505b287da2b677a44ad3498503df235485065b550548e4d0937cd
hovercard-subject-tagpull_request:15418516
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular.js/pull/7329/files
twitter:imagehttps://avatars.githubusercontent.com/u/1840284?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1840284?s=400&v=4
og:image:altRequest Type: bug How to reproduce: http://plnkr.co/edit/Yd705mYbqKJ3n79TXLmx?p=preview Component(s): misc core Impact: medium Complexity: small Detailed Description: Fixes current filterFilter'...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5f2a0c7865178af3d91dd9f13b0cdfc3c73a2529c873d2780bb4c01271a57ec6
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular.js git https://github.com/angular/angular.js.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id460078
octolytics-dimension-repository_nwoangular/angular.js
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id460078
octolytics-dimension-repository_network_root_nwoangular/angular.js
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8aae7b8d6caacacf5c66eaeb2702d8dc88d85b4a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular.js/pull/7329/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular.js%2Fpull%2F7329%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular.js%2Fpull%2F7329%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular.js
Reloadhttps://github.com/angular/angular.js/pull/7329/files
Reloadhttps://github.com/angular/angular.js/pull/7329/files
Reloadhttps://github.com/angular/angular.js/pull/7329/files
Please reload this pagehttps://github.com/angular/angular.js/pull/7329/files
angular https://github.com/angular
angular.jshttps://github.com/angular/angular.js
Notifications https://github.com/login?return_to=%2Fangular%2Fangular.js
Fork 27.1k https://github.com/login?return_to=%2Fangular%2Fangular.js
Star 58.6k https://github.com/login?return_to=%2Fangular%2Fangular.js
Code https://github.com/angular/angular.js
Issues 389 https://github.com/angular/angular.js/issues
Pull requests 72 https://github.com/angular/angular.js/pulls
Actions https://github.com/angular/angular.js/actions
Projects https://github.com/angular/angular.js/projects
Wiki https://github.com/angular/angular.js/wiki
Security and quality 0 https://github.com/angular/angular.js/security
Insights https://github.com/angular/angular.js/pulse
Code https://github.com/angular/angular.js
Issues https://github.com/angular/angular.js/issues
Pull requests https://github.com/angular/angular.js/pulls
Actions https://github.com/angular/angular.js/actions
Projects https://github.com/angular/angular.js/projects
Wiki https://github.com/angular/angular.js/wiki
Security and quality https://github.com/angular/angular.js/security
Insights https://github.com/angular/angular.js/pulse
albertboadahttps://github.com/albertboada
angular:masterhttps://github.com/angular/angular.js/tree/master
albertboada:b/fix-filterfilter-nestedhttps://github.com/albertboada/angular.js/tree/b/fix-filterfilter-nested
Conversation 18 https://github.com/angular/angular.js/pull/7329
Commits 1 https://github.com/angular/angular.js/pull/7329/commits
Checks 0 https://github.com/angular/angular.js/pull/7329/checks
Files changed https://github.com/angular/angular.js/pull/7329/files
Please reload this pagehttps://github.com/angular/angular.js/pull/7329/files
fix(filterFilter) deeply-nested predicate objects + multiple conditions were not giving expected results https://github.com/angular/angular.js/pull/7329/files#top
Show all changes 1 commit https://github.com/angular/angular.js/pull/7329/files
30515ef fix(filterFilter) fix deeply-nested predicate objects + multiple cond… albertboada May 2, 2014 https://github.com/angular/angular.js/pull/7329/commits/30515ef47cf4ac8f68c5e6cc65d5c18e62493535
Clear filters https://github.com/angular/angular.js/pull/7329/files
Please reload this pagehttps://github.com/angular/angular.js/pull/7329/files
Please reload this pagehttps://github.com/angular/angular.js/pull/7329/files
filter.js https://github.com/angular/angular.js/pull/7329/files#diff-0169d79c931945b120854c3e105e75e1f5f0a30ed0ba048aa0324fe43fadf8d9
filterSpec.js https://github.com/angular/angular.js/pull/7329/files#diff-0c1f798e05dc469b93aa7f82544d403cf2171429d368c13416773e526edfded2
src/ng/filter/filter.jshttps://github.com/angular/angular.js/pull/7329/files#diff-0169d79c931945b120854c3e105e75e1f5f0a30ed0ba048aa0324fe43fadf8d9
View file https://github.com/albertboada/angular.js/blob/30515ef47cf4ac8f68c5e6cc65d5c18e62493535/src/ng/filter/filter.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular.js/pull/7329/{{ revealButtonHref }}
https://github.com/angular/angular.js/pull/7329/files#diff-0169d79c931945b120854c3e105e75e1f5f0a30ed0ba048aa0324fe43fadf8d9
https://github.com/angular/angular.js/pull/7329/files#diff-0169d79c931945b120854c3e105e75e1f5f0a30ed0ba048aa0324fe43fadf8d9
test/ng/filter/filterSpec.jshttps://github.com/angular/angular.js/pull/7329/files#diff-0c1f798e05dc469b93aa7f82544d403cf2171429d368c13416773e526edfded2
View file https://github.com/albertboada/angular.js/blob/30515ef47cf4ac8f68c5e6cc65d5c18e62493535/test/ng/filter/filterSpec.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular.js/pull/7329/{{ revealButtonHref }}
https://github.com/angular/angular.js/pull/7329/files#diff-0c1f798e05dc469b93aa7f82544d403cf2171429d368c13416773e526edfded2
https://github.com/angular/angular.js/pull/7329/files#diff-0c1f798e05dc469b93aa7f82544d403cf2171429d368c13416773e526edfded2
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.