René's URL Explorer Experiment


Title: Fix(filter): Filter objects with circular references by brettshollenberger · Pull Request #6319 · angular/angular.js · GitHub

Open Graph Title: Fix(filter): Filter objects with circular references by brettshollenberger · Pull Request #6319 · angular/angular.js

X Title: Fix(filter): Filter objects with circular references by brettshollenberger · Pull Request #6319 · angular/angular.js

Description: AngularJS - HTML enhanced for web apps! Contribute to angular/angular.js development by creating an account on GitHub.

Open Graph Description: Overview of the issue - When filtering confronts a circular reference, it causes an infinite recursion & subsequent stack overflow. Motivation for or Use Case - As modeling libraries evolve for...

X Description: Overview of the issue - When filtering confronts a circular reference, it causes an infinite recursion & subsequent stack overflow. Motivation for or Use Case - As modeling libraries evolve...

Opengraph URL: https://github.com/angular/angular.js/pull/6319

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5d5ec767-74ae-bc8b-7387-3e3843c502e6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id904A:7990:F3227B:15ABA97:6A5894A5
html-safe-nonce28be28e13a3bec251c54ec6678cf4148107843990b14f5f6b4d2b4de04433c6c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDRBOjc5OTA6RjMyMjdCOjE1QUJBOTc6NkE1ODk0QTUiLCJ2aXNpdG9yX2lkIjoiODQ2NTYyNjIzMDM4NzIzMjM3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac0650a17d61f8274bea4f588fcdbad9e197dd08bb98575153455694eb6cb5e7f9
hovercard-subject-tagpull_request:12661988
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular.js/6319/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5a67c395b7f3b6ec143fe09e8198f3834759858534eaf0c31133ded21824a155/angular/angular.js/pull/6319
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5a67c395b7f3b6ec143fe09e8198f3834759858534eaf0c31133ded21824a155/angular/angular.js/pull/6319
og:image:altOverview of the issue - When filtering confronts a circular reference, it causes an infinite recursion & subsequent stack overflow. Motivation for or Use Case - As modeling libraries evolve for...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebrettshollenberger
hostnamegithub.com
expected-hostnamegithub.com
None5f2a0c7865178af3d91dd9f13b0cdfc3c73a2529c873d2780bb4c01271a57ec6
turbo-cache-controlno-cache
go-importgithub.com/angular/angular.js git https://github.com/angular/angular.js.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id460078
octolytics-dimension-repository_nwoangular/angular.js
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id460078
octolytics-dimension-repository_network_root_nwoangular/angular.js
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8aae7b8d6caacacf5c66eaeb2702d8dc88d85b4a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular.js/pull/6319#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular.js%2Fpull%2F6319
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular.js%2Fpull%2F6319
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular.js
Reloadhttps://github.com/angular/angular.js/pull/6319
Reloadhttps://github.com/angular/angular.js/pull/6319
Reloadhttps://github.com/angular/angular.js/pull/6319
Please reload this pagehttps://github.com/angular/angular.js/pull/6319
angular https://github.com/angular
angular.jshttps://github.com/angular/angular.js
Notifications https://github.com/login?return_to=%2Fangular%2Fangular.js
Fork 27.1k https://github.com/login?return_to=%2Fangular%2Fangular.js
Star 58.6k https://github.com/login?return_to=%2Fangular%2Fangular.js
Code https://github.com/angular/angular.js
Issues 389 https://github.com/angular/angular.js/issues
Pull requests 72 https://github.com/angular/angular.js/pulls
Actions https://github.com/angular/angular.js/actions
Projects https://github.com/angular/angular.js/projects
Wiki https://github.com/angular/angular.js/wiki
Security and quality 0 https://github.com/angular/angular.js/security
Insights https://github.com/angular/angular.js/pulse
Code https://github.com/angular/angular.js
Issues https://github.com/angular/angular.js/issues
Pull requests https://github.com/angular/angular.js/pulls
Actions https://github.com/angular/angular.js/actions
Projects https://github.com/angular/angular.js/projects
Wiki https://github.com/angular/angular.js/wiki
Security and quality https://github.com/angular/angular.js/security
Insights https://github.com/angular/angular.js/pulse
brettshollenbergerhttps://github.com/brettshollenberger
angular:masterhttps://github.com/angular/angular.js/tree/master
brettshollenberger:features/filter-objects-with-circular-referenceshttps://github.com/brettshollenberger/angular.js/tree/features/filter-objects-with-circular-references
Conversationhttps://github.com/angular/angular.js/pull/6319
Commits7 (7)https://github.com/angular/angular.js/pull/6319/commits
Checkshttps://github.com/angular/angular.js/pull/6319/checks
Files changedhttps://github.com/angular/angular.js/pull/6319/files
Fix(filter): Filter objects with circular referenceshttps://github.com/angular/angular.js/pull/6319#top
brettshollenbergerhttps://github.com/brettshollenberger
angular:masterhttps://github.com/angular/angular.js/tree/master
brettshollenberger:features/filter-objects-with-circular-referenceshttps://github.com/brettshollenberger/angular.js/tree/features/filter-objects-with-circular-references
https://github.com/brettshollenberger
brettshollenbergerhttps://github.com/brettshollenberger
Feb 18, 2014https://github.com/angular/angular.js/pull/6319#issue-27812779
https://github.com/FacultyCreative/ngActiveResourcehttps://github.com/FacultyCreative/ngActiveResource
http://jsfiddle.net/S2UY6/9/http://jsfiddle.net/S2UY6/9/
Please reload this pagehttps://github.com/angular/angular.js/pull/6319
brettshollenbergerhttps://github.com/brettshollenberger
February 18, 2014 11:53https://github.com/angular/angular.js/pull/6319#commits-pushed-1f40a39
https://github.com/brettshollenberger
fix(filter): Add test for filtering circular referenceshttps://github.com/angular/angular.js/pull/6319/commits/1f40a39bc2644e67087b9068dabd865171ec75b5
1f40a39https://github.com/angular/angular.js/pull/6319/commits/1f40a39bc2644e67087b9068dabd865171ec75b5
https://github.com/brettshollenberger
fix(filter): End filtering recursion for circular referenceshttps://github.com/angular/angular.js/pull/6319/commits/7cec2f6b6f05eb550ec041ddb8a3ce00a7101338
7cec2f6https://github.com/angular/angular.js/pull/6319/commits/7cec2f6b6f05eb550ec041ddb8a3ce00a7101338
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Feb 18, 2014https://github.com/angular/angular.js/pull/6319#issuecomment-35411428
contributing docshttps://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#contributing-to-angularjs
#6319http://kent.doddsfamily.us/issue-template/#/angular/angular.js/issue/6319
Please reload this pagehttps://github.com/angular/angular.js/pull/6319
caitphttps://github.com/caitp
Feb 18, 2014 https://github.com/angular/angular.js/pull/6319#discussion-diff-9834075
View reviewed changes https://github.com/angular/angular.js/pull/6319/files/7cec2f6b6f05eb550ec041ddb8a3ce00a7101338#diff-0c1f798e05dc469b93aa7f82544d403cf2171429d368c13416773e526edfded2
test/ng/filter/filterSpec.jshttps://github.com/angular/angular.js/pull/6319/files#diff-0c1f798e05dc469b93aa7f82544d403cf2171429d368c13416773e526edfded2
caitphttps://github.com/caitp
Feb 18, 2014https://github.com/angular/angular.js/pull/6319#discussion_r9834075
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular.js/pull/6319
https://github.com/caitp
caitphttps://github.com/caitp
Feb 18, 2014https://github.com/angular/angular.js/pull/6319#issuecomment-35414426
Please reload this pagehttps://github.com/angular/angular.js/pull/6319
caitphttps://github.com/caitp
Feb 18, 2014 https://github.com/angular/angular.js/pull/6319#discussion-diff-9834272
View reviewed changes https://github.com/angular/angular.js/pull/6319/files/7cec2f6b6f05eb550ec041ddb8a3ce00a7101338#diff-0169d79c931945b120854c3e105e75e1f5f0a30ed0ba048aa0324fe43fadf8d9
src/ng/filter/filter.jshttps://github.com/angular/angular.js/pull/6319/files#diff-0169d79c931945b120854c3e105e75e1f5f0a30ed0ba048aa0324fe43fadf8d9
caitphttps://github.com/caitp
Feb 18, 2014https://github.com/angular/angular.js/pull/6319#discussion_r9834272
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular.js/pull/6319
brettshollenbergerhttps://github.com/brettshollenberger
Feb 18, 2014https://github.com/angular/angular.js/pull/6319#discussion_r9834660
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular.js/pull/6319
brettshollenbergerhttps://github.com/brettshollenberger
February 18, 2014 13:46https://github.com/angular/angular.js/pull/6319#commits-pushed-07d4d14
https://github.com/brettshollenberger
fix(filter): Add final results of filtering to expectationhttps://github.com/angular/angular.js/pull/6319/commits/07d4d14dc25ee220b87ccdfd1cf81edcdc01a558
07d4d14https://github.com/angular/angular.js/pull/6319/commits/07d4d14dc25ee220b87ccdfd1cf81edcdc01a558
https://github.com/brettshollenberger
fix(filter): Use stack of evaluated objects to prevent circular refer…https://github.com/angular/angular.js/pull/6319/commits/3b96b4e1c5cadf88c1a44dab827407929d71ebcb
3b96b4ehttps://github.com/angular/angular.js/pull/6319/commits/3b96b4e1c5cadf88c1a44dab827407929d71ebcb
https://github.com/brettshollenberger
fix(filter): Only perform circular reference check on non-primitive t…https://github.com/angular/angular.js/pull/6319/commits/ca217987934a87f76427630d97bf47ec6ce4bd6e
ca21798https://github.com/angular/angular.js/pull/6319/commits/ca217987934a87f76427630d97bf47ec6ce4bd6e
https://github.com/brettshollenberger
fix(filter): Also perform circular reference check on functions; they…https://github.com/angular/angular.js/pull/6319/commits/245721e994d25cb6b1b18f8d6850233aa20ff1b4
245721ehttps://github.com/angular/angular.js/pull/6319/commits/245721e994d25cb6b1b18f8d6850233aa20ff1b4
https://github.com/brettshollenberger
brettshollenbergerhttps://github.com/brettshollenberger
Feb 18, 2014https://github.com/angular/angular.js/pull/6319#issuecomment-35420082
@caitphttps://github.com/caitp
Please reload this pagehttps://github.com/angular/angular.js/pull/6319
caitphttps://github.com/caitp
Feb 18, 2014 https://github.com/angular/angular.js/pull/6319#discussion-diff-9837157
View reviewed changes https://github.com/angular/angular.js/pull/6319/files/245721e994d25cb6b1b18f8d6850233aa20ff1b4#diff-0169d79c931945b120854c3e105e75e1f5f0a30ed0ba048aa0324fe43fadf8d9
src/ng/filter/filter.jshttps://github.com/angular/angular.js/pull/6319/files#diff-0169d79c931945b120854c3e105e75e1f5f0a30ed0ba048aa0324fe43fadf8d9
caitphttps://github.com/caitp
Feb 18, 2014https://github.com/angular/angular.js/pull/6319#discussion_r9837157
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular.js/pull/6319
https://github.com/caitp
caitphttps://github.com/caitp
Feb 18, 2014https://github.com/angular/angular.js/pull/6319#event-94663757
https://github.com/caitp
caitphttps://github.com/caitp
type: feature https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22type%3A%20feature%22
Feb 18, 2014https://github.com/angular/angular.js/pull/6319#event-94663800
https://github.com/caitp
caitphttps://github.com/caitp
Feb 18, 2014https://github.com/angular/angular.js/pull/6319#issuecomment-35426680
Please reload this pagehttps://github.com/angular/angular.js/pull/6319
https://github.com/brettshollenberger
brettshollenbergerhttps://github.com/brettshollenberger
Feb 18, 2014https://github.com/angular/angular.js/pull/6319#issuecomment-35434778
@caitphttps://github.com/caitp
Please reload this pagehttps://github.com/angular/angular.js/pull/6319
https://github.com/brettshollenberger
fix(filters): Simplify blockhttps://github.com/angular/angular.js/pull/6319/commits/a9d814abd96913fad5d735694778ac6ca624cd97
a9d814ahttps://github.com/angular/angular.js/pull/6319/commits/a9d814abd96913fad5d735694778ac6ca624cd97
https://github.com/brettshollenberger
brettshollenbergerhttps://github.com/brettshollenberger
cla: yes https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
cla: no https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22cla%3A%20no%22
Feb 19, 2014https://github.com/angular/angular.js/pull/6319#event-94958767
https://github.com/caitp
caitphttps://github.com/caitp
Feb 19, 2014https://github.com/angular/angular.js/pull/6319#event-94992032
https://github.com/caitp
caitphttps://github.com/caitp
Mar 12, 2014 https://github.com/angular/angular.js/pull/6319#ref-issue-29238975
Use search.$ in filter will result in Call stack exceeded error if the objects have properties that self reference #6655 https://github.com/angular/angular.js/issues/6655
IgorMinarhttps://github.com/IgorMinar
Mar 13, 2014 https://github.com/angular/angular.js/pull/6319#discussion-diff-10586351
View reviewed changes https://github.com/angular/angular.js/pull/6319/files/a9d814abd96913fad5d735694778ac6ca624cd97#diff-0169d79c931945b120854c3e105e75e1f5f0a30ed0ba048aa0324fe43fadf8d9
src/ng/filter/filter.jshttps://github.com/angular/angular.js/pull/6319/files#diff-0169d79c931945b120854c3e105e75e1f5f0a30ed0ba048aa0324fe43fadf8d9
IgorMinarhttps://github.com/IgorMinar
Mar 13, 2014https://github.com/angular/angular.js/pull/6319#discussion_r10586351
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular.js/pull/6319
IgorMinarhttps://github.com/IgorMinar
Mar 13, 2014https://github.com/angular/angular.js/pull/6319#discussion_r10586520
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular.js/pull/6319
https://github.com/IgorMinar
IgorMinarhttps://github.com/IgorMinar
Mar 13, 2014https://github.com/angular/angular.js/pull/6319#issuecomment-37588793
Please reload this pagehttps://github.com/angular/angular.js/pull/6319
https://github.com/caitp
caitphttps://github.com/caitp
Jun 9, 2014 https://github.com/angular/angular.js/pull/6319#ref-pullrequest-35278715
Avoid stack overflow in filterFilter when using objects containing circular references #7751 https://github.com/angular/angular.js/pull/7751
https://github.com/caitp
caitphttps://github.com/caitp
Jul 7, 2014https://github.com/angular/angular.js/pull/6319#issuecomment-48210306
@IgorMinarhttps://github.com/IgorMinar
Please reload this pagehttps://github.com/angular/angular.js/pull/6319
https://github.com/caitp
caitphttps://github.com/caitp
Jul 9, 2014https://github.com/angular/angular.js/pull/6319#issuecomment-48421085
@brettshollenbergerhttps://github.com/brettshollenberger
Please reload this pagehttps://github.com/angular/angular.js/pull/6319
https://github.com/caitp
caitphttps://github.com/caitp
Jul 9, 2014https://github.com/angular/angular.js/pull/6319#event-139518617
https://github.com/caitp
caitphttps://github.com/caitp
resolution: won't fix https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22resolution%3A%20won%27t%20fix%22
Jul 9, 2014https://github.com/angular/angular.js/pull/6319#event-139518697
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Oct 25, 2014 https://github.com/angular/angular.js/pull/6319#ref-issue-46807069
Collection of filterFilter related issues (with regard to #9757) #9788 https://github.com/angular/angular.js/issues/9788
Narretzhttps://github.com/Narretz
Feb 15, 2017 https://github.com/angular/angular.js/pull/6319#ref-commit-2796ec1
https://github.com/Narretz
docs(filterFilter): add note about self-referencing objects in arrayhttps://github.com/angular/angular.js/commit/2796ec172bf48233410c65d0287e0c0922e1a3be
2796ec1https://github.com/angular/angular.js/commit/2796ec172bf48233410c65d0287e0c0922e1a3be
#6655https://github.com/angular/angular.js/issues/6655
#6319https://github.com/angular/angular.js/pull/6319
Narretzhttps://github.com/Narretz
Feb 15, 2017 https://github.com/angular/angular.js/pull/6319#ref-commit-15149c1
https://github.com/Narretz
docs(filterFilter): add note about self-referencing objects in arrayhttps://github.com/angular/angular.js/commit/15149c1da1020f139dfcdd50c8e641f8f43088a4
15149c1https://github.com/angular/angular.js/commit/15149c1da1020f139dfcdd50c8e641f8f43088a4
#6655https://github.com/angular/angular.js/issues/6655
#6319https://github.com/angular/angular.js/pull/6319
ellimisthttps://github.com/ellimist
Mar 15, 2017 https://github.com/angular/angular.js/pull/6319#ref-commit-adb5e1c
https://github.com/Narretz
https://github.com/ellimist
docs(filterFilter): add note about self-referencing objects in arrayhttps://github.com/ellimist/angular.js/commit/adb5e1c1db3f6fc995141aabceaf3fba8980e1bf
adb5e1chttps://github.com/ellimist/angular.js/commit/adb5e1c1db3f6fc995141aabceaf3fba8980e1bf
angular#6655https://github.com/angular/angular.js/issues/6655
angular#6319https://github.com/angular/angular.js/pull/6319
https://github.co/hiddenchars
https://github.com/angular/angular.js/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular.js%2Fpull%2F6319
https://github.com/caitp
caitp https://github.com/caitp
cla: yes https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
resolution: not core https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22resolution%3A%20not%20core%22
resolution: won't fix https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22resolution%3A%20won%27t%20fix%22
type: bug https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%22
type: feature https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22type%3A%20feature%22
1.3.x - superluminal-nudge https://github.com/angular/angular.js/milestone/32
Please reload this pagehttps://github.com/angular/angular.js/pull/6319
https://github.com/brettshollenberger
https://github.com/mary-poppins
https://github.com/caitp
https://github.com/IgorMinar
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.