René's URL Explorer Experiment


Title: WIP - feat($injector): add support for non-string IDs (and other minor stuff) by gkalpak · Pull Request #14998 · angular/angular.js · GitHub

Open Graph Title: WIP - feat($injector): add support for non-string IDs (and other minor stuff) by gkalpak · Pull Request #14998 · angular/angular.js

X Title: WIP - feat($injector): add support for non-string IDs (and other minor stuff) by gkalpak · Pull Request #14998 · angular/angular.js

Description: What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Feature. What is the current behavior? (You can also link to an open issue here) Only strings can be used as service...

Open Graph Description: What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Feature. What is the current behavior? (You can also link to an open issue here) Only strings can be used as service...

X Description: What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Feature. What is the current behavior? (You can also link to an open issue here) Only strings can be used as service...

Opengraph URL: https://github.com/angular/angular.js/pull/14998

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a9d3d652-7a4c-f67a-76fb-174b0d2f2f5d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8672:AA45D:2AFDB96:3B6355D:6964E7E9
html-safe-nonce06a6dc8dbffc0f7aa4a4fbb7bca57c2c3e7653a10a23ee2e8cd0bcc22d35702e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NjcyOkFBNDVEOjJBRkRCOTY6M0I2MzU1RDo2OTY0RTdFOSIsInZpc2l0b3JfaWQiOiI2MTM0MjE2OTE4MzQ5MTc4ODU3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac29342ae76227da5bc1110a115661e01674c249e22ab8cf6599ba54967f913cc4
hovercard-subject-tagpull_request:80349175
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular.js/14998/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0f3d0329e616d6befa340297f6101c998805fa7850c69a61467b147becd11a63/angular/angular.js/pull/14998
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0f3d0329e616d6befa340297f6101c998805fa7850c69a61467b147becd11a63/angular/angular.js/pull/14998
og:image:altWhat kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Feature. What is the current behavior? (You can also link to an open issue here) Only strings can be used as service...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegkalpak
hostnamegithub.com
expected-hostnamegithub.com
None3c30097417ecb9dfdab6b2e8bc7dc38d73e183d6ad48f94cb69e4a5daa2dbb87
turbo-cache-controlno-preview
go-importgithub.com/angular/angular.js git https://github.com/angular/angular.js.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id460078
octolytics-dimension-repository_nwoangular/angular.js
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id460078
octolytics-dimension-repository_network_root_nwoangular/angular.js
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release69fc54a84c74307369dba42af5401200531d116e
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular.js/pull/14998#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular.js%2Fpull%2F14998
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular.js%2Fpull%2F14998
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular.js
Reloadhttps://github.com/angular/angular.js/pull/14998
Reloadhttps://github.com/angular/angular.js/pull/14998
Reloadhttps://github.com/angular/angular.js/pull/14998
angular https://github.com/angular
angular.jshttps://github.com/angular/angular.js
Notifications https://github.com/login?return_to=%2Fangular%2Fangular.js
Fork 27.3k https://github.com/login?return_to=%2Fangular%2Fangular.js
Star 59k https://github.com/login?return_to=%2Fangular%2Fangular.js
Code https://github.com/angular/angular.js
Issues 389 https://github.com/angular/angular.js/issues
Pull requests 72 https://github.com/angular/angular.js/pulls
Actions https://github.com/angular/angular.js/actions
Projects 0 https://github.com/angular/angular.js/projects
Wiki https://github.com/angular/angular.js/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/angular/angular.js/security
Please reload this pagehttps://github.com/angular/angular.js/pull/14998
Insights https://github.com/angular/angular.js/pulse
Code https://github.com/angular/angular.js
Issues https://github.com/angular/angular.js/issues
Pull requests https://github.com/angular/angular.js/pulls
Actions https://github.com/angular/angular.js/actions
Projects https://github.com/angular/angular.js/projects
Wiki https://github.com/angular/angular.js/wiki
Security https://github.com/angular/angular.js/security
Insights https://github.com/angular/angular.js/pulse
gkalpakhttps://github.com/gkalpak
angular:masterhttps://github.com/angular/angular.js/tree/master
gkalpak:feat-injector-non-string-idshttps://github.com/gkalpak/angular.js/tree/feat-injector-non-string-ids
WIP - feat($injector): add support for non-string IDs (and other minor stuff) https://github.com/angular/angular.js/pull/14998#top
gkalpakhttps://github.com/gkalpak
angular:masterhttps://github.com/angular/angular.js/tree/master
gkalpak:feat-injector-non-string-idshttps://github.com/gkalpak/angular.js/tree/feat-injector-non-string-ids
Conversation 2 https://github.com/angular/angular.js/pull/14998
Commits 4 https://github.com/angular/angular.js/pull/14998/commits
Checks 0 https://github.com/angular/angular.js/pull/14998/checks
Files changed https://github.com/angular/angular.js/pull/14998/files
Please reload this pagehttps://github.com/angular/angular.js/pull/14998
https://github.co/hiddenchars
https://github.com/angular/angular.js/pull/{{ revealButtonHref }}
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Aug 6, 2016https://github.com/angular/angular.js/pull/14998#issue-169763768
#10347https://github.com/angular/angular.js/issues/10347
https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-formathttps://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
#10347https://github.com/angular/angular.js/issues/10347
Please reload this pagehttps://github.com/angular/angular.js/pull/14998
gkalpakhttps://github.com/gkalpak
August 6, 2016 18:46https://github.com/angular/angular.js/pull/14998#commits-pushed-ab325a0
https://github.com/gkalpak
feat(HashMap): add support for .has() and initializing with an objecthttps://github.com/angular/angular.js/pull/14998/commits/ab325a0c3d8f0c6a9672ac8008cf039e6f0c6674
ab325a0https://github.com/angular/angular.js/pull/14998/commits/ab325a0c3d8f0c6a9672ac8008cf039e6f0c6674
https://github.com/gkalpak
refactor($injector): minor clean uphttps://github.com/angular/angular.js/pull/14998/commits/2e0441dd23f10bbae714a30d6eda7884a1e09c2c
2e0441dhttps://github.com/angular/angular.js/pull/14998/commits/2e0441dd23f10bbae714a30d6eda7884a1e09c2c
https://github.com/gkalpak
test($injector): fix incorrect test and error message assertionshttps://github.com/angular/angular.js/pull/14998/commits/a9863bfa669d6414bfd3a280177f1455731ca05d
a9863bfhttps://github.com/angular/angular.js/pull/14998/commits/a9863bfa669d6414bfd3a280177f1455731ca05d
https://github.com/gkalpak
feat($injector): add support for non-string IDshttps://github.com/angular/angular.js/pull/14998/commits/32bde2d0bbb0f5f7465aa3e73011928b7621c824
32bde2dhttps://github.com/angular/angular.js/pull/14998/commits/32bde2d0bbb0f5f7465aa3e73011928b7621c824
angular#10347https://github.com/angular/angular.js/issues/10347
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
type: feature https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22type%3A%20feature%22
frequency: high https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22frequency%3A%20high%22
needs: review https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22needs%3A%20review%22
component: di https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22component%3A%20di%22
needs: public api https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22needs%3A%20public%20api%22
severity: inconvenient https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22severity%3A%20inconvenient%22
branch: 1.6.x https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22branch%3A%201.6.x%22
needs: docs https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22needs%3A%20docs%22
Aug 6, 2016https://github.com/angular/angular.js/pull/14998#event-747517768
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
1.6.xhttps://github.com/angular/angular.js/milestone/105
Aug 6, 2016https://github.com/angular/angular.js/pull/14998#event-747517776
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Aug 6, 2016https://github.com/angular/angular.js/pull/14998#event-747517777
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Aug 6, 2016https://github.com/angular/angular.js/pull/14998#issuecomment-238046327
Please reload this pagehttps://github.com/angular/angular.js/pull/14998
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Sep 1, 2016https://github.com/angular/angular.js/pull/14998#event-775435575
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Sep 1, 2016https://github.com/angular/angular.js/pull/14998#event-775436427
https://github.com/Narretz
Narretzhttps://github.com/Narretz
1.6.xhttps://github.com/angular/angular.js/milestone/105
1.7.xhttps://github.com/angular/angular.js/milestone/144
Apr 12, 2018https://github.com/angular/angular.js/pull/14998#event-1570413199
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
1.7.xhttps://github.com/angular/angular.js/milestone/144
May 16, 2018https://github.com/angular/angular.js/pull/14998#event-1630328278
https://github.com/jbedard
jbedardhttps://github.com/jbedard
May 16, 2018https://github.com/angular/angular.js/pull/14998#issuecomment-389625137
http://github.com/jbedard/ng-facade/https://github.com/jbedard/ng-facade/
Please reload this pagehttps://github.com/angular/angular.js/pull/14998
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
branch: 1.6.x https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22branch%3A%201.6.x%22
May 20, 2020https://github.com/angular/angular.js/pull/14998#event-3355054709
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular.js%2Fpull%2F14998
cla: yes https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
component: di https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22component%3A%20di%22
frequency: high https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22frequency%3A%20high%22
needs: docs https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22needs%3A%20docs%22
needs: public api https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22needs%3A%20public%20api%22
needs: review https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22needs%3A%20review%22
severity: inconvenient https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22severity%3A%20inconvenient%22
type: feature https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22type%3A%20feature%22
1.8.x - won't fix https://github.com/angular/angular.js/milestone/145
di: Allow arbitrary objects as identifiers for services https://github.com/angular/angular.js/issues/10347
Please reload this pagehttps://github.com/angular/angular.js/pull/14998
https://github.com/gkalpak
https://github.com/jbedard
https://github.com/petebacondarwin
https://github.com/Narretz
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.