| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:a9d3d652-7a4c-f67a-76fb-174b0d2f2f5d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8672:AA45D:2AFDB96:3B6355D:6964E7E9 |
| html-safe-nonce | 06a6dc8dbffc0f7aa4a4fbb7bca57c2c3e7653a10a23ee2e8cd0bcc22d35702e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NjcyOkFBNDVEOjJBRkRCOTY6M0I2MzU1RDo2OTY0RTdFOSIsInZpc2l0b3JfaWQiOiI2MTM0MjE2OTE4MzQ5MTc4ODU3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 29342ae76227da5bc1110a115661e01674c249e22ab8cf6599ba54967f913cc4 |
| hovercard-subject-tag | pull_request:80349175 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular.js/14998/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/0f3d0329e616d6befa340297f6101c998805fa7850c69a61467b147becd11a63/angular/angular.js/pull/14998 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0f3d0329e616d6befa340297f6101c998805fa7850c69a61467b147becd11a63/angular/angular.js/pull/14998 |
| og:image:alt | What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature.
What is the current behavior? (You can also link to an open issue here)
Only strings can be used as service... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gkalpak |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3c30097417ecb9dfdab6b2e8bc7dc38d73e183d6ad48f94cb69e4a5daa2dbb87 |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular.js git https://github.com/angular/angular.js.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 460078 |
| octolytics-dimension-repository_nwo | angular/angular.js |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 460078 |
| octolytics-dimension-repository_network_root_nwo | angular/angular.js |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 69fc54a84c74307369dba42af5401200531d116e |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/angular/angular.js/pull/14998#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular.js%2Fpull%2F14998 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular.js%2Fpull%2F14998 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular.js |
| Reload | https://github.com/angular/angular.js/pull/14998 |
| Reload | https://github.com/angular/angular.js/pull/14998 |
| Reload | https://github.com/angular/angular.js/pull/14998 |
|
angular
| https://github.com/angular |
| angular.js | https://github.com/angular/angular.js |
|
Notifications
| https://github.com/login?return_to=%2Fangular%2Fangular.js |
|
Fork
27.3k
| https://github.com/login?return_to=%2Fangular%2Fangular.js |
|
Star
59k
| https://github.com/login?return_to=%2Fangular%2Fangular.js |
|
Code
| https://github.com/angular/angular.js |
|
Issues
389
| https://github.com/angular/angular.js/issues |
|
Pull requests
72
| https://github.com/angular/angular.js/pulls |
|
Actions
| https://github.com/angular/angular.js/actions |
|
Projects
0
| https://github.com/angular/angular.js/projects |
|
Wiki
| https://github.com/angular/angular.js/wiki |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/angular/angular.js/security |
| Please reload this page | https://github.com/angular/angular.js/pull/14998 |
|
Insights
| https://github.com/angular/angular.js/pulse |
|
Code
| https://github.com/angular/angular.js |
|
Issues
| https://github.com/angular/angular.js/issues |
|
Pull requests
| https://github.com/angular/angular.js/pulls |
|
Actions
| https://github.com/angular/angular.js/actions |
|
Projects
| https://github.com/angular/angular.js/projects |
|
Wiki
| https://github.com/angular/angular.js/wiki |
|
Security
| https://github.com/angular/angular.js/security |
|
Insights
| https://github.com/angular/angular.js/pulse |
| gkalpak | https://github.com/gkalpak |
| angular:master | https://github.com/angular/angular.js/tree/master |
| gkalpak:feat-injector-non-string-ids | https://github.com/gkalpak/angular.js/tree/feat-injector-non-string-ids |
|
WIP - feat($injector): add support for non-string IDs (and other minor stuff)
| https://github.com/angular/angular.js/pull/14998#top |
| gkalpak | https://github.com/gkalpak |
| angular:master | https://github.com/angular/angular.js/tree/master |
| gkalpak:feat-injector-non-string-ids | https://github.com/gkalpak/angular.js/tree/feat-injector-non-string-ids |
|
Conversation
2
| https://github.com/angular/angular.js/pull/14998 |
|
Commits
4
| https://github.com/angular/angular.js/pull/14998/commits |
|
Checks
0
| https://github.com/angular/angular.js/pull/14998/checks |
|
Files changed
| https://github.com/angular/angular.js/pull/14998/files |
| Please reload this page | https://github.com/angular/angular.js/pull/14998 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular.js/pull/{{ revealButtonHref }} |
|
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Aug 6, 2016 | https://github.com/angular/angular.js/pull/14998#issue-169763768 |
| #10347 | https://github.com/angular/angular.js/issues/10347 |
| https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format | https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format |
| #10347 | https://github.com/angular/angular.js/issues/10347 |
| Please reload this page | https://github.com/angular/angular.js/pull/14998 |
| gkalpak | https://github.com/gkalpak |
| August 6, 2016 18:46 | https://github.com/angular/angular.js/pull/14998#commits-pushed-ab325a0 |
|
| https://github.com/gkalpak |
| feat(HashMap): add support for .has() and initializing with an object | https://github.com/angular/angular.js/pull/14998/commits/ab325a0c3d8f0c6a9672ac8008cf039e6f0c6674 |
| ab325a0 | https://github.com/angular/angular.js/pull/14998/commits/ab325a0c3d8f0c6a9672ac8008cf039e6f0c6674 |
|
| https://github.com/gkalpak |
| refactor($injector): minor clean up | https://github.com/angular/angular.js/pull/14998/commits/2e0441dd23f10bbae714a30d6eda7884a1e09c2c |
| 2e0441d | https://github.com/angular/angular.js/pull/14998/commits/2e0441dd23f10bbae714a30d6eda7884a1e09c2c |
|
| https://github.com/gkalpak |
| test($injector): fix incorrect test and error message assertions | https://github.com/angular/angular.js/pull/14998/commits/a9863bfa669d6414bfd3a280177f1455731ca05d |
| a9863bf | https://github.com/angular/angular.js/pull/14998/commits/a9863bfa669d6414bfd3a280177f1455731ca05d |
|
| https://github.com/gkalpak |
| feat($injector): add support for non-string IDs | https://github.com/angular/angular.js/pull/14998/commits/32bde2d0bbb0f5f7465aa3e73011928b7621c824 |
| 32bde2d | https://github.com/angular/angular.js/pull/14998/commits/32bde2d0bbb0f5f7465aa3e73011928b7621c824 |
| angular#10347 | https://github.com/angular/angular.js/issues/10347 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
type: feature
| https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22type%3A%20feature%22 |
|
frequency: high
| https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22frequency%3A%20high%22 |
|
needs: review
| https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22needs%3A%20review%22 |
|
component: di
| https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22component%3A%20di%22 |
|
needs: public api
| https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22needs%3A%20public%20api%22 |
|
severity: inconvenient
| https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22severity%3A%20inconvenient%22 |
|
branch: 1.6.x
| https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22branch%3A%201.6.x%22 |
|
needs: docs
| https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22needs%3A%20docs%22 |
| Aug 6, 2016 | https://github.com/angular/angular.js/pull/14998#event-747517768 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| 1.6.x | https://github.com/angular/angular.js/milestone/105 |
| Aug 6, 2016 | https://github.com/angular/angular.js/pull/14998#event-747517776 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Aug 6, 2016 | https://github.com/angular/angular.js/pull/14998#event-747517777 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Aug 6, 2016 | https://github.com/angular/angular.js/pull/14998#issuecomment-238046327 |
| Please reload this page | https://github.com/angular/angular.js/pull/14998 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Sep 1, 2016 | https://github.com/angular/angular.js/pull/14998#event-775435575 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Sep 1, 2016 | https://github.com/angular/angular.js/pull/14998#event-775436427 |
| https://github.com/Narretz |
| Narretz | https://github.com/Narretz |
| 1.6.x | https://github.com/angular/angular.js/milestone/105 |
| 1.7.x | https://github.com/angular/angular.js/milestone/144 |
| Apr 12, 2018 | https://github.com/angular/angular.js/pull/14998#event-1570413199 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| 1.7.x | https://github.com/angular/angular.js/milestone/144 |
| May 16, 2018 | https://github.com/angular/angular.js/pull/14998#event-1630328278 |
| https://github.com/jbedard |
| jbedard | https://github.com/jbedard |
| May 16, 2018 | https://github.com/angular/angular.js/pull/14998#issuecomment-389625137 |
| http://github.com/jbedard/ng-facade/ | https://github.com/jbedard/ng-facade/ |
| Please reload this page | https://github.com/angular/angular.js/pull/14998 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
branch: 1.6.x
| https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22branch%3A%201.6.x%22 |
| May 20, 2020 | https://github.com/angular/angular.js/pull/14998#event-3355054709 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular.js%2Fpull%2F14998 |
|
cla: yes
| https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
component: di
| https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22component%3A%20di%22 |
|
frequency: high
| https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22frequency%3A%20high%22 |
|
needs: docs
| https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22needs%3A%20docs%22 |
|
needs: public api
| https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22needs%3A%20public%20api%22 |
|
needs: review
| https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22needs%3A%20review%22 |
|
severity: inconvenient
| https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22severity%3A%20inconvenient%22 |
|
type: feature
| https://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22type%3A%20feature%22 |
|
1.8.x - won't fix
| https://github.com/angular/angular.js/milestone/145 |
|
di: Allow arbitrary objects as identifiers for services
| https://github.com/angular/angular.js/issues/10347 |
| Please reload this page | https://github.com/angular/angular.js/pull/14998 |
|
| https://github.com/gkalpak |
|
| https://github.com/jbedard |
|
| https://github.com/petebacondarwin |
|
| https://github.com/Narretz |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |