René's URL Explorer Experiment


Title: ngMinlength and ngMaxlength attribute not bind value, when model value is type Number · Issue #5936 · angular/angular.js · GitHub

Open Graph Title: ngMinlength and ngMaxlength attribute not bind value, when model value is type Number · Issue #5936 · angular/angular.js

X Title: ngMinlength and ngMaxlength attribute not bind value, when model value is type Number · Issue #5936 · angular/angular.js

Description: cdc4d48#diff-c244afd8def7f268b16ee91a0341c4b2R514 I was reading the commit above, and i have a question... In the previous code, if the 'value' was type Number, the '.length' property return 'undefined'. So instead of go in the 'if' cond...

Open Graph Description: cdc4d48#diff-c244afd8def7f268b16ee91a0341c4b2R514 I was reading the commit above, and i have a question... In the previous code, if the 'value' was type Number, the '.length' property return 'undef...

X Description: cdc4d48#diff-c244afd8def7f268b16ee91a0341c4b2R514 I was reading the commit above, and i have a question... In the previous code, if the 'value' was type Number, the '.length' proper...

Opengraph URL: https://github.com/angular/angular.js/issues/5936

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"ngMinlength and ngMaxlength attribute not bind value, when model value is type Number","articleBody":"https://github.com/angular/angular.js/commit/cdc4d485a6daa0c74e5d07d8def2a3ee68d93d13#diff-c244afd8def7f268b16ee91a0341c4b2R514\n\nI was reading the commit above, and i have a question...\n\nIn the previous code, if the 'value' was type Number, the '.length' property return 'undefined'. So instead of go in the 'if' condition, go in the 'else'.\n\nBut in this new condition 'ctrl.$isEmpty(value) || value.length', if the 'value' is a Number, then the condition will return false. Then the validation wont pass. But in the previous condition the same case pass correctly.\n\nMy question is: This behavior was intentional? Because i understand if i want a field with a number value i can use input type=\"number\" and then use the 'min' and 'max' attributes. But the layout that i get for this type of input is different in each browser, and some times doesnt fit in the design of the app.\n\nIf i am right, i can submit a pull request do help with this, but first i have to be sure that this behavior wasnt intentional.\n\nThis example uses Angular 1.2.7 and will success the validation:\nhttp://plnkr.co/edit/YRpqT6Dwc6xbe2LYHEwq\n\nThis example uses Angular 1.2.8 and will fail the validation: http://plnkr.co/edit/rZgEtjyDuErDro9K94Q3\n\nThe same will apply for 'maxlength' attribute.\n","author":{"url":"https://github.com/vitorlopez","@type":"Person","name":"vitorlopez"},"datePublished":"2014-01-22T17:40:35Z","url":"https://github.com/angular/angular.js/issues/5936"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:5ff0f933-1278-1bbf-f5e1-4eb4ea7b4320
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8B82:29930C:7FB5E5:B06B3A:6AFDF2A1
html-safe-nonce84c68403111ebe81bc42b9a2204fb07093952e686c74ca99d7aabaf265870249
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QjgyOjI5OTMwQzo3RkI1RTU6QjA2QjNBOjZBRkRGMkExIiwidmlzaXRvcl9pZCI6IjgxMDYyNTU0OTAyNTEzNTQ3ODUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4b7c32971dcfd9214a267fcf1019f54a10f6423b0520a925c78f41d6c568ea5c
hovercard-subject-tagissue:26107862
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular.js/5936/issue_layout
twitter:imagehttps://opengraph.githubassets.com/2b75877f2a46c67abb36278bdbfbe7329047d8a5ba79cab0935d04e39c201f0f/angular/angular.js/issues/5936
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2b75877f2a46c67abb36278bdbfbe7329047d8a5ba79cab0935d04e39c201f0f/angular/angular.js/issues/5936
og:image:altcdc4d48#diff-c244afd8def7f268b16ee91a0341c4b2R514 I was reading the commit above, and i have a question... In the previous code, if the 'value' was type Number, the '.length' property return 'undef...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamevitorlopez
hostnamegithub.com
expected-hostnamegithub.com
Nonedd812ec581ecac95855f5ec917ef9827506c39a9da1443f43ddb4179a46471eb
turbo-cache-controlno-preview
go-importgithub.com/angular/angular.js git https://github.com/angular/angular.js.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id460078
octolytics-dimension-repository_nwoangular/angular.js
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id460078
octolytics-dimension-repository_network_root_nwoangular/angular.js
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release32ac708bac264dafdc28e10ff49b4d137f0c34a7
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular.js/issues/5936#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular.js%2Fissues%2F5936
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular.js%2Fissues%2F5936
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular.js
Reloadhttps://github.com/angular/angular.js/issues/5936
Reloadhttps://github.com/angular/angular.js/issues/5936
Reloadhttps://github.com/angular/angular.js/issues/5936
angularhttps://github.com/angular
angular.jshttps://github.com/angular/angular.js
Codehttps://github.com/angular/angular.js
Issues389 (389)https://github.com/angular/angular.js/issues
Pull requests72 (72)https://github.com/angular/angular.js/pulls
Actionshttps://github.com/angular/angular.js/actions
Projectshttps://github.com/angular/angular.js/projects
Wikihttps://github.com/angular/angular.js/wiki
Security and qualityhttps://github.com/angular/angular.js/security
Insightshttps://github.com/angular/angular.js/insights
https://github.com/angular/angular.js
ngMinlength and ngMaxlength attribute not bind value, when model value is type Numberhttps://github.com/angular/angular.js/issues/5936#top
frequency: lowhttps://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22frequency%3A%20low%22
resolution: duplicatehttps://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22resolution%3A%20duplicate%22
resolution: fixedhttps://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22resolution%3A%20fixed%22
type: featurehttps://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22type%3A%20feature%22
1.3.x - superluminal-nudgehttps://github.com/angular/angular.js/milestone/32
https://github.com/vitorlopez
vitorlopezhttps://github.com/vitorlopez
on Jan 22, 2014https://github.com/angular/angular.js/issues/5936#issue-26107862
cdc4d48#diff-c244afd8def7f268b16ee91a0341c4b2R514https://github.com/angular/angular.js/commit/cdc4d485a6daa0c74e5d07d8def2a3ee68d93d13#diff-c244afd8def7f268b16ee91a0341c4b2R514
http://plnkr.co/edit/YRpqT6Dwc6xbe2LYHEwqhttp://plnkr.co/edit/YRpqT6Dwc6xbe2LYHEwq
http://plnkr.co/edit/rZgEtjyDuErDro9K94Q3http://plnkr.co/edit/rZgEtjyDuErDro9K94Q3
https://github.com/caitp
caitphttps://github.com/caitp
on Jan 23, 2014https://github.com/angular/angular.js/issues/5936#issuecomment-33085122
#1588https://github.com/angular/angular.js/pull/1588
https://github.com/vitorlopez
vitorlopezhttps://github.com/vitorlopez
on Jan 23, 2014https://github.com/angular/angular.js/issues/5936#issuecomment-33110444
https://github.com/caitp
caitphttps://github.com/caitp
on Jan 23, 2014https://github.com/angular/angular.js/issues/5936#issuecomment-33125747
caitphttps://github.com/caitp
on Jan 27, 2014https://github.com/angular/angular.js/issues/5936#event-88805446
fix(input): ngMinlength/ngMaxlength should not invalidate non-stringl…https://github.com/caitp/angular.js/commit/572baa0744dc0a8eed922df983db5fd0dbee8355
572baa0https://github.com/caitp/angular.js/commit/572baa0744dc0a8eed922df983db5fd0dbee8355
fix(input): ngMinlength/ngMaxlength should not invalidate non-stringl…https://github.com/caitp/angular.js/commit/ab75a9f1e5cb4df7312f1beae9e2a9c80f74e5a9
ab75a9fhttps://github.com/caitp/angular.js/commit/ab75a9f1e5cb4df7312f1beae9e2a9c80f74e5a9
fix(input): ngMinlength/ngMaxlength should not invalidate non-stringl…https://github.com/caitp/angular.js/commit/7edfb1401de981c8bb77a9e277f172b503442af8
7edfb14https://github.com/caitp/angular.js/commit/7edfb1401de981c8bb77a9e277f172b503442af8
caitphttps://github.com/caitp
on Mar 19, 2014https://github.com/angular/angular.js/issues/5936#event-103294809
fix(input): ngMinlength/ngMaxlength should not invalidate non-stringl…https://github.com/caitp/angular.js/commit/bc663cccaa4aa4841fd66463a18a8de8d14c3f70
bc663cchttps://github.com/caitp/angular.js/commit/bc663cccaa4aa4841fd66463a18a8de8d14c3f70
https://github.com/caitp
caitphttps://github.com/caitp
on Sep 25, 2014https://github.com/angular/angular.js/issues/5936#issuecomment-56830398
https://github.com/caitp
caitphttps://github.com/caitp
on Sep 25, 2014https://github.com/angular/angular.js/issues/5936#issuecomment-56834621
caitphttps://github.com/caitp
completedhttps://github.com/angular/angular.js/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Sep 25, 2014https://github.com/angular/angular.js/issues/5936#event-170224918
caitphttps://github.com/caitp
resolution: fixedhttps://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22resolution%3A%20fixed%22
on Sep 25, 2014https://github.com/angular/angular.js/issues/5936#event-170225113
https://github.com/caitp
caitphttps://github.com/caitp
on Sep 25, 2014https://github.com/angular/angular.js/issues/5936#issuecomment-56834979
caitphttps://github.com/caitp
on Sep 25, 2014https://github.com/angular/angular.js/issues/5936#event-170226328
caitphttps://github.com/caitp
on Sep 25, 2014https://github.com/angular/angular.js/issues/5936#event-170258586
fix(input): format as string before running minlength/maxlength forma…https://github.com/caitp/angular.js/commit/b80808a071a19d01993566f8ac30c7261e458f93
https://docs.github.com/articles/closing-issues-via-commit-messages
b80808ahttps://github.com/caitp/angular.js/commit/b80808a071a19d01993566f8ac30c7261e458f93
fix(input): always format viewValue as a string inputs with text cont…https://github.com/caitp/angular.js/commit/3c80dcff6efe8b4188a6e3fd175ca745ea11a812
https://docs.github.com/articles/closing-issues-via-commit-messages
3c80dcfhttps://github.com/caitp/angular.js/commit/3c80dcff6efe8b4188a6e3fd175ca745ea11a812
fix(input): always format viewValue as a string inputs with text cont…https://github.com/angular/angular.js/commit/1b8b41ad23770592013fce925ee9d7444ed4f07c
https://docs.github.com/articles/closing-issues-via-commit-messages
1b8b41ahttps://github.com/angular/angular.js/commit/1b8b41ad23770592013fce925ee9d7444ed4f07c
https://github.com/caitp
caitphttps://github.com/caitp
on Sep 25, 2014https://github.com/angular/angular.js/issues/5936#issuecomment-56856872
1b8b41ahttps://github.com/angular/angular.js/commit/1b8b41ad23770592013fce925ee9d7444ed4f07c
caitphttps://github.com/caitp
completedhttps://github.com/angular/angular.js/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Sep 25, 2014https://github.com/angular/angular.js/issues/5936#event-170309028
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular.js/issues/5936
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular.js/issues/5936
frequency: lowhttps://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22frequency%3A%20low%22
resolution: duplicatehttps://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22resolution%3A%20duplicate%22
resolution: fixedhttps://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22resolution%3A%20fixed%22
type: featurehttps://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22type%3A%20feature%22
1.3.x - superluminal-nudgehttps://github.com/angular/angular.js/milestone/32
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.