Title: ngMinlength and ngMaxlength attribute not bind value, when model value is type Number · Issue #5936 · angular/angular.js · GitHub
Open Graph Title: ngMinlength and ngMaxlength attribute not bind value, when model value is type Number · Issue #5936 · angular/angular.js
X Title: ngMinlength and ngMaxlength attribute not bind value, when model value is type Number · Issue #5936 · angular/angular.js
Description: cdc4d48#diff-c244afd8def7f268b16ee91a0341c4b2R514 I was reading the commit above, and i have a question... In the previous code, if the 'value' was type Number, the '.length' property return 'undefined'. So instead of go in the 'if' cond...
Open Graph Description: cdc4d48#diff-c244afd8def7f268b16ee91a0341c4b2R514 I was reading the commit above, and i have a question... In the previous code, if the 'value' was type Number, the '.length' property return 'undef...
X Description: cdc4d48#diff-c244afd8def7f268b16ee91a0341c4b2R514 I was reading the commit above, and i have a question... In the previous code, if the 'value' was type Number, the '.length' proper...
Opengraph URL: https://github.com/angular/angular.js/issues/5936
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"ngMinlength and ngMaxlength attribute not bind value, when model value is type Number","articleBody":"https://github.com/angular/angular.js/commit/cdc4d485a6daa0c74e5d07d8def2a3ee68d93d13#diff-c244afd8def7f268b16ee91a0341c4b2R514\n\nI was reading the commit above, and i have a question...\n\nIn the previous code, if the 'value' was type Number, the '.length' property return 'undefined'. So instead of go in the 'if' condition, go in the 'else'.\n\nBut in this new condition 'ctrl.$isEmpty(value) || value.length', if the 'value' is a Number, then the condition will return false. Then the validation wont pass. But in the previous condition the same case pass correctly.\n\nMy question is: This behavior was intentional? Because i understand if i want a field with a number value i can use input type=\"number\" and then use the 'min' and 'max' attributes. But the layout that i get for this type of input is different in each browser, and some times doesnt fit in the design of the app.\n\nIf i am right, i can submit a pull request do help with this, but first i have to be sure that this behavior wasnt intentional.\n\nThis example uses Angular 1.2.7 and will success the validation:\nhttp://plnkr.co/edit/YRpqT6Dwc6xbe2LYHEwq\n\nThis example uses Angular 1.2.8 and will fail the validation: http://plnkr.co/edit/rZgEtjyDuErDro9K94Q3\n\nThe same will apply for 'maxlength' attribute.\n","author":{"url":"https://github.com/vitorlopez","@type":"Person","name":"vitorlopez"},"datePublished":"2014-01-22T17:40:35Z","url":"https://github.com/angular/angular.js/issues/5936"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:5ff0f933-1278-1bbf-f5e1-4eb4ea7b4320 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8B82:29930C:7FB5E5:B06B3A:6AFDF2A1 |
| html-safe-nonce | 84c68403111ebe81bc42b9a2204fb07093952e686c74ca99d7aabaf265870249 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QjgyOjI5OTMwQzo3RkI1RTU6QjA2QjNBOjZBRkRGMkExIiwidmlzaXRvcl9pZCI6IjgxMDYyNTU0OTAyNTEzNTQ3ODUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 4b7c32971dcfd9214a267fcf1019f54a10f6423b0520a925c78f41d6c568ea5c |
| hovercard-subject-tag | issue:26107862 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular.js/5936/issue_layout |
| twitter:image | https://opengraph.githubassets.com/2b75877f2a46c67abb36278bdbfbe7329047d8a5ba79cab0935d04e39c201f0f/angular/angular.js/issues/5936 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2b75877f2a46c67abb36278bdbfbe7329047d8a5ba79cab0935d04e39c201f0f/angular/angular.js/issues/5936 |
| og:image:alt | cdc4d48#diff-c244afd8def7f268b16ee91a0341c4b2R514 I was reading the commit above, and i have a question... In the previous code, if the 'value' was type Number, the '.length' property return 'undef... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | vitorlopez |
| hostname | github.com |
| expected-hostname | github.com |
| None | dd812ec581ecac95855f5ec917ef9827506c39a9da1443f43ddb4179a46471eb |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular.js git https://github.com/angular/angular.js.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 460078 |
| octolytics-dimension-repository_nwo | angular/angular.js |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 460078 |
| octolytics-dimension-repository_network_root_nwo | angular/angular.js |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 32ac708bac264dafdc28e10ff49b4d137f0c34a7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width