René's URL Explorer Experiment


Title: perf(orderBy): filters needlessly executed on every digest · Issue #16348 · angular/angular.js · GitHub

Open Graph Title: perf(orderBy): filters needlessly executed on every digest · Issue #16348 · angular/angular.js

X Title: perf(orderBy): filters needlessly executed on every digest · Issue #16348 · angular/angular.js

Description: I'm submitting a ... bug report feature request other Current behavior: from the docs: When filters are executed In templates, filters are only executed when their inputs have changed... There are two exceptions to this rule: 1. In gener...

Open Graph Description: I'm submitting a ... bug report feature request other Current behavior: from the docs: When filters are executed In templates, filters are only executed when their inputs have changed... There are ...

X Description: I'm submitting a ... bug report feature request other Current behavior: from the docs: When filters are executed In templates, filters are only executed when their inputs have changed... There ...

Opengraph URL: https://github.com/angular/angular.js/issues/16348

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"perf(orderBy): filters needlessly executed on every digest","articleBody":"**I'm submitting a ...**\r\n\u003c!-- (check one with \"x\") -->\r\n- [ ] bug report\r\n- [x] feature request\r\n- [ ] other \u003c!--(Please do not submit support requests here - see above)-->\r\n\r\n**Current behavior:**\r\n\u003c!-- Describe how the bug manifests / how the current features are insufficient. -->\r\nfrom [the docs](https://docs.angularjs.org/guide/filter#when-filters-are-executed):\r\n> When filters are executed\r\n> In templates, filters are only executed when their inputs have changed... There are two exceptions to this rule: 1. In general, this applies only to filters that take primitive values as inputs. Filters that receive Objects as input are executed on each $digest, as it would be too costly to track if the inputs have changed...\r\n\r\nThis effectively means that in all the instances of `ng-repeat` that use `orderBy`, this filter is rerun on every digest. Instead of \"costly\" tracking the input array for changes, the framework first sorts this array and then still tracks it. The sorting part here is a pure performance loss which doesn't make any sense.\r\n\r\n**Expected / new behavior:**\r\nSimilar to the `$stateful` flag, it'd be great to have another flag for filters like `orderBy`. This flag will make the filter be executed only if its inputs have changed even if the inputs are objects.\r\n\r\n**Minimal reproduction of the problem with instructions:**\r\nhttp://jsbin.com/nulonon/edit?html,js,output\r\n\r\n**AngularJS version:** 1.6.x, 1.5.x\r\n\r\n**Browser:** all","author":{"url":"https://github.com/thorn0","@type":"Person","name":"thorn0"},"datePublished":"2017-11-28T10:51:24Z","url":"https://github.com/angular/angular.js/issues/16348"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:7b0f11c7-e91f-4cde-297f-862f679849a2
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB1E6:2F2F14:1EA985:29C190:6AFD8F15
html-safe-nonce027011156ec957508ed599a61234d62d9f93a21a8547a9543695c911ce7c5728
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMUU2OjJGMkYxNDoxRUE5ODU6MjlDMTkwOjZBRkQ4RjE1IiwidmlzaXRvcl9pZCI6Ijg5MTI4MjgwMzE3OTAwNTkyODUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb4e982ddbbed19cab5141f15058cba32e169be49ba03d9376df4402c3da74bc3
hovercard-subject-tagissue:277339513
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular.js/16348/issue_layout
twitter:imagehttps://opengraph.githubassets.com/0575e74ffbf6c8ac7c85a4f8f6e940f9ee06c5f9cdc7d417f0ef489e1398fdd9/angular/angular.js/issues/16348
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0575e74ffbf6c8ac7c85a4f8f6e940f9ee06c5f9cdc7d417f0ef489e1398fdd9/angular/angular.js/issues/16348
og:image:altI'm submitting a ... bug report feature request other Current behavior: from the docs: When filters are executed In templates, filters are only executed when their inputs have changed... There are ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamethorn0
hostnamegithub.com
expected-hostnamegithub.com
Nonebc86424ef34a73b386237872800e922d149d65ba907f63d6f150a2dcb8433bea
turbo-cache-controlno-preview
go-importgithub.com/angular/angular.js git https://github.com/angular/angular.js.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id460078
octolytics-dimension-repository_nwoangular/angular.js
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id460078
octolytics-dimension-repository_network_root_nwoangular/angular.js
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release927a6c5ab1c32b38830f1b9d3050c0b9e9aa92e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular.js/issues/16348#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular.js%2Fissues%2F16348
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular.js%2Fissues%2F16348
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular.js
Reloadhttps://github.com/angular/angular.js/issues/16348
Reloadhttps://github.com/angular/angular.js/issues/16348
Reloadhttps://github.com/angular/angular.js/issues/16348
angularhttps://github.com/angular
angular.jshttps://github.com/angular/angular.js
Codehttps://github.com/angular/angular.js
Issues389 (389)https://github.com/angular/angular.js/issues
Pull requests72 (72)https://github.com/angular/angular.js/pulls
Actionshttps://github.com/angular/angular.js/actions
Projectshttps://github.com/angular/angular.js/projects
Wikihttps://github.com/angular/angular.js/wiki
Security and qualityhttps://github.com/angular/angular.js/security
Insightshttps://github.com/angular/angular.js/insights
https://github.com/angular/angular.js
perf(orderBy): filters needlessly executed on every digesthttps://github.com/angular/angular.js/issues/16348#top
component: $parsehttps://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22component%3A%20%24parse%22
component: filtershttps://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22component%3A%20filters%22
frequency: lowhttps://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22frequency%3A%20low%22
type: perfhttps://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22type%3A%20perf%22
1.8.x - won't fixhttps://github.com/angular/angular.js/milestone/145
https://github.com/thorn0
thorn0https://github.com/thorn0
on Nov 28, 2017https://github.com/angular/angular.js/issues/16348#issue-277339513
the docshttps://docs.angularjs.org/guide/filter#when-filters-are-executed
http://jsbin.com/nulonon/edit?html,js,outputhttp://jsbin.com/nulonon/edit?html,js,output
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
on Nov 28, 2017https://github.com/angular/angular.js/issues/16348#issuecomment-347505375
@jbedardhttps://github.com/jbedard
http://jsbin.com/yicolak/edit?html,js,outputhttp://jsbin.com/yicolak/edit?html,js,output
petebacondarwinhttps://github.com/petebacondarwin
component: $parsehttps://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22component%3A%20%24parse%22
component: filtershttps://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22component%3A%20filters%22
frequency: lowhttps://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22frequency%3A%20low%22
type: perfhttps://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22type%3A%20perf%22
on Nov 28, 2017https://github.com/angular/angular.js/issues/16348#event-1361234992
https://github.com/thorn0
thorn0https://github.com/thorn0
on Nov 28, 2017https://github.com/angular/angular.js/issues/16348#issuecomment-347555145
https://github.com/thorn0
thorn0https://github.com/thorn0
on Nov 28, 2017https://github.com/angular/angular.js/issues/16348#issuecomment-347556530
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
on Nov 28, 2017https://github.com/angular/angular.js/issues/16348#issuecomment-347681548
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
on Nov 28, 2017https://github.com/angular/angular.js/issues/16348#issuecomment-347681835
https://github.com/jbedard
jbedardhttps://github.com/jbedard
on Nov 28, 2017https://github.com/angular/angular.js/issues/16348#issuecomment-347695464
97b00cahttps://github.com/angular/angular.js/commit/97b00ca497676aaff8a803762a9f8c7ff4aa24dd
https://github.com/jbedard
jbedardhttps://github.com/jbedard
on Dec 6, 2017https://github.com/angular/angular.js/issues/16348#issuecomment-349539546
@thorn0https://github.com/thorn0
invokes valueOfhttps://github.com/angular/angular.js/blob/v1.6.7/src/ng/parse.js#L1822-L1825
https://github.com/jbedard
jbedardhttps://github.com/jbedard
on Dec 6, 2017https://github.com/angular/angular.js/issues/16348#issuecomment-349543613
$watchCollection interceptorhttps://github.com/angular/angular.js/blob/v1.6.7/src/ng/rootScope.js#L631
marked as $statefulhttps://github.com/angular/angular.js/blob/v1.6.7/src/ng/rootScope.js#L612
allowing input-watching of collection literalshttps://github.com/angular/angular.js/blob/97b00ca497676aaff8a803762a9f8c7ff4aa24dd/src/ng/rootScope.js#L583-L588
https://github.com/thorn0
thorn0https://github.com/thorn0
on Dec 6, 2017https://github.com/angular/angular.js/issues/16348#issuecomment-349630863
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
on Dec 6, 2017https://github.com/angular/angular.js/issues/16348#issuecomment-349662469
@thorn0https://github.com/thorn0
https://github.com/thorn0
thorn0https://github.com/thorn0
on Dec 6, 2017https://github.com/angular/angular.js/issues/16348#issuecomment-349685090
@jbedardhttps://github.com/jbedard
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
on Dec 7, 2017https://github.com/angular/angular.js/issues/16348#issuecomment-350063681
gkalpakhttps://github.com/gkalpak
1.7.x - won't fixhttps://github.com/angular/angular.js/milestone/145
on Sep 26, 2018https://github.com/angular/angular.js/issues/16348#event-1869257312
https://github.com/raybellis
raybellishttps://github.com/raybellis
on Mar 13, 2019https://github.com/angular/angular.js/issues/16348#issuecomment-472356376
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
on Mar 13, 2019https://github.com/angular/angular.js/issues/16348#issuecomment-472359874
@raybellishttps://github.com/raybellis
https://github.com/raybellis
raybellishttps://github.com/raybellis
on Mar 13, 2019https://github.com/angular/angular.js/issues/16348#issuecomment-472369473
#16348 (comment)https://github.com/angular/angular.js/issues/16348#issuecomment-347505375
https://github.com/raybellis
raybellishttps://github.com/raybellis
on Mar 13, 2019https://github.com/angular/angular.js/issues/16348#issuecomment-472369836
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular.js/issues/16348
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular.js/issues/16348
component: $parsehttps://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22component%3A%20%24parse%22
component: filtershttps://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22component%3A%20filters%22
frequency: lowhttps://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22frequency%3A%20low%22
type: perfhttps://github.com/angular/angular.js/issues?q=state%3Aopen%20label%3A%22type%3A%20perf%22
1.8.x - won't fixNo due datehttps://github.com/angular/angular.js/milestone/145
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.