René's URL Explorer Experiment


Title: feat(@angular/cli): add circular dependency detection by filipesilva · Pull Request #6813 · angular/angular-cli · GitHub

Open Graph Title: feat(@angular/cli): add circular dependency detection by filipesilva · Pull Request #6813 · angular/angular-cli

X Title: feat(@angular/cli): add circular dependency detection by filipesilva · Pull Request #6813 · angular/angular-cli

Description: Circular dependencies, like app.module.ts importing app.component.ts which in turn imports app.module.ts, now display a warning during builds: kamik@T460p MINGW64 /d/sandbox/master-project (master) $ ng build Hash: 3516b252f4e32d6c5bb8 Time: 8693ms chunk {0} polyfills.bundle.js, polyfills.bundle.js.map (polyfills) 160 kB {4} [initial] [rendered] chunk {1} main.bundle.js, main.bundle.js.map (main) 5.95 kB {3} [initial] [rendered] chunk {2} styles.bundle.js, styles.bundle.js.map (styles) 10.5 kB {4} [initial] [rendered] chunk {3} vendor.bundle.js, vendor.bundle.js.map (vendor) 1.88 MB [initial] [rendered] chunk {4} inline.bundle.js, inline.bundle.js.map (inline) 0 bytes [entry] [rendered] WARNING in Circular dependency detected: src\app\app.module.ts -> src\app\app.component.ts -> src\app\app.module.ts WARNING in Circular dependency detected: src\app\app.component.ts -> src\app\app.module.ts -> src\app\app.component.ts It is important to detect and eliminate circular dependencies because leaving them in might lead to Maximum call stack size exceeded errors, or imports being undefined at runtime. To remove these warnings from your project you can factor out the circular dependency into a separate module. For instance, if module A imports foo from module B, and module B imports bar from module A, it is enough to extract foo into module C. You can turn off these warnings by running ng set apps.0.hideCircularDependencyWarnings=true. This will add the "hideCircularDependencyWarnings": true value to your .angular-cli.json and disable the warnings. Fix #6309 Fix #6739

Open Graph Description: Circular dependencies, like app.module.ts importing app.component.ts which in turn imports app.module.ts, now display a warning during builds: kamik@T460p MINGW64 /d/sandbox/master-project (master)...

X Description: Circular dependencies, like app.module.ts importing app.component.ts which in turn imports app.module.ts, now display a warning during builds: kamik@T460p MINGW64 /d/sandbox/master-project (master)...

Opengraph URL: https://github.com/angular/angular-cli/pull/6813

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f9e56a1d-c227-9e6f-760f-a0033b8429c9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD860:215B92:14853A5:1B51A42:6B013092
html-safe-nonce0d4a35a92de917cee169d991519ca45382d190afec0eed5dfe8fa97228e3cba4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEODYwOjIxNUI5MjoxNDg1M0E1OjFCNTFBNDI6NkIwMTMwOTIiLCJ2aXNpdG9yX2lkIjoiMjY0OTA0NzAxODYzNDI5MzM5NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac23a40db2ac7cfe1ad0c50b3e701fe9aa40ac4c64d9c821c398939810474a35da
hovercard-subject-tagpull_request:127651038
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular-cli/pull/6813/files
twitter:imagehttps://avatars.githubusercontent.com/u/4172079?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4172079?s=400&v=4
og:image:altCircular dependencies, like app.module.ts importing app.component.ts which in turn imports app.module.ts, now display a warning during builds: kamik@T460p MINGW64 /d/sandbox/master-project (master)...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular-cli git https://github.com/angular/angular-cli.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id36891867
octolytics-dimension-repository_nwoangular/angular-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id36891867
octolytics-dimension-repository_network_root_nwoangular/angular-cli
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular-cli/pull/6813/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F6813%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F6813%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular-cli
Reloadhttps://github.com/angular/angular-cli/pull/6813/files
Reloadhttps://github.com/angular/angular-cli/pull/6813/files
Reloadhttps://github.com/angular/angular-cli/pull/6813/files
angularhttps://github.com/angular
angular-clihttps://github.com/angular/angular-cli
Codehttps://github.com/angular/angular-cli
Issues198 (198)https://github.com/angular/angular-cli/issues
Pull requests23 (23)https://github.com/angular/angular-cli/pulls
Actionshttps://github.com/angular/angular-cli/actions
Security and quality8 (8)https://github.com/angular/angular-cli/security
Insightshttps://github.com/angular/angular-cli/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
filipesilvahttps://github.com/filipesilva
angular:masterhttps://github.com/angular/angular-cli/tree/master
filipesilva:circular-dephttps://github.com/filipesilva/angular-cli/tree/circular-dep
Conversation 13 https://github.com/angular/angular-cli/pull/6813
Commits 1 https://github.com/angular/angular-cli/pull/6813/commits
Checks 0 https://github.com/angular/angular-cli/pull/6813/checks
Files changed https://github.com/angular/angular-cli/pull/6813/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/6813/files
feat(@angular/cli): add circular dependency detection https://github.com/angular/angular-cli/pull/6813/files#top
Show all changes 1 commit https://github.com/angular/angular-cli/pull/6813/files
0d93406 feat(@angular/cli): add circular dependency detection filipesilva Jun 27, 2017 https://github.com/angular/angular-cli/pull/6813/commits/0d93406b3dd49e77c706cb795583f17c1a0eba2d
Clear filters https://github.com/angular/angular-cli/pull/6813/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/6813/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/6813/files
angular-cli.md https://github.com/angular/angular-cli/pull/6813/files#diff-ec18b7a20bda0b4942f59995f86657f52a8af5fa1d2968916c06c627f01ea634
package.json https://github.com/angular/angular-cli/pull/6813/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
schema.json https://github.com/angular/angular-cli/pull/6813/files#diff-32987bbfada21b13e6fc84df071833233d14ff546d38cce4de41388118b0fdee
common.ts https://github.com/angular/angular-cli/pull/6813/files#diff-ce610a461b2cfb986cfcc67ef2527eaac5b0cf325d0ac1f15c146e6be9d0b282
package.json https://github.com/angular/angular-cli/pull/6813/files#diff-b6726b257c1f40fd790e351d34abb639af4c9bfc76fa83a5d3947f3ebc788c56
eject.ts https://github.com/angular/angular-cli/pull/6813/files#diff-476b273d6f6b00245bef84dbe972a692a2daa48552f6b255e96b67198b39a158
circular-dependency.ts https://github.com/angular/angular-cli/pull/6813/files#diff-718ccdcce3df4c2496a3fab8c2567a62daa4d5d76d8c18ad83074c455a6954ae
docs/documentation/angular-cli.mdhttps://github.com/angular/angular-cli/pull/6813/files#diff-ec18b7a20bda0b4942f59995f86657f52a8af5fa1d2968916c06c627f01ea634
View file https://github.com/filipesilva/angular-cli/blob/0d93406b3dd49e77c706cb795583f17c1a0eba2d/docs/documentation/angular-cli.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/6813/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/6813/files#diff-ec18b7a20bda0b4942f59995f86657f52a8af5fa1d2968916c06c627f01ea634
https://github.com/angular/angular-cli/pull/6813/files#diff-ec18b7a20bda0b4942f59995f86657f52a8af5fa1d2968916c06c627f01ea634
package.jsonhttps://github.com/angular/angular-cli/pull/6813/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
View file https://github.com/filipesilva/angular-cli/blob/0d93406b3dd49e77c706cb795583f17c1a0eba2d/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/6813/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/6813/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
https://github.com/angular/angular-cli/pull/6813/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
packages/@angular/cli/lib/config/schema.jsonhttps://github.com/angular/angular-cli/pull/6813/files#diff-32987bbfada21b13e6fc84df071833233d14ff546d38cce4de41388118b0fdee
View file https://github.com/filipesilva/angular-cli/blob/0d93406b3dd49e77c706cb795583f17c1a0eba2d/packages/%40angular/cli/lib/config/schema.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/6813/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/6813/files#diff-32987bbfada21b13e6fc84df071833233d14ff546d38cce4de41388118b0fdee
https://github.com/angular/angular-cli/pull/6813/files#diff-32987bbfada21b13e6fc84df071833233d14ff546d38cce4de41388118b0fdee
packages/@angular/cli/models/webpack-configs/common.tshttps://github.com/angular/angular-cli/pull/6813/files#diff-ce610a461b2cfb986cfcc67ef2527eaac5b0cf325d0ac1f15c146e6be9d0b282
View file https://github.com/filipesilva/angular-cli/blob/0d93406b3dd49e77c706cb795583f17c1a0eba2d/packages/%40angular/cli/models/webpack-configs/common.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/6813/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/6813/files#diff-ce610a461b2cfb986cfcc67ef2527eaac5b0cf325d0ac1f15c146e6be9d0b282
https://github.com/angular/angular-cli/pull/6813/files#diff-ce610a461b2cfb986cfcc67ef2527eaac5b0cf325d0ac1f15c146e6be9d0b282
https://github.com/angular/angular-cli/pull/6813/files#diff-ce610a461b2cfb986cfcc67ef2527eaac5b0cf325d0ac1f15c146e6be9d0b282
https://github.com/angular/angular-cli/pull/6813/files#diff-ce610a461b2cfb986cfcc67ef2527eaac5b0cf325d0ac1f15c146e6be9d0b282
packages/@angular/cli/package.jsonhttps://github.com/angular/angular-cli/pull/6813/files#diff-b6726b257c1f40fd790e351d34abb639af4c9bfc76fa83a5d3947f3ebc788c56
View file https://github.com/filipesilva/angular-cli/blob/0d93406b3dd49e77c706cb795583f17c1a0eba2d/packages/%40angular/cli/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/6813/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/6813/files#diff-b6726b257c1f40fd790e351d34abb639af4c9bfc76fa83a5d3947f3ebc788c56
https://github.com/angular/angular-cli/pull/6813/files#diff-b6726b257c1f40fd790e351d34abb639af4c9bfc76fa83a5d3947f3ebc788c56
packages/@angular/cli/tasks/eject.tshttps://github.com/angular/angular-cli/pull/6813/files#diff-476b273d6f6b00245bef84dbe972a692a2daa48552f6b255e96b67198b39a158
View file https://github.com/filipesilva/angular-cli/blob/0d93406b3dd49e77c706cb795583f17c1a0eba2d/packages/%40angular/cli/tasks/eject.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/6813/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/6813/files#diff-476b273d6f6b00245bef84dbe972a692a2daa48552f6b255e96b67198b39a158
https://github.com/angular/angular-cli/pull/6813/files#diff-476b273d6f6b00245bef84dbe972a692a2daa48552f6b255e96b67198b39a158
https://github.com/angular/angular-cli/pull/6813/files#diff-476b273d6f6b00245bef84dbe972a692a2daa48552f6b255e96b67198b39a158
https://github.com/angular/angular-cli/pull/6813/files#diff-476b273d6f6b00245bef84dbe972a692a2daa48552f6b255e96b67198b39a158
tests/e2e/tests/misc/circular-dependency.tshttps://github.com/angular/angular-cli/pull/6813/files#diff-718ccdcce3df4c2496a3fab8c2567a62daa4d5d76d8c18ad83074c455a6954ae
View file https://github.com/filipesilva/angular-cli/blob/0d93406b3dd49e77c706cb795583f17c1a0eba2d/tests/e2e/tests/misc/circular-dependency.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/6813/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.